From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> To: Oliver O'Halloran <oohall@gmail.com>, linuxppc-dev@lists.ozlabs.org Cc: arbab@linux.vnet.ibm.com, bsingharora@gmail.com, linux-nvdimm@lists.01.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, linux-mm@kvack.org Subject: Re: [PATCH 1/9] mm/huge_memory: Use zap_deposited_table() more Date: Wed, 12 Apr 2017 11:14:30 +0530 [thread overview] Message-ID: <878tn6qiwx.fsf@skywalker.in.ibm.com> (raw) In-Reply-To: <20170411174233.21902-2-oohall@gmail.com> Oliver O'Halloran <oohall@gmail.com> writes: > Depending flags of the PMD being zapped there may or may not be a > deposited pgtable to be freed. In two of the three cases this is open > coded while the third uses the zap_deposited_table() helper. This patch > converts the others to use the helper to clean things up a bit. > > Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: linux-mm@kvack.org > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- > For reference: > > void zap_deposited_table(struct mm_struct *mm, pmd_t *pmd) > { > pgtable_t pgtable; > > pgtable = pgtable_trans_huge_withdraw(mm, pmd); > pte_free(mm, pgtable); > atomic_long_dec(&mm->nr_ptes); > } > --- > mm/huge_memory.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b787c4cfda0e..aa01dd47cc65 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1615,8 +1615,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > if (is_huge_zero_pmd(orig_pmd)) > tlb_remove_page_size(tlb, pmd_page(orig_pmd), HPAGE_PMD_SIZE); > } else if (is_huge_zero_pmd(orig_pmd)) { > - pte_free(tlb->mm, pgtable_trans_huge_withdraw(tlb->mm, pmd)); > - atomic_long_dec(&tlb->mm->nr_ptes); > + zap_deposited_table(tlb->mm, pmd); > spin_unlock(ptl); > tlb_remove_page_size(tlb, pmd_page(orig_pmd), HPAGE_PMD_SIZE); > } else { > @@ -1625,10 +1624,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > VM_BUG_ON_PAGE(page_mapcount(page) < 0, page); > VM_BUG_ON_PAGE(!PageHead(page), page); > if (PageAnon(page)) { > - pgtable_t pgtable; > - pgtable = pgtable_trans_huge_withdraw(tlb->mm, pmd); > - pte_free(tlb->mm, pgtable); > - atomic_long_dec(&tlb->mm->nr_ptes); > + zap_deposited_table(tlb->mm, pmd); > add_mm_counter(tlb->mm, MM_ANONPAGES, -HPAGE_PMD_NR); > } else { > if (arch_needs_pgtable_deposit()) > -- > 2.9.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> To: "Oliver O'Halloran" <oohall@gmail.com>, linuxppc-dev@lists.ozlabs.org Cc: arbab@linux.vnet.ibm.com, bsingharora@gmail.com, linux-nvdimm@lists.01.org, "Oliver O'Halloran" <oohall@gmail.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, linux-mm@kvack.org Subject: Re: [PATCH 1/9] mm/huge_memory: Use zap_deposited_table() more Date: Wed, 12 Apr 2017 11:14:30 +0530 [thread overview] Message-ID: <878tn6qiwx.fsf@skywalker.in.ibm.com> (raw) In-Reply-To: <20170411174233.21902-2-oohall@gmail.com> Oliver O'Halloran <oohall@gmail.com> writes: > Depending flags of the PMD being zapped there may or may not be a > deposited pgtable to be freed. In two of the three cases this is open > coded while the third uses the zap_deposited_table() helper. This patch > converts the others to use the helper to clean things up a bit. > > Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: linux-mm@kvack.org > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- > For reference: > > void zap_deposited_table(struct mm_struct *mm, pmd_t *pmd) > { > pgtable_t pgtable; > > pgtable = pgtable_trans_huge_withdraw(mm, pmd); > pte_free(mm, pgtable); > atomic_long_dec(&mm->nr_ptes); > } > --- > mm/huge_memory.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b787c4cfda0e..aa01dd47cc65 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1615,8 +1615,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > if (is_huge_zero_pmd(orig_pmd)) > tlb_remove_page_size(tlb, pmd_page(orig_pmd), HPAGE_PMD_SIZE); > } else if (is_huge_zero_pmd(orig_pmd)) { > - pte_free(tlb->mm, pgtable_trans_huge_withdraw(tlb->mm, pmd)); > - atomic_long_dec(&tlb->mm->nr_ptes); > + zap_deposited_table(tlb->mm, pmd); > spin_unlock(ptl); > tlb_remove_page_size(tlb, pmd_page(orig_pmd), HPAGE_PMD_SIZE); > } else { > @@ -1625,10 +1624,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > VM_BUG_ON_PAGE(page_mapcount(page) < 0, page); > VM_BUG_ON_PAGE(!PageHead(page), page); > if (PageAnon(page)) { > - pgtable_t pgtable; > - pgtable = pgtable_trans_huge_withdraw(tlb->mm, pmd); > - pte_free(tlb->mm, pgtable); > - atomic_long_dec(&tlb->mm->nr_ptes); > + zap_deposited_table(tlb->mm, pmd); > add_mm_counter(tlb->mm, MM_ANONPAGES, -HPAGE_PMD_NR); > } else { > if (arch_needs_pgtable_deposit()) > -- > 2.9.3
next prev parent reply other threads:[~2017-04-12 5:44 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-11 17:42 ZONE_DEVICE and pmem API support for powerpc Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-11 17:42 ` [PATCH 1/9] mm/huge_memory: Use zap_deposited_table() more Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-12 5:44 ` Aneesh Kumar K.V [this message] 2017-04-12 5:44 ` Aneesh Kumar K.V 2017-04-18 21:35 ` David Rientjes 2017-04-18 21:35 ` David Rientjes 2017-04-11 17:42 ` [PATCH 2/9] mm/huge_memory: Deposit a pgtable for DAX PMD faults when required Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-12 5:51 ` Aneesh Kumar K.V 2017-04-12 5:51 ` Aneesh Kumar K.V 2017-04-12 5:51 ` Aneesh Kumar K.V 2017-04-11 17:42 ` [PATCH 3/9] powerpc/mm: Add _PAGE_DEVMAP for ppc64 Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-12 0:19 ` Stephen Rothwell 2017-04-12 0:19 ` Stephen Rothwell 2017-04-12 3:07 ` Aneesh Kumar K.V 2017-04-12 3:07 ` Aneesh Kumar K.V 2017-04-13 5:20 ` Aneesh Kumar K.V 2017-04-13 5:20 ` Aneesh Kumar K.V 2017-04-11 17:42 ` [PATCH 4/9] powerpc/mm: Reshuffle vmemmap_free() Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-12 0:33 ` Stephen Rothwell 2017-04-12 0:33 ` Stephen Rothwell 2017-04-11 17:42 ` [PATCH 5/9] powerpc/vmemmap: Add altmap support Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-12 0:24 ` Balbir Singh 2017-04-12 0:24 ` Balbir Singh 2017-04-11 17:42 ` [PATCH 6/9] powerpc, mm: Enable ZONE_DEVICE on powerpc Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-12 0:25 ` Balbir Singh 2017-04-12 0:25 ` Balbir Singh 2017-04-12 0:43 ` Stephen Rothwell 2017-04-12 0:43 ` Stephen Rothwell 2017-04-12 2:03 ` Michael Ellerman 2017-04-12 2:03 ` Michael Ellerman 2017-04-11 17:42 ` [PATCH 7/9] powerpc/mm: Wire up ioremap_cache Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-23 11:53 ` [7/9] " Michael Ellerman 2017-04-23 11:53 ` Michael Ellerman 2017-04-11 17:42 ` [PATCH 8/9] powerpc/mm: Wire up hpte_removebolted for powernv Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran [not found] ` <20170411174233.21902-9-oohall-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-11 22:50 ` Anton Blanchard 2017-04-11 22:50 ` Anton Blanchard 2017-04-12 0:18 ` Stephen Rothwell 2017-04-12 0:18 ` Stephen Rothwell 2017-04-12 3:30 ` Rashmica Gupta 2017-04-12 3:30 ` Rashmica Gupta 2017-04-12 1:53 ` Balbir Singh 2017-04-12 1:53 ` Balbir Singh 2017-04-13 4:21 ` Oliver O'Halloran 2017-04-13 4:21 ` Oliver O'Halloran 2017-04-13 10:10 ` Michael Ellerman 2017-04-13 10:10 ` Michael Ellerman 2017-04-11 17:42 ` [PATCH 9/9] powerpc: Add pmem API support Oliver O'Halloran 2017-04-11 17:42 ` Oliver O'Halloran 2017-04-11 18:22 ` ZONE_DEVICE and pmem API support for powerpc Dan Williams 2017-04-11 18:22 ` Dan Williams 2017-04-12 9:14 ` Oliver O'Halloran 2017-04-12 9:14 ` Oliver O'Halloran 2017-04-12 1:10 ` Stephen Rothwell 2017-04-12 1:10 ` Stephen Rothwell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=878tn6qiwx.fsf@skywalker.in.ibm.com \ --to=aneesh.kumar@linux.vnet.ibm.com \ --cc=arbab@linux.vnet.ibm.com \ --cc=bsingharora@gmail.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=oohall@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.