All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] hostmem-file: plug a small leak
@ 2016-04-13 16:57 marcandre.lureau
  2016-04-14 11:34 ` Igor Mammedov
  0 siblings, 1 reply; 7+ messages in thread
From: marcandre.lureau @ 2016-04-13 16:57 UTC (permalink / raw)
  To: qemu-devel; +Cc: pbonzini, Marc-André Lureau

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 backends/hostmem-file.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index b17a1f1..5c4b808 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -121,11 +121,19 @@ file_backend_instance_init(Object *o)
                             set_mem_path, NULL);
 }
 
+static void file_backend_instance_finalize(Object *o)
+{
+    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
+
+    g_free(fb->mem_path);
+}
+
 static const TypeInfo file_backend_info = {
     .name = TYPE_MEMORY_BACKEND_FILE,
     .parent = TYPE_MEMORY_BACKEND,
     .class_init = file_backend_class_init,
     .instance_init = file_backend_instance_init,
+    .instance_finalize = file_backend_instance_finalize,
     .instance_size = sizeof(HostMemoryBackendFile),
 };
 
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
  2016-04-13 16:57 [Qemu-devel] [PATCH] hostmem-file: plug a small leak marcandre.lureau
@ 2016-04-14 11:34 ` Igor Mammedov
  2016-04-14 13:24   ` Paolo Bonzini
  0 siblings, 1 reply; 7+ messages in thread
From: Igor Mammedov @ 2016-04-14 11:34 UTC (permalink / raw)
  To: marcandre.lureau; +Cc: qemu-devel, pbonzini

On Wed, 13 Apr 2016 18:57:40 +0200
marcandre.lureau@redhat.com wrote:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  backends/hostmem-file.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> index b17a1f1..5c4b808 100644
> --- a/backends/hostmem-file.c
> +++ b/backends/hostmem-file.c
> @@ -121,11 +121,19 @@ file_backend_instance_init(Object *o)
>                              set_mem_path, NULL);
>  }
>  
> +static void file_backend_instance_finalize(Object *o)
> +{
> +    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
> +
> +    g_free(fb->mem_path);
> +}
> +
>  static const TypeInfo file_backend_info = {
>      .name = TYPE_MEMORY_BACKEND_FILE,
>      .parent = TYPE_MEMORY_BACKEND,
>      .class_init = file_backend_class_init,
>      .instance_init = file_backend_instance_init,
> +    .instance_finalize = file_backend_instance_finalize,
>      .instance_size = sizeof(HostMemoryBackendFile),
>  };
>  

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
  2016-04-14 11:34 ` Igor Mammedov
@ 2016-04-14 13:24   ` Paolo Bonzini
  2016-04-14 15:44     ` Igor Mammedov
  0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2016-04-14 13:24 UTC (permalink / raw)
  To: Igor Mammedov, marcandre.lureau; +Cc: qemu-devel



On 14/04/2016 13:34, Igor Mammedov wrote:
> On Wed, 13 Apr 2016 18:57:40 +0200
> marcandre.lureau@redhat.com wrote:
> 
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>

Igor, feel free to send a pull request or even to add yourself as
hostmem maintainer.

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
  2016-04-14 13:24   ` Paolo Bonzini
@ 2016-04-14 15:44     ` Igor Mammedov
  2016-04-14 17:26       ` Paolo Bonzini
  0 siblings, 1 reply; 7+ messages in thread
From: Igor Mammedov @ 2016-04-14 15:44 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: marcandre.lureau, qemu-devel

On Thu, 14 Apr 2016 15:24:10 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 14/04/2016 13:34, Igor Mammedov wrote:
> > On Wed, 13 Apr 2016 18:57:40 +0200
> > marcandre.lureau@redhat.com wrote:
> >   
> >> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >>
> >> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>  
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>  
> 
> Igor, feel free to send a pull request or even to add yourself as
> hostmem maintainer.
I can't send pull signed pull request as I don't have a trusted key.

> 
> Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
  2016-04-14 15:44     ` Igor Mammedov
@ 2016-04-14 17:26       ` Paolo Bonzini
  2016-04-15  6:56         ` Markus Armbruster
  0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2016-04-14 17:26 UTC (permalink / raw)
  To: Igor Mammedov; +Cc: marcandre.lureau, qemu-devel



On 14/04/2016 17:44, Igor Mammedov wrote:
> On Thu, 14 Apr 2016 15:24:10 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>> On 14/04/2016 13:34, Igor Mammedov wrote:
>>> On Wed, 13 Apr 2016 18:57:40 +0200
>>> marcandre.lureau@redhat.com wrote:
>>>   
>>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>>
>>>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>  
>>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>  
>>
>> Igor, feel free to send a pull request or even to add yourself as
>> hostmem maintainer.
> I can't send pull signed pull request as I don't have a trusted key.

Ok, then I guess this will have to wait for 2.7.  No big deal, it's
really minor.  Marc-André, please remind me when I'm back. :)

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
  2016-04-14 17:26       ` Paolo Bonzini
@ 2016-04-15  6:56         ` Markus Armbruster
  2016-04-15 13:49           ` Paolo Bonzini
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2016-04-15  6:56 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: Igor Mammedov, marcandre.lureau, qemu-devel

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 14/04/2016 17:44, Igor Mammedov wrote:
>> On Thu, 14 Apr 2016 15:24:10 +0200
>> Paolo Bonzini <pbonzini@redhat.com> wrote:
>> 
>>> On 14/04/2016 13:34, Igor Mammedov wrote:
>>>> On Wed, 13 Apr 2016 18:57:40 +0200
>>>> marcandre.lureau@redhat.com wrote:
>>>>   
>>>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>>>
>>>>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>  
>>>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>  
>>>
>>> Igor, feel free to send a pull request or even to add yourself as
>>> hostmem maintainer.
>> I can't send pull signed pull request as I don't have a trusted key.

Needs fixing.

> Ok, then I guess this will have to wait for 2.7.  No big deal, it's
> really minor.  Marc-André, please remind me when I'm back. :)

Yes, no big deal, but I could do a pull request for 2.6 if that's okay
with Paolo.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
  2016-04-15  6:56         ` Markus Armbruster
@ 2016-04-15 13:49           ` Paolo Bonzini
  0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2016-04-15 13:49 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: Igor Mammedov, marcandre.lureau, qemu-devel



On 15/04/2016 08:56, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>> On 14/04/2016 17:44, Igor Mammedov wrote:
>>> On Thu, 14 Apr 2016 15:24:10 +0200
>>> Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>
>>>> On 14/04/2016 13:34, Igor Mammedov wrote:
>>>>> On Wed, 13 Apr 2016 18:57:40 +0200
>>>>> marcandre.lureau@redhat.com wrote:
>>>>>   
>>>>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>>>>
>>>>>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>  
>>>>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>  
>>>>
>>>> Igor, feel free to send a pull request or even to add yourself as
>>>> hostmem maintainer.
>>> I can't send pull signed pull request as I don't have a trusted key.
> 
> Needs fixing.
> 
>> Ok, then I guess this will have to wait for 2.7.  No big deal, it's
>> really minor.  Marc-André, please remind me when I'm back. :)
> 
> Yes, no big deal, but I could do a pull request for 2.6 if that's okay
> with Paolo.

I'm always okay with doing less work, and I obviously trust anyone who
has already sent a pull request to Peter (plus some that haven't).

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-04-15 13:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 16:57 [Qemu-devel] [PATCH] hostmem-file: plug a small leak marcandre.lureau
2016-04-14 11:34 ` Igor Mammedov
2016-04-14 13:24   ` Paolo Bonzini
2016-04-14 15:44     ` Igor Mammedov
2016-04-14 17:26       ` Paolo Bonzini
2016-04-15  6:56         ` Markus Armbruster
2016-04-15 13:49           ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.