* [PATCH] virtio: fix typo in vring_need_event() doc comment
@ 2015-04-15 12:35 Stefan Hajnoczi
2015-04-19 5:06 ` Rusty Russell
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2015-04-15 12:35 UTC (permalink / raw)
To: virtualization; +Cc: Stefan Hajnoczi, Michael S. Tsirkin
Here the "other side" refers to the guest or host.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/uapi/linux/virtio_ring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h
index a3318f3..915980a 100644
--- a/include/uapi/linux/virtio_ring.h
+++ b/include/uapi/linux/virtio_ring.h
@@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int num, unsigned long align)
}
/* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
-/* Assuming a given event_idx value from the other size, if
+/* Assuming a given event_idx value from the other side, if
* we have just incremented index from old to new_idx,
* should we trigger an event? */
static inline int vring_need_event(__u16 event_idx, __u16 new_idx, __u16 old)
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio: fix typo in vring_need_event() doc comment
2015-04-15 12:35 [PATCH] virtio: fix typo in vring_need_event() doc comment Stefan Hajnoczi
@ 2015-04-19 5:06 ` Rusty Russell
2015-04-20 6:03 ` Michael S. Tsirkin
0 siblings, 1 reply; 5+ messages in thread
From: Rusty Russell @ 2015-04-19 5:06 UTC (permalink / raw)
To: virtualization; +Cc: Stefan Hajnoczi, Michael S. Tsirkin
Stefan Hajnoczi <stefanha@redhat.com> writes:
> Here the "other side" refers to the guest or host.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Applied.
Thanks!
Rusty.
> ---
> include/uapi/linux/virtio_ring.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h
> index a3318f3..915980a 100644
> --- a/include/uapi/linux/virtio_ring.h
> +++ b/include/uapi/linux/virtio_ring.h
> @@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int num, unsigned long align)
> }
>
> /* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
> -/* Assuming a given event_idx value from the other size, if
> +/* Assuming a given event_idx value from the other side, if
> * we have just incremented index from old to new_idx,
> * should we trigger an event? */
> static inline int vring_need_event(__u16 event_idx, __u16 new_idx, __u16 old)
> --
> 2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio: fix typo in vring_need_event() doc comment
2015-04-19 5:06 ` Rusty Russell
@ 2015-04-20 6:03 ` Michael S. Tsirkin
2015-04-20 12:34 ` Rusty Russell
0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2015-04-20 6:03 UTC (permalink / raw)
To: Rusty Russell; +Cc: Stefan Hajnoczi, virtualization
On Sun, Apr 19, 2015 at 02:36:38PM +0930, Rusty Russell wrote:
> Stefan Hajnoczi <stefanha@redhat.com> writes:
> > Here the "other side" refers to the guest or host.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Applied.
>
> Thanks!
> Rusty.
Just to make sure, are you applying this for 4.1?
> > ---
> > include/uapi/linux/virtio_ring.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h
> > index a3318f3..915980a 100644
> > --- a/include/uapi/linux/virtio_ring.h
> > +++ b/include/uapi/linux/virtio_ring.h
> > @@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int num, unsigned long align)
> > }
> >
> > /* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
> > -/* Assuming a given event_idx value from the other size, if
> > +/* Assuming a given event_idx value from the other side, if
> > * we have just incremented index from old to new_idx,
> > * should we trigger an event? */
> > static inline int vring_need_event(__u16 event_idx, __u16 new_idx, __u16 old)
> > --
> > 2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio: fix typo in vring_need_event() doc comment
2015-04-20 6:03 ` Michael S. Tsirkin
@ 2015-04-20 12:34 ` Rusty Russell
0 siblings, 0 replies; 5+ messages in thread
From: Rusty Russell @ 2015-04-20 12:34 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Stefan Hajnoczi, virtualization
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Sun, Apr 19, 2015 at 02:36:38PM +0930, Rusty Russell wrote:
>> Stefan Hajnoczi <stefanha@redhat.com> writes:
>> > Here the "other side" refers to the guest or host.
>> >
>> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>>
>> Applied.
>>
>> Thanks!
>> Rusty.
>
> Just to make sure, are you applying this for 4.1?
No, I am going to hand you my pending queue.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] virtio: fix typo in vring_need_event() doc comment
@ 2015-05-01 23:12 Rusty Russell
0 siblings, 0 replies; 5+ messages in thread
From: Rusty Russell @ 2015-05-01 23:12 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, Michael S. Tsirkin
From: Stefan Hajnoczi <stefanha@redhat.com>
Here the "other side" refers to the guest or host.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
include/uapi/linux/virtio_ring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h
index a3318f31e8e7..915980ac68df 100644
--- a/include/uapi/linux/virtio_ring.h
+++ b/include/uapi/linux/virtio_ring.h
@@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int num, unsigned long align)
}
/* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
-/* Assuming a given event_idx value from the other size, if
+/* Assuming a given event_idx value from the other side, if
* we have just incremented index from old to new_idx,
* should we trigger an event? */
static inline int vring_need_event(__u16 event_idx, __u16 new_idx, __u16 old)
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-01 23:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 12:35 [PATCH] virtio: fix typo in vring_need_event() doc comment Stefan Hajnoczi
2015-04-19 5:06 ` Rusty Russell
2015-04-20 6:03 ` Michael S. Tsirkin
2015-04-20 12:34 ` Rusty Russell
2015-05-01 23:12 Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.