* [PATCH] mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios.
@ 2013-10-16 5:42 Sonic Zhang
2013-10-21 1:29 ` Chris Ball
0 siblings, 1 reply; 2+ messages in thread
From: Sonic Zhang @ 2013-10-16 5:42 UTC (permalink / raw)
To: Chris Ball, linux-mmc; +Cc: adi-buildroot-devel, Sonic Zhang
From: Sonic Zhang <sonic.zhang@analog.com>
The DMA operation in SDIO CMD53 may fail because the 4 bit SDIO mode
is not set up correctly on BF548.
Remove 2 blank lines as well.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
drivers/mmc/host/bfin_sdh.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c
index 94fae2f..e62c5bc 100644
--- a/drivers/mmc/host/bfin_sdh.c
+++ b/drivers/mmc/host/bfin_sdh.c
@@ -391,6 +391,7 @@ static void sdh_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
/* Disable 4 bit SDIO */
cfg &= ~SD4E;
}
+ bfin_write_SDH_CFG(cfg);
host->power_mode = ios->power_mode;
#ifndef RSI_BLKSZ
@@ -415,7 +416,6 @@ static void sdh_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
cfg &= ~SD_CMD_OD;
# endif
-
if (ios->power_mode != MMC_POWER_OFF)
cfg |= PWR_ON;
else
@@ -433,7 +433,6 @@ static void sdh_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
clk_ctl |= CLK_E;
host->clk_div = clk_div;
bfin_write_SDH_CLK_CTL(clk_ctl);
-
} else
sdh_stop_clock(host);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios.
2013-10-16 5:42 [PATCH] mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios Sonic Zhang
@ 2013-10-21 1:29 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2013-10-21 1:29 UTC (permalink / raw)
To: Sonic Zhang; +Cc: linux-mmc, adi-buildroot-devel, Sonic Zhang
Hi Sonic,
On Wed, Oct 16 2013, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> The DMA operation in SDIO CMD53 may fail because the 4 bit SDIO mode
> is not set up correctly on BF548.
> Remove 2 blank lines as well.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Thanks, pushed to mmc-next for 3.13.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-21 1:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-16 5:42 [PATCH] mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios Sonic Zhang
2013-10-21 1:29 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.