All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [pull request] Pull request for branch pciutils-fix
@ 2009-08-01 22:37 Thomas Petazzoni
  2009-08-01 22:37 ` [Buildroot] [PATCH 1/1] pciutils: fix build with external toolchains Thomas Petazzoni
  2009-08-02  8:01 ` [Buildroot] [pull request] Pull request for branch pciutils-fix Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2009-08-01 22:37 UTC (permalink / raw)
  To: buildroot

The following changes since commit e15c0d07e15e94e800bd9a0cf3c24f45aeacd89c:
  Peter Korsgaard (1):
        target/device: rename program invocation symbol in defconfigs

are available in the git repository at:

  git://git.busybox.net/~tpetazzoni/git/buildroot pciutils-fix

Thomas Petazzoni (1):
      pciutils: fix build with external toolchains

 CHANGES                      |    1 +
 package/pciutils/pciutils.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

Thanks,
-- 
Thomas Petazzoni

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] pciutils: fix build with external toolchains
  2009-08-01 22:37 [Buildroot] [pull request] Pull request for branch pciutils-fix Thomas Petazzoni
@ 2009-08-01 22:37 ` Thomas Petazzoni
  2009-08-02  7:58   ` Peter Korsgaard
  2009-08-02  8:01 ` [Buildroot] [pull request] Pull request for branch pciutils-fix Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2009-08-01 22:37 UTC (permalink / raw)
  To: buildroot

Buildroot Makefile to compile pciutils wasn't passing TARGET_LDFLAGS
to pciutils build system. Therefore, at link time, the pciutils build
system was not taking into account the important --sysroot option,
which was breaking the link with external toolchains.

Fixes bug #523.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 CHANGES                      |    1 +
 package/pciutils/pciutils.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/CHANGES b/CHANGES
index 527383c..684b394 100644
--- a/CHANGES
+++ b/CHANGES
@@ -50,6 +50,7 @@
 	#495: Bump bind package to 9.5.1-P3 (security)
 	#497: OpenSSL RSA key generation hangs on x86_64
 	#509: Bump sqlite package to 3.6.16
+	#527: pciutils broken with external toolchain
 
 2009.05, Released June 1st, 2009:
 
diff --git a/package/pciutils/pciutils.mk b/package/pciutils/pciutils.mk
index 0d8155f..976afbf 100644
--- a/package/pciutils/pciutils.mk
+++ b/package/pciutils/pciutils.mk
@@ -41,7 +41,7 @@ $(PCIUTILS_DIR)/.unpacked: $(DL_DIR)/$(PCIUTILS_SOURCE) $(DL_DIR)/$(PCIIDS_SOURC
 	touch $@
 
 $(PCIUTILS_DIR)/.compiled: $(PCIUTILS_DIR)/.unpacked
-	$(MAKE1) CC="$(TARGET_CC)" OPT="$(TARGET_CFLAGS)" RANLIB=$(TARGET_RANLIB) AR=$(TARGET_AR) -C $(PCIUTILS_DIR) \
+	$(MAKE1) CC="$(TARGET_CC)" OPT="$(TARGET_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS)" RANLIB=$(TARGET_RANLIB) AR=$(TARGET_AR) -C $(PCIUTILS_DIR) \
 		SHAREDIR="/usr/share/misc" \
 		ZLIB=$(PCIUTILS_HAVE_ZLIB) \
 		HOST=$(KERNEL_ARCH)-linux \
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] pciutils: fix build with external toolchains
  2009-08-01 22:37 ` [Buildroot] [PATCH 1/1] pciutils: fix build with external toolchains Thomas Petazzoni
@ 2009-08-02  7:58   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2009-08-02  7:58 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Buildroot Makefile to compile pciutils wasn't passing TARGET_LDFLAGS
 Thomas> to pciutils build system. Therefore, at link time, the pciutils build
 Thomas> system was not taking into account the important --sysroot option,
 Thomas> which was breaking the link with external toolchains.

 Thomas> Fixes bug #523.

 Thomas> +++ b/CHANGES
 Thomas> @@ -50,6 +50,7 @@
 Thomas>  	#495: Bump bind package to 9.5.1-P3 (security)
 Thomas>  	#497: OpenSSL RSA key generation hangs on x86_64
 Thomas>  	#509: Bump sqlite package to 3.6.16
 Thomas> +	#527: pciutils broken with external toolchain

523, not 527 - But I'll fix that up myself.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [pull request] Pull request for branch pciutils-fix
  2009-08-01 22:37 [Buildroot] [pull request] Pull request for branch pciutils-fix Thomas Petazzoni
  2009-08-01 22:37 ` [Buildroot] [PATCH 1/1] pciutils: fix build with external toolchains Thomas Petazzoni
@ 2009-08-02  8:01 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2009-08-02  8:01 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The following changes since commit e15c0d07e15e94e800bd9a0cf3c24f45aeacd89c:
 Thomas>   Peter Korsgaard (1):
 Thomas>         target/device: rename program invocation symbol in defconfigs

 Thomas> are available in the git repository at:

 Thomas>   git://git.busybox.net/~tpetazzoni/git/buildroot pciutils-fix

 Thomas> Thomas Petazzoni (1):
 Thomas>       pciutils: fix build with external toolchains

Pulled and pushed, thanks!

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-02  8:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-01 22:37 [Buildroot] [pull request] Pull request for branch pciutils-fix Thomas Petazzoni
2009-08-01 22:37 ` [Buildroot] [PATCH 1/1] pciutils: fix build with external toolchains Thomas Petazzoni
2009-08-02  7:58   ` Peter Korsgaard
2009-08-02  8:01 ` [Buildroot] [pull request] Pull request for branch pciutils-fix Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.