All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, si-wei.liu@oracle.com
Subject: Re: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id
Date: Fri, 15 Apr 2022 11:00:37 +0800	[thread overview]
Message-ID: <87985be4-8cb0-2292-d799-5a91fb32acda@redhat.com> (raw)
In-Reply-To: <20220411122942.225717-3-elic@nvidia.com>


在 2022/4/11 20:29, Eli Cohen 写道:
> Add structure to define the payload of control VQ messages carrying the
> configured vlan ID. It will be used in subsequent patches of this
> series.
>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
> ---
>   include/uapi/linux/virtio_net.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index 3f55a4215f11..b94a405fa8d2 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -270,6 +270,9 @@ struct virtio_net_ctrl_mac {
>   #define VIRTIO_NET_CTRL_VLAN       2
>    #define VIRTIO_NET_CTRL_VLAN_ADD             0
>    #define VIRTIO_NET_CTRL_VLAN_DEL             1
> +struct virtio_net_ctrl_vlan {
> +	__virtio16 id;
> +};


It looks to me there's no need to bother uAPI and we can simply use 
__virtio16 in patch 3?

Thanks


>   
>   /*
>    * Control link announce acknowledgement


WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>, mst@redhat.com
Cc: si-wei.liu@oracle.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id
Date: Fri, 15 Apr 2022 11:00:37 +0800	[thread overview]
Message-ID: <87985be4-8cb0-2292-d799-5a91fb32acda@redhat.com> (raw)
In-Reply-To: <20220411122942.225717-3-elic@nvidia.com>


在 2022/4/11 20:29, Eli Cohen 写道:
> Add structure to define the payload of control VQ messages carrying the
> configured vlan ID. It will be used in subsequent patches of this
> series.
>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
> ---
>   include/uapi/linux/virtio_net.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index 3f55a4215f11..b94a405fa8d2 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -270,6 +270,9 @@ struct virtio_net_ctrl_mac {
>   #define VIRTIO_NET_CTRL_VLAN       2
>    #define VIRTIO_NET_CTRL_VLAN_ADD             0
>    #define VIRTIO_NET_CTRL_VLAN_DEL             1
> +struct virtio_net_ctrl_vlan {
> +	__virtio16 id;
> +};


It looks to me there's no need to bother uAPI and we can simply use 
__virtio16 in patch 3?

Thanks


>   
>   /*
>    * Control link announce acknowledgement

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2022-04-15  3:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 12:29 [PATCH 0/3 RESEND] mlx5_vdpa: Support MAC/VLAN haw offloading Eli Cohen
2022-04-11 12:29 ` [PATCH 1/3] vdpa/mlx5: Remove flow counter from steering Eli Cohen
2022-04-11 12:29 ` [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id Eli Cohen
2022-04-15  3:00   ` Jason Wang [this message]
2022-04-15  3:00     ` Jason Wang
2022-05-02  5:39     ` Eli Cohen
2022-04-11 12:29 ` [PATCH 3/3] vdpa/mlx5: Add RX MAC VLAN filter support Eli Cohen
2022-04-15  3:58   ` Jason Wang
2022-04-15  3:58     ` Jason Wang
2022-05-02  5:38     ` Eli Cohen
2022-05-05  8:14       ` Jason Wang
2022-05-05  8:14         ` Jason Wang
  -- strict thread matches above, loose matches on Subject: below --
2022-04-11 12:27 [PATCH 0/3] mlx5_vdpa: Support MAC/VLAN haw offloading Eli Cohen
2022-04-11 12:27 ` [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id Eli Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87985be4-8cb0-2292-d799-5a91fb32acda@redhat.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.