[PATCH v3] OpenCSD: Support for Arm CoreSight decode lib

[PATCH v3] OpenCSD: Support for Arm CoreSight decode lib

[Leo Yan]

This patch is to add recipe for OpenCSD, which is an open source
CoreSight trace decode library and utility.

Also create a new folder recipes-devtools under meta-arm to place
this recipe.

v3: Added support native building (Bertrand Marquis).

v2: Refined recipe to use '-C' make option so can catch make error
    (Bertrand Marquis).

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 .../recipes-devtools/opencsd/opencsd_git.bb   | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 meta-arm/recipes-devtools/opencsd/opencsd_git.bb

diff --git a/meta-arm/recipes-devtools/opencsd/opencsd_git.bb b/meta-arm/recipes-devtools/opencsd/opencsd_git.bb
new file mode 100644
index 0000000..f1d4cac
--- /dev/null
+++ b/meta-arm/recipes-devtools/opencsd/opencsd_git.bb
@@ -0,0 +1,31 @@
+SUMMARY = "OpenCSD - An open source CoreSight(tm) Trace Decode library"
+HOMEPAGE = "https://github.com/Linaro/OpenCSD"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=ad8cb685eb324d2fa2530b985a43f3e5"
+
+SRC_URI = "git://github.com/Linaro/OpenCSD;protocol=http;branch=master"
+SRCREV = "03c194117971e4ad0598df29395757ced2e6e9bd"
+
+S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST = "(x86_64.*|aarch64.*)-linux"
+
+EXTRA_OEMAKE = "ARCH='${TARGET_ARCH}' \
+                CROSS_COMPILE='${TARGET_SYS}-' \
+                CC='${CC}' \
+                CXX='${CXX}' \
+                LIB='${AR}' \
+                LINKER='${CXX}' \
+                LINUX64=1 \
+                DEBUG=1 \
+                "
+
+do_compile() {
+    oe_runmake -C ${S}/decoder/build/linux ${EXTRA_OEMAKE}
+}
+
+do_install() {
+    oe_runmake -C ${S}/decoder/build/linux PREFIX=${D}/usr install
+}
+
+BBCLASSEXTEND = "native"
-- 
2.17.1

Re: [PATCH v3] OpenCSD: Support for Arm CoreSight decode lib

[Bertrand Marquis]

[-- Attachment #1: Type: text/plain, Size: 2008 bytes --]



On 18 Mar 2020, at 07:19, Leo Yan <leo.yan@linaro.org<mailto:leo.yan@linaro.org>> wrote:

This patch is to add recipe for OpenCSD, which is an open source
CoreSight trace decode library and utility.

Also create a new folder recipes-devtools under meta-arm to place
this recipe.

v3: Added support native building (Bertrand Marquis).

v2: Refined recipe to use '-C' make option so can catch make error
   (Bertrand Marquis).

Signed-off-by: Leo Yan <leo.yan@linaro.org<mailto:leo.yan@linaro.org>>
---
.../recipes-devtools/opencsd/opencsd_git.bb   | 31 +++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 meta-arm/recipes-devtools/opencsd/opencsd_git.bb

diff --git a/meta-arm/recipes-devtools/opencsd/opencsd_git.bb b/meta-arm/recipes-devtools/opencsd/opencsd_git.bb
new file mode 100644
index 0000000..f1d4cac
--- /dev/null
+++ b/meta-arm/recipes-devtools/opencsd/opencsd_git.bb
@@ -0,0 +1,31 @@
+SUMMARY = "OpenCSD - An open source CoreSight(tm) Trace Decode library"
+HOMEPAGE = "https://github.com/Linaro/OpenCSD"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=ad8cb685eb324d2fa2530b985a43f3e5"
+
+SRC_URI = "git://github.com/Linaro/OpenCSD;protocol=http;branch=master"
+SRCREV = "03c194117971e4ad0598df29395757ced2e6e9bd"
+
+S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST = "(x86_64.*|aarch64.*)-linux"
+
+EXTRA_OEMAKE = "ARCH='${TARGET_ARCH}' \
+                CROSS_COMPILE='${TARGET_SYS}-' \
+                CC='${CC}' \
+                CXX='${CXX}' \
+                LIB='${AR}' \
+                LINKER='${CXX}' \
+                LINUX64=1 \
+                DEBUG=1 \
+                "
+
+do_compile() {
+    oe_runmake -C ${S}/decoder/build/linux ${EXTRA_OEMAKE}
+}
+
+do_install() {
+    oe_runmake -C ${S}/decoder/build/linux PREFIX=${D}/usr install
+}
+
+BBCLASSEXTEND = "native"
—
2.17.1


Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com<mailto:bertrand.marquis@arm.com>>




[-- Attachment #2: Type: text/html, Size: 4658 bytes --]

Re: [meta-arm] [PATCH v3] OpenCSD: Support for Arm CoreSight decode lib

[Jon Mason]

On Thu, Mar 19, 2020 at 08:01:49AM +0000, Bertrand Marquis wrote:
> 
> 
> On 18 Mar 2020, at 07:19, Leo Yan <leo.yan@linaro.org<mailto:leo.yan@linaro.org>> wrote:
> 
> This patch is to add recipe for OpenCSD, which is an open source
> CoreSight trace decode library and utility.
> 
> Also create a new folder recipes-devtools under meta-arm to place
> this recipe.
> 
> v3: Added support native building (Bertrand Marquis).
> 
> v2: Refined recipe to use '-C' make option so can catch make error
>    (Bertrand Marquis).

Applied to the master branch of meta-arm.  Nit, in thw future, if you
can add comments like v2 and v3 under a '---', it would save me from
having to edit the commit message to remove them.  Git will
automatically remove everything between the first --- and the start of
the patch (and this is how the do comments like this in emails on
LKML).

Thanks,
Jon

> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org<mailto:leo.yan@linaro.org>>
> ---
> .../recipes-devtools/opencsd/opencsd_git.bb   | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 meta-arm/recipes-devtools/opencsd/opencsd_git.bb
> 
> diff --git a/meta-arm/recipes-devtools/opencsd/opencsd_git.bb b/meta-arm/recipes-devtools/opencsd/opencsd_git.bb
> new file mode 100644
> index 0000000..f1d4cac
> --- /dev/null
> +++ b/meta-arm/recipes-devtools/opencsd/opencsd_git.bb
> @@ -0,0 +1,31 @@
> +SUMMARY = "OpenCSD - An open source CoreSight(tm) Trace Decode library"
> +HOMEPAGE = "https://github.com/Linaro/OpenCSD"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=ad8cb685eb324d2fa2530b985a43f3e5"
> +
> +SRC_URI = "git://github.com/Linaro/OpenCSD;protocol=http;branch=master"
> +SRCREV = "03c194117971e4ad0598df29395757ced2e6e9bd"
> +
> +S = "${WORKDIR}/git"
> +
> +COMPATIBLE_HOST = "(x86_64.*|aarch64.*)-linux"
> +
> +EXTRA_OEMAKE = "ARCH='${TARGET_ARCH}' \
> +                CROSS_COMPILE='${TARGET_SYS}-' \
> +                CC='${CC}' \
> +                CXX='${CXX}' \
> +                LIB='${AR}' \
> +                LINKER='${CXX}' \
> +                LINUX64=1 \
> +                DEBUG=1 \
> +                "
> +
> +do_compile() {
> +    oe_runmake -C ${S}/decoder/build/linux ${EXTRA_OEMAKE}
> +}
> +
> +do_install() {
> +    oe_runmake -C ${S}/decoder/build/linux PREFIX=${D}/usr install
> +}
> +
> +BBCLASSEXTEND = "native"
> —
> 2.17.1
> 
> 
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com<mailto:bertrand.marquis@arm.com>>
> 
> 
> 

> 

Re: [meta-arm] [PATCH v3] OpenCSD: Support for Arm CoreSight decode lib

[Leo Yan]

On Thu, Mar 19, 2020 at 05:04:24PM -0400, Jon Mason wrote:
> On Thu, Mar 19, 2020 at 08:01:49AM +0000, Bertrand Marquis wrote:
> > 
> > 
> > On 18 Mar 2020, at 07:19, Leo Yan <leo.yan@linaro.org<mailto:leo.yan@linaro.org>> wrote:
> > 
> > This patch is to add recipe for OpenCSD, which is an open source
> > CoreSight trace decode library and utility.
> > 
> > Also create a new folder recipes-devtools under meta-arm to place
> > this recipe.
> > 
> > v3: Added support native building (Bertrand Marquis).
> > 
> > v2: Refined recipe to use '-C' make option so can catch make error
> >    (Bertrand Marquis).
> 
> Applied to the master branch of meta-arm.  Nit, in thw future, if you
> can add comments like v2 and v3 under a '---', it would save me from
> having to edit the commit message to remove them.  Git will
> automatically remove everything between the first --- and the start of
> the patch (and this is how the do comments like this in emails on
> LKML).

Thank you, Jon.  I am aware this with your reminding and read a good
practice [1] and later will follow.

Thanks,
Leo

[1] https://lkml.org/lkml/2020/3/10/1403