[PATCH] Bluetooth: btqcomsmd: Fix module autoload

[PATCH] Bluetooth: btqcomsmd: Fix module autoload

[Javier Martinez Canillas]

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/bluetooth/btqcomsmd.ko | grep alias
$

After this patch:

$ modinfo drivers/bluetooth/btqcomsmd.ko | grep alias
alias:          of:N*T*Cqcom,wcnss-btC*
alias:          of:N*T*Cqcom,wcnss-bt

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/bluetooth/btqcomsmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
index 08c2c93887c1..8d4868af9bbd 100644
--- a/drivers/bluetooth/btqcomsmd.c
+++ b/drivers/bluetooth/btqcomsmd.c
@@ -165,6 +165,7 @@ static const struct of_device_id btqcomsmd_of_match[] = {
 	{ .compatible = "qcom,wcnss-bt", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, btqcomsmd_of_match);
 
 static struct platform_driver btqcomsmd_driver = {
 	.probe = btqcomsmd_probe,
-- 
2.7.4

Re: [PATCH] Bluetooth: btqcomsmd: Fix module autoload

[Javier Martinez Canillas]

Hello,

On 01/02/2017 10:09 AM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/bluetooth/btqcomsmd.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/bluetooth/btqcomsmd.ko | grep alias
> alias:          of:N*T*Cqcom,wcnss-btC*
> alias:          of:N*T*Cqcom,wcnss-bt
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] Bluetooth: btqcomsmd: Fix module autoload

[Marcel Holtmann]

Hi Javier,

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/bluetooth/btqcomsmd.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/bluetooth/btqcomsmd.ko | grep alias
> alias:          of:N*T*Cqcom,wcnss-btC*
> alias:          of:N*T*Cqcom,wcnss-bt
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
> drivers/bluetooth/btqcomsmd.c | 1 +
> 1 file changed, 1 insertion(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel