All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Egorenkov <egorenar@linux.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, axboe@kernel.dk, david@redhat.com,
	hch@infradead.org, hch@lst.de, hdanton@sina.com, jack@suse.cz,
	jgg@nvidia.com, jhubbard@nvidia.com, jlayton@kernel.org,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	logang@deltatee.com, viro@zeniv.linux.org.uk,
	willy@infradead.org, Marc Hartmayer <mhartmay@linux.ibm.com>
Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE
Date: Sat, 18 Feb 2023 09:29:11 +0100	[thread overview]
Message-ID: <87a61b9y20.fsf@oc8242746057.ibm.com> (raw)
In-Reply-To: <732891.1676670463@warthog.procyon.org.uk>
In-Reply-To: 

Hi David,


David Howells <dhowells@redhat.com> writes:

> Does the attached fix the problem for you?  The data being written into the
> pipe needs to be limited to the size of the file.
>
> David
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index c01bbcb9fa92..6362ac697a70 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2948,7 +2948,8 @@ ssize_t filemap_splice_read(struct file *in, loff_t *ppos,
>  			if (writably_mapped)
>  				flush_dcache_folio(folio);
>  
> -			n = splice_folio_into_pipe(pipe, folio, *ppos, len);
> +			n = min_t(loff_t, len, isize - *ppos);
> +			n = splice_folio_into_pipe(pipe, folio, *ppos, n);
>  			if (!n)
>  				goto out;
>  			len -= n;

Yes, this change fixed the problem.

Thanks
Regards
Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Egorenkov <egorenar@linux.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, axboe@kernel.dk, david@redhat.com,
	hch@infradead.org, hch@lst.de, hdanton@sina.com, jack@suse.cz,
	jgg@nvidia.com, jhubbard@nvidia.com, jlayton@kernel.org,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	logang@deltatee.com, viro@zeniv.linux.org.uk,
	willy@infradead.org, Marc Hartmayer <mhartmay@linux.ibm.com>
Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE
Date: Sat, 18 Feb 2023 09:29:11 +0100	[thread overview]
Message-ID: <87a61b9y20.fsf@oc8242746057.ibm.com> (raw)
In-Reply-To: <732891.1676670463@warthog.procyon.org.uk>
In-Reply-To: 

Hi David,


David Howells <dhowells@redhat.com> writes:

> Does the attached fix the problem for you?  The data being written into the
> pipe needs to be limited to the size of the file.
>
> David
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index c01bbcb9fa92..6362ac697a70 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2948,7 +2948,8 @@ ssize_t filemap_splice_read(struct file *in, loff_t *ppos,
>  			if (writably_mapped)
>  				flush_dcache_folio(folio);
>  
> -			n = splice_folio_into_pipe(pipe, folio, *ppos, len);
> +			n = min_t(loff_t, len, isize - *ppos);
> +			n = splice_folio_into_pipe(pipe, folio, *ppos, n);
>  			if (!n)
>  				goto out;
>  			len -= n;

Yes, this change fixed the problem.

Thanks
Regards
Alex


  reply	other threads:[~2023-02-18  8:29 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 17:13 [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) David Howells
2023-02-14 17:13 ` [PATCH v14 01/17] mm: Pass info, not iter, into filemap_get_pages() David Howells
2023-02-14 17:13 ` [PATCH v14 02/17] splice: Add a func to do a splice from a buffered file without ITER_PIPE David Howells
2023-02-18  2:41   ` Ming Lei
2023-02-18  9:25   ` David Howells
2023-02-14 17:13 ` [PATCH v14 03/17] splice: Add a func to do a splice from an O_DIRECT " David Howells
2023-02-14 17:13 ` [PATCH v14 04/17] shmem: Implement splice-read David Howells
2023-02-14 17:13 ` [PATCH v14 05/17] overlayfs: " David Howells
2023-02-15 14:21   ` Miklos Szeredi
2023-02-15 15:03   ` David Howells
2023-02-15 15:32     ` Miklos Szeredi
2023-02-15 15:40   ` [PATCH v15 " David Howells
2023-02-15 15:50     ` Miklos Szeredi
2023-02-15 15:53       ` Matthew Wilcox
2023-02-15 16:38         ` Christoph Hellwig
2023-02-15 16:40         ` Miklos Szeredi
2023-02-15 15:58     ` David Howells
2023-02-14 17:13 ` [PATCH v14 06/17] coda: " David Howells
2023-02-14 18:04   ` Jan Harkes
2023-02-14 17:13 ` [PATCH v14 07/17] tty, proc, kernfs, random: Use direct_splice_read() David Howells
2023-02-14 17:13 ` [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE David Howells
2023-02-14 17:24   ` Mezgani Ali
2023-02-17  8:22   ` Ming Lei
2023-02-17  9:18     ` Ming Lei
2023-02-17 20:39   ` Alexander Egorenkov
2023-02-17 20:59     ` egorenar
2023-02-17 21:24       ` David Howells
2023-02-17 21:16     ` David Howells
2023-02-17 21:47     ` David Howells
2023-02-18  8:29       ` Alexander Egorenkov [this message]
2023-02-18  8:29         ` Alexander Egorenkov
2023-02-18  9:18       ` David Howells
2023-02-14 17:13 ` [PATCH v14 09/17] iov_iter: Kill ITER_PIPE David Howells
2023-02-14 17:13 ` [PATCH v14 10/17] iov_iter: Define flags to qualify page extraction David Howells
2023-02-14 17:13 ` [PATCH v14 11/17] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-02-14 17:13 ` [PATCH v14 12/17] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-02-14 17:13 ` [PATCH v14 13/17] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-02-14 17:13 ` [PATCH v14 14/17] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-02-14 17:13 ` [PATCH v14 15/17] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-02-14 17:13 ` [PATCH v14 16/17] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-02-14 17:13 ` [PATCH v14 17/17] block: convert bio_map_user_iov " David Howells
2023-02-14 22:56 ` [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) David Howells
2023-02-14 23:05   ` Jens Axboe
2023-02-15  8:07   ` David Howells
2023-02-15 14:23     ` Christoph Hellwig
2023-02-15 14:38       ` Christoph Hellwig
2023-02-15 15:43       ` David Howells
2023-02-15  8:20   ` David Howells
2023-02-14 23:01 ` David Howells
2023-02-14 23:01   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a61b9y20.fsf@oc8242746057.ibm.com \
    --to=egorenar@linux.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=david@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=hdanton@sina.com \
    --cc=jack@suse.cz \
    --cc=jgg@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=jlayton@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=logang@deltatee.com \
    --cc=mhartmay@linux.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.