* [PATCH] fault-inject: Enable stacktrace filter for x86-64
@ 2022-11-10 11:30 Jakub Sitnicki
2022-11-11 16:41 ` Akinobu Mita
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Sitnicki @ 2022-11-10 11:30 UTC (permalink / raw)
To: linux-kernel; +Cc: kernel-team, linux-kbuild, x86, Akinobu Mita, Andrew Morton
Stacktrace filtering for fault injection has been disabled on x86-64 since
2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
injection: disable stacktrace filter for x86-64").
In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").
We can now re-enable the stacktrace filter for x86-64.
Cc: linux-kbuild@vger.kernel.org
Cc: x86@kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 3fc7abffc7aa..32c5329b0dd9 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1963,7 +1963,6 @@ config FAIL_SUNRPC
config FAULT_INJECTION_STACKTRACE_FILTER
bool "stacktrace filter for fault-injection capabilities"
depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
- depends on !X86_64
select STACKTRACE
depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
help
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fault-inject: Enable stacktrace filter for x86-64
2022-11-10 11:30 [PATCH] fault-inject: Enable stacktrace filter for x86-64 Jakub Sitnicki
@ 2022-11-11 16:41 ` Akinobu Mita
2022-11-14 9:56 ` Jakub Sitnicki
0 siblings, 1 reply; 3+ messages in thread
From: Akinobu Mita @ 2022-11-11 16:41 UTC (permalink / raw)
To: Jakub Sitnicki
Cc: linux-kernel, kernel-team, linux-kbuild, x86, Andrew Morton, Wei Yongjun
2022年11月10日(木) 20:30 Jakub Sitnicki <jakub@cloudflare.com>:
>
> Stacktrace filtering for fault injection has been disabled on x86-64 since
> 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
> injection: disable stacktrace filter for x86-64").
>
> In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
> in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").
>
> We can now re-enable the stacktrace filter for x86-64.
The same change by Wei Yongjun is already in the linux-next via -mm tree.
But thank you for the good explanation.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fault-inject: Enable stacktrace filter for x86-64
2022-11-11 16:41 ` Akinobu Mita
@ 2022-11-14 9:56 ` Jakub Sitnicki
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Sitnicki @ 2022-11-14 9:56 UTC (permalink / raw)
To: Akinobu Mita
Cc: linux-kernel, kernel-team, linux-kbuild, x86, Andrew Morton, Wei Yongjun
On Sat, Nov 12, 2022 at 01:41 AM +09, Akinobu Mita wrote:
> 2022年11月10日(木) 20:30 Jakub Sitnicki <jakub@cloudflare.com>:
>>
>> Stacktrace filtering for fault injection has been disabled on x86-64 since
>> 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
>> injection: disable stacktrace filter for x86-64").
>>
>> In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
>> in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").
>>
>> We can now re-enable the stacktrace filter for x86-64.
>
> The same change by Wei Yongjun is already in the linux-next via -mm tree.
>
> But thank you for the good explanation.
Thanks for letting me know. Will check linux-next next time.
Please ignore my patch. Sorry for the noise.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-14 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 11:30 [PATCH] fault-inject: Enable stacktrace filter for x86-64 Jakub Sitnicki
2022-11-11 16:41 ` Akinobu Mita
2022-11-14 9:56 ` Jakub Sitnicki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.