* [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static
@ 2022-04-27 21:28 Zhi Wang
2022-04-27 21:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n Zhi Wang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zhi Wang @ 2022-04-27 21:28 UTC (permalink / raw)
To: intel-gvt-dev, intel-gfx; +Cc: Jason Gunthorpe
After the refactor of GVT-g, the reference of intel_gvt_match_device()
only happens in handlers.c. Make it static to let the compiler be
happy.
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Robert Beckett <bob.beckett@collabora.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
---
drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index cf00398c2870..a93f8fd423c2 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -72,7 +72,7 @@ unsigned long intel_gvt_get_device_type(struct intel_gvt *gvt)
return 0;
}
-bool intel_gvt_match_device(struct intel_gvt *gvt,
+static bool intel_gvt_match_device(struct intel_gvt *gvt,
unsigned long device)
{
return intel_gvt_get_device_type(gvt) & device;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
2022-04-27 21:28 [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static Zhi Wang
@ 2022-04-27 21:28 ` Zhi Wang
2022-04-28 8:29 ` Jani Nikula
2022-04-27 21:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gvt: Make intel_gvt_match_device() static Patchwork
2022-04-28 8:28 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
2 siblings, 1 reply; 5+ messages in thread
From: Zhi Wang @ 2022-04-27 21:28 UTC (permalink / raw)
To: intel-gvt-dev, intel-gfx; +Cc: Jason Gunthorpe
A compiling error was reported when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n.
Fix the problem by using the pre-defined macro.
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
---
drivers/gpu/drm/i915/intel_gvt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_gvt.c b/drivers/gpu/drm/i915/intel_gvt.c
index 24bc693439e8..e98b6d69a91a 100644
--- a/drivers/gpu/drm/i915/intel_gvt.c
+++ b/drivers/gpu/drm/i915/intel_gvt.c
@@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT);
EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
+#endif
EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gvt: Make intel_gvt_match_device() static
2022-04-27 21:28 [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static Zhi Wang
2022-04-27 21:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n Zhi Wang
@ 2022-04-27 21:33 ` Patchwork
2022-04-28 8:28 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-04-27 21:33 UTC (permalink / raw)
To: Zhi Wang; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/gvt: Make intel_gvt_match_device() static
URL : https://patchwork.freedesktop.org/series/103237/
State : failure
== Summary ==
Error: patch https://patchwork.freedesktop.org/api/1.0/series/103237/revisions/1/mbox/ not applied
Applying: drm/i915/gvt: Make intel_gvt_match_device() static
Applying: drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/intel_gvt.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/intel_gvt.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/intel_gvt.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static
2022-04-27 21:28 [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static Zhi Wang
2022-04-27 21:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n Zhi Wang
2022-04-27 21:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gvt: Make intel_gvt_match_device() static Patchwork
@ 2022-04-28 8:28 ` Jani Nikula
2 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2022-04-28 8:28 UTC (permalink / raw)
To: Zhi Wang, intel-gvt-dev, intel-gfx; +Cc: Jason Gunthorpe
On Wed, 27 Apr 2022, Zhi Wang <zhi.wang.linux@gmail.com> wrote:
> After the refactor of GVT-g, the reference of intel_gvt_match_device()
> only happens in handlers.c. Make it static to let the compiler be
> happy.
>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Robert Beckett <bob.beckett@collabora.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index cf00398c2870..a93f8fd423c2 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -72,7 +72,7 @@ unsigned long intel_gvt_get_device_type(struct intel_gvt *gvt)
> return 0;
> }
>
> -bool intel_gvt_match_device(struct intel_gvt *gvt,
> +static bool intel_gvt_match_device(struct intel_gvt *gvt,
> unsigned long device)
> {
> return intel_gvt_get_device_type(gvt) & device;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
2022-04-27 21:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n Zhi Wang
@ 2022-04-28 8:29 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2022-04-28 8:29 UTC (permalink / raw)
To: Zhi Wang, intel-gvt-dev, intel-gfx; +Cc: Jason Gunthorpe
On Wed, 27 Apr 2022, Zhi Wang <zhi.wang.linux@gmail.com> wrote:
> A compiling error was reported when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n.
> Fix the problem by using the pre-defined macro.
>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
We'll get this right, for now, but I do wonder if breaking these is
going to be a perpetual thing. :(
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_gvt.c b/drivers/gpu/drm/i915/intel_gvt.c
> index 24bc693439e8..e98b6d69a91a 100644
> --- a/drivers/gpu/drm/i915/intel_gvt.c
> +++ b/drivers/gpu/drm/i915/intel_gvt.c
> @@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
> +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
> +#endif
> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-28 8:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 21:28 [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static Zhi Wang
2022-04-27 21:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n Zhi Wang
2022-04-28 8:29 ` Jani Nikula
2022-04-27 21:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gvt: Make intel_gvt_match_device() static Patchwork
2022-04-28 8:28 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.