All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/3] API/cgroup: Shorten cgroup to cg in most symbols
Date: Thu, 10 Feb 2022 07:32:27 +0000	[thread overview]
Message-ID: <87a6ezkwes.fsf@suse.de> (raw)
In-Reply-To: <CAEemH2fjSLAdY4xO7WMekGX=3sPFjt0xVknNxJedk1-agsb3zQ@mail.gmail.com>

Hello Li,

Li Wang <liwang@redhat.com> writes:

> On Tue, Feb 8, 2022 at 10:04 PM Richard Palethorpe via ltp <ltp@lists.linux.it> wrote:
>
>  With the current naming it is common to have 'group' repeated 3 or
>  even 4 times in one line. This causes a number of readability
>  problems. Renaming it to cg reduces the amount of repetition.
>
>  The one place it is not renamed is in tst_test because it won't cause
>  repetition there. Meanwhile it is easier to search the internet for
>  'linux cgroup' than 'linux cg'.
>
>  Li Wang suggested renaming tst_cg to tst_cg_test because it is
>  consistent with tst_cg_drain. However I think tst_cg is used so often
>  that it is more important to have shorter lines.
>
> To be honest, I only wanted that tst_cg_test pointer :).

I understand, but I saw that a lot of lines had become too long with
other changes. It's starting to get difficult to manage.

>
> But I have no objection to renaming 'tst_cgroup_*' to 'tst_cg_*'
> for the whole APIs. (Though I don't like it)
>
> Let's hear more voices from peers.

;-)


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-02-10  7:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 14:03 [LTP] [PATCH 0/3] memcontrol04 and s/cgroup/cg/ Richard Palethorpe via ltp
2022-02-08 14:03 ` [LTP] [PATCH 1/3] API/cgroup: Add memory.{events, low} Richard Palethorpe via ltp
2022-02-16 15:27   ` Cyril Hrubis
2022-02-17  3:14   ` Li Wang
2022-02-08 14:03 ` [LTP] [PATCH 2/3] API/cgroup: Shorten cgroup to cg in most symbols Richard Palethorpe via ltp
2022-02-09  4:51   ` Li Wang
2022-02-10  7:32     ` Richard Palethorpe [this message]
2022-02-16 15:26     ` Cyril Hrubis
2022-02-17  3:13       ` Li Wang
2022-02-17  5:37         ` Richard Palethorpe
2022-02-08 14:03 ` [LTP] [PATCH 3/3] memcontrol04: Copy from kselftest Richard Palethorpe via ltp
2022-02-09 10:47   ` Li Wang
2022-02-10  7:34     ` Richard Palethorpe
2022-02-09 11:05   ` Li Wang
2022-02-10  6:23     ` Li Wang
2022-02-10  7:12       ` Li Wang
2022-02-14  5:40         ` Richard Palethorpe
2022-02-16 10:13           ` Li Wang
2022-02-17  4:35             ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6ezkwes.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.