Re: [LTP] [PATCH 3/3] memcontrol04: Copy from kselftest

[Li Wang <liwang@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 4602 bytes --]

Hi Richard,

On Mon, Feb 14, 2022 at 2:07 PM Richard Palethorpe <rpalethorpe@suse.de>
wrote:

> Hello Li,
>
> Li Wang <liwang@redhat.com> writes:
>
> > On Thu, Feb 10, 2022 at 2:23 PM Li Wang <liwang@redhat.com> wrote:
> >
> >  On Wed, Feb 9, 2022 at 7:05 PM Li Wang <liwang@redhat.com> wrote:
> >
> >  Btw, there are some TFAILs from my manual run.
> >  (I will look into that try to figure it out tomorrow)
> >
> >  tst_test.c:1521: TINFO: Testing on ext4
> >  tst_test.c:996: TINFO: Formatting /dev/loop0 with ext4 opts='' extra
> opts=''
> >  mke2fs 1.46.5 (30-Dec-2021)
> >  tst_test.c:1452: TINFO: Timeout per run is 0h 05m 00s
> >  memcontrol04.c:118: TINFO: Child 242775 in leaf_C: Allocating
> pagecache: 52428800
> >  memcontrol04.c:118: TINFO: Child 242776 in leaf_D: Allocating
> pagecache: 52428800
> >  memcontrol04.c:118: TINFO: Child 242777 in leaf_F: Allocating
> pagecache: 52428800
> >  memcontrol04.c:99: TINFO: Child 242778 in trunk_G: Allocating anon:
> 155189248
> >  memcontrol04.c:170: TPASS: Expect: (A/B memory.current=54181888) ~=
> 52428800
> >  memcontrol04.c:176: TPASS: Expect: (A/B/C memory.current=30957568) ~=
> 34603008
> >  memcontrol04.c:178: TPASS: Expect: (A/B/D memory.current=22282240) ~=
> 17825792
> >  memcontrol04.c:180: TPASS: Expect: (A/B/E memory.current=0) ~= 0
> >  memcontrol04.c:99: TINFO: Child 242779 in trunk_G: Allocating anon:
> 174063616
> >  memcontrol04.c:193: TPASS: Expect: (oom events=0) == 0
> >  memcontrol04.c:196: TPASS: Expect: (low events=373) > 0
> >  memcontrol04.c:193: TPASS: Expect: (oom events=0) == 0
> >  memcontrol04.c:196: TPASS: Expect: (low events=373) > 0
> >  memcontrol04.c:193: TPASS: Expect: (oom events=0) == 0
> >  memcontrol04.c:198: TPASS: Expect: (low events=0) == 0
> >  memcontrol04.c:193: TPASS: Expect: (oom events=0) == 0
> >  memcontrol04.c:198: TFAIL: Expect: (low events=370) == 0
> >
> >  It looks like a logic issue here, as we do alloc_pagecache 50MB
> >  respectively in the leaf_cg[C, D, E, F] and only the 'memory.low'
> >
> > My apologies, the leaf_cg[E] does not have 50MB page cache
> > allocating, that is the main reason with no memory reclaims happening.
> > '500MB' low boundary obviously overcommitment, so leaf_cg[E] will
> > get the part of parent’s protection proportional to its actual memory
> > usage. However, it doesn't matter for this case, leaf_cg[E] can get
> > no event grows as well. Because it has no memory consumption at all.
>
> leaf_cg[F]'s memory.low == 0. So how can it have reclaim events where
> memory.current < memory.low?
>
> Testing on the upstream kernel there are no low events in F.
>

A bit weird...

From my test, it indeed has the events that occur.
(even the original test fail as the same)
And the leaf_cg[F]'s memory.current is almost 1MB.

# uname -r
5.17.0-rc4.liwang
...
tst_test.c:1521: TINFO: Testing on xfs
tst_test.c:996: TINFO: Formatting /dev/loop0 with xfs opts='' extra opts=''
tst_test.c:1452: TINFO: Timeout per run is 0h 05m 00s
memcontrol04.c:118: TINFO: Child 21200 in leaf_C: Allocating pagecache:
52428800
memcontrol04.c:118: TINFO: Child 21201 in leaf_D: Allocating pagecache:
52428800
memcontrol04.c:118: TINFO: Child 21202 in leaf_F: Allocating pagecache:
52428800
memcontrol04.c:99: TINFO: Child 21203 in trunk_G: Allocating anon: 155189248
memcontrol04.c:170: TPASS: Expect: (A/B memory.current=54083584) ~= 52428800
memcontrol04.c:176: TPASS: Expect: (A/B/C memory.current=29822976) ~=
34603008
memcontrol04.c:178: TPASS: Expect: (A/B/D memory.current=22061056) ~=
17825792
memcontrol04.c:180: TPASS: Expect: (A/B/E memory.current=0) ~= 0
memcontrol04.c:99: TINFO: Child 21204 in trunk_G: Allocating anon: 174063616
memcontrol04.c:193: TPASS: Expect: (leaf_cg0: oom events=0) == 0
memcontrol04.c:196: TPASS: Expect: (leaf_cg0: low events=427) > 0
memcontrol04.c:193: TPASS: Expect: (leaf_cg1: oom events=0) == 0
memcontrol04.c:196: TPASS: Expect: (leaf_cg1: low events=427) > 0
memcontrol04.c:193: TPASS: Expect: (leaf_cg2: oom events=0) == 0
memcontrol04.c:198: TPASS: Expect: (leaf_cg2: low events=0) == 0
memcontrol04.c:193: TPASS: Expect: (leaf_cg3: oom events=0) == 0
memcontrol04.c:198: TFAIL: Expect: (leaf_cg3: low events=415) == 0

Summary:
passed   44
failed   4
broken   0
skipped  0
warnings 0


# pwd
/root/linux-5.17-rc4/tools/testing/selftests/cgroup

# ./test_memcontrol
ok 1 test_memcg_subtree_control
ok 2 test_memcg_current
ok 3 test_memcg_min
not ok 4 test_memcg_low

-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 6432 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp