From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
regressions@lists.linux.dev, mhi <mhi@lists.linux.dev>
Subject: Re: [regression] mhi: ath11k resume fails on some devices
Date: Thu, 07 Oct 2021 12:48:19 +0300 [thread overview]
Message-ID: <87a6jl9ndo.fsf@codeaurora.org> (raw)
In-Reply-To: <CAMZdPi8P7YZPhPir+WfS3cY_a7He1m2Pq2uqBhczPdEeoNRb0Q@mail.gmail.com> (Loic Poulain's message of "Fri, 24 Sep 2021 11:43:55 +0200")
(adding the new mhi list, yay)
Hi Loic,
Loic Poulain <loic.poulain@linaro.org> writes:
>> Loic Poulain <loic.poulain@linaro.org> writes:
>>
>> > On Thu, 16 Sept 2021 at 10:00, Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> >> At the moment I'm running my tests with commit 020d3b26c07a reverted and
>> >> everything works without problems. Is there a simple way to fix this? Or
>> >> maybe we should just revert the commit? Commit log and kernel logs from
>> >> a failing case below.
>> >
>> > Do you have log of success case?
>>
>> A log from a successful case in the end of email, using v5.15-rc1 plus
>> revert of commit 020d3b26c07abe27.
>>
>> > To me, the device loses power, that is why MHI resuming is failing.
>> > Normally the device should be properly recovered/reinitialized. Before
>> > that patch the power loss was simply not detected (or handled at
>> > higher stack level).
>>
>> Currently in ath11k we always keep the firmware running when in suspend,
>> this is a workaround due to problems between mac80211 and MHI stack.
>> IIRC the problem was something related MHI creating struct device during
>> resume or something like that.
>
> Could you give a try with the attached patch? It should solve your
> issue without breaking modem support.
Sorry for taking so long, but I now tested your patch on top of
v5.15-rc3 and, as expected, everything works as before with QCA6390 on
NUC x86 testbox.
Tested-by: Kalle Valo <kvalo@codeaurora.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
regressions@lists.linux.dev, mhi <mhi@lists.linux.dev>
Subject: Re: [regression] mhi: ath11k resume fails on some devices
Date: Thu, 07 Oct 2021 12:48:19 +0300 [thread overview]
Message-ID: <87a6jl9ndo.fsf@codeaurora.org> (raw)
In-Reply-To: <CAMZdPi8P7YZPhPir+WfS3cY_a7He1m2Pq2uqBhczPdEeoNRb0Q@mail.gmail.com> (Loic Poulain's message of "Fri, 24 Sep 2021 11:43:55 +0200")
(adding the new mhi list, yay)
Hi Loic,
Loic Poulain <loic.poulain@linaro.org> writes:
>> Loic Poulain <loic.poulain@linaro.org> writes:
>>
>> > On Thu, 16 Sept 2021 at 10:00, Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> >> At the moment I'm running my tests with commit 020d3b26c07a reverted and
>> >> everything works without problems. Is there a simple way to fix this? Or
>> >> maybe we should just revert the commit? Commit log and kernel logs from
>> >> a failing case below.
>> >
>> > Do you have log of success case?
>>
>> A log from a successful case in the end of email, using v5.15-rc1 plus
>> revert of commit 020d3b26c07abe27.
>>
>> > To me, the device loses power, that is why MHI resuming is failing.
>> > Normally the device should be properly recovered/reinitialized. Before
>> > that patch the power loss was simply not detected (or handled at
>> > higher stack level).
>>
>> Currently in ath11k we always keep the firmware running when in suspend,
>> this is a workaround due to problems between mac80211 and MHI stack.
>> IIRC the problem was something related MHI creating struct device during
>> resume or something like that.
>
> Could you give a try with the attached patch? It should solve your
> issue without breaking modem support.
Sorry for taking so long, but I now tested your patch on top of
v5.15-rc3 and, as expected, everything works as before with QCA6390 on
NUC x86 testbox.
Tested-by: Kalle Valo <kvalo@codeaurora.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-10-07 9:48 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:00 [regression] mhi: ath11k resume fails on some devices Kalle Valo
2021-09-16 8:00 ` Kalle Valo
2021-09-16 10:18 ` Loic Poulain
2021-09-16 10:18 ` Loic Poulain
2021-09-16 10:18 ` Loic Poulain
2021-09-16 11:12 ` Manivannan Sadhasivam
2021-09-16 11:12 ` Manivannan Sadhasivam
[not found] ` <CAMZdPi94607mZorp+Zmkw3seWXak6p9Jr05CQ5hhfgKQoG8n7Q@mail.gmail.com>
2021-09-16 16:35 ` Manivannan Sadhasivam
2021-09-16 16:35 ` Manivannan Sadhasivam
2021-09-16 16:42 ` Kalle Valo
2021-09-16 16:42 ` Kalle Valo
2021-09-16 16:42 ` Kalle Valo
2021-09-16 17:19 ` Manivannan Sadhasivam
2021-09-16 17:19 ` Manivannan Sadhasivam
2021-09-23 8:34 ` Carl Huang
2021-09-23 8:34 ` Carl Huang
2021-09-23 8:59 ` Manivannan Sadhasivam
2021-09-23 8:59 ` Manivannan Sadhasivam
2021-09-23 9:26 ` Carl Huang
2021-09-23 9:26 ` Carl Huang
2021-09-23 10:50 ` Loic Poulain
2021-09-23 10:50 ` Loic Poulain
2021-09-23 10:50 ` Loic Poulain
2021-09-24 9:07 ` Kalle Valo
2021-09-24 9:07 ` Kalle Valo
2021-09-24 9:07 ` Kalle Valo
2021-09-24 9:57 ` Manivannan Sadhasivam
2021-09-24 9:57 ` Manivannan Sadhasivam
2021-10-07 9:55 ` Kalle Valo
2021-10-07 9:55 ` Kalle Valo
2021-10-21 10:01 ` Manivannan Sadhasivam
2021-10-21 10:01 ` Manivannan Sadhasivam
2021-09-24 8:36 ` Kalle Valo
2021-09-24 8:36 ` Kalle Valo
2021-09-24 8:36 ` Kalle Valo
2021-09-24 9:43 ` Loic Poulain
2021-09-24 9:43 ` Loic Poulain
2021-09-24 9:43 ` Loic Poulain
2021-09-24 10:00 ` Manivannan Sadhasivam
2021-09-24 10:00 ` Manivannan Sadhasivam
2021-10-07 9:48 ` Kalle Valo [this message]
2021-10-07 9:48 ` Kalle Valo
2021-10-19 12:12 ` Kalle Valo
2021-10-19 12:12 ` Kalle Valo
2021-10-21 10:03 ` Manivannan Sadhasivam
2021-10-21 10:03 ` Manivannan Sadhasivam
2021-11-12 11:36 ` Thorsten Leemhuis
2021-11-12 11:36 ` Thorsten Leemhuis
2021-11-18 17:41 ` Manivannan Sadhasivam
2021-11-18 17:41 ` Manivannan Sadhasivam
2021-12-01 7:34 ` Thorsten Leemhuis
2021-12-01 7:34 ` Thorsten Leemhuis
2021-09-25 17:40 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6jl9ndo.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.