* [Buildroot] [PATCH v2 0/2] fix for alsa-lib support for python
@ 2021-09-09 15:17 Illia Bitkov
2021-09-09 15:17 ` [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config Illia Bitkov
2021-09-09 15:17 ` [Buildroot] [PATCH v2 2/2] package/alsa-lib: always use python3 Illia Bitkov
0 siblings, 2 replies; 5+ messages in thread
From: Illia Bitkov @ 2021-09-09 15:17 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Illia Bitkov, Adam Dusketta
Hello.
First patch adding module smixer-python to build when option "Python support for alsa-lib" is active.
Currently this option doesn't influence a build at all.
Also smixer-python is the only component that depends on python and also supports python3.
So second patch removes dependancy to python2.
In v2 made commits cleaner
Illia Bitkov (2):
package/alsa-lib: add smixer-python module for alsa-lib python config
package/alsa-lib: always use python3
package/alsa-lib/Config.in | 2 +-
package/alsa-lib/alsa-lib.mk | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config
2021-09-09 15:17 [Buildroot] [PATCH v2 0/2] fix for alsa-lib support for python Illia Bitkov
@ 2021-09-09 15:17 ` Illia Bitkov
2021-09-21 19:04 ` Arnout Vandecappelle
2021-09-09 15:17 ` [Buildroot] [PATCH v2 2/2] package/alsa-lib: always use python3 Illia Bitkov
1 sibling, 1 reply; 5+ messages in thread
From: Illia Bitkov @ 2021-09-09 15:17 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Illia Bitkov, Adam Dusketta
Add simple mixer python bindings to build when "Python support for alsa-lib" is active.
smixer-python is the only one python module which exists in alsa-lib.
Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
---
package/alsa-lib/Config.in | 2 +-
package/alsa-lib/alsa-lib.mk | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
index f334b66bff..4168d1f220 100644
--- a/package/alsa-lib/Config.in
+++ b/package/alsa-lib/Config.in
@@ -22,7 +22,7 @@ if BR2_PACKAGE_ALSA_LIB
config BR2_PACKAGE_ALSA_LIB_PYTHON
bool "Python support for alsa-lib"
- depends on BR2_PACKAGE_PYTHON
+ depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
help
Add python support for alsa-lib.
Python will be built and libpython will be installed
diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
index c71ad5dd58..99c53f9408 100644
--- a/package/alsa-lib/alsa-lib.mk
+++ b/package/alsa-lib/alsa-lib.mk
@@ -57,12 +57,22 @@ ALSA_LIB_CONF_OPTS += --disable-old-symbols
endif
ifeq ($(BR2_PACKAGE_ALSA_LIB_PYTHON),y)
+ALSA_LIB_CONF_OPTS += \
+ --enable-mixer-pymods
+ifeq ($(BR2_PACKAGE_PYTHON),y)
ALSA_LIB_CONF_OPTS += \
--with-pythonlibs=-lpython$(PYTHON_VERSION_MAJOR) \
--with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
ALSA_LIB_DEPENDENCIES = python
else
+ALSA_LIB_CONF_OPTS += \
+ --with-pythonlibs=-lpython$(PYTHON3_VERSION_MAJOR) \
+ --with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
+ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
+ALSA_LIB_DEPENDENCIES = python3
+endif
+else
ALSA_LIB_CONF_OPTS += --disable-python
endif
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/alsa-lib: always use python3
2021-09-09 15:17 [Buildroot] [PATCH v2 0/2] fix for alsa-lib support for python Illia Bitkov
2021-09-09 15:17 ` [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config Illia Bitkov
@ 2021-09-09 15:17 ` Illia Bitkov
1 sibling, 0 replies; 5+ messages in thread
From: Illia Bitkov @ 2021-09-09 15:17 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Illia Bitkov, Adam Dusketta
Python is only required for smixer-python and it supports python3
Because python2 is deprecated removing it as a build dependacy
Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
---
package/alsa-lib/Config.in | 2 +-
package/alsa-lib/alsa-lib.mk | 11 +----------
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
index 4168d1f220..af3de984d9 100644
--- a/package/alsa-lib/Config.in
+++ b/package/alsa-lib/Config.in
@@ -22,7 +22,7 @@ if BR2_PACKAGE_ALSA_LIB
config BR2_PACKAGE_ALSA_LIB_PYTHON
bool "Python support for alsa-lib"
- depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+ depends on BR2_PACKAGE_PYTHON3
help
Add python support for alsa-lib.
Python will be built and libpython will be installed
diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
index 99c53f9408..4e9fc916df 100644
--- a/package/alsa-lib/alsa-lib.mk
+++ b/package/alsa-lib/alsa-lib.mk
@@ -58,20 +58,11 @@ endif
ifeq ($(BR2_PACKAGE_ALSA_LIB_PYTHON),y)
ALSA_LIB_CONF_OPTS += \
- --enable-mixer-pymods
-ifeq ($(BR2_PACKAGE_PYTHON),y)
-ALSA_LIB_CONF_OPTS += \
- --with-pythonlibs=-lpython$(PYTHON_VERSION_MAJOR) \
- --with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
-ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
-ALSA_LIB_DEPENDENCIES = python
-else
-ALSA_LIB_CONF_OPTS += \
+ --enable-mixer-pymods \
--with-pythonlibs=-lpython$(PYTHON3_VERSION_MAJOR) \
--with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
ALSA_LIB_DEPENDENCIES = python3
-endif
else
ALSA_LIB_CONF_OPTS += --disable-python
endif
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config
2021-09-09 15:17 ` [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config Illia Bitkov
@ 2021-09-21 19:04 ` Arnout Vandecappelle
2021-10-04 14:05 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-09-21 19:04 UTC (permalink / raw)
To: Illia Bitkov, buildroot; +Cc: Bernd Kuhls, Adam Dusketta
On 09/09/2021 17:17, Illia Bitkov wrote:
> Add simple mixer python bindings to build when "Python support for alsa-lib" is active.
> smixer-python is the only one python module which exists in alsa-lib.
Please wrap the commit message at 72 columns.
I've changed the subject line to "package/alsa-lib: smixer-python module
supports python3" because IMHO adding python3 is the most important feature of
this patch.
Applied to master, thanks.
Regards,
Arnout
>
> Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
> ---
> package/alsa-lib/Config.in | 2 +-
> package/alsa-lib/alsa-lib.mk | 10 ++++++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
> index f334b66bff..4168d1f220 100644
> --- a/package/alsa-lib/Config.in
> +++ b/package/alsa-lib/Config.in
> @@ -22,7 +22,7 @@ if BR2_PACKAGE_ALSA_LIB
>
> config BR2_PACKAGE_ALSA_LIB_PYTHON
> bool "Python support for alsa-lib"
> - depends on BR2_PACKAGE_PYTHON
> + depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> help
> Add python support for alsa-lib.
> Python will be built and libpython will be installed
> diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
> index c71ad5dd58..99c53f9408 100644
> --- a/package/alsa-lib/alsa-lib.mk
> +++ b/package/alsa-lib/alsa-lib.mk
> @@ -57,12 +57,22 @@ ALSA_LIB_CONF_OPTS += --disable-old-symbols
> endif
>
> ifeq ($(BR2_PACKAGE_ALSA_LIB_PYTHON),y)
> +ALSA_LIB_CONF_OPTS += \
> + --enable-mixer-pymods
> +ifeq ($(BR2_PACKAGE_PYTHON),y)
> ALSA_LIB_CONF_OPTS += \
> --with-pythonlibs=-lpython$(PYTHON_VERSION_MAJOR) \
> --with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
> ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
> ALSA_LIB_DEPENDENCIES = python
> else
> +ALSA_LIB_CONF_OPTS += \
> + --with-pythonlibs=-lpython$(PYTHON3_VERSION_MAJOR) \
> + --with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
> +ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
> +ALSA_LIB_DEPENDENCIES = python3
> +endif
> +else
> ALSA_LIB_CONF_OPTS += --disable-python
> endif
>
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config
2021-09-21 19:04 ` Arnout Vandecappelle
@ 2021-10-04 14:05 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-10-04 14:05 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: Bernd Kuhls, Illia Bitkov, Adam Dusketta, buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 09/09/2021 17:17, Illia Bitkov wrote:
>> Add simple mixer python bindings to build when "Python support for alsa-lib" is active.
>> smixer-python is the only one python module which exists in alsa-lib.
> Please wrap the commit message at 72 columns.
> I've changed the subject line to "package/alsa-lib: smixer-python
> module supports python3" because IMHO adding python3 is the most
> important feature of this patch.
Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-04 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 15:17 [Buildroot] [PATCH v2 0/2] fix for alsa-lib support for python Illia Bitkov
2021-09-09 15:17 ` [Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config Illia Bitkov
2021-09-21 19:04 ` Arnout Vandecappelle
2021-10-04 14:05 ` Peter Korsgaard
2021-09-09 15:17 ` [Buildroot] [PATCH v2 2/2] package/alsa-lib: always use python3 Illia Bitkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.