* [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled
@ 2020-10-01 11:20 Matteo Croce
2020-10-01 14:00 ` Vitaly Kuznetsov
2020-10-19 15:17 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Matteo Croce @ 2020-10-01 11:20 UTC (permalink / raw)
To: kvm; +Cc: linux-kernel, Paolo Bonzini, Vitaly Kuznetsov, Sean Christopherson
From: Matteo Croce <mcroce@microsoft.com>
Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
arch/x86/kvm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index fbd5bd7a945a..f92dfd8ef10d 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -66,6 +66,7 @@ config KVM_WERROR
default y if X86_64 && !KASAN
# We use the dependency on !COMPILE_TEST to not be enabled
# blindly in allmodconfig or allyesconfig configurations
+ depends on KVM
depends on (X86_64 && !KASAN) || !COMPILE_TEST
depends on EXPERT
help
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled
2020-10-01 11:20 [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled Matteo Croce
@ 2020-10-01 14:00 ` Vitaly Kuznetsov
2020-10-01 14:19 ` Matteo Croce
2020-10-19 15:17 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Vitaly Kuznetsov @ 2020-10-01 14:00 UTC (permalink / raw)
To: Matteo Croce, kvm; +Cc: linux-kernel, Paolo Bonzini, Sean Christopherson
Matteo Croce <mcroce@linux.microsoft.com> writes:
> From: Matteo Croce <mcroce@microsoft.com>
>
> Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
>
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
I'd even say
Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")
> ---
> arch/x86/kvm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index fbd5bd7a945a..f92dfd8ef10d 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -66,6 +66,7 @@ config KVM_WERROR
> default y if X86_64 && !KASAN
> # We use the dependency on !COMPILE_TEST to not be enabled
> # blindly in allmodconfig or allyesconfig configurations
> + depends on KVM
> depends on (X86_64 && !KASAN) || !COMPILE_TEST
> depends on EXPERT
> help
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled
2020-10-01 14:00 ` Vitaly Kuznetsov
@ 2020-10-01 14:19 ` Matteo Croce
0 siblings, 0 replies; 4+ messages in thread
From: Matteo Croce @ 2020-10-01 14:19 UTC (permalink / raw)
To: Vitaly Kuznetsov; +Cc: kvm, linux-kernel, Paolo Bonzini, Sean Christopherson
On Thu, Oct 1, 2020 at 4:01 PM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> Matteo Croce <mcroce@linux.microsoft.com> writes:
>
> > From: Matteo Croce <mcroce@microsoft.com>
> >
> > Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
> >
> > Signed-off-by: Matteo Croce <mcroce@microsoft.com>
>
> I'd even say
>
> Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")
>
Indeed, thanks
> > ---
> > arch/x86/kvm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index fbd5bd7a945a..f92dfd8ef10d 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -66,6 +66,7 @@ config KVM_WERROR
> > default y if X86_64 && !KASAN
> > # We use the dependency on !COMPILE_TEST to not be enabled
> > # blindly in allmodconfig or allyesconfig configurations
> > + depends on KVM
> > depends on (X86_64 && !KASAN) || !COMPILE_TEST
> > depends on EXPERT
> > help
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> --
> Vitaly
>
--
per aspera ad upstream
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled
2020-10-01 11:20 [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled Matteo Croce
2020-10-01 14:00 ` Vitaly Kuznetsov
@ 2020-10-19 15:17 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-10-19 15:17 UTC (permalink / raw)
To: Matteo Croce, kvm; +Cc: linux-kernel, Vitaly Kuznetsov, Sean Christopherson
On 01/10/20 13:20, Matteo Croce wrote:
> From: Matteo Croce <mcroce@microsoft.com>
>
> Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
>
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
> arch/x86/kvm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index fbd5bd7a945a..f92dfd8ef10d 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -66,6 +66,7 @@ config KVM_WERROR
> default y if X86_64 && !KASAN
> # We use the dependency on !COMPILE_TEST to not be enabled
> # blindly in allmodconfig or allyesconfig configurations
> + depends on KVM
> depends on (X86_64 && !KASAN) || !COMPILE_TEST
> depends on EXPERT
> help
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-19 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 11:20 [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled Matteo Croce
2020-10-01 14:00 ` Vitaly Kuznetsov
2020-10-01 14:19 ` Matteo Croce
2020-10-19 15:17 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.