All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Yongbo Zhang <giraffesnn123@gmail.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
	alsa-devel@alsa-project.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Chen Li <licheng0822@thundersoft.com>
Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer
Date: 11 May 2020 10:30:15 +0900	[thread overview]
Message-ID: <87a72f9s2g.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20200508074753.10362-1-giraffesnn123@gmail.com>


Hi Yongbo

Thank you for the patch

> SSI BUSIF buffer is possible to overflow or underflow, especially in a
> hypervisor environment. If there is no interrupt support, it will eventually
> lead to errors in pcm data.
> This patch adds overflow and underflow interrupt support for SSI BUSIF buffer.
> 
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reported-by: Chen Li <licheng0822@thundersoft.com>
> Signed-off-by: Yongbo Zhang <giraffesnn123@gmail.com>
> Tested-by: Chen Li <licheng0822@thundersoft.com>
> ---
(snip)
> @@ -635,6 +713,19 @@ static int rsnd_ssi_irq(struct rsnd_mod *mod,
>  	if (enable)
>  		val = rsnd_ssi_is_dma_mode(mod) ? 0x0e000000 : 0x0f000000;
>  
> +	if (is_tdm || is_tdm_split) {
> +		switch (id) {
> +		case 0:
> +		case 1:
> +		case 2:
> +		case 3:
> +		case 4:
> +		case 9:
> +			val |= 0xff00;
> +			break;
> +		}
> +	}

This is small things, but we like to have
	- val |= 0xff00;
	+ val |= 0x0000ff00;

Except above

	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto

WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Yongbo Zhang <giraffesnn123@gmail.com>
Cc: Chen Li <licheng0822@thundersoft.com>,
	alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	broonie@kernel.org
Subject: Re: [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer
Date: 11 May 2020 10:30:15 +0900	[thread overview]
Message-ID: <87a72f9s2g.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20200508074753.10362-1-giraffesnn123@gmail.com>


Hi Yongbo

Thank you for the patch

> SSI BUSIF buffer is possible to overflow or underflow, especially in a
> hypervisor environment. If there is no interrupt support, it will eventually
> lead to errors in pcm data.
> This patch adds overflow and underflow interrupt support for SSI BUSIF buffer.
> 
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reported-by: Chen Li <licheng0822@thundersoft.com>
> Signed-off-by: Yongbo Zhang <giraffesnn123@gmail.com>
> Tested-by: Chen Li <licheng0822@thundersoft.com>
> ---
(snip)
> @@ -635,6 +713,19 @@ static int rsnd_ssi_irq(struct rsnd_mod *mod,
>  	if (enable)
>  		val = rsnd_ssi_is_dma_mode(mod) ? 0x0e000000 : 0x0f000000;
>  
> +	if (is_tdm || is_tdm_split) {
> +		switch (id) {
> +		case 0:
> +		case 1:
> +		case 2:
> +		case 3:
> +		case 4:
> +		case 9:
> +			val |= 0xff00;
> +			break;
> +		}
> +	}

This is small things, but we like to have
	- val |= 0xff00;
	+ val |= 0x0000ff00;

Except above

	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto

  parent reply	other threads:[~2020-05-11  1:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  7:47 [PATCH] ASoC: rsnd: add interrupt support for SSI BUSIF buffer Yongbo Zhang
2020-05-08  7:47 ` Yongbo Zhang
2020-05-08 23:56 ` kbuild test robot
2020-05-08 23:56   ` kbuild test robot
2020-05-08 23:56   ` kbuild test robot
2020-05-09 11:07 ` kbuild test robot
2020-05-09 11:07   ` kbuild test robot
2020-05-09 11:07   ` kbuild test robot
2020-05-11  1:30 ` Kuninori Morimoto [this message]
2020-05-11  1:30   ` Kuninori Morimoto
2020-05-12  6:39 ` kbuild test robot
2020-05-12  6:39   ` kbuild test robot
2020-05-12  6:39   ` kbuild test robot
2020-05-09  2:23 kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a72f9s2g.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=giraffesnn123@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=licheng0822@thundersoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.