* [Buildroot] [PATCH 1/1] flare-engine: fix debug build
@ 2018-11-18 21:34 Fabrice Fontaine
2018-11-19 15:08 ` Peter Korsgaard
2018-11-26 16:17 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2018-11-18 21:34 UTC (permalink / raw)
To: buildroot
If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug
as Debug will add -pg (gprof) which is not always available on toolchain
Fixes:
- http://autobuild.buildroot.org/results/a12ae622a44bbe025c3a8b7e8e4c253b52927ae8
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/flare-engine/flare-engine.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/flare-engine/flare-engine.mk b/package/flare-engine/flare-engine.mk
index 0aac3bd33c..2f36602348 100644
--- a/package/flare-engine/flare-engine.mk
+++ b/package/flare-engine/flare-engine.mk
@@ -14,4 +14,9 @@ FLARE_ENGINE_DEPENDENCIES += sdl2 sdl2_image sdl2_mixer sdl2_ttf
# Don't use /usr/games and /usr/share/games
FLARE_ENGINE_CONF_OPTS += -DBINDIR=bin -DDATADIR=share/flare
+# Don't use the default Debug type as it adds -pg (gprof)
+ifeq ($(BR2_ENABLE_DEBUG),y)
+FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=RelWithDebInfo
+endif
+
$(eval $(cmake-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] flare-engine: fix debug build
2018-11-18 21:34 [Buildroot] [PATCH 1/1] flare-engine: fix debug build Fabrice Fontaine
@ 2018-11-19 15:08 ` Peter Korsgaard
2018-11-19 17:45 ` Fabrice Fontaine
2018-11-26 16:17 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2018-11-19 15:08 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug
> as Debug will add -pg (gprof) which is not always available on toolchain
Is this RelWithDebInfo something specific to flare-engine or is that
"standard" cmake? If so, perhaps we should use it globally instead of
Debug?
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] flare-engine: fix debug build
2018-11-19 15:08 ` Peter Korsgaard
@ 2018-11-19 17:45 ` Fabrice Fontaine
0 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2018-11-19 17:45 UTC (permalink / raw)
To: buildroot
Dear Peter,
Le lun. 19 nov. 2018 ? 16:08, Peter Korsgaard <peter@korsgaard.com> a ?crit :
>
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>
> > If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug
> > as Debug will add -pg (gprof) which is not always available on toolchain
>
> Is this RelWithDebInfo something specific to flare-engine or is that
> "standard" cmake? If so, perhaps we should use it globally instead of
> Debug?
Unfortunately, this is specific to flare-engine.
>
> Committed, thanks.
>
> --
> Bye, Peter Korsgaard
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] flare-engine: fix debug build
2018-11-18 21:34 [Buildroot] [PATCH 1/1] flare-engine: fix debug build Fabrice Fontaine
2018-11-19 15:08 ` Peter Korsgaard
@ 2018-11-26 16:17 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-11-26 16:17 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug
> as Debug will add -pg (gprof) which is not always available on toolchain
> Fixes:
> - http://autobuild.buildroot.org/results/a12ae622a44bbe025c3a8b7e8e4c253b52927ae8
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2018.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-26 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-18 21:34 [Buildroot] [PATCH 1/1] flare-engine: fix debug build Fabrice Fontaine
2018-11-19 15:08 ` Peter Korsgaard
2018-11-19 17:45 ` Fabrice Fontaine
2018-11-26 16:17 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.