[PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[Kuninori Morimoto]

Hi Simon

These patches adds sound support for KingFisher.
We can enable it on top of v4.20-rc1, but, it is not stable.
We need this patch (= from ASoC for-v4.21 branch) to be stable it.

	223bc10b84970fd772c105b550beeef3ac3502be
	("ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new")

Kuninori Morimoto (4):
  arm64: renesas: ulcb: use audio-graph-card
  arm64: renesas: ulcb: add HDMI sound support
  arm64: renesas: ulcb-kf: add pcm3168 sound codec
  arm64: renesas_defconfig: select Kingfisher Sound related configs

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 151 +++++++++++++++++++++++++++++++
 arch/arm64/boot/dts/renesas/ulcb.dtsi    |  70 ++++++++++----
 arch/arm64/configs/renesas_defconfig     |   2 +
 3 files changed, 206 insertions(+), 17 deletions(-)

-- 
2.7.4



Best regards
---
Kuninori Morimoto

[PATCH 1/4] arm64: renesas: ulcb: use audio-graph-card

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

ULCB can use daughter board which is called as KingFisher.
It has extra sound interface, thus we want to use it.
But, basically, ALSA SoC can't use Multiple sound card with single
CPU sound interface (= SSI). Thus we need to use Single Sound Card
with multiple DAI interface.

To be easy to expand ULCB sound card on KingFisher, it is better to
use multi-dai-link style sound card on ULCB sound DT.

Now, "simple-audio-card" / "audio-graph-card" both can support
multi-dai-link style, but HDMI sound support (which is not yet supported
on ULCB) needs "audio-graph-card".
Using audio-graph-card is better selection.
This patch exchange current sound card to use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 42 +++++++++++++++++++++--------------
 1 file changed, 25 insertions(+), 17 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 89daca7..a936f06 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -83,20 +83,11 @@
 		regulator-always-on;
 	};
 
-	rsnd_ak4613: sound {
-		compatible = "simple-audio-card";
+	sound_card: sound {
+		compatible = "audio-graph-card";
+		label = "rcar-sound";
 
-		simple-audio-card,format = "left_j";
-		simple-audio-card,bitclock-master = <&sndcpu>;
-		simple-audio-card,frame-master = <&sndcpu>;
-
-		sndcpu: simple-audio-card,cpu {
-			sound-dai = <&rcar_sound>;
-		};
-
-		sndcodec: simple-audio-card,codec {
-			sound-dai = <&ak4613>;
-		};
+		dais = <&rsnd_port0>;
 	};
 
 	vcc_sdhi0: regulator-vcc-sdhi0 {
@@ -211,6 +202,12 @@
 		asahi-kasei,out4-single-end;
 		asahi-kasei,out5-single-end;
 		asahi-kasei,out6-single-end;
+
+		port {
+			ak4613_endpoint: endpoint {
+				remote-endpoint = <&rsnd_endpoint0>;
+			};
+		};
 	};
 
 	cs2000: clk-multiplier@4f {
@@ -390,10 +387,21 @@
 		 <&audio_clk_c>,
 		 <&cpg CPG_CORE CPG_AUDIO_CLK_I>;
 
-	rcar_sound,dai {
-		dai0 {
-			playback = <&ssi0 &src0 &dvc0>;
-			capture  = <&ssi1 &src1 &dvc1>;
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		rsnd_port0: port@0 {
+			reg = <0>;
+			rsnd_endpoint0: endpoint {
+				remote-endpoint = <&ak4613_endpoint>;
+
+				dai-format = "left_j";
+				bitclock-master = <&rsnd_endpoint0>;
+				frame-master = <&rsnd_endpoint0>;
+
+				playback = <&ssi0 &src0 &dvc0>;
+				capture  = <&ssi1 &src1 &dvc1>;
+			};
 		};
 	};
 };
-- 
2.7.4

[PATCH 2/4] arm64: renesas: ulcb: add HDMI sound support

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

This patch adds missing ULCB HDMI sound support.
To use sound card, HDMI video is mandatory.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index a936f06..de49b2a 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -6,6 +6,14 @@
  * Copyright (C) 2016 Cogent Embedded, Inc.
  */
 
+/*
+ * SSI-AK4613
+ *	aplay   -D plughw:0,0 xxx.wav
+ *	arecord -D plughw:0,0 xxx.wav
+ * SSI-HDMI
+ *	aplay   -D plughw:0,1 xxx.wav
+ */
+
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
 
@@ -87,7 +95,9 @@
 		compatible = "audio-graph-card";
 		label = "rcar-sound";
 
-		dais = <&rsnd_port0>;
+		dais = <&rsnd_port0	/* ak4613 */
+			&rsnd_port1	/* HDMI0  */
+			>;
 	};
 
 	vcc_sdhi0: regulator-vcc-sdhi0 {
@@ -173,6 +183,12 @@
 				remote-endpoint = <&hdmi0_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi0_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint1>;
+			};
+		};
 	};
 };
 
@@ -403,6 +419,18 @@
 				capture  = <&ssi1 &src1 &dvc1>;
 			};
 		};
+		rsnd_port1: port@1 {
+			reg = <1>;
+			rsnd_endpoint1: endpoint {
+				remote-endpoint = <&dw_hdmi0_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint1>;
+				frame-master = <&rsnd_endpoint1>;
+
+				playback = <&ssi2>;
+			};
+		};
 	};
 };
 
-- 
2.7.4

[PATCH 3/4] arm64: renesas: ulcb-kf: add pcm3168 sound codec

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

KingFisher has pcm3168 sound codec. This patch enables it.
Because pcm3168 can't handle symmetric channel on playback/
capture, we need to handle it as different DAI.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 151 +++++++++++++++++++++++++++++++
 1 file changed, 151 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 1b316d79..fdd625d 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -6,11 +6,50 @@
  * Copyright (C) 2017 Cogent Embedded, Inc.
  */
 
+/*
+ * SSI-PCM3168A
+ *	aplay   -D plughw:0,2 xxx.wav
+ *	arecord -D plughw:0,3 xxx.wav
+ */
+
 / {
 	aliases {
 		serial1 = &hscif0;
 		serial2 = &scif1;
 	};
+
+	clk8snd: clk8snd {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <24576000>;
+	};
+
+	clksnd: clksnd {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <22579200>;
+	};
+
+	clksndsel: clksndsel {
+		#clock-cells = <0>;
+		compatible = "gpio-mux-clock";
+		clocks = <&clk8snd>, <&clksnd>;
+		select-gpios = <&gpio_exp_75 13 GPIO_ACTIVE_HIGH>;
+	};
+
+	snd_3p3v: regulator-snd_3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "snd-3.3v";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
+	snd_vcc5v: regulator-snd_vcc5v {
+		compatible = "regulator-fixed";
+		regulator-name = "snd-vcc5v";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
 };
 
 &can0 {
@@ -44,6 +83,7 @@
 };
 
 &i2c2 {
+	/* U11 */
 	gpio_exp_74: gpio@74 {
 		compatible = "ti,tca9539";
 		reg = <0x74>;
@@ -53,6 +93,13 @@
 		interrupt-parent = <&gpio6>;
 		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
 
+		audio_out_off {
+			gpio-hog;
+			gpios = <0 GPIO_ACTIVE_HIGH>; /* P00 */
+			output-high;
+			line-name = "Audio_Out_OFF";
+		};
+
 		hub_pwen {
 			gpio-hog;
 			gpios = <6 GPIO_ACTIVE_HIGH>;
@@ -80,8 +127,16 @@
 			output-high;
 			line-name = "OTG EXTLPn";
 		};
+
+		snd_rst {
+			gpio-hog;
+			gpios = <15 GPIO_ACTIVE_HIGH>; /* P17 */
+			output-high;
+			line-name = "SND_RST";
+		};
 	};
 
+	/* U5 */
 	gpio_exp_75: gpio@75 {
 		compatible = "ti,tca9539";
 		reg = <0x75>;
@@ -98,6 +153,49 @@
 		#size-cells = <0>;
 		reg = <0x71>;
 		reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
+
+		/* Audio_SDA, Audio_SCL */
+		i2c@7 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <7>;
+
+			pcm3168a: audio-codec@44 {
+				#sound-dai-cells = <0>;
+				compatible = "ti,pcm3168a";
+				reg = <0x44>;
+				clocks = <&clksndsel>;
+				clock-names = "scki";
+
+				VDD1-supply	= <&snd_3p3v>;
+				VDD2-supply	= <&snd_3p3v>;
+				VCCAD1-supply	= <&snd_vcc5v>;
+				VCCAD2-supply	= <&snd_vcc5v>;
+				VCCDA1-supply	= <&snd_vcc5v>;
+				VCCDA2-supply	= <&snd_vcc5v>;
+
+				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					port@0 {
+						reg = <0>;
+						pcm3168a_endpoint_p: endpoint {
+							remote-endpoint = <&rsnd_endpoint2>;
+							clocks = <&clksndsel>;
+							mclk-fs = <512>;
+						};
+					};
+					port@1 {
+						reg = <1>;
+						pcm3168a_endpoint_c: endpoint {
+							remote-endpoint = <&rsnd_endpoint3>;
+							clocks = <&clksndsel>;
+							mclk-fs = <512>;
+						};
+					};
+				};
+			};
+		};
 	};
 };
 
@@ -173,6 +271,11 @@
 		groups = "usb0";
 		function = "usb0";
 	};
+
+	sound_pcm_pins: sound-pcm {
+		groups = "ssi349_ctrl", "ssi3_data", "ssi4_data";
+		function = "ssi";
+	};
 };
 
 &scif1 {
@@ -193,3 +296,51 @@
 &xhci0 {
 	status = "okay";
 };
+
+&sound_card {
+	dais = <&rsnd_port0	/* ak4613 */
+		&rsnd_port1	/* HDMI0  */
+		&rsnd_port2	/* pcm3168a playback */
+		&rsnd_port3	/* pcm3168a capture  */
+		>;
+};
+
+&rcar_sound {
+	pinctrl-0 = <&sound_pins
+		     &sound_clk_pins
+		     &sound_pcm_pins>;
+
+	ports {
+		/* rsnd_port0/1 are on salvator-common */
+		rsnd_port2: port@2 {
+			reg = <2>;
+			rsnd_endpoint2: endpoint {
+				remote-endpoint = <&pcm3168a_endpoint_p>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint2>;
+				frame-master = <&rsnd_endpoint2>;
+				dai-tdm-slot-num = <8>;
+
+				playback = <&ssi3>;
+			};
+		};
+		rsnd_port3: port@3 {
+			reg = <3>;
+			rsnd_endpoint3: endpoint {
+				remote-endpoint = <&pcm3168a_endpoint_c>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint3>;
+				frame-master = <&rsnd_endpoint3>;
+				dai-tdm-slot-num = <6>;
+
+				capture  = <&ssi4>;
+			};
+		};
+	};
+};
+
+&ssi4 {
+	shared-pin;
+};
-- 
2.7.4

[PATCH 4/4] arm64: renesas_defconfig: select Kingfisher Sound related configs

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

This patch selects PCA954x, PCM3168A which are missing for
Kingfisher Sound.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/configs/renesas_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
index bc227d1..51e8386 100644
--- a/arch/arm64/configs/renesas_defconfig
+++ b/arch/arm64/configs/renesas_defconfig
@@ -136,6 +136,7 @@ CONFIG_VIRTIO_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_MUX=y
+CONFIG_I2C_MUX_PCA954x=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_I2C_SH_MOBILE=y
 CONFIG_I2C_RCAR=y
@@ -242,6 +243,7 @@ CONFIG_SND=y
 CONFIG_SND_SOC=y
 CONFIG_SND_SOC_RCAR=y
 CONFIG_SND_SOC_AK4613=y
+CONFIG_SND_SOC_PCM3168A_I2C=y
 CONFIG_SND_SIMPLE_CARD=y
 CONFIG_SND_SIMPLE_SCU_CARD=y
 CONFIG_SND_AUDIO_GRAPH_CARD=y
-- 
2.7.4

[PATCH 5/4] arm64: defconfig: select Kingfisher Sound related configs

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

This patch selects PCM3168A which is missing for Kingfisher Sound

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
Hi Simon

I missed this patch. Please include this, too.

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 9d0b42d..1d994b8 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -490,6 +490,7 @@ CONFIG_SND_SOC_RL6231=m
 CONFIG_SND_SOC_RT5514=m
 CONFIG_SND_SOC_RT5514_SPI=m
 CONFIG_SND_SOC_RT5645=m
+CONFIG_SND_SOC_PCM3168A_I2C=m
 CONFIG_SND_SIMPLE_CARD=m
 CONFIG_SND_SIMPLE_SCU_CARD=y
 CONFIG_SND_AUDIO_GRAPH_CARD=m
-- 
2.7.4

Re: [PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[Simon Horman]

On Thu, Nov 08, 2018 at 01:57:41AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> These patches adds sound support for KingFisher.
> We can enable it on top of v4.20-rc1, but, it is not stable.
> We need this patch (= from ASoC for-v4.21 branch) to be stable it.
> 
> 	223bc10b84970fd772c105b550beeef3ac3502be
> 	("ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new")

Perhaps it is best to wait for that patch to hit an rc release.
Do you know when that will happen?

> 
> Kuninori Morimoto (4):
>   arm64: renesas: ulcb: use audio-graph-card
>   arm64: renesas: ulcb: add HDMI sound support
>   arm64: renesas: ulcb-kf: add pcm3168 sound codec
>   arm64: renesas_defconfig: select Kingfisher Sound related configs
> 
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 151 +++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/renesas/ulcb.dtsi    |  70 ++++++++++----
>  arch/arm64/configs/renesas_defconfig     |   2 +
>  3 files changed, 206 insertions(+), 17 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> 
> Best regards
> ---
> Kuninori Morimoto
> 

Re: [PATCH 3/4] arm64: renesas: ulcb-kf: add pcm3168 sound codec

[Jiada Wang]

Hi Morimoto-san

with the TDM Split patch-set you sent earlier in community,
together with this DTS change set,
I am able to test TDM Split mode,
just some minor findings.

On 2018/11/08 10:59, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> KingFisher has pcm3168 sound codec. This patch enables it.
> Because pcm3168 can't handle symmetric channel on playback/
> capture, we need to handle it as different DAI.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 151 +++++++++++++++++++++++++++++++
>   1 file changed, 151 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 1b316d79..fdd625d 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -6,11 +6,50 @@
>    * Copyright (C) 2017 Cogent Embedded, Inc.
>    */
>   
> +/*
> + * SSI-PCM3168A
> + *	aplay   -D plughw:0,2 xxx.wav
> + *	arecord -D plughw:0,3 xxx.wav
> + */
> +
>   / {
>   	aliases {
>   		serial1 = &hscif0;
>   		serial2 = &scif1;
>   	};
> +
> +	clk8snd: clk8snd {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <24576000>;
> +	};
This is the same clock as cs2000, why not directly refer to &cs2000 from 
clksndsel,
otherwise, if snd_soc_rcar is loaded after snd_soc_pcm3168a_i2c,
load of snd_soc_pcm3168a_i2c fails with
"[    8.412356] pcm3168a 15-0044: Failed to reset device: -6"
and sound cards can not be created

Thanks,
Jiada
> +
> +	clksnd: clksnd {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <22579200>;
> +	};
> +
> +	clksndsel: clksndsel {
> +		#clock-cells = <0>;
> +		compatible = "gpio-mux-clock";
> +		clocks = <&clk8snd>, <&clksnd>;
> +		select-gpios = <&gpio_exp_75 13 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	snd_3p3v: regulator-snd_3p3v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "snd-3.3v";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +
> +	snd_vcc5v: regulator-snd_vcc5v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "snd-vcc5v";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +	};
>   };
>   
>   &can0 {
> @@ -44,6 +83,7 @@
>   };
>   
>   &i2c2 {
> +	/* U11 */
>   	gpio_exp_74: gpio@74 {
>   		compatible = "ti,tca9539";
>   		reg = <0x74>;
> @@ -53,6 +93,13 @@
>   		interrupt-parent = <&gpio6>;
>   		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
>   
> +		audio_out_off {
> +			gpio-hog;
> +			gpios = <0 GPIO_ACTIVE_HIGH>; /* P00 */
> +			output-high;
> +			line-name = "Audio_Out_OFF";
> +		};
> +
>   		hub_pwen {
>   			gpio-hog;
>   			gpios = <6 GPIO_ACTIVE_HIGH>;
> @@ -80,8 +127,16 @@
>   			output-high;
>   			line-name = "OTG EXTLPn";
>   		};
> +
> +		snd_rst {
> +			gpio-hog;
> +			gpios = <15 GPIO_ACTIVE_HIGH>; /* P17 */
> +			output-high;
> +			line-name = "SND_RST";
> +		};
>   	};
>   
> +	/* U5 */
>   	gpio_exp_75: gpio@75 {
>   		compatible = "ti,tca9539";
>   		reg = <0x75>;
> @@ -98,6 +153,49 @@
>   		#size-cells = <0>;
>   		reg = <0x71>;
>   		reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
> +
> +		/* Audio_SDA, Audio_SCL */
> +		i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <7>;
> +
> +			pcm3168a: audio-codec@44 {
> +				#sound-dai-cells = <0>;
> +				compatible = "ti,pcm3168a";
> +				reg = <0x44>;
> +				clocks = <&clksndsel>;
> +				clock-names = "scki";
> +
> +				VDD1-supply	= <&snd_3p3v>;
> +				VDD2-supply	= <&snd_3p3v>;
> +				VCCAD1-supply	= <&snd_vcc5v>;
> +				VCCAD2-supply	= <&snd_vcc5v>;
> +				VCCDA1-supply	= <&snd_vcc5v>;
> +				VCCDA2-supply	= <&snd_vcc5v>;
> +
> +				ports {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					port@0 {
> +						reg = <0>;
> +						pcm3168a_endpoint_p: endpoint {
> +							remote-endpoint = <&rsnd_endpoint2>;
> +							clocks = <&clksndsel>;
> +							mclk-fs = <512>;
> +						};
> +					};
> +					port@1 {
> +						reg = <1>;
> +						pcm3168a_endpoint_c: endpoint {
> +							remote-endpoint = <&rsnd_endpoint3>;
> +							clocks = <&clksndsel>;
> +							mclk-fs = <512>;
> +						};
> +					};
> +				};
> +			};
> +		};
>   	};
>   };
>   
> @@ -173,6 +271,11 @@
>   		groups = "usb0";
>   		function = "usb0";
>   	};
> +
> +	sound_pcm_pins: sound-pcm {
> +		groups = "ssi349_ctrl", "ssi3_data", "ssi4_data";
> +		function = "ssi";
> +	};
>   };
>   
>   &scif1 {
> @@ -193,3 +296,51 @@
>   &xhci0 {
>   	status = "okay";
>   };
> +
> +&sound_card {
> +	dais = <&rsnd_port0	/* ak4613 */
> +		&rsnd_port1	/* HDMI0  */
> +		&rsnd_port2	/* pcm3168a playback */
> +		&rsnd_port3	/* pcm3168a capture  */
> +		>;
> +};
> +
> +&rcar_sound {
> +	pinctrl-0 = <&sound_pins
> +		     &sound_clk_pins
> +		     &sound_pcm_pins>;
> +
> +	ports {
> +		/* rsnd_port0/1 are on salvator-common */
> +		rsnd_port2: port@2 {
> +			reg = <2>;
> +			rsnd_endpoint2: endpoint {
> +				remote-endpoint = <&pcm3168a_endpoint_p>;
> +
> +				dai-format = "i2s";
> +				bitclock-master = <&rsnd_endpoint2>;
> +				frame-master = <&rsnd_endpoint2>;
> +				dai-tdm-slot-num = <8>;
> +
> +				playback = <&ssi3>;
> +			};
> +		};
> +		rsnd_port3: port@3 {
> +			reg = <3>;
> +			rsnd_endpoint3: endpoint {
> +				remote-endpoint = <&pcm3168a_endpoint_c>;
> +
> +				dai-format = "i2s";
> +				bitclock-master = <&rsnd_endpoint3>;
> +				frame-master = <&rsnd_endpoint3>;
> +				dai-tdm-slot-num = <6>;
> +
> +				capture  = <&ssi4>;
> +			};
> +		};
> +	};
> +};
> +
> +&ssi4 {
> +	shared-pin;
> +};

Re: [PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[Kuninori Morimoto]

Hi Simon

> > These patches adds sound support for KingFisher.
> > We can enable it on top of v4.20-rc1, but, it is not stable.
> > We need this patch (= from ASoC for-v4.21 branch) to be stable it.
> > 
> > 	223bc10b84970fd772c105b550beeef3ac3502be
> > 	("ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new")
> 
> Perhaps it is best to wait for that patch to hit an rc release.
> Do you know when that will happen?

It will be v4.21, not for v4.20.

Best regards
---
Kuninori Morimoto

Re: [PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[Simon Horman]

On Fri, Nov 09, 2018 at 12:02:01AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > These patches adds sound support for KingFisher.
> > > We can enable it on top of v4.20-rc1, but, it is not stable.
> > > We need this patch (= from ASoC for-v4.21 branch) to be stable it.
> > > 
> > > 	223bc10b84970fd772c105b550beeef3ac3502be
> > > 	("ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new")
> > 
> > Perhaps it is best to wait for that patch to hit an rc release.
> > Do you know when that will happen?
> 
> It will be v4.21, not for v4.20.

Are the dependencies present in v4.21-rc1?
If so perhaps we could apply this series as
my branches are currently based on v4.21-rc1.

Let me know what you think.

Re: [PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[Simon Horman]

On Fri, Nov 09, 2018 at 10:47:07AM +0100, Simon Horman wrote:
> On Fri, Nov 09, 2018 at 12:02:01AM +0000, Kuninori Morimoto wrote:
> > 
> > Hi Simon
> > 
> > > > These patches adds sound support for KingFisher.
> > > > We can enable it on top of v4.20-rc1, but, it is not stable.
> > > > We need this patch (= from ASoC for-v4.21 branch) to be stable it.
> > > > 
> > > > 	223bc10b84970fd772c105b550beeef3ac3502be
> > > > 	("ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new")
> > > 
> > > Perhaps it is best to wait for that patch to hit an rc release.
> > > Do you know when that will happen?
> > 
> > It will be v4.21, not for v4.20.
> 
> Are the dependencies present in v4.21-rc1?
> If so perhaps we could apply this series as
> my branches are currently based on v4.21-rc1.
> 
> Let me know what you think.

Hi Morimoto-san,

could you let me know your thoughts on this?

Re: [PATCH 0/4] arm64: renesas: enable ULCB HDMI / ULCB-KF sound

[Kuninori Morimoto]

Hi Simon

sorry for my late response

> > > It will be v4.21, not for v4.20.
> > 
> > Are the dependencies present in v4.21-rc1?
> > If so perhaps we could apply this series as
> > my branches are currently based on v4.21-rc1.
> > 
> > Let me know what you think.
> 
> Hi Morimoto-san,
> 
> could you let me know your thoughts on this?

Does your branches are based on v4.21-rc1 ? not v4.20-rc1 ?
The necessary patch is not yet included on v4.20-rc1.
But will be OK on v4.21-rc1

I will re-post it if linus/master branch includes
necessary commit.

Re: [PATCH 3/4] arm64: renesas: ulcb-kf: add pcm3168 sound codec

[Jiada Wang]

Hi Morimoto-san


On 2018/11/08 22:36, Jiada Wang wrote:
> Hi Morimoto-san
>
> with the TDM Split patch-set you sent earlier in community,
> together with this DTS change set,
> I am able to test TDM Split mode,
> just some minor findings.
>
> On 2018/11/08 10:59, Kuninori Morimoto wrote:
>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> KingFisher has pcm3168 sound codec. This patch enables it.
>> Because pcm3168 can't handle symmetric channel on playback/
>> capture, we need to handle it as different DAI.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> ---
>>   arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 151 
>> +++++++++++++++++++++++++++++++
>>   1 file changed, 151 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi 
>> b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> index 1b316d79..fdd625d 100644
>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> @@ -6,11 +6,50 @@
>>    * Copyright (C) 2017 Cogent Embedded, Inc.
>>    */
>>   +/*
>> + * SSI-PCM3168A
>> + *    aplay   -D plughw:0,2 xxx.wav
>> + *    arecord -D plughw:0,3 xxx.wav
>> + */
>> +
>>   / {
>>       aliases {
>>           serial1 = &hscif0;
>>           serial2 = &scif1;
>>       };
>> +
>> +    clk8snd: clk8snd {
>> +        compatible = "fixed-clock";
>> +        #clock-cells = <0>;
>> +        clock-frequency = <24576000>;
>> +    };
> This is the same clock as cs2000, why not directly refer to &cs2000 
> from clksndsel,
> otherwise, if snd_soc_rcar is loaded after snd_soc_pcm3168a_i2c,
> load of snd_soc_pcm3168a_i2c fails with
> "[    8.412356] pcm3168a 15-0044: Failed to reset device: -6"
> and sound cards can not be created
>

Could you let me know your thoughts on this?

thanks，
Jiada

> Thanks,
> Jiada
>> +
>> +    clksnd: clksnd {
>> +        compatible = "fixed-clock";
>> +        #clock-cells = <0>;
>> +        clock-frequency = <22579200>;
>> +    };
>> +
>> +    clksndsel: clksndsel {
>> +        #clock-cells = <0>;
>> +        compatible = "gpio-mux-clock";
>> +        clocks = <&clk8snd>, <&clksnd>;
>> +        select-gpios = <&gpio_exp_75 13 GPIO_ACTIVE_HIGH>;
>> +    };
>> +
>> +    snd_3p3v: regulator-snd_3p3v {
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "snd-3.3v";
>> +        regulator-min-microvolt = <3300000>;
>> +        regulator-max-microvolt = <3300000>;
>> +    };
>> +
>> +    snd_vcc5v: regulator-snd_vcc5v {
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "snd-vcc5v";
>> +        regulator-min-microvolt = <5000000>;
>> +        regulator-max-microvolt = <5000000>;
>> +    };
>>   };
>>     &can0 {
>> @@ -44,6 +83,7 @@
>>   };
>>     &i2c2 {
>> +    /* U11 */
>>       gpio_exp_74: gpio@74 {
>>           compatible = "ti,tca9539";
>>           reg = <0x74>;
>> @@ -53,6 +93,13 @@
>>           interrupt-parent = <&gpio6>;
>>           interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
>>   +        audio_out_off {
>> +            gpio-hog;
>> +            gpios = <0 GPIO_ACTIVE_HIGH>; /* P00 */
>> +            output-high;
>> +            line-name = "Audio_Out_OFF";
>> +        };
>> +
>>           hub_pwen {
>>               gpio-hog;
>>               gpios = <6 GPIO_ACTIVE_HIGH>;
>> @@ -80,8 +127,16 @@
>>               output-high;
>>               line-name = "OTG EXTLPn";
>>           };
>> +
>> +        snd_rst {
>> +            gpio-hog;
>> +            gpios = <15 GPIO_ACTIVE_HIGH>; /* P17 */
>> +            output-high;
>> +            line-name = "SND_RST";
>> +        };
>>       };
>>   +    /* U5 */
>>       gpio_exp_75: gpio@75 {
>>           compatible = "ti,tca9539";
>>           reg = <0x75>;
>> @@ -98,6 +153,49 @@
>>           #size-cells = <0>;
>>           reg = <0x71>;
>>           reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
>> +
>> +        /* Audio_SDA, Audio_SCL */
>> +        i2c@7 {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            reg = <7>;
>> +
>> +            pcm3168a: audio-codec@44 {
>> +                #sound-dai-cells = <0>;
>> +                compatible = "ti,pcm3168a";
>> +                reg = <0x44>;
>> +                clocks = <&clksndsel>;
>> +                clock-names = "scki";
>> +
>> +                VDD1-supply    = <&snd_3p3v>;
>> +                VDD2-supply    = <&snd_3p3v>;
>> +                VCCAD1-supply    = <&snd_vcc5v>;
>> +                VCCAD2-supply    = <&snd_vcc5v>;
>> +                VCCDA1-supply    = <&snd_vcc5v>;
>> +                VCCDA2-supply    = <&snd_vcc5v>;
>> +
>> +                ports {
>> +                    #address-cells = <1>;
>> +                    #size-cells = <0>;
>> +                    port@0 {
>> +                        reg = <0>;
>> +                        pcm3168a_endpoint_p: endpoint {
>> +                            remote-endpoint = <&rsnd_endpoint2>;
>> +                            clocks = <&clksndsel>;
>> +                            mclk-fs = <512>;
>> +                        };
>> +                    };
>> +                    port@1 {
>> +                        reg = <1>;
>> +                        pcm3168a_endpoint_c: endpoint {
>> +                            remote-endpoint = <&rsnd_endpoint3>;
>> +                            clocks = <&clksndsel>;
>> +                            mclk-fs = <512>;
>> +                        };
>> +                    };
>> +                };
>> +            };
>> +        };
>>       };
>>   };
>>   @@ -173,6 +271,11 @@
>>           groups = "usb0";
>>           function = "usb0";
>>       };
>> +
>> +    sound_pcm_pins: sound-pcm {
>> +        groups = "ssi349_ctrl", "ssi3_data", "ssi4_data";
>> +        function = "ssi";
>> +    };
>>   };
>>     &scif1 {
>> @@ -193,3 +296,51 @@
>>   &xhci0 {
>>       status = "okay";
>>   };
>> +
>> +&sound_card {
>> +    dais = <&rsnd_port0    /* ak4613 */
>> +        &rsnd_port1    /* HDMI0  */
>> +        &rsnd_port2    /* pcm3168a playback */
>> +        &rsnd_port3    /* pcm3168a capture  */
>> +        >;
>> +};
>> +
>> +&rcar_sound {
>> +    pinctrl-0 = <&sound_pins
>> +             &sound_clk_pins
>> +             &sound_pcm_pins>;
>> +
>> +    ports {
>> +        /* rsnd_port0/1 are on salvator-common */
>> +        rsnd_port2: port@2 {
>> +            reg = <2>;
>> +            rsnd_endpoint2: endpoint {
>> +                remote-endpoint = <&pcm3168a_endpoint_p>;
>> +
>> +                dai-format = "i2s";
>> +                bitclock-master = <&rsnd_endpoint2>;
>> +                frame-master = <&rsnd_endpoint2>;
>> +                dai-tdm-slot-num = <8>;
>> +
>> +                playback = <&ssi3>;
>> +            };
>> +        };
>> +        rsnd_port3: port@3 {
>> +            reg = <3>;
>> +            rsnd_endpoint3: endpoint {
>> +                remote-endpoint = <&pcm3168a_endpoint_c>;
>> +
>> +                dai-format = "i2s";
>> +                bitclock-master = <&rsnd_endpoint3>;
>> +                frame-master = <&rsnd_endpoint3>;
>> +                dai-tdm-slot-num = <6>;
>> +
>> +                capture  = <&ssi4>;
>> +            };
>> +        };
>> +    };
>> +};
>> +
>> +&ssi4 {
>> +    shared-pin;
>> +};
>

Re: [PATCH 3/4] arm64: renesas: ulcb-kf: add pcm3168 sound codec

[Kuninori Morimoto]

Hi Jiada

> >> +
> >> +    clk8snd: clk8snd {
> >> +        compatible = "fixed-clock";
> >> +        #clock-cells = <0>;
> >> +        clock-frequency = <24576000>;
> >> +    };
> > This is the same clock as cs2000, why not directly refer to &cs2000
> > from clksndsel,
> > otherwise, if snd_soc_rcar is loaded after snd_soc_pcm3168a_i2c,
> > load of snd_soc_pcm3168a_i2c fails with
> > "[    8.412356] pcm3168a 15-0044: Failed to reset device: -6"
> > and sound cards can not be created
> > 
> 
> Could you let me know your thoughts on this?

Thank you for pointing it.
I will fix it in v2

Best regards
---
Kuninori Morimoto