* [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash
@ 2018-07-20 9:16 Laurent Hartanerot
2018-07-20 9:42 ` Peter Korsgaard
2018-07-20 21:31 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Laurent Hartanerot @ 2018-07-20 9:16 UTC (permalink / raw)
To: buildroot
From: Laurent Hartanerot <laurent.hartanerot@atos.net>
Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net>
---
package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
index 511e3b3b6c..25d25e1871 100644
--- a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
+++ b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
@@ -79,7 +79,7 @@ endif
ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
define IMX_GPU_VIV_FIXUP_PKGCONFIG
for lib in egl gbm glesv1_cm glesv2 vg; do \
- ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc
+ ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc \
done
endef
endif
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash
2018-07-20 9:16 [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash Laurent Hartanerot
@ 2018-07-20 9:42 ` Peter Korsgaard
2018-07-20 11:16 ` Thomas Petazzoni
2018-07-20 21:31 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2018-07-20 9:42 UTC (permalink / raw)
To: buildroot
>>>>> "Laurent" == Laurent Hartanerot <laurent.hartanerot@gmail.com> writes:
> From: Laurent Hartanerot <laurent.hartanerot@atos.net>
> Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net>
> ---
> package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> index 511e3b3b6c..25d25e1871 100644
> --- a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> +++ b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> @@ -79,7 +79,7 @@ endif
> ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
> define IMX_GPU_VIV_FIXUP_PKGCONFIG
> for lib in egl gbm glesv1_cm glesv2 vg; do \
> - ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc
> + ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc \
A semicolon is also missing. I've changed it to do '|| exit 1; \' like
we do elsewhere to catch failures and committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash
2018-07-20 9:42 ` Peter Korsgaard
@ 2018-07-20 11:16 ` Thomas Petazzoni
2018-07-20 11:47 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-07-20 11:16 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 20 Jul 2018 11:42:15 +0200, Peter Korsgaard wrote:
> >>>>> "Laurent" == Laurent Hartanerot <laurent.hartanerot@gmail.com> writes:
>
> > From: Laurent Hartanerot <laurent.hartanerot@atos.net>
> > Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net>
> > ---
> > package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> > index 511e3b3b6c..25d25e1871 100644
> > --- a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> > +++ b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> > @@ -79,7 +79,7 @@ endif
> > ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
> > define IMX_GPU_VIV_FIXUP_PKGCONFIG
> > for lib in egl gbm glesv1_cm glesv2 vg; do \
> > - ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc
> > + ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc \
>
> A semicolon is also missing. I've changed it to do '|| exit 1; \' like
> we do elsewhere to catch failures and committed, thanks.
Actually, in this sort of case, I would prefer to use a make for loop:
$(foreach lib,egl gbm glesv1_cm glesv2 vg, \
ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
)
make automatically aborts the loop if there's an error, and $(lib) is
more readable than $${lib}.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash
2018-07-20 11:16 ` Thomas Petazzoni
@ 2018-07-20 11:47 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-07-20 11:47 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
Hi,
>> A semicolon is also missing. I've changed it to do '|| exit 1; \' like
>> we do elsewhere to catch failures and committed, thanks.
> Actually, in this sort of case, I would prefer to use a make for loop:
> $(foreach lib,egl gbm glesv1_cm glesv2 vg, \
> ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
> )
> make automatically aborts the loop if there's an error, and $(lib) is
> more readable than $${lib}.
Correct. I left it like this as the file has several other shell loops.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash
2018-07-20 9:16 [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash Laurent Hartanerot
2018-07-20 9:42 ` Peter Korsgaard
@ 2018-07-20 21:31 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-07-20 21:31 UTC (permalink / raw)
To: buildroot
>>>>> "Laurent" == Laurent Hartanerot <laurent.hartanerot@gmail.com> writes:
> From: Laurent Hartanerot <laurent.hartanerot@atos.net>
> Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net>
Committed to 2018.02.x and 2018.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20180720091038.24853-1-laurent.hartanerot@gmail.com>]
end of thread, other threads:[~2018-07-20 21:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 9:16 [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash Laurent Hartanerot
2018-07-20 9:42 ` Peter Korsgaard
2018-07-20 11:16 ` Thomas Petazzoni
2018-07-20 11:47 ` Peter Korsgaard
2018-07-20 21:31 ` Peter Korsgaard
[not found] <20180720091038.24853-1-laurent.hartanerot@gmail.com>
2018-07-20 9:23 ` Gary Bisson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.