* [Buildroot] [PATCH 2/4] quota: depend on host-nfs-utils
2018-05-18 11:31 [Buildroot] [PATCH 1/4] nfs-utils: add host package Baruch Siach
@ 2018-05-18 11:31 ` Baruch Siach
2018-06-17 14:55 ` Peter Korsgaard
2018-05-18 11:31 ` [Buildroot] [PATCH 3/4] samba4: " Baruch Siach
` (4 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Baruch Siach @ 2018-05-18 11:31 UTC (permalink / raw)
To: buildroot
host-nfs-utils provides the host rpcgen utility. This fixes the build on
recent Fedora systems that removed rpcgen from the glibc package.
Fixes:
http://autobuild.buildroot.net/results/730/730acb23663ebbbaba847073979654670a8bc64c/
http://autobuild.buildroot.net/results/e49/e49932e9d958203d585cdddd795df06aad6ff3a9/
http://autobuild.buildroot.net/results/1b7/1b7dccf7b9742d1b9cb57bffe55eac5cfc66b15c/
Cc: Jarkko Sakkinen <jarkko.sakkinen@intel.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/quota/quota.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/quota/quota.mk b/package/quota/quota.mk
index 5bd9013d6a36..38e18a60c28c 100644
--- a/package/quota/quota.mk
+++ b/package/quota/quota.mk
@@ -6,7 +6,7 @@
QUOTA_VERSION = 4.01
QUOTA_SITE = http://downloads.sourceforge.net/project/linuxquota/quota-tools/$(QUOTA_VERSION)
-QUOTA_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
+QUOTA_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-nfs-utils
QUOTA_AUTORECONF = YES
QUOTA_LICENSE = GPL-2.0+
QUOTA_CONF_OPTS = --disable-strip-binaries
--
2.17.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 3/4] samba4: depend on host-nfs-utils
2018-05-18 11:31 [Buildroot] [PATCH 1/4] nfs-utils: add host package Baruch Siach
2018-05-18 11:31 ` [Buildroot] [PATCH 2/4] quota: depend on host-nfs-utils Baruch Siach
@ 2018-05-18 11:31 ` Baruch Siach
2018-06-17 14:55 ` Peter Korsgaard
2018-05-18 11:31 ` [Buildroot] [PATCH 4/4] autofs: " Baruch Siach
` (3 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Baruch Siach @ 2018-05-18 11:31 UTC (permalink / raw)
To: buildroot
host-nfs-utils provides the host rpcgen utility. This fixes the build on
recent Fedora systems that removed rpcgen from the glibc package.
Fixes:
http://autobuild.buildroot.net/results/6f8/6f869b8c7c182dfe7f1a291b5952320504540ebf/
http://autobuild.buildroot.net/results/4c2/4c228dd6369e4fc11b798af6ab2abe06d7473b78/
http://autobuild.buildroot.net/results/489/489be441abd19fba2b0c39357e64a6adcf773b60/
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/samba4/samba4.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/samba4/samba4.mk b/package/samba4/samba4.mk
index c77bc04a89fe..b03af34cd045 100644
--- a/package/samba4/samba4.mk
+++ b/package/samba4/samba4.mk
@@ -11,7 +11,7 @@ SAMBA4_INSTALL_STAGING = YES
SAMBA4_LICENSE = GPL-3.0+
SAMBA4_LICENSE_FILES = COPYING
SAMBA4_DEPENDENCIES = \
- host-e2fsprogs host-heimdal host-python \
+ host-e2fsprogs host-heimdal host-python host-nfs-utils \
e2fsprogs popt python zlib \
$(if $(BR2_PACKAGE_LIBAIO),libaio) \
$(if $(BR2_PACKAGE_LIBCAP),libcap) \
--
2.17.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 4/4] autofs: depend on host-nfs-utils
2018-05-18 11:31 [Buildroot] [PATCH 1/4] nfs-utils: add host package Baruch Siach
2018-05-18 11:31 ` [Buildroot] [PATCH 2/4] quota: depend on host-nfs-utils Baruch Siach
2018-05-18 11:31 ` [Buildroot] [PATCH 3/4] samba4: " Baruch Siach
@ 2018-05-18 11:31 ` Baruch Siach
2018-06-17 14:55 ` Peter Korsgaard
2018-05-18 12:32 ` [Buildroot] [PATCH 1/4] nfs-utils: add host package Thomas Petazzoni
` (2 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Baruch Siach @ 2018-05-18 11:31 UTC (permalink / raw)
To: buildroot
host-nfs-utils provides the host rpcgen utility. This fixes the build on
recent Fedora systems that removed rpcgen from the glibc package.
Fixes:
http://autobuild.buildroot.net/results/383/383bc8462f32a226645c9b792b8d65a25d74529d/
http://autobuild.buildroot.net/results/0c0/0c00f72512754b721813e13f0828d3a942f7b955/
http://autobuild.buildroot.net/results/50b/50b66d2a3c8264f618d7aa813b10050ed147209f/
Cc: Jonathan Ben Avraham <yba@tkos.co.il>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/autofs/autofs.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/autofs/autofs.mk b/package/autofs/autofs.mk
index 87a218441e34..e7c65ef4b09c 100644
--- a/package/autofs/autofs.mk
+++ b/package/autofs/autofs.mk
@@ -9,7 +9,7 @@ AUTOFS_SOURCE = autofs-$(AUTOFS_VERSION).tar.xz
AUTOFS_SITE = $(BR2_KERNEL_MIRROR)/linux/daemons/autofs/v5
AUTOFS_LICENSE = GPL-2.0+
AUTOFS_LICENSE_FILES = COPYING COPYRIGHT
-AUTOFS_DEPENDENCIES = host-flex host-bison host-pkgconf
+AUTOFS_DEPENDENCIES = host-flex host-bison host-pkgconf host-nfs-utils
# autofs looks on the build machine for the path of modprobe, so tell
# it explicitly where it will be located on the target.
--
2.17.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-18 11:31 [Buildroot] [PATCH 1/4] nfs-utils: add host package Baruch Siach
` (2 preceding siblings ...)
2018-05-18 11:31 ` [Buildroot] [PATCH 4/4] autofs: " Baruch Siach
@ 2018-05-18 12:32 ` Thomas Petazzoni
2018-05-18 12:33 ` Thomas Petazzoni
2018-05-19 10:44 ` Thomas Petazzoni
2018-06-17 14:55 ` Peter Korsgaard
5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2018-05-18 12:32 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 18 May 2018 14:31:56 +0300, Baruch Siach wrote:
> We only need the host package for the rpcgen utility. glibc deprecated
> this utility in version 2.26. Fedora has recently removed rpcgen from
> its glibc package. So we need to build the rpcgen from the nfs-utils
> package.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Ah, I was looking for a solution to this rpcgen problem.
It is worth mentioning that we have a big patch in the libtirpc package
to add the source code for rpcgen. So perhaps this should be removed,
and libtirpc should depend on host-nfs-utils.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-18 12:32 ` [Buildroot] [PATCH 1/4] nfs-utils: add host package Thomas Petazzoni
@ 2018-05-18 12:33 ` Thomas Petazzoni
0 siblings, 0 replies; 16+ messages in thread
From: Thomas Petazzoni @ 2018-05-18 12:33 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 18 May 2018 14:32:17 +0200, Thomas Petazzoni wrote:
> Ah, I was looking for a solution to this rpcgen problem.
>
> It is worth mentioning that we have a big patch in the libtirpc package
> to add the source code for rpcgen. So perhaps this should be removed,
> and libtirpc should depend on host-nfs-utils.
Forget that: I saw your patch that does *exactly* this.
I should read *all* the patches in the queue before replying to the
first ones :-)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-18 11:31 [Buildroot] [PATCH 1/4] nfs-utils: add host package Baruch Siach
` (3 preceding siblings ...)
2018-05-18 12:32 ` [Buildroot] [PATCH 1/4] nfs-utils: add host package Thomas Petazzoni
@ 2018-05-19 10:44 ` Thomas Petazzoni
2018-05-21 6:07 ` Baruch Siach
2018-06-17 14:55 ` Peter Korsgaard
5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2018-05-19 10:44 UTC (permalink / raw)
To: buildroot
Hello Baruch,
On Fri, 18 May 2018 14:31:56 +0300, Baruch Siach wrote:
> We only need the host package for the rpcgen utility. glibc deprecated
> this utility in version 2.26. Fedora has recently removed rpcgen from
> its glibc package. So we need to build the rpcgen from the nfs-utils
> package.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
I've done some testing. First, this package needs host-pkgconf in
HOST_NFS_UTILS_DEPENDENCIES, because the configure.ac script uses
autoconf macros from pkgconfig.m4. With this fixed, host-nfs-utils
builds fine on my system (Fedora 27).
However, it doesn't build on Fedora 28, because the <rpc/types.h>
header is not available. If this one gets fixed by using a local copy
of <rpc/types.h>, then the build fails for <rpc/rpc.h>, etc.
So in fact on Fedora 28, not only rpcgen is not provided, but also the
RPC headers are not provided.
Do you have an idea on how to address this ? Do we need to build
host-libtirpc ?
If you don't have a Fedora 28 system at hand, you can easily create a
Docker container with Fedora 28 installed.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-19 10:44 ` Thomas Petazzoni
@ 2018-05-21 6:07 ` Baruch Siach
2018-05-21 8:19 ` Thomas Petazzoni
0 siblings, 1 reply; 16+ messages in thread
From: Baruch Siach @ 2018-05-21 6:07 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Sat, May 19, 2018 at 12:44:12PM +0200, Thomas Petazzoni wrote:
> On Fri, 18 May 2018 14:31:56 +0300, Baruch Siach wrote:
> > We only need the host package for the rpcgen utility. glibc deprecated
> > this utility in version 2.26. Fedora has recently removed rpcgen from
> > its glibc package. So we need to build the rpcgen from the nfs-utils
> > package.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> I've done some testing. First, this package needs host-pkgconf in
> HOST_NFS_UTILS_DEPENDENCIES, because the configure.ac script uses
> autoconf macros from pkgconfig.m4. With this fixed, host-nfs-utils
> builds fine on my system (Fedora 27).
>
> However, it doesn't build on Fedora 28, because the <rpc/types.h>
> header is not available. If this one gets fixed by using a local copy
> of <rpc/types.h>, then the build fails for <rpc/rpc.h>, etc.
>
> So in fact on Fedora 28, not only rpcgen is not provided, but also the
> RPC headers are not provided.
>
> Do you have an idea on how to address this ? Do we need to build
> host-libtirpc ?
I'll take a look.
If we need host-libtirpc we would not be able to remove the rpcgen patch since
that would create a circular dependency.
Why do we actually need rpcgen in libtirpc?
> If you don't have a Fedora 28 system at hand, you can easily create a
> Docker container with Fedora 28 installed.
Thanks for the tip.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-21 6:07 ` Baruch Siach
@ 2018-05-21 8:19 ` Thomas Petazzoni
2018-05-21 8:28 ` Baruch Siach
0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2018-05-21 8:19 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 21 May 2018 09:07:56 +0300, Baruch Siach wrote:
> > Do you have an idea on how to address this ? Do we need to build
> > host-libtirpc ?
>
> I'll take a look.
Thanks!
> If we need host-libtirpc we would not be able to remove the rpcgen patch since
> that would create a circular dependency.
Except if we manage to convince host-libtirpc that it should just
install the RPC headers, and not do anything that needs rpcgen.
> Why do we actually need rpcgen in libtirpc?
If I remember correctly, it's because it needs to generate the C code
matching those RPC descriptions:
./tirpc/rpc/rpcb_prot.x
./tirpc/rpcsvc/crypt.x
./tirpc/rpcsvc/key_prot.x
But it's been a very long time I did this, and libtirpc has been
updated multiple times since then.
Alternatively, one approach would be to bundle a pre-generated version
of those C files instead of having to run rpcgen. Not the nicest
solution, but that's one solution.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-21 8:19 ` Thomas Petazzoni
@ 2018-05-21 8:28 ` Baruch Siach
2018-05-21 8:32 ` Thomas Petazzoni
0 siblings, 1 reply; 16+ messages in thread
From: Baruch Siach @ 2018-05-21 8:28 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, May 21, 2018 at 10:19:28AM +0200, Thomas Petazzoni wrote:
> On Mon, 21 May 2018 09:07:56 +0300, Baruch Siach wrote:
>
> > > Do you have an idea on how to address this ? Do we need to build
> > > host-libtirpc ?
> >
> > I'll take a look.
>
> Thanks!
>
> > If we need host-libtirpc we would not be able to remove the rpcgen patch since
> > that would create a circular dependency.
>
> Except if we manage to convince host-libtirpc that it should just
> install the RPC headers, and not do anything that needs rpcgen.
>
> > Why do we actually need rpcgen in libtirpc?
>
> If I remember correctly, it's because it needs to generate the C code
> matching those RPC descriptions:
>
> ./tirpc/rpc/rpcb_prot.x
> ./tirpc/rpcsvc/crypt.x
> ./tirpc/rpcsvc/key_prot.x
The libtirpc tarball bundles these generated files. But for some reason we
regenerate them from C.
> But it's been a very long time I did this, and libtirpc has been
> updated multiple times since then.
>
> Alternatively, one approach would be to bundle a pre-generated version
> of those C files instead of having to run rpcgen. Not the nicest
> solution, but that's one solution.
If we can use the bundled files, we can get rid of rpcgen in libtirpc.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-21 8:28 ` Baruch Siach
@ 2018-05-21 8:32 ` Thomas Petazzoni
2018-05-21 8:58 ` Baruch Siach
0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2018-05-21 8:32 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 21 May 2018 11:28:18 +0300, Baruch Siach wrote:
> > ./tirpc/rpc/rpcb_prot.x
> > ./tirpc/rpcsvc/crypt.x
> > ./tirpc/rpcsvc/key_prot.x
>
> The libtirpc tarball bundles these generated files. But for some reason we
> regenerate them from C.
Hu ? Those .x files are not the generated files. Those are the source
files. rpcgen reads .x files and generates C code. You seem to have
understood it backwards.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-21 8:32 ` Thomas Petazzoni
@ 2018-05-21 8:58 ` Baruch Siach
0 siblings, 0 replies; 16+ messages in thread
From: Baruch Siach @ 2018-05-21 8:58 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, May 21, 2018 at 10:32:59AM +0200, Thomas Petazzoni wrote:
> On Mon, 21 May 2018 11:28:18 +0300, Baruch Siach wrote:
>
> > > ./tirpc/rpc/rpcb_prot.x
> > > ./tirpc/rpcsvc/crypt.x
> > > ./tirpc/rpcsvc/key_prot.x
> >
> > The libtirpc tarball bundles these generated files. But for some reason we
> > regenerate them from C.
>
> Hu ? Those .x files are not the generated files. Those are the source
> files. rpcgen reads .x files and generates C code. You seem to have
> understood it backwards.
Right. But still the .h and .c file that are generated from these .x files are
bundled with libtirpc. As far as I can see these are the files:
src/key_prot_xdr.c
src/rpcb_st_xdr.c
tirpc/rpcsvc/crypt.h
tirpc/rpc/rpcb_prot.h
tirpc/rpc/key_prot.h
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/4] nfs-utils: add host package
2018-05-18 11:31 [Buildroot] [PATCH 1/4] nfs-utils: add host package Baruch Siach
` (4 preceding siblings ...)
2018-05-19 10:44 ` Thomas Petazzoni
@ 2018-06-17 14:55 ` Peter Korsgaard
5 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2018-06-17 14:55 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> We only need the host package for the rpcgen utility. glibc deprecated
> this utility in version 2.26. Fedora has recently removed rpcgen from
> its glibc package. So we need to build the rpcgen from the nfs-utils
> package.
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 16+ messages in thread