From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/ca-certificates: don't hash certificates.crt
Date: Tue, 29 May 2018 08:50:44 +0200 [thread overview]
Message-ID: <87a7sjuf97.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180506161944.7451-1-martin@barkynet.com> (Martin Bark's message of "Sun, 6 May 2018 17:19:43 +0100")
>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:
> Copy certificates.crt to /etc/ssl/certs after we run c_rehash to
> prevent it getting hashed by mistake.
What is the effect of running c_rehash on it? Just an extra symlink or
any functional difference?
> Signed-off-by: Martin Bark <martin@barkynet.com>
> ---
> package/ca-certificates/ca-certificates.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
> diff --git a/package/ca-certificates/ca-certificates.mk b/package/ca-certificates/ca-certificates.mk
> index cb0e961465..b99e6f47ca 100644
> --- a/package/ca-certificates/ca-certificates.mk
> +++ b/package/ca-certificates/ca-certificates.mk
> @@ -30,14 +30,20 @@ define CA_CERTIFICATES_INSTALL_TARGET_CMDS
> # Create symlinks to certificates under /etc/ssl/certs
> # and generate the bundle
> + rm -f $(@D)/ca-certificates.crt
> cd $(TARGET_DIR) ;\
> for i in `find usr/share/ca-certificates -name "*.crt"` ; do \
> ln -sf ../../../$$i etc/ssl/certs/`basename $${i} .crt`.pem ;\
> - cat $$i >>etc/ssl/certs/ca-certificates.crt ;\
> + cat $$i >>$(@D)/ca-certificates.crt ;\
> done
Alternatively we could redirect the entire for loop to the bundle, E.G.
done > $(@D)/ca-certificates.crt
While this seems like an improvement for when ca-certificates-reinstall
is run, I'm not sure what the relation is to $SUBJECT?
> # Create symlinks to the certificates by their hash values
> $(HOST_DIR)/bin/c_rehash $(TARGET_DIR)/etc/ssl/certs
> +
> + # Install the certificates bundle we just created
> + $(INSTALL) -D -m 644 $(@D)/ca-certificates.crt \
> + $(TARGET_DIR)/etc/ssl/certs/ca-certificates.crt
> +
> endef
> $(eval $(generic-package))
> --
> 2.17.0
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-05-29 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 16:19 [Buildroot] [PATCH 1/2] package/ca-certificates: don't hash certificates.crt Martin Bark
2018-05-06 16:19 ` [Buildroot] [PATCH 2/2] package/ca-certificates: bump version to 20180409 Martin Bark
2018-05-29 6:52 ` Peter Korsgaard
2018-05-29 6:50 ` Peter Korsgaard [this message]
2018-05-29 9:48 ` [Buildroot] [PATCH 1/2] package/ca-certificates: don't hash certificates.crt Martin Bark
2018-05-29 10:08 ` Peter Korsgaard
2018-05-29 10:40 ` Martin Bark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7sjuf97.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.