All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/ca-certificates: don't hash certificates.crt
Date: Tue, 29 May 2018 12:08:48 +0200	[thread overview]
Message-ID: <87sh6a7ozz.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAFGQKxf5Nn5AKMJ6-n8Ue_qvoE-O9x09yoC9T1nbz5OOp5781g@mail.gmail.com> (Martin Bark's message of "Tue, 29 May 2018 10:48:48 +0100")

>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:

 > Peter,
 > On 29 May 2018 at 07:50, Peter Korsgaard <peter@korsgaard.com> wrote:

 >> >>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:
 >> 
 >> > Copy certificates.crt to /etc/ssl/certs after we run c_rehash to
 >> > prevent it getting hashed by mistake.
 >> 
 >> What is the effect of running c_rehash on it? Just an extra symlink or
 >> any functional difference?
 >> 

 > c_rehash hashes certificates.crt by mistake and that symlink clashes with
 > one of the CA certificates.  The end result is one of the hashes
 > incorrectly points to certificates.crt instead of the CA certificate.  I
 > noticed this during testing because i checked /etc/ssl/certs was the same
 > as under ubuntu.

Ok, can you rework the commit message with these details (and perhaps
the for loop change) and resubmit? Thanks!

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-05-29 10:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-06 16:19 [Buildroot] [PATCH 1/2] package/ca-certificates: don't hash certificates.crt Martin Bark
2018-05-06 16:19 ` [Buildroot] [PATCH 2/2] package/ca-certificates: bump version to 20180409 Martin Bark
2018-05-29  6:52   ` Peter Korsgaard
2018-05-29  6:50 ` [Buildroot] [PATCH 1/2] package/ca-certificates: don't hash certificates.crt Peter Korsgaard
2018-05-29  9:48   ` Martin Bark
2018-05-29 10:08     ` Peter Korsgaard [this message]
2018-05-29 10:40       ` Martin Bark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh6a7ozz.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.