* [v2] usb: dwc3: pci: Properly cleanup resource
@ 2018-03-19 8:56 Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2018-03-19 8:56 UTC (permalink / raw)
To: Thinh Nguyen, linux-usb; +Cc: John Youn, Andy Shevchenko
Hi,
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> Platform device is allocated before adding resources. Make sure to
> properly cleanup on error case.
>
> Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()")
this commit is from way back in 3.16, please resend with a "Cc:
<stable@vger.kernel.org>" tag before this fixes line.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [v2] usb: dwc3: pci: Properly cleanup resource
@ 2018-03-16 23:00 Thinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Thinh Nguyen @ 2018-03-16 23:00 UTC (permalink / raw)
To: Felipe Balbi, linux-usb; +Cc: John Youn, Thinh Nguyen, Andy Shevchenko
Platform device is allocated before adding resources. Make sure to
properly cleanup on error case.
Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()")
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
Changes in v2:
- Separate from patch series "usb: dwc3: pci: Make device properties customizable"
drivers/usb/dwc3/dwc3-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 3ba11136ebf0..c961a94d136b 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -222,7 +222,7 @@ static int dwc3_pci_probe(struct pci_dev *pci,
ret = platform_device_add_resources(dwc->dwc3, res, ARRAY_SIZE(res));
if (ret) {
dev_err(dev, "couldn't add resources to dwc3 device\n");
- return ret;
+ goto err;
}
dwc->pci = pci;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 8:56 [v2] usb: dwc3: pci: Properly cleanup resource Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-03-16 23:00 Thinh Nguyen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.