* [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
@ 2018-02-14 7:59 Anusha Srivatsa
2018-02-14 8:38 ` ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4) Patchwork
` (6 more replies)
0 siblings, 7 replies; 17+ messages in thread
From: Anusha Srivatsa @ 2018-02-14 7:59 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Forward Error Correction is supported on DP 1.4.
This patch adds corresponding DPCD register definitions.
v2: Add dri-devel mailing list to the CC list(Jani)
v3: Change names, add missing masks (Manasi)
v4: Add missing shifts to mask (Manasi)
v5: Arrange the definitions in ascending order
of the address (Jani)
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
include/drm/drm_dp_helper.h | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index c239e6e..a19d6fb 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -329,6 +329,13 @@
# define DP_DS_12BPC 2
# define DP_DS_16BPC 3
+/* DP Forward error Correction Registers */
+#define DP_FEC_CAPABILITY (0x090)
+# define DP_FEC_CAPABLE (1 << 0)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
+# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
+
/* link configuration */
#define DP_LINK_BW_SET 0x100
# define DP_LINK_RATE_TABLE 0x00 /* eDP 1.4 */
@@ -445,6 +452,18 @@
#define DP_UPSTREAM_DEVICE_DP_PWR_NEED 0x118 /* 1.2 */
# define DP_PWR_NOT_NEEDED (1 << 0)
+#define DP_FEC_CONFIGURATION 0x120
+# define DP_FEC_READY (1 << 0)
+# define DP_FEC_ERR_COUNT_DIS (0 << 1)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
+# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
+# define DP_FEC_ERR_COUNT_SEL_MASK (0xff << 4)
+# define DP_FEC_LANE_0_SELECT (0 << 4)
+# define DP_FEC_LANE_1_SELECT (1 << 4)
+# define DP_FEC_LANE_2_SELECT (2 << 4)
+# define DP_FEC_LANE_3_SELECT (3 << 4)
+
#define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */
# define DP_AUX_FRAME_SYNC_VALID (1 << 0)
@@ -620,6 +639,17 @@
#define DP_TEST_SINK 0x270
# define DP_TEST_SINK_START (1 << 0)
+#define DP_FEC_STATUS 0x280
+# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
+# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
+
+#define DP_FEC_ERROR_COUNT_LSB 0x0281
+
+#define DP_FEC_ERROR_COUNT_MSB 0x0282
+# define DP_FEC_ERROR_COUNT_MASK 0x7F
+# define DP_FEC_ERR_COUNT_SHIFT 8
+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
+
#define DP_PAYLOAD_TABLE_UPDATE_STATUS 0x2c0 /* 1.2 MST */
# define DP_PAYLOAD_TABLE_UPDATED (1 << 0)
# define DP_PAYLOAD_ACT_HANDLED (1 << 1)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4)
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
@ 2018-02-14 8:38 ` Patchwork
2018-02-14 9:52 ` ✗ Fi.CI.IGT: warning " Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-02-14 8:38 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev4)
URL : https://patchwork.freedesktop.org/series/34259/
State : success
== Summary ==
Series 34259v4 drm: Add DPCD definitions for DP 1.4 FEC feature
https://patchwork.freedesktop.org/api/1.0/series/34259/revisions/4/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-cnl-y3) fdo#105058
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fdo#105058 https://bugs.freedesktop.org/show_bug.cgi?id=105058
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:265 dwarn:0 dfail:0 fail:2 skip:21 time:440s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:423s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:376s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:484s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:287s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:487s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:484s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:470s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:458s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:569s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:584s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:415s
fi-gdg-551 total:288 pass:180 dwarn:0 dfail:0 fail:0 skip:108 time:283s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:509s
fi-hsw-4770 total:288 pass:259 dwarn:0 dfail:0 fail:2 skip:27 time:410s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:410s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:461s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:455s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:498s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:500s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:590s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:430s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:508s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:524s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:486s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:479s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:414s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:526s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:402s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:470s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:455s
e404d341ffdd255f9a7d8e4461170694edcb3e25 drm-tip: 2018y-02m-14d-01h-12m-17s UTC integration manifest
f2011cea39e2 drm: Add DPCD definitions for DP 1.4 FEC feature
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8007/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.IGT: warning for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4)
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
2018-02-14 8:38 ` ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4) Patchwork
@ 2018-02-14 9:52 ` Patchwork
2018-02-14 11:59 ` [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Jani Nikula
` (4 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-02-14 9:52 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev4)
URL : https://patchwork.freedesktop.org/series/34259/
State : warning
== Summary ==
Test kms_vblank:
Subgroup pipe-c-ts-continuation-dpms-rpm:
fail -> PASS (shard-hsw) fdo#105069 +2
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-shrfb-draw-blt:
dmesg-fail -> PASS (shard-apl) fdo#101623
Subgroup fbc-1p-shrfb-fliptrack:
fail -> PASS (shard-apl) fdo#103167
Subgroup fbc-rgb101010-draw-blt:
pass -> SKIP (shard-snb)
Test kms_draw_crc:
Subgroup draw-method-xrgb2101010-mmap-cpu-xtiled:
pass -> SKIP (shard-snb)
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Subgroup oa-exponents:
fail -> PASS (shard-apl) fdo#102254
Subgroup enable-disable:
pass -> FAIL (shard-apl) fdo#103715
Test kms_cursor_crc:
Subgroup cursor-256x256-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103375
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
fdo#105069 https://bugs.freedesktop.org/show_bug.cgi?id=105069
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3344 pass:1729 dwarn:1 dfail:0 fail:21 skip:1591 time:13868s
shard-hsw total:3407 pass:1706 dwarn:1 dfail:0 fail:53 skip:1645 time:13983s
shard-snb total:3427 pass:1346 dwarn:1 dfail:0 fail:10 skip:2070 time:7540s
Blacklisted hosts:
shard-kbl total:3427 pass:1908 dwarn:1 dfail:0 fail:21 skip:1497 time:11107s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8007/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
2018-02-14 8:38 ` ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4) Patchwork
2018-02-14 9:52 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2018-02-14 11:59 ` Jani Nikula
2018-02-14 19:28 ` Anusha Srivatsa
` (3 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2018-02-14 11:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Manasi Navare, Anusha Srivatsa, dri-devel
On Tue, 13 Feb 2018, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> Forward Error Correction is supported on DP 1.4.
> This patch adds corresponding DPCD register definitions.
>
> v2: Add dri-devel mailing list to the CC list(Jani)
>
> v3: Change names, add missing masks (Manasi)
>
> v4: Add missing shifts to mask (Manasi)
>
> v5: Arrange the definitions in ascending order
> of the address (Jani)
Okay, my apologies, I noticed some further errors that I really should
have noticed earlier. Please see comments inline.
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> include/drm/drm_dp_helper.h | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c239e6e..a19d6fb 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -329,6 +329,13 @@
> # define DP_DS_12BPC 2
> # define DP_DS_16BPC 3
>
> +/* DP Forward error Correction Registers */
> +#define DP_FEC_CAPABILITY (0x090)
Nitpick, the braces are unnecessary.
All the FEC dpcd offset definitions should have /* 1.4 */ at the end
(just the offset macros, not the contents).
> +# define DP_FEC_CAPABLE (1 << 0)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
> +
> /* link configuration */
> #define DP_LINK_BW_SET 0x100
> # define DP_LINK_RATE_TABLE 0x00 /* eDP 1.4 */
> @@ -445,6 +452,18 @@
> #define DP_UPSTREAM_DEVICE_DP_PWR_NEED 0x118 /* 1.2 */
> # define DP_PWR_NOT_NEEDED (1 << 0)
>
> +#define DP_FEC_CONFIGURATION 0x120
> +# define DP_FEC_READY (1 << 0)
> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
> +# define DP_FEC_ERR_COUNT_SEL_MASK (0xff << 4)
# define DP_FEC_ERROR_COUNT_SEL_MASK (7 << 1)
Put that above the values for error count sel.
And then
#define DP_FEC_LANE_SELECT_MASK (3 << 4)
> +# define DP_FEC_LANE_0_SELECT (0 << 4)
> +# define DP_FEC_LANE_1_SELECT (1 << 4)
> +# define DP_FEC_LANE_2_SELECT (2 << 4)
> +# define DP_FEC_LANE_3_SELECT (3 << 4)
> +
> #define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */
> # define DP_AUX_FRAME_SYNC_VALID (1 << 0)
>
> @@ -620,6 +639,17 @@
> #define DP_TEST_SINK 0x270
> # define DP_TEST_SINK_START (1 << 0)
>
> +#define DP_FEC_STATUS 0x280
> +# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
> +# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
> +
> +#define DP_FEC_ERROR_COUNT_LSB 0x0281
> +
> +#define DP_FEC_ERROR_COUNT_MSB 0x0282
> +# define DP_FEC_ERROR_COUNT_MASK 0x7F
> +# define DP_FEC_ERR_COUNT_SHIFT 8
Unnecessary.
> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
> +
> #define DP_PAYLOAD_TABLE_UPDATE_STATUS 0x2c0 /* 1.2 MST */
> # define DP_PAYLOAD_TABLE_UPDATED (1 << 0)
> # define DP_PAYLOAD_ACT_HANDLED (1 << 1)
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
` (2 preceding siblings ...)
2018-02-14 11:59 ` [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Jani Nikula
@ 2018-02-14 19:28 ` Anusha Srivatsa
2018-02-15 13:53 ` Jani Nikula
2018-02-14 21:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Add DPCD definitions for DP 1.4 FEC feature (rev5) Patchwork
` (2 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Anusha Srivatsa @ 2018-02-14 19:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Manasi Navare, Anusha Srivatsa, dri-devel
Forward Error Correction is supported on DP 1.4.
This patch adds corresponding DPCD register definitions.
v2: Add dri-devel mailing list to the CC list(Jani)
v3: Change names, add missing masks (Manasi)
v4: Add missing shifts to mask (Manasi)
v5: Arrange the definitions in ascending order
of the address (Jani)
v6: remove unnecessary definitions. Add missing masks,
add "/* 1.4 */" to offset definitions. (Jani)
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
include/drm/drm_dp_helper.h | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index c239e6e..4de97e9 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -329,6 +329,13 @@
# define DP_DS_12BPC 2
# define DP_DS_16BPC 3
+/* DP Forward error Correction Registers */
+#define DP_FEC_CAPABILITY 0x090 /* 1.4 */
+# define DP_FEC_CAPABLE (1 << 0)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
+# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
+
/* link configuration */
#define DP_LINK_BW_SET 0x100
# define DP_LINK_RATE_TABLE 0x00 /* eDP 1.4 */
@@ -445,6 +452,19 @@
#define DP_UPSTREAM_DEVICE_DP_PWR_NEED 0x118 /* 1.2 */
# define DP_PWR_NOT_NEEDED (1 << 0)
+#define DP_FEC_CONFIGURATION 0x120 /* 1.4 */
+# define DP_FEC_READY (1 << 0)
+# define DP_FEC_ERR_COUNT_SEL_MASK (7 << 1)
+# define DP_FEC_ERR_COUNT_DIS (0 << 1)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
+# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
+# define DP_FEC_LANE_SELECT_MASK (3 << 4)
+# define DP_FEC_LANE_0_SELECT (0 << 4)
+# define DP_FEC_LANE_1_SELECT (1 << 4)
+# define DP_FEC_LANE_2_SELECT (2 << 4)
+# define DP_FEC_LANE_3_SELECT (3 << 4)
+
#define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */
# define DP_AUX_FRAME_SYNC_VALID (1 << 0)
@@ -620,6 +640,16 @@
#define DP_TEST_SINK 0x270
# define DP_TEST_SINK_START (1 << 0)
+#define DP_FEC_STATUS 0x280 /* 1.4 */
+# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
+# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
+
+#define DP_FEC_ERROR_COUNT_LSB 0x0281 /* 1.4 */
+
+#define DP_FEC_ERROR_COUNT_MSB 0x0282 /* 1.4 */
+# define DP_FEC_ERROR_COUNT_MASK 0x7F
+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
+
#define DP_PAYLOAD_TABLE_UPDATE_STATUS 0x2c0 /* 1.2 MST */
# define DP_PAYLOAD_TABLE_UPDATED (1 << 0)
# define DP_PAYLOAD_ACT_HANDLED (1 << 1)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm: Add DPCD definitions for DP 1.4 FEC feature (rev5)
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
` (3 preceding siblings ...)
2018-02-14 19:28 ` Anusha Srivatsa
@ 2018-02-14 21:34 ` Patchwork
2018-02-14 21:51 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-15 6:54 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-02-14 21:34 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev5)
URL : https://patchwork.freedesktop.org/series/34259/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a2efb7357012 drm: Add DPCD definitions for DP 1.4 FEC feature
-:37: CHECK: Prefer using the BIT macro
#37: FILE: include/drm/drm_dp_helper.h:334:
+# define DP_FEC_CAPABLE (1 << 0)
-:38: CHECK: Prefer using the BIT macro
#38: FILE: include/drm/drm_dp_helper.h:335:
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
-:39: CHECK: Prefer using the BIT macro
#39: FILE: include/drm/drm_dp_helper.h:336:
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
-:40: CHECK: Prefer using the BIT macro
#40: FILE: include/drm/drm_dp_helper.h:337:
+# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
-:50: CHECK: Prefer using the BIT macro
#50: FILE: include/drm/drm_dp_helper.h:456:
+# define DP_FEC_READY (1 << 0)
-:53: CHECK: Prefer using the BIT macro
#53: FILE: include/drm/drm_dp_helper.h:459:
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
-:58: CHECK: Prefer using the BIT macro
#58: FILE: include/drm/drm_dp_helper.h:464:
+# define DP_FEC_LANE_1_SELECT (1 << 4)
-:70: CHECK: Prefer using the BIT macro
#70: FILE: include/drm/drm_dp_helper.h:644:
+# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
-:71: CHECK: Prefer using the BIT macro
#71: FILE: include/drm/drm_dp_helper.h:645:
+# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
-:77: CHECK: Prefer using the BIT macro
#77: FILE: include/drm/drm_dp_helper.h:651:
+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
total: 0 errors, 0 warnings, 10 checks, 48 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev5)
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
` (4 preceding siblings ...)
2018-02-14 21:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Add DPCD definitions for DP 1.4 FEC feature (rev5) Patchwork
@ 2018-02-14 21:51 ` Patchwork
2018-02-15 6:54 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-02-14 21:51 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev5)
URL : https://patchwork.freedesktop.org/series/34259/
State : success
== Summary ==
Series 34259v5 drm: Add DPCD definitions for DP 1.4 FEC feature
https://patchwork.freedesktop.org/api/1.0/series/34259/revisions/5/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
pass -> DMESG-FAIL (fi-cnl-y3) fdo#104951
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:424s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:432s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:375s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:285s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:480s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:490s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:455s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:570s
fi-cnl-y3 total:288 pass:261 dwarn:0 dfail:1 fail:0 skip:26 time:574s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:419s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:283s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:512s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:390s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:408s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:460s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:412s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:457s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:498s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:501s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:592s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:433s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:507s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:528s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:487s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:480s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:414s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:434s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:394s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:472s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:451s
c552bd1bdbff57717814c72748f1351d9b2019d5 drm-tip: 2018y-02m-14d-20h-59m-41s UTC integration manifest
a2efb7357012 drm: Add DPCD definitions for DP 1.4 FEC feature
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8031/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.IGT: failure for drm: Add DPCD definitions for DP 1.4 FEC feature (rev5)
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
` (5 preceding siblings ...)
2018-02-14 21:51 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-02-15 6:54 ` Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-02-15 6:54 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev5)
URL : https://patchwork.freedesktop.org/series/34259/
State : failure
== Summary ==
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-apl) fdo#99912
Test perf_pmu:
Subgroup busy-idle-rcs0:
pass -> FAIL (shard-apl)
Test perf:
Subgroup buffer-fill:
fail -> PASS (shard-apl) fdo#103755
Test pm_rpm:
Subgroup system-suspend:
pass -> SKIP (shard-hsw) fdo#103375
Test pm_rps:
Subgroup min-max-config-loaded:
pass -> FAIL (shard-apl) fdo#104060
Test kms_flip:
Subgroup flip-vs-expired-vblank:
pass -> FAIL (shard-apl) fdo#102887
Test drv_selftest:
Subgroup live_gtt:
pass -> INCOMPLETE (shard-apl) fdo#103927
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
fail -> PASS (shard-hsw)
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104060 https://bugs.freedesktop.org/show_bug.cgi?id=104060
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
shard-apl total:3392 pass:1747 dwarn:1 dfail:0 fail:23 skip:1618 time:13316s
shard-hsw total:3427 pass:1758 dwarn:1 dfail:0 fail:10 skip:1657 time:14612s
shard-snb total:3427 pass:1348 dwarn:1 dfail:0 fail:11 skip:2067 time:7648s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8031/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2018-02-14 19:28 ` Anusha Srivatsa
@ 2018-02-15 13:53 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2018-02-15 13:53 UTC (permalink / raw)
To: intel-gfx; +Cc: Manasi Navare, Anusha Srivatsa, dri-devel
On Wed, 14 Feb 2018, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> Forward Error Correction is supported on DP 1.4.
> This patch adds corresponding DPCD register definitions.
>
> v2: Add dri-devel mailing list to the CC list(Jani)
>
> v3: Change names, add missing masks (Manasi)
>
> v4: Add missing shifts to mask (Manasi)
>
> v5: Arrange the definitions in ascending order
> of the address (Jani)
>
> v6: remove unnecessary definitions. Add missing masks,
> add "/* 1.4 */" to offset definitions. (Jani)
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Pushed to drm-misc-next, thanks for the patch.
BR,
Jani.
> ---
> include/drm/drm_dp_helper.h | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c239e6e..4de97e9 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -329,6 +329,13 @@
> # define DP_DS_12BPC 2
> # define DP_DS_16BPC 3
>
> +/* DP Forward error Correction Registers */
> +#define DP_FEC_CAPABILITY 0x090 /* 1.4 */
> +# define DP_FEC_CAPABLE (1 << 0)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
> +
> /* link configuration */
> #define DP_LINK_BW_SET 0x100
> # define DP_LINK_RATE_TABLE 0x00 /* eDP 1.4 */
> @@ -445,6 +452,19 @@
> #define DP_UPSTREAM_DEVICE_DP_PWR_NEED 0x118 /* 1.2 */
> # define DP_PWR_NOT_NEEDED (1 << 0)
>
> +#define DP_FEC_CONFIGURATION 0x120 /* 1.4 */
> +# define DP_FEC_READY (1 << 0)
> +# define DP_FEC_ERR_COUNT_SEL_MASK (7 << 1)
> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
> +# define DP_FEC_LANE_SELECT_MASK (3 << 4)
> +# define DP_FEC_LANE_0_SELECT (0 << 4)
> +# define DP_FEC_LANE_1_SELECT (1 << 4)
> +# define DP_FEC_LANE_2_SELECT (2 << 4)
> +# define DP_FEC_LANE_3_SELECT (3 << 4)
> +
> #define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */
> # define DP_AUX_FRAME_SYNC_VALID (1 << 0)
>
> @@ -620,6 +640,16 @@
> #define DP_TEST_SINK 0x270
> # define DP_TEST_SINK_START (1 << 0)
>
> +#define DP_FEC_STATUS 0x280 /* 1.4 */
> +# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
> +# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
> +
> +#define DP_FEC_ERROR_COUNT_LSB 0x0281 /* 1.4 */
> +
> +#define DP_FEC_ERROR_COUNT_MSB 0x0282 /* 1.4 */
> +# define DP_FEC_ERROR_COUNT_MASK 0x7F
> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
> +
> #define DP_PAYLOAD_TABLE_UPDATE_STATUS 0x2c0 /* 1.2 MST */
> # define DP_PAYLOAD_TABLE_UPDATED (1 << 0)
> # define DP_PAYLOAD_ACT_HANDLED (1 << 1)
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2017-12-22 22:02 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
@ 2017-12-22 23:39 ` Manasi Navare
0 siblings, 0 replies; 17+ messages in thread
From: Manasi Navare @ 2017-12-22 23:39 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx, dri-devel
On Fri, Dec 22, 2017 at 02:02:50PM -0800, Anusha Srivatsa wrote:
> Forward Error Correction is supported on DP 1.4.
> This patch adds corresponding DPCD register definitions.
>
> v2: Add dri-devel mailing list to the CC list(Jani)
>
> v3: Change names, add missing masks (Manasi)
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> include/drm/drm_dp_helper.h | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index da58a42..4f75034 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -284,6 +284,36 @@
> # define DP_DSC_BITS_PER_PIXEL_1_2 0x3
> # define DP_DSC_BITS_PER_PIXEL_1 0x4
>
> +/* DP Forward error Correction Registers */
> +#define DP_FEC_CAPABILITY 0x090
> +# define DP_FEC_CAPABLE (1 << 0)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
> +
> +#define DP_FEC_CONFIGURATION 0x120
> +# define DP_FEC_READY (1 << 0)
> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
> +# define DP_FEC_ERR_COUNT_SEL_MASK (0xFF)
This mask should be with a proper shift to obtain only the
ERR_COUNT_SEL bits. It should be (0xff << 4). See all other mask defines.
After that change,
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi
> +# define DP_FEC_LANE_0_SELECT (0 << 4)
> +# define DP_FEC_LANE_1_SELECT (1 << 4)
> +# define DP_FEC_LANE_2_SELECT (2 << 4)
> +# define DP_FEC_LANE_3_SELECT (3 << 4)
> +
> +#define DP_FEC_STATUS 0x280
> +# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
> +# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
> +
> +#define DP_FEC_ERROR_COUNT_LSB 0x0281
> +
> +#define DP_FEC_ERROR_COUNT_MSB 0x0282
> +# define DP_FEC_ERROR_COUNT_MASK 0x7F
> +# define DP_FEC_ERR_COUNT_SHIFT 8
> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
> +
> #define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
> # define DP_PSR_IS_SUPPORTED 1
> # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
@ 2017-12-22 22:02 Anusha Srivatsa
2017-12-22 23:39 ` Manasi Navare
0 siblings, 1 reply; 17+ messages in thread
From: Anusha Srivatsa @ 2017-12-22 22:02 UTC (permalink / raw)
To: intel-gfx; +Cc: Manasi Navare, Anusha Srivatsa, dri-devel
Forward Error Correction is supported on DP 1.4.
This patch adds corresponding DPCD register definitions.
v2: Add dri-devel mailing list to the CC list(Jani)
v3: Change names, add missing masks (Manasi)
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
include/drm/drm_dp_helper.h | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index da58a42..4f75034 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -284,6 +284,36 @@
# define DP_DSC_BITS_PER_PIXEL_1_2 0x3
# define DP_DSC_BITS_PER_PIXEL_1 0x4
+/* DP Forward error Correction Registers */
+#define DP_FEC_CAPABILITY 0x090
+# define DP_FEC_CAPABLE (1 << 0)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
+# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
+
+#define DP_FEC_CONFIGURATION 0x120
+# define DP_FEC_READY (1 << 0)
+# define DP_FEC_ERR_COUNT_DIS (0 << 1)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
+# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
+# define DP_FEC_ERR_COUNT_SEL_MASK (0xFF)
+# define DP_FEC_LANE_0_SELECT (0 << 4)
+# define DP_FEC_LANE_1_SELECT (1 << 4)
+# define DP_FEC_LANE_2_SELECT (2 << 4)
+# define DP_FEC_LANE_3_SELECT (3 << 4)
+
+#define DP_FEC_STATUS 0x280
+# define DP_FEC_DECODE_EN_DETECTED (1 << 0)
+# define DP_FEC_DECODE_DIS_DETECTED (1 << 1)
+
+#define DP_FEC_ERROR_COUNT_LSB 0x0281
+
+#define DP_FEC_ERROR_COUNT_MSB 0x0282
+# define DP_FEC_ERROR_COUNT_MASK 0x7F
+# define DP_FEC_ERR_COUNT_SHIFT 8
+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
+
#define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
# define DP_PSR_IS_SUPPORTED 1
# define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* RE: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2017-12-21 20:36 ` Manasi Navare
@ 2017-12-21 20:51 ` Srivatsa, Anusha
0 siblings, 0 replies; 17+ messages in thread
From: Srivatsa, Anusha @ 2017-12-21 20:51 UTC (permalink / raw)
To: Navare, Manasi D; +Cc: intel-gfx, dri-devel
>-----Original Message-----
>From: Navare, Manasi D
>Sent: Thursday, December 21, 2017 12:36 PM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>
>Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Ville Syrjala
><ville.syrjala@linux.intel.com>; Jani Nikula <jani.nikula@linux.intel.com>
>Subject: Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
>
>On Mon, Nov 27, 2017 at 04:55:44PM -0800, Anusha Srivatsa wrote:
>> Forward Error Correction is supported on DP 1.4.
>> This patch adds corresponding DPCD register definitions.
>>
>> v2: Add dri-devel to the CC list
>>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>> include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index da58a42..bc816ea 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -284,6 +284,35 @@
>> # define DP_DSC_BITS_PER_PIXEL_1_2 0x3
>> # define DP_DSC_BITS_PER_PIXEL_1 0x4
>>
>> +/* DP Forward error Correction Registers */
>> +#define DP_FEC_CAPABILITY 0x090
>> +# define DP_FEC_CAPABLE (1 << 0)
>> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
>> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
>> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
>> +
>> +#define DP_FEC_CONFIGURATION 0x120
>> +# define DP_FEC_READY (1 << 0)
>> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
>> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
>> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
>> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
>
>These above values indicate the value of FEC_ERROR_COUNT_SEL.
>I think we would need a mask for FEC_ERROR_COUNT_SEL field so that we can
>read this field as drm_dpcd_read(DP_FEC_CONFIGURATION) &
>FEC_ERROR_COUNT_SEL_MASK and then compare this to each of the values for
>that field.
>So we would need an extra #define for the MASK
Sounds good....
>> +# define DP_FEC_LANE_0_SELECT (0 << 4)
>> +# define DP_FEC_LANE_1_SELECT (1 << 4)
>> +# define DP_FEC_LANE_2_SELECT (2 << 4)
>> +# define DP_FEC_LANE_3_SELECT (3 << 4)
>> +
>> +#define DP_FEC_STATUS 0x280
>> +# define DP_FEC_EN_DETECTED (1 << 0)
>
>I think better name would be DP_FEC_DECODE_EN_DETECTED since this refers to
>FEC_DECODE_EN link symbol sequence
Now that you mentioned, I noticed that's the name used in spec too. I wonder why I went ahead with the above name. Shall change it. Thanks.
>> +# define DP_FEC_DEC_DETECTED (1 << 1)
>
>And this should be DP_FEC_DECODE_DIS_DETECTED since this refers to
>FEC_DECODE_DIS link symbol sequence
>
>> +
>> +#define DP_FEC_ERROR_COUNT_1 0x0281
>> +# define DP_FEC_ERR_COUNT_7_0(err_count) (err_count << 0)
>
>So this is a RO register and so we wont be writing the err_count by passing it as
>an argument as above.
>And this is the entire reister that indicates the LSB of ERR_COUNT you can just
>rename the register as DP_FEC_ERR_COUNT_LSB So while reading you just pass
>this register address and get LSB into a variable.
Yes, good point.
>
>> +
>> +#define DP_FEC_ERROR_COUNT_2 0x0282
>> +# define DP_FEC_ERR_COUNT_14_8(err_count) (err_count << 0)
>
>This could be DP_FEC_ERR_COUNT_MSB_MASK and SHIFT should be 8 since you
>want to put this value at the 8th bit of a 16 bit value.
This helps.... thanks!
>> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
>
>Everything else looks good.
Thanks Manasi. I will incorporate these changes in the next revision.
Anusha
>Manasi
>
>> +
>> #define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
>> # define DP_PSR_IS_SUPPORTED 1
>> # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
>> --
>> 2.7.4
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2017-11-28 0:55 Anusha Srivatsa
@ 2017-12-21 20:36 ` Manasi Navare
2017-12-21 20:51 ` Srivatsa, Anusha
0 siblings, 1 reply; 17+ messages in thread
From: Manasi Navare @ 2017-12-21 20:36 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx, dri-devel
On Mon, Nov 27, 2017 at 04:55:44PM -0800, Anusha Srivatsa wrote:
> Forward Error Correction is supported on DP 1.4.
> This patch adds corresponding DPCD register definitions.
>
> v2: Add dri-devel to the CC list
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index da58a42..bc816ea 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -284,6 +284,35 @@
> # define DP_DSC_BITS_PER_PIXEL_1_2 0x3
> # define DP_DSC_BITS_PER_PIXEL_1 0x4
>
> +/* DP Forward error Correction Registers */
> +#define DP_FEC_CAPABILITY 0x090
> +# define DP_FEC_CAPABLE (1 << 0)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
> +
> +#define DP_FEC_CONFIGURATION 0x120
> +# define DP_FEC_READY (1 << 0)
> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
These above values indicate the value of FEC_ERROR_COUNT_SEL.
I think we would need a mask for FEC_ERROR_COUNT_SEL field so that
we can read this field as drm_dpcd_read(DP_FEC_CONFIGURATION) & FEC_ERROR_COUNT_SEL_MASK
and then compare this to each of the values for that field.
So we would need an extra #define for the MASK
> +# define DP_FEC_LANE_0_SELECT (0 << 4)
> +# define DP_FEC_LANE_1_SELECT (1 << 4)
> +# define DP_FEC_LANE_2_SELECT (2 << 4)
> +# define DP_FEC_LANE_3_SELECT (3 << 4)
> +
> +#define DP_FEC_STATUS 0x280
> +# define DP_FEC_EN_DETECTED (1 << 0)
I think better name would be DP_FEC_DECODE_EN_DETECTED since this refers
to FEC_DECODE_EN link symbol sequence
> +# define DP_FEC_DEC_DETECTED (1 << 1)
And this should be DP_FEC_DECODE_DIS_DETECTED since this refers to
FEC_DECODE_DIS link symbol sequence
> +
> +#define DP_FEC_ERROR_COUNT_1 0x0281
> +# define DP_FEC_ERR_COUNT_7_0(err_count) (err_count << 0)
So this is a RO register and so we wont be writing the err_count by passing it as
an argument as above.
And this is the entire reister that indicates the LSB of ERR_COUNT you can just rename the
register as DP_FEC_ERR_COUNT_LSB
So while reading you just pass this register address and get LSB into a variable.
> +
> +#define DP_FEC_ERROR_COUNT_2 0x0282
> +# define DP_FEC_ERR_COUNT_14_8(err_count) (err_count << 0)
This could be DP_FEC_ERR_COUNT_MSB_MASK and SHIFT should be 8 since
you want to put this value at the 8th bit of a 16 bit value.
> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
Everything else looks good.
Manasi
> +
> #define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
> # define DP_PSR_IS_SUPPORTED 1
> # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2017-11-23 7:15 ` Jani Nikula
@ 2017-11-28 0:59 ` Srivatsa, Anusha
0 siblings, 0 replies; 17+ messages in thread
From: Srivatsa, Anusha @ 2017-11-28 0:59 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
>-----Original Message-----
>From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>Sent: Wednesday, November 22, 2017 11:15 PM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>gfx@lists.freedesktop.org
>Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Ville Syrjala
><ville.syrjala@linux.intel.com>; Navare, Manasi D <manasi.d.navare@intel.com>
>Subject: Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
>
>On Wed, 22 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
>> Forward Error Correction is supported on DP 1.4.
>> This patch adds corresponding DPCD register definitions.
>
>Needs to be posted on dri-devel.
Sent to dri-devel too. Thanks Jani.
Anusha
>BR,
>Jani.
>
>
>>
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>> include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 9049ef1..b0eee16 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -284,6 +284,35 @@
>> # define DP_DSC_BITS_PER_PIXEL_1_2 0x3
>> # define DP_DSC_BITS_PER_PIXEL_1 0x4
>>
>> +/* DP Forward error Correction Registers */
>> +#define DP_FEC_CAPABILITY 0x090
>> +# define DP_FEC_CAPABLE (1 << 0)
>> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
>> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
>> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
>> +
>> +#define DP_FEC_CONFIGURATION 0x120
>> +# define DP_FEC_READY (1 << 0)
>> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
>> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
>> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
>> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
>> +# define DP_FEC_LANE_0_SELECT (0 << 4)
>> +# define DP_FEC_LANE_1_SELECT (1 << 4)
>> +# define DP_FEC_LANE_2_SELECT (2 << 4)
>> +# define DP_FEC_LANE_3_SELECT (3 << 4)
>> +
>> +#define DP_FEC_STATUS 0x280
>> +# define DP_FEC_EN_DETECTED (1 << 0)
>> +# define DP_FEC_DEC_DETECTED (1 << 1)
>> +
>> +#define DP_FEC_ERROR_COUNT_1 0x0281
>> +# define DP_FEC_ERR_COUNT_7_0(err_count) (err_count << 0)
>> +
>> +#define DP_FEC_ERROR_COUNT_2 0x0282
>> +# define DP_FEC_ERR_COUNT_14_8(err_count) (err_count << 0)
>> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
>> +
>> #define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
>> # define DP_PSR_IS_SUPPORTED 1
>> # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
>
>--
>Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
@ 2017-11-28 0:55 Anusha Srivatsa
2017-12-21 20:36 ` Manasi Navare
0 siblings, 1 reply; 17+ messages in thread
From: Anusha Srivatsa @ 2017-11-28 0:55 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Forward Error Correction is supported on DP 1.4.
This patch adds corresponding DPCD register definitions.
v2: Add dri-devel to the CC list
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index da58a42..bc816ea 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -284,6 +284,35 @@
# define DP_DSC_BITS_PER_PIXEL_1_2 0x3
# define DP_DSC_BITS_PER_PIXEL_1 0x4
+/* DP Forward error Correction Registers */
+#define DP_FEC_CAPABILITY 0x090
+# define DP_FEC_CAPABLE (1 << 0)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
+# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
+
+#define DP_FEC_CONFIGURATION 0x120
+# define DP_FEC_READY (1 << 0)
+# define DP_FEC_ERR_COUNT_DIS (0 << 1)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
+# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
+# define DP_FEC_LANE_0_SELECT (0 << 4)
+# define DP_FEC_LANE_1_SELECT (1 << 4)
+# define DP_FEC_LANE_2_SELECT (2 << 4)
+# define DP_FEC_LANE_3_SELECT (3 << 4)
+
+#define DP_FEC_STATUS 0x280
+# define DP_FEC_EN_DETECTED (1 << 0)
+# define DP_FEC_DEC_DETECTED (1 << 1)
+
+#define DP_FEC_ERROR_COUNT_1 0x0281
+# define DP_FEC_ERR_COUNT_7_0(err_count) (err_count << 0)
+
+#define DP_FEC_ERROR_COUNT_2 0x0282
+# define DP_FEC_ERR_COUNT_14_8(err_count) (err_count << 0)
+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
+
#define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
# define DP_PSR_IS_SUPPORTED 1
# define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
2017-11-22 21:49 Anusha Srivatsa
@ 2017-11-23 7:15 ` Jani Nikula
2017-11-28 0:59 ` Srivatsa, Anusha
0 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2017-11-23 7:15 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx
On Wed, 22 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> Forward Error Correction is supported on DP 1.4.
> This patch adds corresponding DPCD register definitions.
Needs to be posted on dri-devel.
BR,
Jani.
>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 9049ef1..b0eee16 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -284,6 +284,35 @@
> # define DP_DSC_BITS_PER_PIXEL_1_2 0x3
> # define DP_DSC_BITS_PER_PIXEL_1 0x4
>
> +/* DP Forward error Correction Registers */
> +#define DP_FEC_CAPABILITY 0x090
> +# define DP_FEC_CAPABLE (1 << 0)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
> +# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
> +
> +#define DP_FEC_CONFIGURATION 0x120
> +# define DP_FEC_READY (1 << 0)
> +# define DP_FEC_ERR_COUNT_DIS (0 << 1)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
> +# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
> +# define DP_FEC_LANE_0_SELECT (0 << 4)
> +# define DP_FEC_LANE_1_SELECT (1 << 4)
> +# define DP_FEC_LANE_2_SELECT (2 << 4)
> +# define DP_FEC_LANE_3_SELECT (3 << 4)
> +
> +#define DP_FEC_STATUS 0x280
> +# define DP_FEC_EN_DETECTED (1 << 0)
> +# define DP_FEC_DEC_DETECTED (1 << 1)
> +
> +#define DP_FEC_ERROR_COUNT_1 0x0281
> +# define DP_FEC_ERR_COUNT_7_0(err_count) (err_count << 0)
> +
> +#define DP_FEC_ERROR_COUNT_2 0x0282
> +# define DP_FEC_ERR_COUNT_14_8(err_count) (err_count << 0)
> +# define DP_FEC_ERR_COUNT_VALID (1 << 7)
> +
> #define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
> # define DP_PSR_IS_SUPPORTED 1
> # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
@ 2017-11-22 21:49 Anusha Srivatsa
2017-11-23 7:15 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Anusha Srivatsa @ 2017-11-22 21:49 UTC (permalink / raw)
To: intel-gfx
Forward Error Correction is supported on DP 1.4.
This patch adds corresponding DPCD register definitions.
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 9049ef1..b0eee16 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -284,6 +284,35 @@
# define DP_DSC_BITS_PER_PIXEL_1_2 0x3
# define DP_DSC_BITS_PER_PIXEL_1 0x4
+/* DP Forward error Correction Registers */
+#define DP_FEC_CAPABILITY 0x090
+# define DP_FEC_CAPABLE (1 << 0)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP (1 << 2)
+# define DP_FEC_BIT_ERROR_COUNT_CAP (1 << 3)
+
+#define DP_FEC_CONFIGURATION 0x120
+# define DP_FEC_READY (1 << 0)
+# define DP_FEC_ERR_COUNT_DIS (0 << 1)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT (2 << 1)
+# define DP_FEC_BIT_ERROR_COUNT (3 << 1)
+# define DP_FEC_LANE_0_SELECT (0 << 4)
+# define DP_FEC_LANE_1_SELECT (1 << 4)
+# define DP_FEC_LANE_2_SELECT (2 << 4)
+# define DP_FEC_LANE_3_SELECT (3 << 4)
+
+#define DP_FEC_STATUS 0x280
+# define DP_FEC_EN_DETECTED (1 << 0)
+# define DP_FEC_DEC_DETECTED (1 << 1)
+
+#define DP_FEC_ERROR_COUNT_1 0x0281
+# define DP_FEC_ERR_COUNT_7_0(err_count) (err_count << 0)
+
+#define DP_FEC_ERROR_COUNT_2 0x0282
+# define DP_FEC_ERR_COUNT_14_8(err_count) (err_count << 0)
+# define DP_FEC_ERR_COUNT_VALID (1 << 7)
+
#define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */
# define DP_PSR_IS_SUPPORTED 1
# define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2018-02-15 13:53 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 7:59 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
2018-02-14 8:38 ` ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4) Patchwork
2018-02-14 9:52 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-02-14 11:59 ` [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Jani Nikula
2018-02-14 19:28 ` Anusha Srivatsa
2018-02-15 13:53 ` Jani Nikula
2018-02-14 21:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Add DPCD definitions for DP 1.4 FEC feature (rev5) Patchwork
2018-02-14 21:51 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-15 6:54 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-12-22 22:02 [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature Anusha Srivatsa
2017-12-22 23:39 ` Manasi Navare
2017-11-28 0:55 Anusha Srivatsa
2017-12-21 20:36 ` Manasi Navare
2017-12-21 20:51 ` Srivatsa, Anusha
2017-11-22 21:49 Anusha Srivatsa
2017-11-23 7:15 ` Jani Nikula
2017-11-28 0:59 ` Srivatsa, Anusha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.