All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kexec: fix build when BR2_STRIP_none=y
Date: Fri, 02 Dec 2016 17:11:07 +0100	[thread overview]
Message-ID: <87a8ce8g6c.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1480679517-551-1-git-send-email-marcin.nowakowski@imgtec.com> (Marcin Nowakowski's message of "Fri, 2 Dec 2016 12:51:57 +0100")

>>>>> "Marcin" == Marcin Nowakowski <marcin.nowakowski@imgtec.com> writes:

 > When BR2_STRIP is set to none, a dummy 'true' app is used instead of
 > strip utility. However, kexec package always requires a real strip
 > executable as it is used to generate intermediate files during the build
 > process.

 > If 'true' is used the build system runs the following command:

 > true --strip-debug -o purgatory/purgatory.ro purgatory/purgatory.ro.sym

 > which obviously doesn't do anything useful and the build later fails
 > with:

 > bin/bin-to-hex purgatory < purgatory/purgatory.ro > kexec/purgatory.c
 > /bin/sh: purgatory/purgatory.ro: No such file or directory
 > kexec/Makefile:7: recipe for target 'kexec/purgatory.c' failed
 > make[2]: *** [kexec/purgatory.c] Error 1

 > To resolve it always specify STRIP=$(CROSS_COMPILE)strip, regardless of
 > buildroot configuration.

My first thought was that we shouldn't strip when the user has selected
not to do so, but as it leaves the unstripped variant around I guess it
is OK.

Committed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-12-02 16:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 11:51 [Buildroot] [PATCH] kexec: fix build when BR2_STRIP_none=y Marcin Nowakowski
2016-12-02 16:11 ` Peter Korsgaard [this message]
2016-12-02 20:38   ` Thomas Petazzoni
2016-12-02 21:09     ` Peter Korsgaard
2016-12-02 21:34       ` Thomas Petazzoni
2016-12-05 22:34         ` Peter Korsgaard
2016-12-06 23:48           ` Arnout Vandecappelle
2016-12-07  7:23             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8ce8g6c.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.