From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kexec: fix build when BR2_STRIP_none=y
Date: Wed, 07 Dec 2016 08:23:56 +0100 [thread overview]
Message-ID: <87eg1ki4mr.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <789c403c-6dd0-4b7a-e718-9ccfac82be66@mind.be> (Arnout Vandecappelle's message of "Wed, 7 Dec 2016 00:48:48 +0100")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
>> >> > My other thought is that I believe it's not the first time (see commit
>> >> > fc174b7057495ebb31393ae27f3ceeefdc490022), so perhaps our idea of
>> >> > having STRIP=true when BR2_STRIP_none=y is a bad idea, and we should
>> >> > handle this in a different way.
>> >>
>> >> The question is how? Create a dummy shell script to better emulate the
>> >> command line options / behaviour of strip?
>>
>> > I'm not sure. Yet another wrapper kind of sucks. Is it possible to pass
>> > enough options to strip to have it not strip anything? :-)
>>
>> Not that I'm aware of at least. Anyone?
> Why do we have to set TARGET_STRIP to something different when
> BR2_STRIP_none=y? BR2_STRIP_none is supposed to mean that we don't strip all
> binaries, it doesn't mean that an individual package isn't allowed to strip its
> binaries...
Sorry, I don't agree. Quite some packages afaik call $(STRIP) (which we
set to TARGET_STRIP) in their 'make install'. Users don't really care if
binaries are stripped during <foo>-install-target or target-finalize,
the end result for them is the same.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2016-12-07 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 11:51 [Buildroot] [PATCH] kexec: fix build when BR2_STRIP_none=y Marcin Nowakowski
2016-12-02 16:11 ` Peter Korsgaard
2016-12-02 20:38 ` Thomas Petazzoni
2016-12-02 21:09 ` Peter Korsgaard
2016-12-02 21:34 ` Thomas Petazzoni
2016-12-05 22:34 ` Peter Korsgaard
2016-12-06 23:48 ` Arnout Vandecappelle
2016-12-07 7:23 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg1ki4mr.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.