All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Mark Brown <broonie@kernel.org>, David Airlie <airlied@linux.ie>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	Thierry Reding <treding@nvidia.com>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Liam Girdwood <lgirdwood@gmail.com>, Simon <horms@verge.net.au>,
	<linux-renesas-soc@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support
Date: Tue, 2 Aug 2016 00:46:26 +0000	[thread overview]
Message-ID: <87a8gwhunk.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20160801143921.GE1041@n2100.armlinux.org.uk>


Hi Russell

> > +static int snd_dw_hdmi_probe(struct platform_device *pdev)
> > +{
> > +	struct dw_hdmi_i2s_audio_data *audio = pdev->dev.platform_data;
> > +	struct platform_device_info pdevinfo;
> > +	struct hdmi_codec_pdata pdata;
> > +
> > +	pdata.ops		= &dw_hdmi_i2s_ops;
> > +	pdata.i2s		= 1;
> > +	pdata.max_i2s_channels	= 6;
> > +	pdata.data		= audio;
> > +
> > +	memset(&pdevinfo, 0, sizeof(pdevinfo));
> > +	pdevinfo.parent		= pdev->dev.parent;
> > +	pdevinfo.id		= PLATFORM_DEVID_AUTO;
> > +	pdevinfo.name		= HDMI_CODEC_DRV_NAME;
> > +	pdevinfo.data		= &pdata;
> > +	pdevinfo.size_data	= sizeof(pdata);
> > +	pdevinfo.dma_mask	= DMA_BIT_MASK(32);
> > +
> > +	return IS_ERR_OR_NULL(platform_device_register_full(&pdevinfo));
> 
> This is certainly wrong.  You're returning a 0/1 value rather than
> an error code when platform_device_register_full() fails.

Thanks.
I forgot why I added this ??
I will fix it on v2 patch

WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Simon <horms@verge.net.au>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	dri-devel@lists.freedesktop.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-renesas-soc@vger.kernel.org,
	Mark Brown <broonie@kernel.org>,
	Thierry Reding <treding@nvidia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support
Date: Tue, 2 Aug 2016 00:46:26 +0000	[thread overview]
Message-ID: <87a8gwhunk.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20160801143921.GE1041@n2100.armlinux.org.uk>


Hi Russell

> > +static int snd_dw_hdmi_probe(struct platform_device *pdev)
> > +{
> > +	struct dw_hdmi_i2s_audio_data *audio = pdev->dev.platform_data;
> > +	struct platform_device_info pdevinfo;
> > +	struct hdmi_codec_pdata pdata;
> > +
> > +	pdata.ops		= &dw_hdmi_i2s_ops;
> > +	pdata.i2s		= 1;
> > +	pdata.max_i2s_channels	= 6;
> > +	pdata.data		= audio;
> > +
> > +	memset(&pdevinfo, 0, sizeof(pdevinfo));
> > +	pdevinfo.parent		= pdev->dev.parent;
> > +	pdevinfo.id		= PLATFORM_DEVID_AUTO;
> > +	pdevinfo.name		= HDMI_CODEC_DRV_NAME;
> > +	pdevinfo.data		= &pdata;
> > +	pdevinfo.size_data	= sizeof(pdata);
> > +	pdevinfo.dma_mask	= DMA_BIT_MASK(32);
> > +
> > +	return IS_ERR_OR_NULL(platform_device_register_full(&pdevinfo));
> 
> This is certainly wrong.  You're returning a 0/1 value rather than
> an error code when platform_device_register_full() fails.

Thanks.
I forgot why I added this ??
I will fix it on v2 patch

  reply	other threads:[~2016-08-02  0:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  2:46 [PATCH 0/3] DesignWare HDMI I2S suport Kuninori Morimoto
2016-06-24  2:46 ` Kuninori Morimoto
2016-06-24  2:40 ` [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support Kuninori Morimoto
2016-06-24  2:40   ` Kuninori Morimoto
2016-06-29  9:50   ` Yakir Yang
2016-07-28 16:05   ` Jose Abreu
2016-07-28 16:05     ` Jose Abreu
2016-08-01  4:57     ` Kuninori Morimoto
2016-08-01  4:57       ` Kuninori Morimoto
2016-08-01  7:45       ` Jose Abreu
2016-08-01  7:45         ` Jose Abreu
2016-08-01 17:45       ` Mark Brown
2016-08-01 17:45         ` Mark Brown
2016-08-02  0:47         ` Kuninori Morimoto
2016-08-02  0:47           ` Kuninori Morimoto
2016-08-02 13:14           ` Daniel Vetter
2016-08-02 13:14             ` Daniel Vetter
2016-08-03  1:29             ` Kuninori Morimoto
2016-08-03  1:29               ` Kuninori Morimoto
2016-08-05 11:13             ` Mark Brown
2016-08-05 11:13               ` Mark Brown
2016-08-01 14:39   ` Russell King - ARM Linux
2016-08-02  0:46     ` Kuninori Morimoto [this message]
2016-08-02  0:46       ` Kuninori Morimoto
2016-06-24  2:47 ` [PATCH 2/3] ASoC: hdmi-codec: callback function will be called with private data Kuninori Morimoto
2016-06-24  2:47   ` Kuninori Morimoto
2016-06-27 17:56   ` Applied "ASoC: hdmi-codec: callback function will be called with private data" to the asoc tree Mark Brown
2016-06-27 17:56     ` Mark Brown
2016-06-24  2:48 ` [PATCH 3/3] ASoC: hdmi-codec: enable multi probe for same device Kuninori Morimoto
2016-06-24  2:48   ` Kuninori Morimoto
2016-08-02  5:25 ` [PATCH 0/3] DesignWare HDMI I2S suport Kuninori Morimoto
2016-08-02  5:25   ` Kuninori Morimoto
2016-08-03 17:28   ` Mark Brown
2016-08-03 17:28     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8gwhunk.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=airlied@linux.ie \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=horms@verge.net.au \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.