* [PATCH] carl9170: Clarify kconfig text @ 2016-04-16 8:33 Lauri Kasanen [not found] ` <1466768.7dLuLFSDol@debian64> 0 siblings, 1 reply; 25+ messages in thread From: Lauri Kasanen @ 2016-04-16 8:33 UTC (permalink / raw) To: Christian Lamparter; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <cand@gmx.com> --- drivers/net/wireless/ath/carl9170/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig index 1a796e5..f3e3222 100644 --- a/drivers/net/wireless/ath/carl9170/Kconfig +++ b/drivers/net/wireless/ath/carl9170/Kconfig @@ -5,7 +5,7 @@ config CARL9170 select FW_LOADER select CRC32 help - This is another driver for the Atheros "otus" 802.11n USB devices. + This is the mainline driver for the Atheros "otus" 802.11n USB devices. This driver provides more features than the original, but it needs a special firmware (carl9170-1.fw) to do that. -- 2.6.2 ^ permalink raw reply related [flat|nested] 25+ messages in thread
[parent not found: <1466768.7dLuLFSDol@debian64>]
* [PATCH v2] carl9170: Clarify kconfig text [not found] ` <1466768.7dLuLFSDol@debian64> @ 2016-04-16 14:18 ` Lauri Kasanen 0 siblings, 0 replies; 25+ messages in thread From: Lauri Kasanen @ 2016-04-16 14:18 UTC (permalink / raw) To: Christian Lamparter; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <cand@gmx.com> --- v2: Remove the mention of the previous driver, suggested by Christian. drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig index 1a796e5..2e34bae 100644 --- a/drivers/net/wireless/ath/carl9170/Kconfig +++ b/drivers/net/wireless/ath/carl9170/Kconfig @@ -5,12 +5,10 @@ config CARL9170 select FW_LOADER select CRC32 help - This is another driver for the Atheros "otus" 802.11n USB devices. + This is the mainline driver for the Atheros "otus" 802.11n USB devices. - This driver provides more features than the original, - but it needs a special firmware (carl9170-1.fw) to do that. - - The firmware can be downloaded from our wiki here: + It needs a special firmware (carl9170-1.fw), which can be downloaded + from our wiki here: <http://wireless.kernel.org/en/users/Drivers/carl9170> If you choose to build a module, it'll be called carl9170. -- 2.6.2 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-16 14:18 ` Lauri Kasanen 0 siblings, 0 replies; 25+ messages in thread From: Lauri Kasanen @ 2016-04-16 14:18 UTC (permalink / raw) To: Christian Lamparter Cc: Kalle Valo, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> --- v2: Remove the mention of the previous driver, suggested by Christian. drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig index 1a796e5..2e34bae 100644 --- a/drivers/net/wireless/ath/carl9170/Kconfig +++ b/drivers/net/wireless/ath/carl9170/Kconfig @@ -5,12 +5,10 @@ config CARL9170 select FW_LOADER select CRC32 help - This is another driver for the Atheros "otus" 802.11n USB devices. + This is the mainline driver for the Atheros "otus" 802.11n USB devices. - This driver provides more features than the original, - but it needs a special firmware (carl9170-1.fw) to do that. ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text 2016-04-16 14:18 ` Lauri Kasanen (?) @ 2016-04-16 15:32 ` Christian Lamparter -1 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-16 15:32 UTC (permalink / raw) To: Lauri Kasanen; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel On Saturday, April 16, 2016 05:18:56 PM Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri Kasanen <cand@gmx.com> Acked-by: Christian Lamparter <chunkeey@googlemail.com> > --- > v2: Remove the mention of the previous driver, suggested by Christian. Thanks! > drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig > index 1a796e5..2e34bae 100644 > --- a/drivers/net/wireless/ath/carl9170/Kconfig > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > @@ -5,12 +5,10 @@ config CARL9170 > select FW_LOADER > select CRC32 > help > - This is another driver for the Atheros "otus" 802.11n USB devices. > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > > - This driver provides more features than the original, > - but it needs a special firmware (carl9170-1.fw) to do that. > - > - The firmware can be downloaded from our wiki here: > + It needs a special firmware (carl9170-1.fw), which can be downloaded > + from our wiki here: > <http://wireless.kernel.org/en/users/Drivers/carl9170> > > If you choose to build a module, it'll be called carl9170. > ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-18 15:45 ` Kalle Valo 0 siblings, 0 replies; 25+ messages in thread From: Kalle Valo @ 2016-04-18 15:45 UTC (permalink / raw) To: Lauri Kasanen; +Cc: Christian Lamparter, linux-wireless, netdev, linux-kernel Lauri Kasanen <cand@gmx.com> writes: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri Kasanen <cand@gmx.com> > --- > v2: Remove the mention of the previous driver, suggested by Christian. > > drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig > index 1a796e5..2e34bae 100644 > --- a/drivers/net/wireless/ath/carl9170/Kconfig > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > @@ -5,12 +5,10 @@ config CARL9170 > select FW_LOADER > select CRC32 > help > - This is another driver for the Atheros "otus" 802.11n USB devices. > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > > - This driver provides more features than the original, > - but it needs a special firmware (carl9170-1.fw) to do that. > - > - The firmware can be downloaded from our wiki here: > + It needs a special firmware (carl9170-1.fw), which can be downloaded > + from our wiki here: > <http://wireless.kernel.org/en/users/Drivers/carl9170> Why even mention anything about a "special firmware" as the firmware is already available from linux-firmware.git? That's default location for all firmware images and I think most, if not all, distros should have it available. So wouldn't it be better not to mention anything about firmware at all? -- Kalle Valo ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-18 15:45 ` Kalle Valo 0 siblings, 0 replies; 25+ messages in thread From: Kalle Valo @ 2016-04-18 15:45 UTC (permalink / raw) To: Lauri Kasanen Cc: Christian Lamparter, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> writes: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> > --- > v2: Remove the mention of the previous driver, suggested by Christian. > > drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig > index 1a796e5..2e34bae 100644 > --- a/drivers/net/wireless/ath/carl9170/Kconfig > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > @@ -5,12 +5,10 @@ config CARL9170 > select FW_LOADER > select CRC32 > help > - This is another driver for the Atheros "otus" 802.11n USB devices. > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > > - This driver provides more features than the original, > - but it needs a special firmware (carl9170-1.fw) to do that. > - > - The firmware can be downloaded from our wiki here: > + It needs a special firmware (carl9170-1.fw), which can be downloaded > + from our wiki here: > <http://wireless.kernel.org/en/users/Drivers/carl9170> Why even mention anything about a "special firmware" as the firmware is already available from linux-firmware.git? That's default location for all firmware images and I think most, if not all, distros should have it available. So wouldn't it be better not to mention anything about firmware at all? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] carl9170: Clarify kconfig text @ 2016-04-18 16:07 ` Lauri Kasanen 0 siblings, 0 replies; 25+ messages in thread From: Lauri Kasanen @ 2016-04-18 16:07 UTC (permalink / raw) To: Kalle Valo; +Cc: Christian Lamparter, linux-wireless, netdev, linux-kernel The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <cand@gmx.com> --- v3: Remove all firmware mentions. drivers/net/wireless/ath/carl9170/Kconfig | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig index 1a796e5..ca1ae09 100644 --- a/drivers/net/wireless/ath/carl9170/Kconfig +++ b/drivers/net/wireless/ath/carl9170/Kconfig @@ -5,13 +5,7 @@ config CARL9170 select FW_LOADER select CRC32 help - This is another driver for the Atheros "otus" 802.11n USB devices. - - This driver provides more features than the original, - but it needs a special firmware (carl9170-1.fw) to do that. - - The firmware can be downloaded from our wiki here: - <http://wireless.kernel.org/en/users/Drivers/carl9170> + This is the mainline driver for the Atheros "otus" 802.11n USB devices. If you choose to build a module, it'll be called carl9170. -- 2.6.2 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v3] carl9170: Clarify kconfig text @ 2016-04-18 16:07 ` Lauri Kasanen 0 siblings, 0 replies; 25+ messages in thread From: Lauri Kasanen @ 2016-04-18 16:07 UTC (permalink / raw) To: Kalle Valo Cc: Christian Lamparter, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> --- v3: Remove all firmware mentions. drivers/net/wireless/ath/carl9170/Kconfig | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig index 1a796e5..ca1ae09 100644 --- a/drivers/net/wireless/ath/carl9170/Kconfig +++ b/drivers/net/wireless/ath/carl9170/Kconfig @@ -5,13 +5,7 @@ config CARL9170 select FW_LOADER select CRC32 help - This is another driver for the Atheros "otus" 802.11n USB devices. - - This driver provides more features than the original, - but it needs a special firmware (carl9170-1.fw) to do that. ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v3] carl9170: Clarify kconfig text 2016-04-18 16:07 ` Lauri Kasanen (?) @ 2016-04-18 16:24 ` Christian Lamparter -1 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-18 16:24 UTC (permalink / raw) To: Lauri Kasanen; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel On Monday, April 18, 2016 07:07:39 PM Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri Kasanen <cand@gmx.com> > --- > v3: Remove all firmware mentions. > > drivers/net/wireless/ath/carl9170/Kconfig | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig > index 1a796e5..ca1ae09 100644 > --- a/drivers/net/wireless/ath/carl9170/Kconfig > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > @@ -5,13 +5,7 @@ config CARL9170 > select FW_LOADER > select CRC32 > help > - This is another driver for the Atheros "otus" 802.11n USB devices. > - > - This driver provides more features than the original, > - but it needs a special firmware (carl9170-1.fw) to do that. > - > - The firmware can be downloaded from our wiki here: > - <http://wireless.kernel.org/en/users/Drivers/carl9170> Please do keep the wiki link. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-18 16:20 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-18 16:20 UTC (permalink / raw) To: Kalle Valo Cc: Lauri Kasanen, linux-wireless, netdev, linux-kernel, sgruszka, emmanuel.grumbach, linuxwifi, johannes.berg On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > Lauri Kasanen <cand@gmx.com> writes: > > > The previous text was confusing, leading readers to think this > > driver was a duplicate, and so didn't need to be enabled. > > > > After the removal of the older staging driver, this is the only > > driver in mainline for these devices. > > > > Signed-off-by: Lauri Kasanen <cand@gmx.com> > > --- > > v2: Remove the mention of the previous driver, suggested by Christian. > > > > drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig > > index 1a796e5..2e34bae 100644 > > --- a/drivers/net/wireless/ath/carl9170/Kconfig > > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > > @@ -5,12 +5,10 @@ config CARL9170 > > select FW_LOADER > > select CRC32 > > help > > - This is another driver for the Atheros "otus" 802.11n USB devices. > > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > > > > - This driver provides more features than the original, > > - but it needs a special firmware (carl9170-1.fw) to do that. > > - > > - The firmware can be downloaded from our wiki here: > > + It needs a special firmware (carl9170-1.fw), which can be downloaded > > + from our wiki here: > > <http://wireless.kernel.org/en/users/Drivers/carl9170> > > Why even mention anything about a "special firmware" as the firmware is > already available from linux-firmware.git? Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too but that failed. <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> > That's default location for all firmware images and I think most, if not all, > distros should have it available. So wouldn't it be better not to mention > anything about firmware at all? Sure, but this could be a different patch then. I think Intel devices (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download firmware from this device from our homepage here" too. So if we want, we can remove them altogether? Regards, Christian ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-18 16:20 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-18 16:20 UTC (permalink / raw) To: Kalle Valo Cc: Lauri Kasanen, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, sgruszka-H+wXaHxf7aLQT0dZR+AlfA, emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w, linuxwifi-ral2JQCrhuEAvxtiuMwx3w, johannes.berg-ral2JQCrhuEAvxtiuMwx3w On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> writes: > > > The previous text was confusing, leading readers to think this > > driver was a duplicate, and so didn't need to be enabled. > > > > After the removal of the older staging driver, this is the only > > driver in mainline for these devices. > > > > Signed-off-by: Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> > > --- > > v2: Remove the mention of the previous driver, suggested by Christian. > > > > drivers/net/wireless/ath/carl9170/Kconfig | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig > > index 1a796e5..2e34bae 100644 > > --- a/drivers/net/wireless/ath/carl9170/Kconfig > > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > > @@ -5,12 +5,10 @@ config CARL9170 > > select FW_LOADER > > select CRC32 > > help > > - This is another driver for the Atheros "otus" 802.11n USB devices. > > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > > > > - This driver provides more features than the original, > > - but it needs a special firmware (carl9170-1.fw) to do that. > > - > > - The firmware can be downloaded from our wiki here: > > + It needs a special firmware (carl9170-1.fw), which can be downloaded > > + from our wiki here: > > <http://wireless.kernel.org/en/users/Drivers/carl9170> > > Why even mention anything about a "special firmware" as the firmware is > already available from linux-firmware.git? Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too but that failed. <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> > That's default location for all firmware images and I think most, if not all, > distros should have it available. So wouldn't it be better not to mention > anything about firmware at all? Sure, but this could be a different patch then. I think Intel devices (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download firmware from this device from our homepage here" too. So if we want, we can remove them altogether? Regards, Christian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text 2016-04-18 16:20 ` Christian Lamparter (?) @ 2016-04-18 16:42 ` Kalle Valo 2016-04-18 17:07 ` Christian Lamparter -1 siblings, 1 reply; 25+ messages in thread From: Kalle Valo @ 2016-04-18 16:42 UTC (permalink / raw) To: Christian Lamparter Cc: Lauri Kasanen, linux-wireless, netdev, linux-kernel, sgruszka, emmanuel.grumbach, linuxwifi, johannes.berg, emmanuel.grumbach Christian Lamparter <chunkeey@googlemail.com> writes: > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> Lauri Kasanen <cand@gmx.com> writes: >> >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig >> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig >> > @@ -5,12 +5,10 @@ config CARL9170 >> > select FW_LOADER >> > select CRC32 >> > help >> > - This is another driver for the Atheros "otus" 802.11n USB devices. >> > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. >> > >> > - This driver provides more features than the original, >> > - but it needs a special firmware (carl9170-1.fw) to do that. >> > - >> > - The firmware can be downloaded from our wiki here: >> > + It needs a special firmware (carl9170-1.fw), which can be downloaded >> > + from our wiki here: >> > <http://wireless.kernel.org/en/users/Drivers/carl9170> >> >> Why even mention anything about a "special firmware" as the firmware is >> already available from linux-firmware.git? > > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too > but that failed. > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> Rick's comment makes sense to me, better just to provide the latest version. No need to unnecessary confuse the users. And if someone really wants to use an older version that she can retrieve it from the git history. >> That's default location for all firmware images and I think most, if not all, >> distros should have it available. So wouldn't it be better not to mention >> anything about firmware at all? > > Sure, but this could be a different patch then. I think Intel devices > (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download > firmware from this device from our homepage here" too. So if we want, > we can remove them altogether? So iwlwifi now has: In order to use this driver, you will need a firmware image for it. You can obtain the microcode from: <http://wireless.kernel.org/en/users/Drivers/iwlwifi>. Maybe that could be changed to mention about the wiki page in general: The driver has a wiki page at: <http://wireless.kernel.org/en/users/Drivers/iwlwifi>. But I know iwlwifi updates the firmware images pretty often so Emmanuel might see this differently. -- Kalle Valo ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-18 17:07 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-18 17:07 UTC (permalink / raw) To: Kalle Valo; +Cc: Lauri Kasanen, linux-wireless, netdev, linux-kernel On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > Christian Lamparter <chunkeey@googlemail.com> writes: > > > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> Lauri Kasanen <cand@gmx.com> writes: > >> > >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig > >> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > >> > @@ -5,12 +5,10 @@ config CARL9170 > >> > select FW_LOADER > >> > select CRC32 > >> > help > >> > - This is another driver for the Atheros "otus" 802.11n USB devices. > >> > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > >> > > >> > - This driver provides more features than the original, > >> > - but it needs a special firmware (carl9170-1.fw) to do that. > >> > - > >> > - The firmware can be downloaded from our wiki here: > >> > + It needs a special firmware (carl9170-1.fw), which can be downloaded > >> > + from our wiki here: > >> > <http://wireless.kernel.org/en/users/Drivers/carl9170> > >> > >> Why even mention anything about a "special firmware" as the firmware is > >> already available from linux-firmware.git? > > > > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too > > but that failed. > > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> > > Rick's comment makes sense to me, better just to provide the latest > version. No need to unnecessary confuse the users. And if someone really > wants to use an older version that she can retrieve it from the git > history. Part of the fun here is that firmware is GPLv2. The linux-firmware.git has to point to or add the firmware source to their tree. They have added every single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz like you normally do for release sources. If you want to read more about it: <http://www.spinics.net/lists/linux-wireless/msg101868.html> ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text @ 2016-04-18 17:07 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-18 17:07 UTC (permalink / raw) To: Kalle Valo Cc: Lauri Kasanen, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > Christian Lamparter <chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes: > > > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> Lauri Kasanen <cand-KK0ffGbhmjU@public.gmane.org> writes: > >> > >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig > >> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig > >> > @@ -5,12 +5,10 @@ config CARL9170 > >> > select FW_LOADER > >> > select CRC32 > >> > help > >> > - This is another driver for the Atheros "otus" 802.11n USB devices. > >> > + This is the mainline driver for the Atheros "otus" 802.11n USB devices. > >> > > >> > - This driver provides more features than the original, > >> > - but it needs a special firmware (carl9170-1.fw) to do that. > >> > - > >> > - The firmware can be downloaded from our wiki here: > >> > + It needs a special firmware (carl9170-1.fw), which can be downloaded > >> > + from our wiki here: > >> > <http://wireless.kernel.org/en/users/Drivers/carl9170> > >> > >> Why even mention anything about a "special firmware" as the firmware is > >> already available from linux-firmware.git? > > > > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too > > but that failed. > > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> > > Rick's comment makes sense to me, better just to provide the latest > version. No need to unnecessary confuse the users. And if someone really > wants to use an older version that she can retrieve it from the git > history. Part of the fun here is that firmware is GPLv2. The linux-firmware.git has to point to or add the firmware source to their tree. They have added every single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz like you normally do for release sources. If you want to read more about it: <http://www.spinics.net/lists/linux-wireless/msg101868.html> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text 2016-04-18 17:07 ` Christian Lamparter (?) @ 2016-04-20 7:59 ` Kalle Valo 2016-04-20 21:11 ` Christian Lamparter -1 siblings, 1 reply; 25+ messages in thread From: Kalle Valo @ 2016-04-20 7:59 UTC (permalink / raw) To: Christian Lamparter; +Cc: Lauri Kasanen, linux-wireless, netdev, linux-kernel Christian Lamparter <chunkeey@googlemail.com> writes: > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >> Christian Lamparter <chunkeey@googlemail.com> writes: >> >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> > >> >> Why even mention anything about a "special firmware" as the firmware is >> >> already available from linux-firmware.git? >> > >> > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too >> > but that failed. >> > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> >> >> Rick's comment makes sense to me, better just to provide the latest >> version. No need to unnecessary confuse the users. And if someone really >> wants to use an older version that she can retrieve it from the git >> history. > > Part of the fun here is that firmware is GPLv2. The linux-firmware.git has > to point to or add the firmware source to their tree. They have added every > single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz > like you normally do for release sources. > > If you want to read more about it: > <http://www.spinics.net/lists/linux-wireless/msg101868.html> Yeah, that's more work. I get that. But I'm still not understanding what's the actual problem which prevents us from updating carl9170 firmware in linux-firmware. -- Kalle Valo ^ permalink raw reply [flat|nested] 25+ messages in thread
* [RESEND] Re: updating carl9170-1.fw in linux-firmware.git @ 2016-04-20 21:11 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-20 21:11 UTC (permalink / raw) To: Kalle Valo Cc: Lauri Kasanen, linux-wireless, netdev, linux-kernel, Linux Firmware Maintainers, Xose Vazquez Perez On Wednesday, April 20, 2016 10:59:44 AM Kalle Valo wrote: > Christian Lamparter <chunkeey@googlemail.com> writes: > > > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > >> Christian Lamparter <chunkeey@googlemail.com> writes: > >> > >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> > > >> >> Why even mention anything about a "special firmware" as the firmware is > >> >> already available from linux-firmware.git? > >> > > >> > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too > >> > but that failed. > >> > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> > >> > >> Rick's comment makes sense to me, better just to provide the latest > >> version. No need to unnecessary confuse the users. And if someone really > >> wants to use an older version that she can retrieve it from the git > >> history. > > > > Part of the fun here is that firmware is GPLv2. The linux-firmware.git has > > to point to or add the firmware source to their tree. They have added every > > single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz > > like you normally do for release sources. > > > > If you want to read more about it: > > <http://www.spinics.net/lists/linux-wireless/msg101868.html> > > Yeah, that's more work. I get that. But I'm still not understanding > what's the actual problem which prevents us from updating carl9170 > firmware in linux-firmware. I'm not sure, but why not ask? I've added the cc'ed Linux Firmware Maintainers. So for those people reading the fw list: What would it take to update the carl9170-1.fw firmware file in your repository to the latest version? Who has to sent the firmware update. Does it have to be the person who sent the first request? (Xose)? The maintainer of the firmware (me)? someone from Qualcomm Atheros? Or someone else (specific)? (the firmware is licensed as GPLv2 - in theory anyone should be able to do that) How should the firmware source update be handled? Currently the latest .tar.xz of the firmware has ~130kb. The formated patches from 1.9.6 to latest are about ~100kb (182 individual patches). How does linux-firmware handle new binary firmware images and new sources? What if carl9170fw-2.bin is added. Do we need another source directory for this in the current tree then? Because carl9170fw-1.bin will still be needed for backwards compatibility so we basically need to duplicate parts of the source? Also, how's the situation with ath9k_htc? The 1.4.0 image contains some GPLv2 code as well? So, why is there no source in the tree, but just the link to it? Because, I would like to do basically the same for carl9170fw and just add a link to the carl9170fw repository and save everyone this source update "song and dance". Regards, Christian ^ permalink raw reply [flat|nested] 25+ messages in thread
* [RESEND] Re: updating carl9170-1.fw in linux-firmware.git @ 2016-04-20 21:11 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-20 21:11 UTC (permalink / raw) To: Kalle Valo Cc: Lauri Kasanen, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Linux Firmware Maintainers, Xose Vazquez Perez On Wednesday, April 20, 2016 10:59:44 AM Kalle Valo wrote: > Christian Lamparter <chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes: > > > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > >> Christian Lamparter <chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes: > >> > >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> > > >> >> Why even mention anything about a "special firmware" as the firmware is > >> >> already available from linux-firmware.git? > >> > > >> > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too > >> > but that failed. > >> > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> > >> > >> Rick's comment makes sense to me, better just to provide the latest > >> version. No need to unnecessary confuse the users. And if someone really > >> wants to use an older version that she can retrieve it from the git > >> history. > > > > Part of the fun here is that firmware is GPLv2. The linux-firmware.git has > > to point to or add the firmware source to their tree. They have added every > > single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz > > like you normally do for release sources. > > > > If you want to read more about it: > > <http://www.spinics.net/lists/linux-wireless/msg101868.html> > > Yeah, that's more work. I get that. But I'm still not understanding > what's the actual problem which prevents us from updating carl9170 > firmware in linux-firmware. I'm not sure, but why not ask? I've added the cc'ed Linux Firmware Maintainers. So for those people reading the fw list: What would it take to update the carl9170-1.fw firmware file in your repository to the latest version? Who has to sent the firmware update. Does it have to be the person who sent the first request? (Xose)? The maintainer of the firmware (me)? someone from Qualcomm Atheros? Or someone else (specific)? (the firmware is licensed as GPLv2 - in theory anyone should be able to do that) How should the firmware source update be handled? Currently the latest .tar.xz of the firmware has ~130kb. The formated patches from 1.9.6 to latest are about ~100kb (182 individual patches). How does linux-firmware handle new binary firmware images and new sources? What if carl9170fw-2.bin is added. Do we need another source directory for this in the current tree then? Because carl9170fw-1.bin will still be needed for backwards compatibility so we basically need to duplicate parts of the source? Also, how's the situation with ath9k_htc? The 1.4.0 image contains some GPLv2 code as well? So, why is there no source in the tree, but just the link to it? Because, I would like to do basically the same for carl9170fw and just add a link to the carl9170fw repository and save everyone this source update "song and dance". Regards, Christian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87wpnrcft4.fsf@kamboji.qca.qualcomm.com>]
[parent not found: <54163090.DmVClckc2L@debian64>]
* Re: [RESEND] Re: updating carl9170-1.fw in linux-firmware.git [not found] ` <54163090.DmVClckc2L@debian64> @ 2016-05-18 8:48 ` Lauri Kasanen 2016-05-19 13:08 ` Kalle Valo 0 siblings, 1 reply; 25+ messages in thread From: Lauri Kasanen @ 2016-05-18 8:48 UTC (permalink / raw) To: Christian Lamparter; +Cc: Kalle Valo, linux-wireless On Tue, 03 May 2016 15:09:39 +0200 Christian Lamparter <chunkeey@googlemail.com> wrote: > On Thursday, April 21, 2016 03:22:15 PM Kalle Valo wrote: > > Christian Lamparter <chunkeey@googlemail.com> writes: > > > > > Maintainers. So for those people reading the fw list: > > > > > > What would it take to update the carl9170-1.fw firmware file in your > > > repository to the latest version? > > > > Thanks for following up on this. It would be good to solve this finally. > Well, this was almost two weeks and no update yet. > Kalle, can you please apply the "[PATCH v2] carl9170: Clarify kconfig text" > patch from "Lauri Kasanen <cand@gmx.com>" [0]. > > [0] <https://marc.info/?l=linux-wireless&m=146081633405880> Seems we missed 4.7? - Lauri ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RESEND] Re: updating carl9170-1.fw in linux-firmware.git 2016-05-18 8:48 ` Lauri Kasanen @ 2016-05-19 13:08 ` Kalle Valo 2016-05-19 13:55 ` Christian Lamparter 0 siblings, 1 reply; 25+ messages in thread From: Kalle Valo @ 2016-05-19 13:08 UTC (permalink / raw) To: Lauri Kasanen; +Cc: Christian Lamparter, linux-wireless Lauri Kasanen <cand@gmx.com> writes: > On Tue, 03 May 2016 15:09:39 +0200 > Christian Lamparter <chunkeey@googlemail.com> wrote: > >> On Thursday, April 21, 2016 03:22:15 PM Kalle Valo wrote: >> > Christian Lamparter <chunkeey@googlemail.com> writes: >> > >> > > Maintainers. So for those people reading the fw list: >> > > >> > > What would it take to update the carl9170-1.fw firmware file in your >> > > repository to the latest version? >> > >> > Thanks for following up on this. It would be good to solve this finally. >> Well, this was almost two weeks and no update yet. >> Kalle, can you please apply the "[PATCH v2] carl9170: Clarify kconfig text" >> patch from "Lauri Kasanen <cand@gmx.com>" [0]. >> >> [0] <https://marc.info/?l=linux-wireless&m=146081633405880> > > Seems we missed 4.7? Yeah, I didn't consider this important enough and delayed it due to lack of time. I now put the patch back to my queue for 4.8, but please check that it's the correct version: https://patchwork.kernel.org/patch/8861621/ But we really should figure out how to get the latest version to linux-firmware, this is not good in the long run. -- Kalle Valo ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RESEND] Re: updating carl9170-1.fw in linux-firmware.git 2016-05-19 13:08 ` Kalle Valo @ 2016-05-19 13:55 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-05-19 13:55 UTC (permalink / raw) To: Kalle Valo; +Cc: Lauri Kasanen, linux-wireless On Thursday, May 19, 2016 04:08:10 PM Kalle Valo wrote: > Lauri Kasanen <cand@gmx.com> writes: > > > On Tue, 03 May 2016 15:09:39 +0200 > > Christian Lamparter <chunkeey@googlemail.com> wrote: > > > >> On Thursday, April 21, 2016 03:22:15 PM Kalle Valo wrote: > >> > Christian Lamparter <chunkeey@googlemail.com> writes: > >> > > >> > > Maintainers. So for those people reading the fw list: > >> > > > >> > > What would it take to update the carl9170-1.fw firmware file in your > >> > > repository to the latest version? > >> > > >> > Thanks for following up on this. It would be good to solve this finally. > >> Well, this was almost two weeks and no update yet. > >> Kalle, can you please apply the "[PATCH v2] carl9170: Clarify kconfig text" > >> patch from "Lauri Kasanen <cand@gmx.com>" [0]. > >> > >> [0] <https://marc.info/?l=linux-wireless&m=146081633405880> > > > > Seems we missed 4.7? > > Yeah, I didn't consider this important enough and delayed it due to lack > of time. I now put the patch back to my queue for 4.8, but please check > that it's the correct version: > > https://patchwork.kernel.org/patch/8861621/ Yes, this links to v2, which is the correct version. > But we really should figure out how to get the latest version to > linux-firmware, this is not good in the long run. Well, none of my firmware patches were added/accepted and nobody responded on how to add it to linux-firmware. I'm open for ideas. Regards, Christan ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: updating carl9170-1.fw in linux-firmware.git 2016-04-20 21:11 ` Christian Lamparter (?) (?) @ 2016-05-20 18:18 ` Xose Vazquez Perez -1 siblings, 0 replies; 25+ messages in thread From: Xose Vazquez Perez @ 2016-05-20 18:18 UTC (permalink / raw) To: Ben Hutchings, Christian Lamparter, Kalle Valo Cc: Linux Firmware Maintainers, linux-wireless On 04/20/2016 11:11 PM, Christian Lamparter wrote: > On Wednesday, April 20, 2016 10:59:44 AM Kalle Valo wrote: >> Christian Lamparter <chunkeey@googlemail.com> writes: >> >>> On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >>>> Christian Lamparter <chunkeey@googlemail.com> writes: >>>> >>>>> On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >>>>> >>>>>> Why even mention anything about a "special firmware" as the firmware is >>>>>> already available from linux-firmware.git? >>>>> >>>>> Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too >>>>> but that failed. >>>>> <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639> >>>> >>>> Rick's comment makes sense to me, better just to provide the latest >>>> version. No need to unnecessary confuse the users. And if someone really >>>> wants to use an older version that she can retrieve it from the git >>>> history. >>> >>> Part of the fun here is that firmware is GPLv2. The linux-firmware.git has >>> to point to or add the firmware source to their tree. They have added every >>> single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz >>> like you normally do for release sources. >>> >>> If you want to read more about it: >>> <http://www.spinics.net/lists/linux-wireless/msg101868.html> >> >> Yeah, that's more work. I get that. But I'm still not understanding >> what's the actual problem which prevents us from updating carl9170 >> firmware in linux-firmware. > I'm not sure, but why not ask? I've added the cc'ed Linux Firmware > Maintainers. So for those people reading the fw list: > > What would it take to update the carl9170-1.fw firmware file in your > repository to the latest version? > > Who has to sent the firmware update. Does it have to be the person who > sent the first request? (Xose)? The maintainer of the firmware (me)? > someone from Qualcomm Atheros? Or someone else (specific)? (the > firmware is licensed as GPLv2 - in theory anyone should be able to > do that) > > How should the firmware source update be handled? Currently the latest > .tar.xz of the firmware has ~130kb. The formated patches from 1.9.6 to > latest are about ~100kb (182 individual patches). > > How does linux-firmware handle new binary firmware images and new > sources? What if carl9170fw-2.bin is added. Do we need another > source directory for this in the current tree then? Because > carl9170fw-1.bin will still be needed for backwards compatibility > so we basically need to duplicate parts of the source? > > Also, how's the situation with ath9k_htc? The 1.4.0 image contains > some GPLv2 code as well? So, why is there no source in the tree, but > just the link to it? Because, I would like to do basically the same > for carl9170fw and just add a link to the carl9170fw repository and > save everyone this source update "song and dance". Hi Ben, could you assist Christian ? -thanks- ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RESEND] Re: updating carl9170-1.fw in linux-firmware.git 2016-04-20 21:11 ` Christian Lamparter ` (2 preceding siblings ...) (?) @ 2016-05-25 14:51 ` Ben Hutchings -1 siblings, 0 replies; 25+ messages in thread From: Ben Hutchings @ 2016-05-25 14:51 UTC (permalink / raw) To: Christian Lamparter, Kalle Valo Cc: Lauri Kasanen, linux-wireless, netdev, linux-kernel, Linux Firmware Maintainers, Xose Vazquez Perez [-- Attachment #1: Type: text/plain, Size: 4090 bytes --] On Wed, 2016-04-20 at 23:11 +0200, Christian Lamparter wrote: > On Wednesday, April 20, 2016 10:59:44 AM Kalle Valo wrote: > > Christian Lamparter <chunkeey@googlemail.com> writes: > > > > > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > > > > Christian Lamparter <chunkeey@googlemail.com> writes: > > > > > > > > > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > > > > > > > > > > > Why even mention anything about a "special firmware" as the firmware is > > > > > > already available from linux-firmware.git? > > > > > > > > > > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too > > > > > but that failed. > > > > > > > > > > > > > Rick's comment makes sense to me, better just to provide the latest > > > > version. No need to unnecessary confuse the users. And if someone really > > > > wants to use an older version that she can retrieve it from the git > > > > history. > > > > > > Part of the fun here is that firmware is GPLv2. The linux-firmware.git has > > > to point to or add the firmware source to their tree. They have added every > > > single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz > > > like you normally do for release sources. > > > > > > If you want to read more about it: > > > <http://www.spinics.net/lists/linux-wireless/msg101868.html> > > > > Yeah, that's more work. I get that. But I'm still not understanding > > what's the actual problem which prevents us from updating carl9170 > > firmware in linux-firmware. > I'm not sure, but why not ask? I've added the cc'ed Linux Firmware > Maintainers. So for those people reading the fw list: > > What would it take to update the carl9170-1.fw firmware file in your > repository to the latest version? > > Who has to sent the firmware update. Does it have to be the person who > sent the first request? (Xose)? The maintainer of the firmware (me)? > someone from Qualcomm Atheros? Or someone else (specific)? (the > firmware is licensed as GPLv2 - in theory anyone should be able to > do that) Given the licence, I don't particularly care. > How should the firmware source update be handled? Currently the latest > .tar.xz of the firmware has ~130kb. The formated patches from 1.9.6 to > latest are about ~100kb (182 individual patches). Either patches that 'git am' can handle, or a git branch. > How does linux-firmware handle new binary firmware images and new > sources? What if carl9170fw-2.bin is added. Do we need another > source directory for this in the current tree then? Because > carl9170fw-1.bin will still be needed for backwards compatibility > so we basically need to duplicate parts of the source? We still need to include the old binary for compatibility, and the old source for GPL compliance. (If there was a source version that could build firmware for both ABI versions, then we could update both binaries and have one set of source files. But it doesn't sound like that's the case.) > Also, how's the situation with ath9k_htc? The 1.4.0 image contains > some GPLv2 code as well? I didn't realise that. > So, why is there no source in the tree, but just the link to it? An oversight which we need to fix. > Because, I would like to do basically the same > for carl9170fw and just add a link to the carl9170fw repository and > save everyone this source update "song and dance". Merely linking to upstream source doesn't satisfy GPLv2 source requirements, at least not in case of commercial distribution. Linux distributors should be able to use a snapshot of linux-firmware as the upstream source for a package, without worrying about whether there are extra sources they need to include. (I'm aware that there are several files that don't actually have clear licences for. But those are at least called out in WHENCE, and were previously distributed as part of the kernel sources for years.) Ben. -- Ben Hutchings Time is nature's way of making sure that everything doesn't happen at once. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [v2] carl9170: Clarify kconfig text 2016-04-16 14:18 ` Lauri Kasanen ` (2 preceding siblings ...) (?) @ 2016-06-04 14:58 ` Kalle Valo -1 siblings, 0 replies; 25+ messages in thread From: Kalle Valo @ 2016-06-04 14:58 UTC (permalink / raw) To: Lauri Kasanen; +Cc: Christian Lamparter, linux-wireless, netdev, linux-kernel Lauri Kasanen <cand@gmx.com> wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri Kasanen <cand@gmx.com> > Acked-by: Christian Lamparter <chunkeey@googlemail.com> Thanks, 1 patch applied to wireless-drivers-next.git: 83e41e77819b carl9170: Clarify kconfig text -- Sent by pwcli https://patchwork.kernel.org/patch/8861621/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text
@ 2016-04-18 16:47 Xose Vazquez Perez
2016-04-18 17:10 ` Christian Lamparter
0 siblings, 1 reply; 25+ messages in thread
From: Xose Vazquez Perez @ 2016-04-18 16:47 UTC (permalink / raw)
To: Christian Lamparter, Lauri Kasanen, Kalle Valo, LKML,
linux-wireless, netdev, Linux Firmware Maintainers
Christian Lamparter wrote:
> Sure, but this could be a different patch then. I think Intel devices
> (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download
> firmware from this device from our homepage here" too. So if we want,
> we can remove them altogether?
linux-firmware.git does not contain firmware for all drivers. _At least_
zd1211rw [1], atmel [2] and ipw2x00 [3] are out of the tree.
[1] http://sf.net/projects/zd1211/files/
[2] http://web.archive.org/web/20121016132320/http://at76c503a.berlios.de/fw_dl.html
[3] http://ipw2100.sf.net/firmware.php http://ipw2200.sf.net/firmware.php
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] carl9170: Clarify kconfig text 2016-04-18 16:47 [PATCH v2] " Xose Vazquez Perez @ 2016-04-18 17:10 ` Christian Lamparter 0 siblings, 0 replies; 25+ messages in thread From: Christian Lamparter @ 2016-04-18 17:10 UTC (permalink / raw) To: Xose Vazquez Perez Cc: Lauri Kasanen, Kalle Valo, LKML, linux-wireless, netdev, Linux Firmware Maintainers, sgruszka On Monday, April 18, 2016 06:47:44 PM Xose Vazquez Perez wrote: > Christian Lamparter wrote: > > > Sure, but this could be a different patch then. I think Intel devices > > (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download > > firmware from this device from our homepage here" too. So if we want, > > we can remove them altogether? > > linux-firmware.git does not contain firmware for all drivers. _At least_ > zd1211rw [1], atmel [2] and ipw2x00 [3] are out of the tree. Yeah, don't forget p54. It needs out-of-tree firmwares as well. But what about iwlegacy? Isn't that another candidate that would fit both requirements (no recent firmware update, firmware in linux-firmware.git) ? > [1] http://sf.net/projects/zd1211/files/ > [2] http://web.archive.org/web/20121016132320/http://at76c503a.berlios.de/fw_dl.html > [3] http://ipw2100.sf.net/firmware.php http://ipw2200.sf.net/firmware.php ^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2016-06-04 14:58 UTC | newest] Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-04-16 8:33 [PATCH] carl9170: Clarify kconfig text Lauri Kasanen [not found] ` <1466768.7dLuLFSDol@debian64> 2016-04-16 14:18 ` [PATCH v2] " Lauri Kasanen 2016-04-16 14:18 ` Lauri Kasanen 2016-04-16 15:32 ` Christian Lamparter 2016-04-18 15:45 ` Kalle Valo 2016-04-18 15:45 ` Kalle Valo 2016-04-18 16:07 ` [PATCH v3] " Lauri Kasanen 2016-04-18 16:07 ` Lauri Kasanen 2016-04-18 16:24 ` Christian Lamparter 2016-04-18 16:20 ` [PATCH v2] " Christian Lamparter 2016-04-18 16:20 ` Christian Lamparter 2016-04-18 16:42 ` Kalle Valo 2016-04-18 17:07 ` Christian Lamparter 2016-04-18 17:07 ` Christian Lamparter 2016-04-20 7:59 ` Kalle Valo 2016-04-20 21:11 ` [RESEND] Re: updating carl9170-1.fw in linux-firmware.git Christian Lamparter 2016-04-20 21:11 ` Christian Lamparter [not found] ` <87wpnrcft4.fsf@kamboji.qca.qualcomm.com> [not found] ` <54163090.DmVClckc2L@debian64> 2016-05-18 8:48 ` Lauri Kasanen 2016-05-19 13:08 ` Kalle Valo 2016-05-19 13:55 ` Christian Lamparter 2016-05-20 18:18 ` Xose Vazquez Perez 2016-05-25 14:51 ` [RESEND] " Ben Hutchings 2016-06-04 14:58 ` [v2] carl9170: Clarify kconfig text Kalle Valo 2016-04-18 16:47 [PATCH v2] " Xose Vazquez Perez 2016-04-18 17:10 ` Christian Lamparter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.