All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Fix some build issues
@ 2014-09-12 15:49 Jérôme Pouiller
  2014-09-12 15:50 ` [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86 Jérôme Pouiller
                   ` (11 more replies)
  0 siblings, 12 replies; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:49 UTC (permalink / raw)
  To: buildroot

This serie fix a couple of problems I have detected using a script I have 
presented in a previous thread [1].


[1] http://lists.busybox.net/pipermail/buildroot/2013-October/081154.html

-- 
J?r?me Pouiller, Sysmic

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:15   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 02/12] xapp_xkbevd: depends on MMU Jérôme Pouiller
                   ` (10 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

... since BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA is only available on x86.

Fix warnings like:
  warning: (BR2_PACKAGE_XDRIVER_XF86_VIDEO_VMWARE) selects
  BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA which has unmet direct dependencies
  (BR2_PACKAGE_MESA3D && (BR2_i386 || BR2_x86_64))

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/x11r7/xdriver_xf86-video-vmware/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/x11r7/xdriver_xf86-video-vmware/Config.in b/package/x11r7/xdriver_xf86-video-vmware/Config.in
index 2e6b24d..a3382d7 100644
--- a/package/x11r7/xdriver_xf86-video-vmware/Config.in
+++ b/package/x11r7/xdriver_xf86-video-vmware/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_VMWARE
 	bool "xf86-video-vmware"
 	depends on BR2_PACKAGE_MESA3D
+	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_RANDRPROTO
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 02/12] xapp_xkbevd: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
  2014-09-12 15:50 ` [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86 Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:21   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 03/12] xapp_xinit: " Jérôme Pouiller
                   ` (9 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/a9ec03bd:

xkbevd.o: In function `_main':
xkbevd.c:(.text+0x3ca): undefined reference to `_fork'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/x11r7/xapp_xkbevd/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/x11r7/xapp_xkbevd/Config.in b/package/x11r7/xapp_xkbevd/Config.in
index cf31565..0cbb9e4 100644
--- a/package/x11r7/xapp_xkbevd/Config.in
+++ b/package/x11r7/xapp_xkbevd/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XKBEVD
 	bool "xkbevd"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBXKBFILE
 	help
 	  XKB event daemon
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 03/12] xapp_xinit: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
  2014-09-12 15:50 ` [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86 Jérôme Pouiller
  2014-09-12 15:50 ` [Buildroot] [PATCH 02/12] xapp_xkbevd: depends on MMU Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:19   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 04/12] xapp_xsm: " Jérôme Pouiller
                   ` (8 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/8b5af679:

xinit.o: In function `_main':
xinit.c:(.text+0x65e): undefined reference to `_fork'
xinit.c:(.text+0x7d4): undefined reference to `_fork'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/x11r7/xapp_xinit/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
index aede5d9..6537d89 100644
--- a/package/x11r7/xapp_xinit/Config.in
+++ b/package/x11r7/xapp_xinit/Config.in
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_XAPP_XINIT
 	bool "xinit"
+	depends on BR2_USE_MMU # fork()
 	# Runtime dependency: can't start an X server unless there is one
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
-	# Runtime dependency; mcookie is also in util-linux
+	#Runtime dependency; mcookie is also in util-linux
 	select BR2_PACKAGE_MCOOKIE if !BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_XAPP_XAUTH
 	select BR2_PACKAGE_XLIB_LIBX11
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 04/12] xapp_xsm: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (2 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 03/12] xapp_xinit: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:15   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 05/12] xapp_xmh: " Jérôme Pouiller
                   ` (7 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes: http://sysmic.org/~jezz/results/455f2788:

remote.o: In function `_remote_start':
remote.c:(.text+0x74): undefined reference to `_fork'
restart.o: In function `_Clone':
restart.c:(.text+0x5a8): undefined reference to `_fork'
restart.o: In function `_Restart':
restart.c:(.text+0xa44): undefined reference to `_fork'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/x11r7/xapp_xsm/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/x11r7/xapp_xsm/Config.in b/package/x11r7/xapp_xsm/Config.in
index d06dc6c..88f20cf 100644
--- a/package/x11r7/xapp_xsm/Config.in
+++ b/package/x11r7/xapp_xsm/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XSM
 	bool "xsm"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBXAW
 	help
 	  X Session Manager
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 05/12] xapp_xmh: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (3 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 04/12] xapp_xsm: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:16   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 06/12] xapp_xdm: " Jérôme Pouiller
                   ` (6 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/1a0bc183:

command.o: In function `__DoCommandToFileOrPipe':
command.c:(.text+0x35e): undefined reference to `_fork'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/x11r7/xapp_xmh/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/x11r7/xapp_xmh/Config.in b/package/x11r7/xapp_xmh/Config.in
index 1ef65c7..4e86d0f 100644
--- a/package/x11r7/xapp_xmh/Config.in
+++ b/package/x11r7/xapp_xmh/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XMH
 	bool "xmh"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBXAW
 	select BR2_PACKAGE_XDATA_XBITMAPS
 	help
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 06/12] xapp_xdm: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (4 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 05/12] xapp_xmh: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:20   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 07/12] xterm: " Jérôme Pouiller
                   ` (5 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/e891eb7e:

dm.o: In function `_StartDisplay':
dm.c:(.text+0xd6e): undefined reference to `_fork'
server.o: In function `_StartServerOnce':
server.c:(.text+0x266): undefined reference to `_fork'
session.o: In function `_runAndWait':
session.c:(.text+0x67a): undefined reference to `_fork'
session.o: In function `_ManageSession':
session.c:(.text+0xa2a): undefined reference to `_fork'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/x11r7/xapp_xdm/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/x11r7/xapp_xdm/Config.in b/package/x11r7/xapp_xdm/Config.in
index 477cd77..6982970 100644
--- a/package/x11r7/xapp_xdm/Config.in
+++ b/package/x11r7/xapp_xdm/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XDM
 	bool "xdm"
+	depends on BR2_USE_MMU # fork()
 	# Runtime dependency: can't start an X server unless there is one
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
 	select BR2_PACKAGE_XAPP_SESSREG
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 07/12] xterm: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (5 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 06/12] xapp_xdm: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:16   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 08/12] xfsprogs: " Jérôme Pouiller
                   ` (4 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/53a729c3:

button.o: In function `_executeCommand':
./button.c:(.text+0x21be): undefined reference to `_fork'
main.o: In function `_get_pty':
./main.c:(.text+0xab0): undefined reference to `_getpt'
main.o: In function `_spawnXTerm':
./main.c:(.text+0x1030): undefined reference to `_fork'
misc.o: In function `_creat_as':
./misc.c:(.text+0x3a56): undefined reference to `_fork'
print.o: In function `_charToPrinter':
./print.c:(.text+0x1ee): undefined reference to `_fork'

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/xterm/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/xterm/Config.in b/package/xterm/Config.in
index 33adf25..e17d2c6 100644
--- a/package/xterm/Config.in
+++ b/package/xterm/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_XTERM
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_XLIB_LIBXAW
 	depends on BR2_PACKAGE_XORG7
+	depends on BR2_USE_MMU # fork()
 	help
 	  xterm terminal emulator
 
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 08/12] xfsprogs: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (6 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 07/12] xterm: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:20   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 09/12] ltp-testsuite: " Jérôme Pouiller
                   ` (3 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/17f32103:

xfs_fsr.o: In function `fsrallfs':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/fsr/xfs_fsr.c:617: undefined reference to `_fork'
collect2: ld returned 1 exit status

madvise.o: In function `madvise_f':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/madvise.c:111: undefined reference to `_madvise'
mincore.o: In function `mincore_f':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/mincore.c:77: undefined reference to `_mincore'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/xfsprogs/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/xfsprogs/Config.in b/package/xfsprogs/Config.in
index 3a31dd2..bb7634c 100644
--- a/package/xfsprogs/Config.in
+++ b/package/xfsprogs/Config.in
@@ -2,11 +2,12 @@
 comment "Note that xfsprogs needs a toolchain with UCLIBC_SV4_DEPRECATED and UCLIBC_HAS_OBSOLETE_BSD_SIGNAL enabled"
 	depends on BR2_PACKAGE_XFSPROGS
 
-comment "xfsprogs needs a toolchain w/ largefile, wchar"
-	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
+comment "xfsprogs needs a toolchain w/ largefile, wchar, MMU"
+	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_USE_MMU)
 
 config BR2_PACKAGE_XFSPROGS
 	bool "xfsprogs"
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_WCHAR # util-linux
 	select BR2_PACKAGE_UTIL_LINUX
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 09/12] ltp-testsuite: depends on MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (7 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 08/12] xfsprogs: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:20   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 10/12] sdl: remove dga support in no MMU Jérôme Pouiller
                   ` (2 subsequent siblings)
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

Fixes http://sysmic.org/~jezz/results/dfc51d2b:

.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_child] Error 1
make[3]: *** Waiting for unfinished jobs....
/tmp/ccF9CQQa.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_parent] Error 1
/tmp/ccwCGpYd.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent_exits.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_parent_exits] Error 1
/tmp/cc8TiB6d.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_process_state.c:43: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_process_state] Error 1
/tmp/ccrf7Gjb.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child_exits.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/ltp-testsuite/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
index 0e71677..76fa1a1 100644
--- a/package/ltp-testsuite/Config.in
+++ b/package/ltp-testsuite/Config.in
@@ -4,6 +4,7 @@ comment "ltp-testsuite needs specific uClibc options, see help"
 
 config BR2_PACKAGE_LTP_TESTSUITE
 	bool "ltp-testsuite"
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_LARGEFILE
@@ -22,7 +23,7 @@ config BR2_PACKAGE_LTP_TESTSUITE
 
 	  http://ltp.sourceforge.net/
 
-comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads"
+comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads, MMU"
 	depends on !BR2_nios2
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INET_IPV6 || \
-		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC || !BR2_USE_MMU
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 10/12] sdl: remove dga support in no MMU
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (8 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 09/12] ltp-testsuite: " Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-12 21:31   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 11/12] directfb: allow SVG support Jérôme Pouiller
  2014-09-12 15:50 ` [Buildroot] [PATCH 12/12] libffi and python: need threads support Jérôme Pouiller
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

DGA support use fork. This prevent executables to link with libSDL.so.

Fixes:
  http://sysmic.org/~jezz/results/5e50c243 (package sdl_mixer)
  http://sysmic.org/~jezz/results/734afef8 (package sdl_net)
  http://sysmic.org/~jezz/results/e2310eb9 (package sdl_image)
  http://sysmic.org/~jezz/results/e2cdcc9a (package sdl_sound)

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/sdl/sdl.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
index 8d0e5bd..77fbdd9 100644
--- a/package/sdl/sdl.mk
+++ b/package/sdl/sdl.mk
@@ -53,6 +53,10 @@ else
 SDL_CONF_OPT += --enable-video-x11=no
 endif
 
+ifneq ($(BR2_USE_MMU),y)
+SDL_CONF_OPT += --enable-dga=no
+endif
+
 ifeq ($(BR2_PACKAGE_TSLIB),y)
 SDL_DEPENDENCIES += tslib
 endif
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 11/12] directfb: allow SVG support
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (9 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 10/12] sdl: remove dga support in no MMU Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-13  7:23   ` Peter Korsgaard
  2014-09-12 15:50 ` [Buildroot] [PATCH 12/12] libffi and python: need threads support Jérôme Pouiller
  11 siblings, 1 reply; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

DirectFB SVG support rely on Cairo and Cairo depends on DirectFB.

Since Cairo DirectFB backend is marked as experimental, this patch choose to
disable this backend when DirectFB SVG support is enable.

In add, this patch may solve some tricky situations between DirectFB and Cairo
(see http://sysmic.org/~jezz/results/c2f11fc0) and improve build reproducibility.

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/cairo/cairo.mk       | 5 ++++-
 package/directfb/Config.in   | 5 +++++
 package/directfb/directfb.mk | 7 +++++++
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
index a4c71b6..bcc0c26 100644
--- a/package/cairo/cairo.mk
+++ b/package/cairo/cairo.mk
@@ -48,7 +48,10 @@ CAIRO_CONF_OPT = \
 
 CAIRO_DEPENDENCIES = host-pkgconf fontconfig pixman
 
-ifeq ($(BR2_PACKAGE_DIRECTFB),y)
+# DirectFB svg support rely on Cairo and Cairo DirectFB support depends on
+# DirectFB. Break circular dependency by disabling DirectFB support in Cairo
+# (which is experimental)
+ifeq ($(BR2_PACKAGE_DIRECTFB)x$(BR2_PACKAGE_DIRECTFB_SVG),yx)
 	CAIRO_CONF_OPT += --enable-directfb
 	CAIRO_DEPENDENCIES += directfb
 else
diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index e3c93a1..dc01228 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -125,6 +125,11 @@ config BR2_PACKAGE_DIRECTFB_PNG
 	default y
 	select BR2_PACKAGE_LIBPNG
 
+config BR2_PACKAGE_DIRECTFB_SVG
+	bool "enable SVG support"
+	default y
+	select BR2_PACKAGE_CAIRO
+
 config BR2_PACKAGE_DIRECTFB_DITHER_RGB16
 	bool "enable advanced dithering of RGB16 surfaces"
 	help
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 3ae7f3e..dd2ca99 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -116,6 +116,13 @@ else
 DIRECTFB_CONF_OPT += --disable-jpeg
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_SVG),y)
+DIRECTFB_CONF_OPT += --enable-svg
+DIRECTFB_DEPENDENCIES += cairo
+else
+DIRECTFB_CONF_OPT += --disable-svg
+endif
+
 ifeq ($(BR2_PACKAGE_DIRECTFB_IMLIB2),y)
 DIRECTFB_CONF_OPT += --enable-imlib2
 DIRECTFB_DEPENDENCIES += imlib2
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 12/12] libffi and python: need threads support
  2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
                   ` (10 preceding siblings ...)
  2014-09-12 15:50 ` [Buildroot] [PATCH 11/12] directfb: allow SVG support Jérôme Pouiller
@ 2014-09-12 15:50 ` Jérôme Pouiller
  2014-09-13  7:39   ` Peter Korsgaard
  2014-09-13  7:57   ` Thomas Petazzoni
  11 siblings, 2 replies; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-12 15:50 UTC (permalink / raw)
  To: buildroot

libffi depends on pthreads.

Python depends on libffi (it can provide a builtin libffi, but also depends on
pthreads). Thus this patch also disable Python support if toolchain is compiled
w/o treads support.

Fixes http://sysmic.org/~jezz/results/204099dd:

../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/libffi/Config.in | 4 ++++
 package/python/Config.in | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/libffi/Config.in b/package/libffi/Config.in
index 7211f8f..6edf570 100644
--- a/package/libffi/Config.in
+++ b/package/libffi/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This
@@ -7,3 +8,6 @@ config BR2_PACKAGE_LIBFFI
 	  interface description at run-time.
 
 	  http://sourceware.org/libffi/
+
+comment "libffi needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/python/Config.in b/package/python/Config.in
index a0c78c6..85438a4 100644
--- a/package/python/Config.in
+++ b/package/python/Config.in
@@ -3,15 +3,17 @@ config BR2_PACKAGE_PYTHON
 	depends on BR2_USE_WCHAR
 	# uses fork()
 	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libffi
 	select BR2_PACKAGE_LIBFFI
 	help
 	  The python language interpreter.
 
 	  http://www.python.org/
 
-comment "python needs a toolchain w/ wchar"
+comment "python needs a toolchain w/ wchar and threads"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 if BR2_PACKAGE_PYTHON
 
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86
  2014-09-12 15:50 ` [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86 Jérôme Pouiller
@ 2014-09-12 21:15   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:15 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > ... since BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA is only available on x86.
 > Fix warnings like:
 >   warning: (BR2_PACKAGE_XDRIVER_XF86_VIDEO_VMWARE) selects
 >   BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA which has unmet direct dependencies
 >   (BR2_PACKAGE_MESA3D && (BR2_i386 || BR2_x86_64))

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 04/12] xapp_xsm: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 04/12] xapp_xsm: " Jérôme Pouiller
@ 2014-09-12 21:15   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:15 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes: http://sysmic.org/~jezz/results/455f2788:
 > remote.o: In function `_remote_start':
 > remote.c:(.text+0x74): undefined reference to `_fork'
 > restart.o: In function `_Clone':
 > restart.c:(.text+0x5a8): undefined reference to `_fork'
 > restart.o: In function `_Restart':
 > restart.c:(.text+0xa44): undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 07/12] xterm: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 07/12] xterm: " Jérôme Pouiller
@ 2014-09-12 21:16   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:16 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/53a729c3:
 > button.o: In function `_executeCommand':
 > ./button.c:(.text+0x21be): undefined reference to `_fork'
 > main.o: In function `_get_pty':
 > ./main.c:(.text+0xab0): undefined reference to `_getpt'
 > main.o: In function `_spawnXTerm':
 > ./main.c:(.text+0x1030): undefined reference to `_fork'
 > misc.o: In function `_creat_as':
 > ./misc.c:(.text+0x3a56): undefined reference to `_fork'
 > print.o: In function `_charToPrinter':
 > ./print.c:(.text+0x1ee): undefined reference to `_fork'

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 05/12] xapp_xmh: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 05/12] xapp_xmh: " Jérôme Pouiller
@ 2014-09-12 21:16   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:16 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/1a0bc183:
 > command.o: In function `__DoCommandToFileOrPipe':
 > command.c:(.text+0x35e): undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 03/12] xapp_xinit: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 03/12] xapp_xinit: " Jérôme Pouiller
@ 2014-09-12 21:19   ` Peter Korsgaard
  2014-09-13  5:59     ` Jérôme Pouiller
  0 siblings, 1 reply; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:19 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/8b5af679:
 > xinit.o: In function `_main':
 > xinit.c:(.text+0x65e): undefined reference to `_fork'
 > xinit.c:(.text+0x7d4): undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
 > ---
 >  package/x11r7/xapp_xinit/Config.in | 3 ++-
 >  1 file changed, 2 insertions(+), 1 deletion(-)

 > diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
 > index aede5d9..6537d89 100644
 > --- a/package/x11r7/xapp_xinit/Config.in
 > +++ b/package/x11r7/xapp_xinit/Config.in
 > @@ -1,8 +1,9 @@
 >  config BR2_PACKAGE_XAPP_XINIT
 >  	bool "xinit"
 > +	depends on BR2_USE_MMU # fork()
 >  	# Runtime dependency: can't start an X server unless there is one
 >  	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
 > -	# Runtime dependency; mcookie is also in util-linux
 > +	#Runtime dependency; mcookie is also in util-linux

I'm not sure why you want to change this. Committed without this line,
thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 08/12] xfsprogs: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 08/12] xfsprogs: " Jérôme Pouiller
@ 2014-09-12 21:20   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:20 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/17f32103:
 > xfs_fsr.o: In function `fsrallfs':
 > /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/fsr/xfs_fsr.c:617: undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > madvise.o: In function `madvise_f':
 > /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/madvise.c:111: undefined reference to `_madvise'
 > mincore.o: In function `mincore_f':
 > /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/mincore.c:77: undefined reference to `_mincore'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
 > ---
 >  package/xfsprogs/Config.in | 5 +++--
 >  1 file changed, 3 insertions(+), 2 deletions(-)

 > diff --git a/package/xfsprogs/Config.in b/package/xfsprogs/Config.in
 > index 3a31dd2..bb7634c 100644
 > --- a/package/xfsprogs/Config.in
 > +++ b/package/xfsprogs/Config.in
 > @@ -2,11 +2,12 @@
 >  comment "Note that xfsprogs needs a toolchain with UCLIBC_SV4_DEPRECATED and UCLIBC_HAS_OBSOLETE_BSD_SIGNAL enabled"
 >  	depends on BR2_PACKAGE_XFSPROGS
 
 > -comment "xfsprogs needs a toolchain w/ largefile, wchar"
 > -	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
 > +comment "xfsprogs needs a toolchain w/ largefile, wchar, MMU"
 > +	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_USE_MMU)

The user typically cannot do anything about the MMU dependency, so we
don't add it to the comment line (but do make the comment depend on MMU
so it's only shown for people who can use it).

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 06/12] xapp_xdm: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 06/12] xapp_xdm: " Jérôme Pouiller
@ 2014-09-12 21:20   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:20 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/e891eb7e:
 > dm.o: In function `_StartDisplay':
 > dm.c:(.text+0xd6e): undefined reference to `_fork'
 > server.o: In function `_StartServerOnce':
 > server.c:(.text+0x266): undefined reference to `_fork'
 > session.o: In function `_runAndWait':
 > session.c:(.text+0x67a): undefined reference to `_fork'
 > session.o: In function `_ManageSession':
 > session.c:(.text+0xa2a): undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 09/12] ltp-testsuite: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 09/12] ltp-testsuite: " Jérôme Pouiller
@ 2014-09-12 21:20   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:20 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/dfc51d2b:
 > .../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child.c:40: undefined reference to `_fork'
 > collect2: ld returned 1 exit status
 > make[3]: *** [tst_checkpoint_child] Error 1
 > make[3]: *** Waiting for unfinished jobs....
 > /tmp/ccF9CQQa.o: In function `main':
 > .../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent.c:40: undefined reference to `_fork'
 > collect2: ld returned 1 exit status
 > make[3]: *** [tst_checkpoint_parent] Error 1
 > /tmp/ccwCGpYd.o: In function `main':
 > .../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent_exits.c:40: undefined reference to `_fork'
 > collect2: ld returned 1 exit status
 > make[3]: *** [tst_checkpoint_parent_exits] Error 1
 > /tmp/cc8TiB6d.o: In function `main':
 > .../ltp-testsuite-20140115/lib/tests/tst_process_state.c:43: undefined reference to `_fork'
 > collect2: ld returned 1 exit status
 > make[3]: *** [tst_process_state] Error 1
 > /tmp/ccrf7Gjb.o: In function `main':
 > .../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child_exits.c:40: undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
 > ---
 >  package/ltp-testsuite/Config.in | 5 +++--
 >  1 file changed, 3 insertions(+), 2 deletions(-)

 > diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
 > index 0e71677..76fa1a1 100644
 > --- a/package/ltp-testsuite/Config.in
 > +++ b/package/ltp-testsuite/Config.in
 > @@ -4,6 +4,7 @@ comment "ltp-testsuite needs specific uClibc options, see help"
 
 >  config BR2_PACKAGE_LTP_TESTSUITE
 >  	bool "ltp-testsuite"
 > +	depends on BR2_USE_MMU # fork()
 >  	depends on BR2_TOOLCHAIN_HAS_THREADS
 >  	depends on BR2_INET_IPV6
 >  	depends on BR2_LARGEFILE
 > @@ -22,7 +23,7 @@ config BR2_PACKAGE_LTP_TESTSUITE
 
 >  	  http://ltp.sourceforge.net/
 
 > -comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads"
 > +comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads, MMU"
 >  	depends on !BR2_nios2
 >  	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INET_IPV6 || \
 > -		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 > +		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC || !BR2_USE_MMU

Same comment as for xfsprogs. Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 02/12] xapp_xkbevd: depends on MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 02/12] xapp_xkbevd: depends on MMU Jérôme Pouiller
@ 2014-09-12 21:21   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:21 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Fixes http://sysmic.org/~jezz/results/a9ec03bd:
 > xkbevd.o: In function `_main':
 > xkbevd.c:(.text+0x3ca): undefined reference to `_fork'
 > collect2: ld returned 1 exit status

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 10/12] sdl: remove dga support in no MMU
  2014-09-12 15:50 ` [Buildroot] [PATCH 10/12] sdl: remove dga support in no MMU Jérôme Pouiller
@ 2014-09-12 21:31   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-12 21:31 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > DGA support use fork. This prevent executables to link with libSDL.so.
 > Fixes:
 >   http://sysmic.org/~jezz/results/5e50c243 (package sdl_mixer)
 >   http://sysmic.org/~jezz/results/734afef8 (package sdl_net)
 >   http://sysmic.org/~jezz/results/e2310eb9 (package sdl_image)
 >   http://sysmic.org/~jezz/results/e2cdcc9a (package sdl_sound)

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 03/12] xapp_xinit: depends on MMU
  2014-09-12 21:19   ` Peter Korsgaard
@ 2014-09-13  5:59     ` Jérôme Pouiller
  0 siblings, 0 replies; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-13  5:59 UTC (permalink / raw)
  To: buildroot

On Friday 12 September 2014 23:19:06 Peter Korsgaard wrote:
> >>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:
[...]
>  >  	# Runtime dependency: can't start an X server unless there is one
>  >  	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
>  > 
>  > -	# Runtime dependency; mcookie is also in util-linux
>  > +	#Runtime dependency; mcookie is also in util-linux
> 
> I'm not sure why you want to change this. Committed without this line,
> thanks.
I don't known either why... It is a mishandling.

-- 
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 11/12] directfb: allow SVG support
  2014-09-12 15:50 ` [Buildroot] [PATCH 11/12] directfb: allow SVG support Jérôme Pouiller
@ 2014-09-13  7:23   ` Peter Korsgaard
  0 siblings, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-13  7:23 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > DirectFB SVG support rely on Cairo and Cairo depends on DirectFB.
 > Since Cairo DirectFB backend is marked as experimental, this patch choose to
 > disable this backend when DirectFB SVG support is enable.

 > In add, this patch may solve some tricky situations between DirectFB and Cairo
 > (see http://sysmic.org/~jezz/results/c2f11fc0) and improve build reproducibility.

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
 > ---
 >  package/cairo/cairo.mk       | 5 ++++-
 >  package/directfb/Config.in   | 5 +++++
 >  package/directfb/directfb.mk | 7 +++++++
 >  3 files changed, 16 insertions(+), 1 deletion(-)

 > diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
 > index a4c71b6..bcc0c26 100644
 > --- a/package/cairo/cairo.mk
 > +++ b/package/cairo/cairo.mk
 > @@ -48,7 +48,10 @@ CAIRO_CONF_OPT = \
 
 >  CAIRO_DEPENDENCIES = host-pkgconf fontconfig pixman
 
 > -ifeq ($(BR2_PACKAGE_DIRECTFB),y)
 > +# DirectFB svg support rely on Cairo and Cairo DirectFB support depends on
 > +# DirectFB. Break circular dependency by disabling DirectFB support in Cairo
 > +# (which is experimental)
 > +ifeq ($(BR2_PACKAGE_DIRECTFB)x$(BR2_PACKAGE_DIRECTFB_SVG),yx)
 >  	CAIRO_CONF_OPT += --enable-directfb
 >  	CAIRO_DEPENDENCIES += directfb
 >  else
 > diff --git a/package/directfb/Config.in b/package/directfb/Config.in
 > index e3c93a1..dc01228 100644
 > --- a/package/directfb/Config.in
 > +++ b/package/directfb/Config.in
 > @@ -125,6 +125,11 @@ config BR2_PACKAGE_DIRECTFB_PNG
 >  	default y
 >  	select BR2_PACKAGE_LIBPNG
 
 > +config BR2_PACKAGE_DIRECTFB_SVG
 > +	bool "enable SVG support"
 > +	default y
 > +	select BR2_PACKAGE_CAIRO

cairo depends on BR2_ARCH_HAS_ATOMICS, so this should also do so.

I suspect this also needs the SVG backend of cairo. From config.log:

configure:19926: checking for libsvg-cairo >= 0.1.6
configure:19936: result: not found
configure:19939: WARNING:
*** SVG-Cairo at least 0.1.6 not found -- SVG image provider will not be built.

So it actually needs libsvg-cairo (which pulls in cairo and the svg
backend of cairo).

It also needs some help to find the cairo includes:

make[5]: Entering directory '/home/peko/source/buildroot/output/build/directfb-1.6.3/interfaces/IDirectFBImageProvider'
  CC       idirectfbimageprovider_dfiff.lo
  CC       idirectfbimageprovider_bmp.lo
  CC       idirectfbimageprovider_pnm.lo
  CC       idirectfbimageprovider_svg.lo
  CC       idirectfbimageprovider_mpeg2.lo
idirectfbimageprovider_svg.c:46:19: fatal error: cairo.h: No such file or directory
compilation terminated.
Makefile:817: recipe for target 'idirectfbimageprovider_svg.lo' failed
make[5]: *** [idirectfbimageprovider_svg.lo] Error 1
make[5]: *** Waiting for unfinished jobs....

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 12/12] libffi and python: need threads support
  2014-09-12 15:50 ` [Buildroot] [PATCH 12/12] libffi and python: need threads support Jérôme Pouiller
@ 2014-09-13  7:39   ` Peter Korsgaard
  2014-09-13  7:57   ` Thomas Petazzoni
  1 sibling, 0 replies; 28+ messages in thread
From: Peter Korsgaard @ 2014-09-13  7:39 UTC (permalink / raw)
  To: buildroot

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > libffi depends on pthreads.
 > Python depends on libffi (it can provide a builtin libffi, but also depends on
 > pthreads). Thus this patch also disable Python support if toolchain is compiled
 > w/o treads support.

 > Fixes http://sysmic.org/~jezz/results/204099dd:

 > ../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
 > ---
 >  package/libffi/Config.in | 4 ++++
 >  package/python/Config.in | 4 +++-

python is not the only user of libffi. From a quick look, they all
depends on threads except for python3, so I've made the same change to
python3.

 >  2 files changed, 7 insertions(+), 1 deletion(-)

 > diff --git a/package/libffi/Config.in b/package/libffi/Config.in
 > index 7211f8f..6edf570 100644
 > --- a/package/libffi/Config.in
 > +++ b/package/libffi/Config.in
 > @@ -1,5 +1,6 @@
 >  config BR2_PACKAGE_LIBFFI
 >  	bool "libffi"
 > +	depends on BR2_TOOLCHAIN_HAS_THREADS
 >  	help
 >  	  The libffi library provides a portable, high level
 >  	  programming interface to various calling conventions. This
 > @@ -7,3 +8,6 @@ config BR2_PACKAGE_LIBFFI
 >  	  interface description at run-time.
 
 >  	  http://sourceware.org/libffi/
 > +
 > +comment "libffi needs a toolchain w/ threads"
 > +	depends on !BR2_TOOLCHAIN_HAS_THREADS
 > diff --git a/package/python/Config.in b/package/python/Config.in
 > index a0c78c6..85438a4 100644
 > --- a/package/python/Config.in
 > +++ b/package/python/Config.in
 > @@ -3,15 +3,17 @@ config BR2_PACKAGE_PYTHON
 >  	depends on BR2_USE_WCHAR
 >  	# uses fork()
 >  	depends on BR2_USE_MMU
 > +	depends on BR2_TOOLCHAIN_HAS_THREADS # libffi
 >  	select BR2_PACKAGE_LIBFFI
 >  	help
 >  	  The python language interpreter.
 
 >  	  http://www.python.org/
 
 > -comment "python needs a toolchain w/ wchar"
 > +comment "python needs a toolchain w/ wchar and threads"
 >  	depends on BR2_USE_MMU
 >  	depends on !BR2_USE_WCHAR
 > +	depends on !BR2_TOOLCHAIN_HAS_THREADS

That's wrong. Seperate 'depends on' gets ANDed together, E.G. they all
have to be true, whereas we want to display the line whenever
mmu and either !wchar OR !threads, so it should be

depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 12/12] libffi and python: need threads support
  2014-09-12 15:50 ` [Buildroot] [PATCH 12/12] libffi and python: need threads support Jérôme Pouiller
  2014-09-13  7:39   ` Peter Korsgaard
@ 2014-09-13  7:57   ` Thomas Petazzoni
  2014-09-14  6:42     ` Jérôme Pouiller
  1 sibling, 1 reply; 28+ messages in thread
From: Thomas Petazzoni @ 2014-09-13  7:57 UTC (permalink / raw)
  To: buildroot

Dear J?r?me Pouiller,

On Fri, 12 Sep 2014 17:50:11 +0200, J?r?me Pouiller wrote:
> libffi depends on pthreads.
> 
> Python depends on libffi (it can provide a builtin libffi, but also depends on
> pthreads). Thus this patch also disable Python support if toolchain is compiled
> w/o treads support.
> 
> Fixes http://sysmic.org/~jezz/results/204099dd:
> 
> ../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

This seems weird. We have a no threads toolchain in our autobuilders
and it was never detected, even though I'm pretty sure libffi was built
a number of times. Do you have the configuration that exhibits the
problem?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [Buildroot] [PATCH 12/12] libffi and python: need threads support
  2014-09-13  7:57   ` Thomas Petazzoni
@ 2014-09-14  6:42     ` Jérôme Pouiller
  0 siblings, 0 replies; 28+ messages in thread
From: Jérôme Pouiller @ 2014-09-14  6:42 UTC (permalink / raw)
  To: buildroot

On Saturday 13 September 2014 09:57:12 Thomas Petazzoni wrote:
> Dear J?r?me Pouiller,
> 
> On Fri, 12 Sep 2014 17:50:11 +0200, J?r?me Pouiller wrote:
> > libffi depends on pthreads.
> > 
> > Python depends on libffi (it can provide a builtin libffi, but also
> > depends on pthreads). Thus this patch also disable Python support if
> > toolchain is compiled w/o treads support.
> > 
> > Fixes http://sysmic.org/~jezz/results/204099dd:
> > 
> > ../src/closures.c:119:21: fatal error: pthread.h: No such file or
> > directory
> 
> This seems weird. We have a no threads toolchain in our autobuilders
> and it was never detected, even though I'm pretty sure libffi was built
> a number of times. Do you have the configuration that exhibits the
> problem?

I can reproduce problem using:

BR2_powerpc=y
BR2_powerpc_440=y
BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_TOOLCHAIN_BUILDROOT_INET_RPC=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_PTHREADS_NONE=y
BR2_BINUTILS_VERSION_2_24=y
BR2_GCC_VERSION_4_9_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_LIBFFI=y

In add, I found this patch :
  http://lists.busybox.net/pipermail/buildroot/2012-November/061976.html

It is seems is had never been applied and it should solve this issue.


-- 
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr

^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2014-09-14  6:42 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12 15:49 [Buildroot] Fix some build issues Jérôme Pouiller
2014-09-12 15:50 ` [Buildroot] [PATCH 01/12] xdriver_xf86-video-vmware: only avaiblable on x86 Jérôme Pouiller
2014-09-12 21:15   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 02/12] xapp_xkbevd: depends on MMU Jérôme Pouiller
2014-09-12 21:21   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 03/12] xapp_xinit: " Jérôme Pouiller
2014-09-12 21:19   ` Peter Korsgaard
2014-09-13  5:59     ` Jérôme Pouiller
2014-09-12 15:50 ` [Buildroot] [PATCH 04/12] xapp_xsm: " Jérôme Pouiller
2014-09-12 21:15   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 05/12] xapp_xmh: " Jérôme Pouiller
2014-09-12 21:16   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 06/12] xapp_xdm: " Jérôme Pouiller
2014-09-12 21:20   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 07/12] xterm: " Jérôme Pouiller
2014-09-12 21:16   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 08/12] xfsprogs: " Jérôme Pouiller
2014-09-12 21:20   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 09/12] ltp-testsuite: " Jérôme Pouiller
2014-09-12 21:20   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 10/12] sdl: remove dga support in no MMU Jérôme Pouiller
2014-09-12 21:31   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 11/12] directfb: allow SVG support Jérôme Pouiller
2014-09-13  7:23   ` Peter Korsgaard
2014-09-12 15:50 ` [Buildroot] [PATCH 12/12] libffi and python: need threads support Jérôme Pouiller
2014-09-13  7:39   ` Peter Korsgaard
2014-09-13  7:57   ` Thomas Petazzoni
2014-09-14  6:42     ` Jérôme Pouiller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.