* [Buildroot] [PATCH] uclibc: fix MIPS variables
@ 2013-11-10 15:01 Thomas Petazzoni
2013-11-10 21:41 ` Peter Korsgaard
2013-11-11 9:19 ` Markos Chandras
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2013-11-10 15:01 UTC (permalink / raw)
To: buildroot
The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc
config option should be enabled for a given MIPS architecture
variant. Therefore, using lower case names doesn't work: they should
be upper case, to match uClibc config option names. This commit makes
sure the mips32, mips32r2 and mips64 builds select the appropriate
uClibc configuration.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Markos Chandras <Markos.Chandras@imgtec.com>
---
package/uclibc/Config.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
index 2dbac12..82dd3aa 100644
--- a/package/uclibc/Config.in
+++ b/package/uclibc/Config.in
@@ -230,9 +230,9 @@ config BR2_UCLIBC_MIPS_ISA
default 2 if BR2_mips_2
default 3 if BR2_mips_3
default 4 if BR2_mips_4
- default mips32 if BR2_mips_32
- default mips32r2 if BR2_mips_32r2
- default mips64 if BR2_mips_64
+ default MIPS32 if BR2_mips_32
+ default MIPS32R2 if BR2_mips_32r2
+ default MIPS64 if BR2_mips_64
config BR2_UCLIBC_SH_TYPE
string
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] uclibc: fix MIPS variables
2013-11-10 15:01 [Buildroot] [PATCH] uclibc: fix MIPS variables Thomas Petazzoni
@ 2013-11-10 21:41 ` Peter Korsgaard
2013-11-11 9:19 ` Markos Chandras
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-11-10 21:41 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc
> config option should be enabled for a given MIPS architecture
> variant. Therefore, using lower case names doesn't work: they should
> be upper case, to match uClibc config option names. This commit makes
> sure the mips32, mips32r2 and mips64 builds select the appropriate
> uClibc configuration.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Markos Chandras <Markos.Chandras@imgtec.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] uclibc: fix MIPS variables
2013-11-10 15:01 [Buildroot] [PATCH] uclibc: fix MIPS variables Thomas Petazzoni
2013-11-10 21:41 ` Peter Korsgaard
@ 2013-11-11 9:19 ` Markos Chandras
1 sibling, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2013-11-11 9:19 UTC (permalink / raw)
To: buildroot
On 11/10/2013 03:01 PM, Thomas Petazzoni wrote:
> The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc
> config option should be enabled for a given MIPS architecture
> variant. Therefore, using lower case names doesn't work: they should
> be upper case, to match uClibc config option names. This commit makes
> sure the mips32, mips32r2 and mips64 builds select the appropriate
> uClibc configuration.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Markos Chandras <Markos.Chandras@imgtec.com>
> ---
> package/uclibc/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index 2dbac12..82dd3aa 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -230,9 +230,9 @@ config BR2_UCLIBC_MIPS_ISA
> default 2 if BR2_mips_2
> default 3 if BR2_mips_3
> default 4 if BR2_mips_4
> - default mips32 if BR2_mips_32
> - default mips32r2 if BR2_mips_32r2
> - default mips64 if BR2_mips_64
> + default MIPS32 if BR2_mips_32
> + default MIPS32R2 if BR2_mips_32r2
> + default MIPS64 if BR2_mips_64
>
> config BR2_UCLIBC_SH_TYPE
> string
>
That looks good to me. Thanks for fixing it.
--
markos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-11 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-10 15:01 [Buildroot] [PATCH] uclibc: fix MIPS variables Thomas Petazzoni
2013-11-10 21:41 ` Peter Korsgaard
2013-11-11 9:19 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.