* [PATCH] add support for Sierra Wireless EM7590 0xc081 composition.
@ 2022-04-25 3:14 Ethan Yang
2022-04-25 5:07 ` Bjørn Mork
0 siblings, 1 reply; 5+ messages in thread
From: Ethan Yang @ 2022-04-25 3:14 UTC (permalink / raw)
To: bjorn, davem, kuba, pabeni, netdev, linux-usb, linux-kernel
Cc: gchiang, Ethan Yang
add support for Sierra Wireless EM7590 0xc081 composition.
Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3353e761016d..fa220a13edb6 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1351,6 +1351,7 @@ static const struct usb_device_id products[] = {
{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */
{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
{QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */
+ {QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)}, /* Sierra Wireless EM7590 */
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] add support for Sierra Wireless EM7590 0xc081 composition.
2022-04-25 3:14 [PATCH] add support for Sierra Wireless EM7590 0xc081 composition Ethan Yang
@ 2022-04-25 5:07 ` Bjørn Mork
2022-04-25 5:40 ` [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590 ipis.yang
0 siblings, 1 reply; 5+ messages in thread
From: Bjørn Mork @ 2022-04-25 5:07 UTC (permalink / raw)
To: Ethan Yang
Cc: davem, kuba, pabeni, netdev, linux-usb, linux-kernel, gchiang,
Ethan Yang
Ethan Yang <ipis.yang@gmail.com> writes:
> add support for Sierra Wireless EM7590 0xc081 composition.
>
> Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 3353e761016d..fa220a13edb6 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1351,6 +1351,7 @@ static const struct usb_device_id products[] = {
> {QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */
> {QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
> {QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */
> + {QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)}, /* Sierra Wireless EM7590 */
> {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
Hello!
The diff looks fine to me, but there are some minor issues with the
commit message. This is how it ended up looking in for me with "git
log":
---
commit 5e3f386fdb23c8e5ba7c24ff5efd6beb73db3e85 (HEAD -> bugfix-master)
Author: Ethan Yang <ipis.yang@gmail.com>
Date: Mon Apr 25 11:14:11 2022 +0800
add support for Sierra Wireless EM7590 0xc081 composition.
add support for Sierra Wireless EM7590 0xc081 composition.
Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
---
The issues I see there are:
1) subject should have a prefix - e.g. "net: usb: qmi_wwan:"
2) don't repeat the subject in the body - that's redundant and ends up
looking like a duplicate line in the commit message. Write
something addding more information instead. Anything you find
relevant
3) I guess you send from a gmail address for a reason. But you most
likely want the Author field to match your Signed-off-by? You can fix
this by including something like this as the *first* line of the
message body:
From: Ethan Yang <etyang@sierrawireless.com>
FYI: checkpatch warns about the last issue:
bjorn@miraculix:/usr/local/src/git/linux$ scripts/checkpatch.pl /tmp/xx
WARNING: From:/Signed-off-by: email address mismatch: 'From: Ethan Yang <ipis.yang@gmail.com>' != 'Signed-off-by: Ethan Yang <etyang@sierrawireless.com>'
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/tmp/xx has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Bjørn
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590
2022-04-25 5:07 ` Bjørn Mork
@ 2022-04-25 5:40 ` ipis.yang
2022-04-25 5:43 ` Bjørn Mork
2022-04-26 9:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: ipis.yang @ 2022-04-25 5:40 UTC (permalink / raw)
To: bjorn, davem, kuba, pabeni, netdev, linux-usb, linux-kernel
Cc: gchiang, ipis.yang, Ethan Yang
From: Ethan Yang <etyang@sierrawireless.com>
add support for Sierra Wireless EM7590 0xc081 composition.
Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3353e761016d..fa220a13edb6 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1351,6 +1351,7 @@ static const struct usb_device_id products[] = {
{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)}, /* Sierra Wireless EM74xx */
{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
{QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)}, /* Sierra Wireless EM7565 */
+ {QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)}, /* Sierra Wireless EM7590 */
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590
2022-04-25 5:40 ` [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590 ipis.yang
@ 2022-04-25 5:43 ` Bjørn Mork
2022-04-26 9:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: Bjørn Mork @ 2022-04-25 5:43 UTC (permalink / raw)
To: ipis.yang
Cc: davem, kuba, pabeni, netdev, linux-usb, linux-kernel, gchiang,
Ethan Yang
Thanks!
Acked-by: Bjørn Mork <bjorn@mork.no>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590
2022-04-25 5:40 ` [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590 ipis.yang
2022-04-25 5:43 ` Bjørn Mork
@ 2022-04-26 9:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-26 9:50 UTC (permalink / raw)
To: Ethan Yang
Cc: bjorn, davem, kuba, pabeni, netdev, linux-usb, linux-kernel,
gchiang, etyang
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 25 Apr 2022 13:40:28 +0800 you wrote:
> From: Ethan Yang <etyang@sierrawireless.com>
>
> add support for Sierra Wireless EM7590 0xc081 composition.
>
> Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590
https://git.kernel.org/netdev/net-next/c/561215482cc6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-26 10:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 3:14 [PATCH] add support for Sierra Wireless EM7590 0xc081 composition Ethan Yang
2022-04-25 5:07 ` Bjørn Mork
2022-04-25 5:40 ` [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590 ipis.yang
2022-04-25 5:43 ` Bjørn Mork
2022-04-26 9:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.