From: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Yannick Vignon <yannick.vignon@nxp.com>
Subject: Re: [PATCH net] net: stmmac: allow a tc-taprio base-time of zero
Date: Tue, 09 Nov 2021 09:20:53 +0100 [thread overview]
Message-ID: <87bl2t3fkq.fsf@kurt> (raw)
In-Reply-To: <20211108202854.1740995-1-vladimir.oltean@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
Hi Vladimir,
On Mon Nov 08 2021, Vladimir Oltean wrote:
> Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when
> base_time is in the past") allowed some base time values in the past,
> but apparently not all, the base-time value of 0 (Jan 1st 1970) is still
> explicitly denied by the driver.
>
> Remove the bogus check.
>
> Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
I've experienced the same problem and wanted to send a patch for
it. Thanks!
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Yannick Vignon <yannick.vignon@nxp.com>
Subject: Re: [PATCH net] net: stmmac: allow a tc-taprio base-time of zero
Date: Tue, 09 Nov 2021 09:20:53 +0100 [thread overview]
Message-ID: <87bl2t3fkq.fsf@kurt> (raw)
In-Reply-To: <20211108202854.1740995-1-vladimir.oltean@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 603 bytes --]
Hi Vladimir,
On Mon Nov 08 2021, Vladimir Oltean wrote:
> Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when
> base_time is in the past") allowed some base time values in the past,
> but apparently not all, the base-time value of 0 (Jan 1st 1970) is still
> explicitly denied by the driver.
>
> Remove the bogus check.
>
> Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
I've experienced the same problem and wanted to send a patch for
it. Thanks!
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-09 8:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 20:28 [PATCH net] net: stmmac: allow a tc-taprio base-time of zero Vladimir Oltean
2021-11-08 20:28 ` Vladimir Oltean
2021-11-09 8:20 ` Kurt Kanzenbach [this message]
2021-11-09 8:20 ` Kurt Kanzenbach
2021-11-09 10:35 ` Vladimir Oltean
2021-11-09 10:35 ` Vladimir Oltean
2021-11-09 14:19 ` [Linux-stm32] " Ahmad Fatoum
2021-11-09 14:19 ` Ahmad Fatoum
2021-11-09 14:22 ` Vladimir Oltean
2021-11-09 14:22 ` Vladimir Oltean
2021-11-10 12:38 ` Vladimir Oltean
2021-11-10 12:38 ` Vladimir Oltean
2021-11-11 10:48 ` Holger Assmann
2021-11-11 10:48 ` Holger Assmann
2021-11-09 14:47 ` Kurt Kanzenbach
2021-11-09 14:47 ` Kurt Kanzenbach
2021-11-09 15:08 ` Yannick Vignon
2021-11-09 15:08 ` Yannick Vignon
2021-11-16 12:18 ` Kurt Kanzenbach
2021-11-16 12:18 ` Kurt Kanzenbach
2021-11-10 14:40 ` patchwork-bot+netdevbpf
2021-11-10 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl2t3fkq.fsf@kurt \
--to=kurt.kanzenbach@linutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yannick.vignon@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.