All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
@ 2021-10-16  0:23 Ashutosh Dixit
  2021-10-16  1:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Ashutosh Dixit @ 2021-10-16  0:23 UTC (permalink / raw)
  To: igt-dev; +Cc: John Harrison, Tvrtko Ursulin, Michal Wajdeczko

gem_submission_method() purports to return the currently used submission
method by the driver, as evidenced by its callers. Therefore remove the
GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously
gem_has_execlists() would return true even if GuC submission was actually
being used in the driver.

Reported-by: John Harrison <john.c.harrison@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 lib/i915/gem_submission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
index 2627b802cfb..b037d04cc4a 100644
--- a/lib/i915/gem_submission.c
+++ b/lib/i915/gem_submission.c
@@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
 		return 0;
 
 	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
-		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
+		flags |= GEM_SUBMISSION_GUC;
 		goto out;
 	}
 
-- 
2.33.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for lib/i915: Return actual submission method from gem_submission_method
  2021-10-16  0:23 [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method Ashutosh Dixit
@ 2021-10-16  1:19 ` Patchwork
  2021-10-16  5:45 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  2021-10-18 23:39 ` [igt-dev] [PATCH i-g-t] " John Harrison
  2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-10-16  1:19 UTC (permalink / raw)
  To: Ashutosh Dixit; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 3549 bytes --]

== Series Details ==

Series: lib/i915: Return actual submission method from gem_submission_method
URL   : https://patchwork.freedesktop.org/series/95906/
State : success

== Summary ==

CI Bug Log - changes from IGT_6251 -> IGTPW_6328
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/index.html

Known issues
------------

  Here are the changes found in IGTPW_6328 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@semaphore:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][1] ([fdo#109271]) +23 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html

  * igt@gem_exec_parallel@engines@userptr:
    - fi-pnv-d510:        [PASS][2] -> [INCOMPLETE][3] ([i915#299])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-dp1:
    - fi-cfl-8109u:       [PASS][4] -> [FAIL][5] ([i915#4165])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp1.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp1.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
    - fi-cfl-8109u:       [PASS][6] -> [DMESG-WARN][7] ([i915#295]) +17 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html

  * igt@runner@aborted:
    - fi-pnv-d510:        NOTRUN -> [FAIL][8] ([i915#2403] / [i915#2722])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/fi-pnv-d510/igt@runner@aborted.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cfl-8109u:       [FAIL][9] ([i915#2546]) -> [DMESG-WARN][10] ([i915#295])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
  [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
  [i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
  [i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165


Participating hosts (39 -> 37)
------------------------------

  Missing    (2): fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6251 -> IGTPW_6328

  CI-20190529: 20190529
  CI_DRM_10744: dc405215cfabb6f13490cbdceb1f6e831e8a8596 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6328: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/index.html
  IGT_6251: 01b6be842d74fb86f3226acb4ddcb85231f4b161 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/index.html

[-- Attachment #2: Type: text/html, Size: 4342 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for lib/i915: Return actual submission method from gem_submission_method
  2021-10-16  0:23 [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method Ashutosh Dixit
  2021-10-16  1:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-10-16  5:45 ` Patchwork
  2021-10-18 23:39 ` [igt-dev] [PATCH i-g-t] " John Harrison
  2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-10-16  5:45 UTC (permalink / raw)
  To: Ashutosh Dixit; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 30286 bytes --]

== Series Details ==

Series: lib/i915: Return actual submission method from gem_submission_method
URL   : https://patchwork.freedesktop.org/series/95906/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6251_full -> IGTPW_6328_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6328_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6328_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6328_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_bw@linear-tiling-2-displays-2560x1440p:
    - shard-snb:          NOTRUN -> [FAIL][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-snb7/igt@kms_bw@linear-tiling-2-displays-2560x1440p.html

  * igt@kms_bw@linear-tiling-4-displays-2560x1440p:
    - shard-kbl:          NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl6/igt@kms_bw@linear-tiling-4-displays-2560x1440p.html

  
Known issues
------------

  Here are the changes found in IGTPW_6328_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@chamelium:
    - shard-iclb:         NOTRUN -> [SKIP][3] ([fdo#111827])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb1/igt@feature_discovery@chamelium.html

  * igt@gem_ctx_persistence@legacy-engines-mixed:
    - shard-snb:          NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +6 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed.html

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          NOTRUN -> [DMESG-WARN][5] ([i915#180])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl6/igt@gem_eio@in-flight-suspend.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         NOTRUN -> [TIMEOUT][6] ([i915#2369] / [i915#3063] / [i915#3648])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@gem_eio@unwedge-stress.html
    - shard-iclb:         NOTRUN -> [TIMEOUT][7] ([i915#2369] / [i915#2481] / [i915#3070])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb8/igt@gem_eio@unwedge-stress.html
    - shard-snb:          NOTRUN -> [FAIL][8] ([i915#3354])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-snb5/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-tglb:         [PASS][9] -> [FAIL][10] ([i915#2842])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-tglb3/igt@gem_exec_fair@basic-pace@rcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [PASS][13] -> [SKIP][14] ([fdo#109271])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_params@no-blt:
    - shard-tglb:         NOTRUN -> [SKIP][15] ([fdo#109283])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb6/igt@gem_exec_params@no-blt.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-apl:          NOTRUN -> [WARN][16] ([i915#2658])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl3/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_pxp@reject-modify-context-protection-off-3:
    - shard-iclb:         NOTRUN -> [SKIP][17] ([i915#4270]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb7/igt@gem_pxp@reject-modify-context-protection-off-3.html

  * igt@gem_pxp@reject-modify-context-protection-on:
    - shard-tglb:         NOTRUN -> [SKIP][18] ([i915#4270]) +1 similar issue
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb1/igt@gem_pxp@reject-modify-context-protection-on.html

  * igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][19] ([i915#768]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb7/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled.html

  * igt@gem_userptr_blits@unsync-unmap-cycles:
    - shard-tglb:         NOTRUN -> [SKIP][20] ([i915#3297])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@gem_userptr_blits@unsync-unmap-cycles.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-apl:          NOTRUN -> [FAIL][21] ([i915#3318])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl6/igt@gem_userptr_blits@vma-merge.html

  * igt@gen7_exec_parse@batch-without-end:
    - shard-iclb:         NOTRUN -> [SKIP][22] ([fdo#109289]) +2 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb4/igt@gen7_exec_parse@batch-without-end.html

  * igt@gen9_exec_parse@bb-oversize:
    - shard-tglb:         NOTRUN -> [SKIP][23] ([i915#2856]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb8/igt@gen9_exec_parse@bb-oversize.html

  * igt@i915_pm_rpm@dpms-non-lpsp:
    - shard-tglb:         NOTRUN -> [SKIP][24] ([fdo#111644] / [i915#1397] / [i915#2411])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb8/igt@i915_pm_rpm@dpms-non-lpsp.html

  * igt@i915_pm_rpm@gem-execbuf-stress-pc8:
    - shard-iclb:         NOTRUN -> [SKIP][25] ([fdo#109293] / [fdo#109506])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb1/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html

  * igt@i915_pm_rpm@i2c:
    - shard-tglb:         [PASS][26] -> [FAIL][27] ([i915#2411] / [i915#68])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-tglb5/igt@i915_pm_rpm@i2c.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb7/igt@i915_pm_rpm@i2c.html
    - shard-kbl:          NOTRUN -> [FAIL][28] ([i915#68])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl6/igt@i915_pm_rpm@i2c.html
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([i915#68])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-iclb6/igt@i915_pm_rpm@i2c.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb2/igt@i915_pm_rpm@i2c.html

  * igt@i915_pm_rpm@modeset-non-lpsp:
    - shard-iclb:         NOTRUN -> [SKIP][31] ([fdo#110892]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb6/igt@i915_pm_rpm@modeset-non-lpsp.html

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-tglb:         NOTRUN -> [SKIP][32] ([i915#1769])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb5/igt@kms_atomic_transition@plane-all-modeset-transition.html

  * igt@kms_big_fb@linear-16bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([fdo#110725] / [fdo#111614])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb7/igt@kms_big_fb@linear-16bpp-rotate-90.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][34] ([fdo#111614])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb1/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
    - shard-apl:          NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3777]) +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
    - shard-kbl:          NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3777]) +3 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl6/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html

  * igt@kms_bw@linear-tiling-2-displays-1920x1080p:
    - shard-apl:          NOTRUN -> [DMESG-FAIL][37] ([i915#4298]) +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl2/igt@kms_bw@linear-tiling-2-displays-1920x1080p.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][38] ([i915#3689]) +3 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs.html

  * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
    - shard-kbl:          NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +12 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +3 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk2/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +11 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl1/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
    - shard-iclb:         NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#3886]) +6 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][43] ([i915#3689] / [i915#3886]) +2 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-d-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
    - shard-glk:          NOTRUN -> [SKIP][44] ([fdo#109271]) +66 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk6/igt@kms_ccs@pipe-d-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

  * igt@kms_chamelium@dp-hpd-storm-disable:
    - shard-glk:          NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +9 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk5/igt@kms_chamelium@dp-hpd-storm-disable.html

  * igt@kms_chamelium@hdmi-edid-change-during-suspend:
    - shard-apl:          NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +28 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl8/igt@kms_chamelium@hdmi-edid-change-during-suspend.html

  * igt@kms_chamelium@hdmi-edid-read:
    - shard-tglb:         NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +7 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb8/igt@kms_chamelium@hdmi-edid-read.html

  * igt@kms_chamelium@vga-hpd-for-each-pipe:
    - shard-kbl:          NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +14 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl3/igt@kms_chamelium@vga-hpd-for-each-pipe.html

  * igt@kms_chamelium@vga-hpd-with-enabled-mode:
    - shard-iclb:         NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +7 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb5/igt@kms_chamelium@vga-hpd-with-enabled-mode.html

  * igt@kms_color_chamelium@pipe-d-ctm-0-5:
    - shard-snb:          NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +21 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-snb6/igt@kms_color_chamelium@pipe-d-ctm-0-5.html

  * igt@kms_color_chamelium@pipe-d-ctm-0-75:
    - shard-iclb:         NOTRUN -> [SKIP][51] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb2/igt@kms_color_chamelium@pipe-d-ctm-0-75.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-iclb:         NOTRUN -> [SKIP][52] ([i915#3116])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb7/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][53] ([i915#1319]) +2 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl7/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109278] / [fdo#109279]) +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb1/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][55] -> [DMESG-WARN][56] ([i915#180]) +2 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque:
    - shard-glk:          [PASS][57] -> [FAIL][58] ([i915#3444])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-glk7/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk9/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
    - shard-apl:          [PASS][59] -> [FAIL][60] ([i915#3444])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
    - shard-kbl:          [PASS][61] -> [FAIL][62] ([i915#3444])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][63] ([fdo#109278]) +17 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb2/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
    - shard-tglb:         NOTRUN -> [SKIP][64] ([i915#3359]) +1 similar issue
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb5/igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-512x512-onscreen:
    - shard-tglb:         NOTRUN -> [SKIP][65] ([fdo#109279] / [i915#3359]) +1 similar issue
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-512x512-onscreen.html

  * igt@kms_dsc@xrgb8888-dsc-compression:
    - shard-tglb:         NOTRUN -> [SKIP][66] ([i915#3828])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb5/igt@kms_dsc@xrgb8888-dsc-compression.html

  * igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][67] ([fdo#111825]) +14 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible.html
    - shard-iclb:         NOTRUN -> [SKIP][68] ([fdo#109274]) +1 similar issue
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb8/igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-snb:          NOTRUN -> [SKIP][69] ([fdo#109271]) +457 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-snb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_flip_tiling@flip-to-yf-tiled:
    - shard-tglb:         NOTRUN -> [SKIP][70] ([fdo#111615]) +2 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb1/igt@kms_flip_tiling@flip-to-yf-tiled.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render:
    - shard-iclb:         NOTRUN -> [SKIP][71] ([fdo#109280]) +13 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
    - shard-kbl:          NOTRUN -> [SKIP][72] ([fdo#109271]) +176 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl4/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html

  * igt@kms_hdr@static-toggle-dpms:
    - shard-iclb:         NOTRUN -> [SKIP][73] ([i915#1187])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb5/igt@kms_hdr@static-toggle-dpms.html

  * igt@kms_invalid_mode@clock-too-high:
    - shard-tglb:         NOTRUN -> [SKIP][74] ([i915#4278])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb1/igt@kms_invalid_mode@clock-too-high.html
    - shard-iclb:         NOTRUN -> [SKIP][75] ([i915#4278])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb1/igt@kms_invalid_mode@clock-too-high.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-tglb:         NOTRUN -> [SKIP][76] ([i915#1839])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
    - shard-iclb:         NOTRUN -> [SKIP][77] ([i915#1839])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb8/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
    - shard-tglb:         NOTRUN -> [SKIP][78] ([fdo#109289])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html

  * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#533])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
    - shard-kbl:          NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl3/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-tglb:         [PASS][81] -> [INCOMPLETE][82] ([i915#456]) +1 similar issue
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-tglb5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][83] ([fdo#108145] / [i915#265]) +2 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][84] ([i915#265])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
    - shard-glk:          NOTRUN -> [FAIL][85] ([i915#265])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk9/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
    - shard-kbl:          NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265]) +1 similar issue
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl7/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
    - shard-glk:          NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk6/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html

  * igt@kms_plane_lowres@pipe-b-tiling-y:
    - shard-tglb:         NOTRUN -> [SKIP][88] ([i915#3536])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb7/igt@kms_plane_lowres@pipe-b-tiling-y.html

  * igt@kms_plane_lowres@pipe-c-tiling-yf:
    - shard-iclb:         NOTRUN -> [SKIP][89] ([i915#3536]) +1 similar issue
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb8/igt@kms_plane_lowres@pipe-c-tiling-yf.html
    - shard-tglb:         NOTRUN -> [SKIP][90] ([fdo#112054]) +1 similar issue
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb2/igt@kms_plane_lowres@pipe-c-tiling-yf.html

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
    - shard-apl:          NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2733])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
    - shard-kbl:          NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2733])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-apl:          NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#658]) +7 similar issues
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
    - shard-kbl:          NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#658]) +4 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
    - shard-iclb:         NOTRUN -> [SKIP][95] ([i915#658]) +1 similar issue
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html

  * igt@kms_psr@psr2_primary_page_flip:
    - shard-iclb:         [PASS][96] -> [SKIP][97] ([fdo#109441]) +4 similar issues
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html

  * igt@kms_sysfs_edid_timing:
    - shard-kbl:          NOTRUN -> [FAIL][98] ([IGT#2])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@kms_sysfs_edid_timing.html

  * igt@kms_tv_load_detect@load-detect:
    - shard-iclb:         NOTRUN -> [SKIP][99] ([fdo#109309])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb2/igt@kms_tv_load_detect@load-detect.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#2437]) +1 similar issue
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl2/igt@kms_writeback@writeback-check-output.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-glk:          NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2437])
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk5/igt@kms_writeback@writeback-fb-id.html

  * igt@kms_writeback@writeback-invalid-parameters:
    - shard-kbl:          NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#2437])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl2/igt@kms_writeback@writeback-invalid-parameters.html

  * igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
    - shard-iclb:         NOTRUN -> [SKIP][103] ([i915#2530])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb7/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
    - shard-apl:          NOTRUN -> [SKIP][104] ([fdo#109271]) +283 similar issues
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl1/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html

  * igt@perf@polling-parameterized:
    - shard-kbl:          [PASS][105] -> [FAIL][106] ([i915#1542])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl3/igt@perf@polling-parameterized.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl1/igt@perf@polling-parameterized.html

  * igt@prime_nv_api@i915_nv_double_import:
    - shard-tglb:         NOTRUN -> [SKIP][107] ([fdo#109291]) +2 similar issues
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb7/igt@prime_nv_api@i915_nv_double_import.html

  * igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name:
    - shard-iclb:         NOTRUN -> [SKIP][108] ([fdo#109291]) +3 similar issues
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb2/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html

  * igt@prime_vgem@fence-write-hang:
    - shard-iclb:         NOTRUN -> [SKIP][109] ([fdo#109295])
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb4/igt@prime_vgem@fence-write-hang.html

  * igt@sysfs_clients@fair-7:
    - shard-apl:          NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2994]) +5 similar issues
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl7/igt@sysfs_clients@fair-7.html

  * igt@sysfs_clients@sema-25:
    - shard-iclb:         NOTRUN -> [SKIP][111] ([i915#2994])
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb7/igt@sysfs_clients@sema-25.html
    - shard-kbl:          NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2994]) +2 similar issues
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl3/igt@sysfs_clients@sema-25.html
    - shard-glk:          NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2994])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk7/igt@sysfs_clients@sema-25.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          [FAIL][114] ([i915#2846]) -> [PASS][115]
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl4/igt@gem_exec_fair@basic-deadline.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl3/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-glk:          [FAIL][116] ([i915#2842]) -> [PASS][117]
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-glk8/igt@gem_exec_fair@basic-none-share@rcs0.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk6/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs1:
    - shard-kbl:          [FAIL][118] ([i915#2842]) -> [PASS][119]
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-kbl6/igt@gem_exec_fair@basic-none@vcs1.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-kbl3/igt@gem_exec_fair@basic-none@vcs1.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [FAIL][120] ([i915#2842]) -> [PASS][121] +2 similar issues
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-iclb:         [FAIL][122] ([i915#2842]) -> [PASS][123]
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-iclb8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-iclb3/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-0:
    - shard-glk:          [DMESG-WARN][124] ([i915#118]) -> [PASS][125]
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk8/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
    - shard-glk:          [FAIL][126] ([i915#3444]) -> [PASS][127]
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-glk1/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-glk1/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html

  * igt@kms_flip@flip-vs-suspend@b-dp1:
    - shard-apl:          [DMESG-WARN][128] ([i915#180]) -> [PASS][129] +1 similar issue
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-apl2/igt@kms_flip@flip-vs-suspend@b-dp1.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl7/igt@kms_flip@flip-vs-suspend@b-dp1.html

  * igt@kms_flip@flip-vs-wf_vblank-interruptible@a-dp1:
    - shard-apl:          [DMESG-WARN][130] ([i915#62]) -> [PASS][131] +19 similar issues
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6251/shard-apl8/igt@kms_flip@flip-vs-wf_vblank-interruptible@a-dp1.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/shard-apl8/igt@kms_flip@flip-vs-wf_vblank-interruptible@a-dp1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
    - shard-glk:          [FAIL][132] ([i915#1888] / [i915#2546]) -> [PASS][133]
   [132]

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6328/index.html

[-- Attachment #2: Type: text/html, Size: 33887 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-16  0:23 [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method Ashutosh Dixit
  2021-10-16  1:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2021-10-16  5:45 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-10-18 23:39 ` John Harrison
  2021-10-18 23:59   ` Dixit, Ashutosh
  2 siblings, 1 reply; 11+ messages in thread
From: John Harrison @ 2021-10-18 23:39 UTC (permalink / raw)
  To: Ashutosh Dixit, igt-dev; +Cc: Tvrtko Ursulin, Michal Wajdeczko

On 10/15/2021 17:23, Ashutosh Dixit wrote:
> gem_submission_method() purports to return the currently used submission
> method by the driver, as evidenced by its callers. Therefore remove the
> GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
>
> This also fixes gem_has_execlists() to match its description, previously
> gem_has_execlists() would return true even if GuC submission was actually
> being used in the driver.
>
> Reported-by: John Harrison <john.c.harrison@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>   lib/i915/gem_submission.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
> index 2627b802cfb..b037d04cc4a 100644
> --- a/lib/i915/gem_submission.c
> +++ b/lib/i915/gem_submission.c
> @@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
>   		return 0;
>   
>   	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
> -		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
> +		flags |= GEM_SUBMISSION_GUC;
>   		goto out;
>   	}
>   
Looks good to me, but as per the comments in the other thread, this 
might have unintended side effects. Have you gone through all instances 
of the submission query usages to check how it is used and whether this 
will break something? E.g. if something is explicitly testing for 
execlist support to mean 'something better than ring buffer' then it 
would now fail.


John.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-18 23:39 ` [igt-dev] [PATCH i-g-t] " John Harrison
@ 2021-10-18 23:59   ` Dixit, Ashutosh
  2021-10-19  0:12     ` Dixit, Ashutosh
  0 siblings, 1 reply; 11+ messages in thread
From: Dixit, Ashutosh @ 2021-10-18 23:59 UTC (permalink / raw)
  To: John Harrison; +Cc: igt-dev, Tvrtko Ursulin, Michal Wajdeczko

On Mon, 18 Oct 2021 16:39:40 -0700, John Harrison wrote:
>
> On 10/15/2021 17:23, Ashutosh Dixit wrote:
> > gem_submission_method() purports to return the currently used submission
> > method by the driver, as evidenced by its callers. Therefore remove the
> > GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
> >
> > This also fixes gem_has_execlists() to match its description, previously
> > gem_has_execlists() would return true even if GuC submission was actually
> > being used in the driver.
> >
> > Reported-by: John Harrison <john.c.harrison@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> >   lib/i915/gem_submission.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
> > index 2627b802cfb..b037d04cc4a 100644
> > --- a/lib/i915/gem_submission.c
> > +++ b/lib/i915/gem_submission.c
> > @@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
> >		return 0;
> >		if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
> > -		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
> > +		flags |= GEM_SUBMISSION_GUC;
> >		goto out;
> >	}
> >
> Looks good to me, but as per the comments in the other thread, this might
> have unintended side effects. Have you gone through all instances of the
> submission query usages to check how it is used and whether this will break
> something? E.g. if something is explicitly testing for execlist support to
> mean 'something better than ring buffer' then it would now fail.

There are at present just these two instances of gem_has_execlists:

*** tests/i915/gem_ctx_shared.c:
disjoint_timelines[162]        igt_require(gem_has_execlists(i915));

*** tests/i915/gem_watchdog.c:
virtual[225]                   igt_require(gem_has_execlists(i915));

I'll try to see if I can figure out if they will be affected in any
way. Meanwhile since Tvrtko seems to have authored/reviewed these tests, if
he can chime in that would be great :) Thanks!

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-18 23:59   ` Dixit, Ashutosh
@ 2021-10-19  0:12     ` Dixit, Ashutosh
  2021-10-19  7:16       ` John Harrison
  0 siblings, 1 reply; 11+ messages in thread
From: Dixit, Ashutosh @ 2021-10-19  0:12 UTC (permalink / raw)
  To: John Harrison, Tvrtko Ursulin; +Cc: igt-dev

On Mon, 18 Oct 2021 16:59:43 -0700, Dixit, Ashutosh wrote:
>
> On Mon, 18 Oct 2021 16:39:40 -0700, John Harrison wrote:
> >
> > On 10/15/2021 17:23, Ashutosh Dixit wrote:
> > > gem_submission_method() purports to return the currently used submission
> > > method by the driver, as evidenced by its callers. Therefore remove the
> > > GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
> > >
> > > This also fixes gem_has_execlists() to match its description, previously
> > > gem_has_execlists() would return true even if GuC submission was actually
> > > being used in the driver.
> > >
> > > Reported-by: John Harrison <john.c.harrison@intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > ---
> > >   lib/i915/gem_submission.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
> > > index 2627b802cfb..b037d04cc4a 100644
> > > --- a/lib/i915/gem_submission.c
> > > +++ b/lib/i915/gem_submission.c
> > > @@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
> > >		return 0;
> > >		if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
> > > -		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
> > > +		flags |= GEM_SUBMISSION_GUC;
> > >		goto out;
> > >	}
> > >
> > Looks good to me, but as per the comments in the other thread, this might
> > have unintended side effects. Have you gone through all instances of the
> > submission query usages to check how it is used and whether this will break
> > something? E.g. if something is explicitly testing for execlist support to
> > mean 'something better than ring buffer' then it would now fail.
>
> There are at present just these two instances of gem_has_execlists:
>
> *** tests/i915/gem_ctx_shared.c:
> disjoint_timelines[162]        igt_require(gem_has_execlists(i915));
>
> *** tests/i915/gem_watchdog.c:
> virtual[225]                   igt_require(gem_has_execlists(i915));
>
> I'll try to see if I can figure out if they will be affected in any
> way.

Actually, earlier these tests were running for both execlists and guc
submission. If they are meant to run even for guc then they will now skip
in the guc case after this patch.

Therefore I am thinking the exact equivalent of what was going on earlier
is this condition:
	igt_require(gem_has_execlists() | gem_has_guc_submission());

So that's all that is needed now correct? But what I am not sure of yet is
whether they were meant to run for guc too or just execlists.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-19  0:12     ` Dixit, Ashutosh
@ 2021-10-19  7:16       ` John Harrison
  2021-10-19  8:39         ` Tvrtko Ursulin
  0 siblings, 1 reply; 11+ messages in thread
From: John Harrison @ 2021-10-19  7:16 UTC (permalink / raw)
  To: Dixit, Ashutosh, Tvrtko Ursulin; +Cc: igt-dev

On 10/18/2021 17:12, Dixit, Ashutosh wrote:
> On Mon, 18 Oct 2021 16:59:43 -0700, Dixit, Ashutosh wrote:
>> On Mon, 18 Oct 2021 16:39:40 -0700, John Harrison wrote:
>>> On 10/15/2021 17:23, Ashutosh Dixit wrote:
>>>> gem_submission_method() purports to return the currently used submission
>>>> method by the driver, as evidenced by its callers. Therefore remove the
>>>> GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
>>>>
>>>> This also fixes gem_has_execlists() to match its description, previously
>>>> gem_has_execlists() would return true even if GuC submission was actually
>>>> being used in the driver.
>>>>
>>>> Reported-by: John Harrison <john.c.harrison@intel.com>
>>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>>>> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>>>> ---
>>>>    lib/i915/gem_submission.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
>>>> index 2627b802cfb..b037d04cc4a 100644
>>>> --- a/lib/i915/gem_submission.c
>>>> +++ b/lib/i915/gem_submission.c
>>>> @@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
>>>> 		return 0;
>>>> 		if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
>>>> -		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
>>>> +		flags |= GEM_SUBMISSION_GUC;
>>>> 		goto out;
>>>> 	}
>>>>
>>> Looks good to me, but as per the comments in the other thread, this might
>>> have unintended side effects. Have you gone through all instances of the
>>> submission query usages to check how it is used and whether this will break
>>> something? E.g. if something is explicitly testing for execlist support to
>>> mean 'something better than ring buffer' then it would now fail.
>> There are at present just these two instances of gem_has_execlists:
>>
>> *** tests/i915/gem_ctx_shared.c:
>> disjoint_timelines[162]        igt_require(gem_has_execlists(i915));
>>
>> *** tests/i915/gem_watchdog.c:
>> virtual[225]                   igt_require(gem_has_execlists(i915));
>>
>> I'll try to see if I can figure out if they will be affected in any
>> way.
> Actually, earlier these tests were running for both execlists and guc
> submission. If they are meant to run even for guc then they will now skip
> in the guc case after this patch.
>
> Therefore I am thinking the exact equivalent of what was going on earlier
> is this condition:
> 	igt_require(gem_has_execlists() | gem_has_guc_submission());
>
> So that's all that is needed now correct? But what I am not sure of yet is
> whether they were meant to run for guc too or just execlists.
Not sure what the ctx_shared one is about. Possibly that should be some 
kind of 'has_contexts()' test (although I thought ring submission did 
have context support post Gen6?). The watchdog one I would guess should 
be 'has_watchdog()' unless this is some more specific subtest? In 
general, it sounds like the 'has_execlists() || has_guc()' test is 
really 'has_scheduler()', but it really is test specific I think.

John.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-19  7:16       ` John Harrison
@ 2021-10-19  8:39         ` Tvrtko Ursulin
  0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-10-19  8:39 UTC (permalink / raw)
  To: John Harrison, Dixit, Ashutosh; +Cc: igt-dev


On 19/10/2021 08:16, John Harrison wrote:
> On 10/18/2021 17:12, Dixit, Ashutosh wrote:
>> On Mon, 18 Oct 2021 16:59:43 -0700, Dixit, Ashutosh wrote:
>>> On Mon, 18 Oct 2021 16:39:40 -0700, John Harrison wrote:
>>>> On 10/15/2021 17:23, Ashutosh Dixit wrote:
>>>>> gem_submission_method() purports to return the currently used 
>>>>> submission
>>>>> method by the driver, as evidenced by its callers. Therefore remove 
>>>>> the
>>>>> GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
>>>>>
>>>>> This also fixes gem_has_execlists() to match its description, 
>>>>> previously
>>>>> gem_has_execlists() would return true even if GuC submission was 
>>>>> actually
>>>>> being used in the driver.
>>>>>
>>>>> Reported-by: John Harrison <john.c.harrison@intel.com>
>>>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>>>>> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>>>>> ---
>>>>>    lib/i915/gem_submission.c | 2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
>>>>> index 2627b802cfb..b037d04cc4a 100644
>>>>> --- a/lib/i915/gem_submission.c
>>>>> +++ b/lib/i915/gem_submission.c
>>>>> @@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
>>>>>         return 0;
>>>>>         if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
>>>>> -        flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
>>>>> +        flags |= GEM_SUBMISSION_GUC;
>>>>>         goto out;
>>>>>     }
>>>>>
>>>> Looks good to me, but as per the comments in the other thread, this 
>>>> might
>>>> have unintended side effects. Have you gone through all instances of 
>>>> the
>>>> submission query usages to check how it is used and whether this 
>>>> will break
>>>> something? E.g. if something is explicitly testing for execlist 
>>>> support to
>>>> mean 'something better than ring buffer' then it would now fail.
>>> There are at present just these two instances of gem_has_execlists:
>>>
>>> *** tests/i915/gem_ctx_shared.c:
>>> disjoint_timelines[162]        igt_require(gem_has_execlists(i915));
>>>
>>> *** tests/i915/gem_watchdog.c:
>>> virtual[225]                   igt_require(gem_has_execlists(i915));
>>>
>>> I'll try to see if I can figure out if they will be affected in any
>>> way.
>> Actually, earlier these tests were running for both execlists and guc
>> submission. If they are meant to run even for guc then they will now skip
>> in the guc case after this patch.
>>
>> Therefore I am thinking the exact equivalent of what was going on earlier
>> is this condition:
>>     igt_require(gem_has_execlists() | gem_has_guc_submission());
>>
>> So that's all that is needed now correct? But what I am not sure of 
>> yet is
>> whether they were meant to run for guc too or just execlists.
> Not sure what the ctx_shared one is about. Possibly that should be some 
> kind of 'has_contexts()' test (although I thought ring submission did 
> have context support post Gen6?). The watchdog one I would guess should 
> be 'has_watchdog()' unless this is some more specific subtest? In 
> general, it sounds like the 'has_execlists() || has_guc()' test is 
> really 'has_scheduler()', but it really is test specific I think.

Yes, gem_watchdog should keep running both with execlists and GuC. 
Perhaps most correct would be to make it skip if set_load_balance fails 
with an errno which indicates creating virtual engines is not supported?

Gem_ctx_shared/disjoint-timlines could perhaps use gem_uses_ppgtt() (for 
create vm) and gem_scheduler_enabled() for context re-ordering.

Regards,

Tvrtko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-19 18:19 ` John Harrison
@ 2021-10-19 20:40   ` Dixit, Ashutosh
  0 siblings, 0 replies; 11+ messages in thread
From: Dixit, Ashutosh @ 2021-10-19 20:40 UTC (permalink / raw)
  To: John Harrison; +Cc: igt-dev, Tvrtko Ursulin

On Tue, 19 Oct 2021 11:19:36 -0700, John Harrison wrote:
>
> On 10/18/2021 20:17, Ashutosh Dixit wrote:
> > gem_submission_method() purports to return the currently used submission
> > method by the driver, as evidenced by its callers. Therefore remove the
> > GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
> >
> > This also fixes gem_has_execlists() to match its description, previously
> > gem_has_execlists() would return true even if GuC submission was actually
> > being used in the driver.
>
> The thought occurs that while the behaviour might now match the description
> (and the naming of the underlying flag), the function name really matches
> the old behaviour. Maybe the function should also be renamed to
> gem_has_execlist_submission()? Maybe even rename both to
> gem_using_(execlist|guc)_submission() to be properly accurate?
>
> Or is that just over polishing things?

No I agree, might as well change the names too while we are at it. We could
probably have both _has_ and _using_ but I am not see much use for _has_ so
will probably just keep _using_ as you suggest.

> >   diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
> > index ea1b5dd1b8c..f50ef13263f 100644
> > --- a/tests/i915/gem_ctx_shared.c
> > +++ b/tests/i915/gem_ctx_shared.c
> > @@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
> >	uint32_t plug;
> >	uint64_t ahnd;
> >   -	igt_require(gem_has_execlists(i915));
> > +	igt_require(gem_has_execlists(i915) ||
> > gem_has_guc_submission(i915));
>
> I believe Tvrtko is suggesting this one should be a different test entirely:
> > Gem_ctx_shared/disjoint-timlines could perhaps use gem_uses_ppgtt() (for
> create vm)
> > and gem_scheduler_enabled() for context re-ordering

OK, let me go through the mails and see what I come up with in the next
version. Thanks.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
  2021-10-19  3:17 Ashutosh Dixit
@ 2021-10-19 18:19 ` John Harrison
  2021-10-19 20:40   ` Dixit, Ashutosh
  0 siblings, 1 reply; 11+ messages in thread
From: John Harrison @ 2021-10-19 18:19 UTC (permalink / raw)
  To: Ashutosh Dixit, igt-dev; +Cc: Tvrtko Ursulin

On 10/18/2021 20:17, Ashutosh Dixit wrote:
> gem_submission_method() purports to return the currently used submission
> method by the driver, as evidenced by its callers. Therefore remove the
> GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.
>
> This also fixes gem_has_execlists() to match its description, previously
> gem_has_execlists() would return true even if GuC submission was actually
> being used in the driver.
The thought occurs that while the behaviour might now match the 
description (and the naming of the underlying flag), the function name 
really matches the old behaviour. Maybe the function should also be 
renamed to gem_has_execlist_submission()? Maybe even rename both to 
gem_using_(execlist|guc)_submission() to be properly accurate?

Or is that just over polishing things?


>
> v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
>      new code equivalent to the previous code.
>
> Reported-by: John Harrison <john.c.harrison@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>   lib/i915/gem_submission.c   | 2 +-
>   tests/i915/gem_ctx_shared.c | 2 +-
>   tests/i915/gem_watchdog.c   | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
> index 2627b802cfb..b037d04cc4a 100644
> --- a/lib/i915/gem_submission.c
> +++ b/lib/i915/gem_submission.c
> @@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
>   		return 0;
>   
>   	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
> -		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
> +		flags |= GEM_SUBMISSION_GUC;
>   		goto out;
>   	}
>   
> diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
> index ea1b5dd1b8c..f50ef13263f 100644
> --- a/tests/i915/gem_ctx_shared.c
> +++ b/tests/i915/gem_ctx_shared.c
> @@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
>   	uint32_t plug;
>   	uint64_t ahnd;
>   
> -	igt_require(gem_has_execlists(i915));
> +	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
I believe Tvrtko is suggesting this one should be a different test entirely:
 > Gem_ctx_shared/disjoint-timlines could perhaps use gem_uses_ppgtt() 
(for create vm)
 > and gem_scheduler_enabled() for context re-ordering

John.

>   
>   	/*
>   	 * Each context, although they share a vm, are expected to be
> diff --git a/tests/i915/gem_watchdog.c b/tests/i915/gem_watchdog.c
> index db562335a2a..21c7710a806 100644
> --- a/tests/i915/gem_watchdog.c
> +++ b/tests/i915/gem_watchdog.c
> @@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
>   	const intel_ctx_t *ctx[num_engines];
>   	uint64_t ahnd;
>   
> -	igt_require(gem_has_execlists(i915));
> +	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
>   
>   	igt_debug("%u virtual engines\n", num_engines);
>   	igt_require(num_engines);

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method
@ 2021-10-19  3:17 Ashutosh Dixit
  2021-10-19 18:19 ` John Harrison
  0 siblings, 1 reply; 11+ messages in thread
From: Ashutosh Dixit @ 2021-10-19  3:17 UTC (permalink / raw)
  To: igt-dev; +Cc: John Harrison, Tvrtko Ursulin

gem_submission_method() purports to return the currently used submission
method by the driver, as evidenced by its callers. Therefore remove the
GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously
gem_has_execlists() would return true even if GuC submission was actually
being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
    new code equivalent to the previous code.

Reported-by: John Harrison <john.c.harrison@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 lib/i915/gem_submission.c   | 2 +-
 tests/i915/gem_ctx_shared.c | 2 +-
 tests/i915/gem_watchdog.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
index 2627b802cfb..b037d04cc4a 100644
--- a/lib/i915/gem_submission.c
+++ b/lib/i915/gem_submission.c
@@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
 		return 0;
 
 	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
-		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
+		flags |= GEM_SUBMISSION_GUC;
 		goto out;
 	}
 
diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
index ea1b5dd1b8c..f50ef13263f 100644
--- a/tests/i915/gem_ctx_shared.c
+++ b/tests/i915/gem_ctx_shared.c
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
 	uint32_t plug;
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
 	/*
 	 * Each context, although they share a vm, are expected to be
diff --git a/tests/i915/gem_watchdog.c b/tests/i915/gem_watchdog.c
index db562335a2a..21c7710a806 100644
--- a/tests/i915/gem_watchdog.c
+++ b/tests/i915/gem_watchdog.c
@@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
 	const intel_ctx_t *ctx[num_engines];
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
 	igt_debug("%u virtual engines\n", num_engines);
 	igt_require(num_engines);
-- 
2.33.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-10-19 20:40 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-16  0:23 [igt-dev] [PATCH i-g-t] lib/i915: Return actual submission method from gem_submission_method Ashutosh Dixit
2021-10-16  1:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-16  5:45 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-18 23:39 ` [igt-dev] [PATCH i-g-t] " John Harrison
2021-10-18 23:59   ` Dixit, Ashutosh
2021-10-19  0:12     ` Dixit, Ashutosh
2021-10-19  7:16       ` John Harrison
2021-10-19  8:39         ` Tvrtko Ursulin
2021-10-19  3:17 Ashutosh Dixit
2021-10-19 18:19 ` John Harrison
2021-10-19 20:40   ` Dixit, Ashutosh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.