All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libselinux: do not duplicate make target when going into subdirectory
@ 2021-04-22  6:43 Nicolas Iooss
  2021-04-26 11:56 ` Petr Lautrbach
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2021-04-22  6:43 UTC (permalink / raw)
  To: selinux

When running "make install-pywrap", make displays:

    make[1]: Entering directory '/root/selinux/libselinux'
    make -C src install-pywrap install-pywrap
    make[2]: Entering directory '/root/selinux/libselinux/src'

The duplicated "install-pywrap" is not expected. Remove it from the
Makefile.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---
 libselinux/Makefile | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/libselinux/Makefile b/libselinux/Makefile
index ac16c15e8d0a..439bc6a9b7fd 100644
--- a/libselinux/Makefile
+++ b/libselinux/Makefile
@@ -50,24 +50,24 @@ all install relabel clean distclean indent:
 	done
 
 swigify: all
-	$(MAKE) -C src swigify $@
+	$(MAKE) -C src $@
 
 pywrap: 
-	$(MAKE) -C src pywrap $@
+	$(MAKE) -C src $@
 
 rubywrap: 
-	$(MAKE) -C src rubywrap $@
+	$(MAKE) -C src $@
 
 install-pywrap: 
-	$(MAKE) -C src install-pywrap $@
+	$(MAKE) -C src $@
 
 install-rubywrap: 
-	$(MAKE) -C src install-rubywrap $@
+	$(MAKE) -C src $@
 
 clean-pywrap:
-	$(MAKE) -C src clean-pywrap $@
+	$(MAKE) -C src $@
 
 clean-rubywrap:
-	$(MAKE) -C src clean-rubywrap $@
+	$(MAKE) -C src $@
 
 test:
-- 
2.31.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] libselinux: do not duplicate make target when going into subdirectory
  2021-04-22  6:43 [PATCH] libselinux: do not duplicate make target when going into subdirectory Nicolas Iooss
@ 2021-04-26 11:56 ` Petr Lautrbach
  2021-04-30 19:24   ` Nicolas Iooss
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Lautrbach @ 2021-04-26 11:56 UTC (permalink / raw)
  To: Nicolas Iooss, selinux

Nicolas Iooss <nicolas.iooss@m4x.org> writes:

> When running "make install-pywrap", make displays:
>
>     make[1]: Entering directory '/root/selinux/libselinux'
>     make -C src install-pywrap install-pywrap
>     make[2]: Entering directory '/root/selinux/libselinux/src'
>
> The duplicated "install-pywrap" is not expected. Remove it from the
> Makefile.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>

Acked-by: Petr Lautrbach <plautrba@redhat.com>

Thanks!


> ---
>  libselinux/Makefile | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/libselinux/Makefile b/libselinux/Makefile
> index ac16c15e8d0a..439bc6a9b7fd 100644
> --- a/libselinux/Makefile
> +++ b/libselinux/Makefile
> @@ -50,24 +50,24 @@ all install relabel clean distclean indent:
>  	done
>  
>  swigify: all
> -	$(MAKE) -C src swigify $@
> +	$(MAKE) -C src $@
>  
>  pywrap: 
> -	$(MAKE) -C src pywrap $@
> +	$(MAKE) -C src $@
>  
>  rubywrap: 
> -	$(MAKE) -C src rubywrap $@
> +	$(MAKE) -C src $@
>  
>  install-pywrap: 
> -	$(MAKE) -C src install-pywrap $@
> +	$(MAKE) -C src $@
>  
>  install-rubywrap: 
> -	$(MAKE) -C src install-rubywrap $@
> +	$(MAKE) -C src $@
>  
>  clean-pywrap:
> -	$(MAKE) -C src clean-pywrap $@
> +	$(MAKE) -C src $@
>  
>  clean-rubywrap:
> -	$(MAKE) -C src clean-rubywrap $@
> +	$(MAKE) -C src $@
>  
>  test:
> -- 
> 2.31.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libselinux: do not duplicate make target when going into subdirectory
  2021-04-26 11:56 ` Petr Lautrbach
@ 2021-04-30 19:24   ` Nicolas Iooss
  0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Iooss @ 2021-04-30 19:24 UTC (permalink / raw)
  To: Petr Lautrbach; +Cc: SElinux list

On Mon, Apr 26, 2021 at 1:56 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> Nicolas Iooss <nicolas.iooss@m4x.org> writes:
>
> > When running "make install-pywrap", make displays:
> >
> >     make[1]: Entering directory '/root/selinux/libselinux'
> >     make -C src install-pywrap install-pywrap
> >     make[2]: Entering directory '/root/selinux/libselinux/src'
> >
> > The duplicated "install-pywrap" is not expected. Remove it from the
> > Makefile.
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>
> Acked-by: Petr Lautrbach <plautrba@redhat.com>
>
> Thanks!

Applied.

Thanks,
Nicolas
> > ---
> >  libselinux/Makefile | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/libselinux/Makefile b/libselinux/Makefile
> > index ac16c15e8d0a..439bc6a9b7fd 100644
> > --- a/libselinux/Makefile
> > +++ b/libselinux/Makefile
> > @@ -50,24 +50,24 @@ all install relabel clean distclean indent:
> >       done
> >
> >  swigify: all
> > -     $(MAKE) -C src swigify $@
> > +     $(MAKE) -C src $@
> >
> >  pywrap:
> > -     $(MAKE) -C src pywrap $@
> > +     $(MAKE) -C src $@
> >
> >  rubywrap:
> > -     $(MAKE) -C src rubywrap $@
> > +     $(MAKE) -C src $@
> >
> >  install-pywrap:
> > -     $(MAKE) -C src install-pywrap $@
> > +     $(MAKE) -C src $@
> >
> >  install-rubywrap:
> > -     $(MAKE) -C src install-rubywrap $@
> > +     $(MAKE) -C src $@
> >
> >  clean-pywrap:
> > -     $(MAKE) -C src clean-pywrap $@
> > +     $(MAKE) -C src $@
> >
> >  clean-rubywrap:
> > -     $(MAKE) -C src clean-rubywrap $@
> > +     $(MAKE) -C src $@
> >
> >  test:
> > --
> > 2.31.0
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-30 19:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22  6:43 [PATCH] libselinux: do not duplicate make target when going into subdirectory Nicolas Iooss
2021-04-26 11:56 ` Petr Lautrbach
2021-04-30 19:24   ` Nicolas Iooss

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.