* [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
@ 2021-01-08 15:28 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-01-08 15:28 UTC (permalink / raw)
To: intel-gfx
Cc: jani.nikula, Maarten Lankhorst, Ville Syrjälä,
Lyude Paul, stable
The pch_get_backlight(), lpt_get_backlight(), and lpt_set_backlight()
functions operate directly on the hardware registers. If inverting the
value is needed, using intel_panel_compute_brightness(), it should only
be done in the interface between hardware registers and
panel->backlight.level.
The CPU mode takeover code added in commit 5b1ec9ac7ab5
("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the
hardware register and converts to panel->backlight.level correctly,
however the value written back should remain in the hardware register
"domain".
This hasn't been an issue, because GM45 machines are the only known
users of i915.invert_brightness and the brightness invert quirk, and
without one of them no conversion is made. It's likely nobody's ever hit
the problem.
Fixes: 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_panel.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 67f81ae995c4..7a4239d1c241 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -1649,16 +1649,13 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
val = pch_get_backlight(connector);
else
val = lpt_get_backlight(connector);
- val = intel_panel_compute_brightness(connector, val);
- panel->backlight.level = clamp(val, panel->backlight.min,
- panel->backlight.max);
if (cpu_mode) {
drm_dbg_kms(&dev_priv->drm,
"CPU backlight register was enabled, switching to PCH override\n");
/* Write converted CPU PWM value to PCH override register */
- lpt_set_backlight(connector->base.state, panel->backlight.level);
+ lpt_set_backlight(connector->base.state, val);
intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
@@ -1666,6 +1663,10 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
cpu_ctl2 & ~BLM_PWM_ENABLE);
}
+ val = intel_panel_compute_brightness(connector, val);
+ panel->backlight.level = clamp(val, panel->backlight.min,
+ panel->backlight.max);
+
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
@ 2021-01-08 15:28 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-01-08 15:28 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, stable
The pch_get_backlight(), lpt_get_backlight(), and lpt_set_backlight()
functions operate directly on the hardware registers. If inverting the
value is needed, using intel_panel_compute_brightness(), it should only
be done in the interface between hardware registers and
panel->backlight.level.
The CPU mode takeover code added in commit 5b1ec9ac7ab5
("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the
hardware register and converts to panel->backlight.level correctly,
however the value written back should remain in the hardware register
"domain".
This hasn't been an issue, because GM45 machines are the only known
users of i915.invert_brightness and the brightness invert quirk, and
without one of them no conversion is made. It's likely nobody's ever hit
the problem.
Fixes: 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_panel.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 67f81ae995c4..7a4239d1c241 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -1649,16 +1649,13 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
val = pch_get_backlight(connector);
else
val = lpt_get_backlight(connector);
- val = intel_panel_compute_brightness(connector, val);
- panel->backlight.level = clamp(val, panel->backlight.min,
- panel->backlight.max);
if (cpu_mode) {
drm_dbg_kms(&dev_priv->drm,
"CPU backlight register was enabled, switching to PCH override\n");
/* Write converted CPU PWM value to PCH override register */
- lpt_set_backlight(connector->base.state, panel->backlight.level);
+ lpt_set_backlight(connector->base.state, val);
intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
@@ -1666,6 +1663,10 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
cpu_ctl2 & ~BLM_PWM_ENABLE);
}
+ val = intel_panel_compute_brightness(connector, val);
+ panel->backlight.level = clamp(val, panel->backlight.min,
+ panel->backlight.max);
+
return 0;
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
2021-01-08 15:28 ` [Intel-gfx] " Jani Nikula
@ 2021-01-08 19:01 ` Lyude Paul
-1 siblings, 0 replies; 10+ messages in thread
From: Lyude Paul @ 2021-01-08 19:01 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Maarten Lankhorst, Ville Syrjälä, stable
Reviewed-by: Lyude Paul <lyude@redhat.com>
Let me know when you've pushed this upstream and I'll go ahead and send out a
rebased version of my backlight series.
On Fri, 2021-01-08 at 17:28 +0200, Jani Nikula wrote:
> The pch_get_backlight(), lpt_get_backlight(), and lpt_set_backlight()
> functions operate directly on the hardware registers. If inverting the
> value is needed, using intel_panel_compute_brightness(), it should only
> be done in the interface between hardware registers and
> panel->backlight.level.
>
> The CPU mode takeover code added in commit 5b1ec9ac7ab5
> ("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the
> hardware register and converts to panel->backlight.level correctly,
> however the value written back should remain in the hardware register
> "domain".
>
> This hasn't been an issue, because GM45 machines are the only known
> users of i915.invert_brightness and the brightness invert quirk, and
> without one of them no conversion is made. It's likely nobody's ever hit
> the problem.
>
> Fixes: 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: <stable@vger.kernel.org> # v5.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
> b/drivers/gpu/drm/i915/display/intel_panel.c
> index 67f81ae995c4..7a4239d1c241 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1649,16 +1649,13 @@ static int lpt_setup_backlight(struct intel_connector
> *connector, enum pipe unus
> val = pch_get_backlight(connector);
> else
> val = lpt_get_backlight(connector);
> - val = intel_panel_compute_brightness(connector, val);
> - panel->backlight.level = clamp(val, panel->backlight.min,
> - panel->backlight.max);
>
> if (cpu_mode) {
> drm_dbg_kms(&dev_priv->drm,
> "CPU backlight register was enabled, switching to
> PCH override\n");
>
> /* Write converted CPU PWM value to PCH override register */
> - lpt_set_backlight(connector->base.state, panel-
> >backlight.level);
> + lpt_set_backlight(connector->base.state, val);
> intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
> pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
>
> @@ -1666,6 +1663,10 @@ static int lpt_setup_backlight(struct intel_connector
> *connector, enum pipe unus
> cpu_ctl2 & ~BLM_PWM_ENABLE);
> }
>
> + val = intel_panel_compute_brightness(connector, val);
> + panel->backlight.level = clamp(val, panel->backlight.min,
> + panel->backlight.max);
> +
> return 0;
> }
>
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
@ 2021-01-08 19:01 ` Lyude Paul
0 siblings, 0 replies; 10+ messages in thread
From: Lyude Paul @ 2021-01-08 19:01 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: stable
Reviewed-by: Lyude Paul <lyude@redhat.com>
Let me know when you've pushed this upstream and I'll go ahead and send out a
rebased version of my backlight series.
On Fri, 2021-01-08 at 17:28 +0200, Jani Nikula wrote:
> The pch_get_backlight(), lpt_get_backlight(), and lpt_set_backlight()
> functions operate directly on the hardware registers. If inverting the
> value is needed, using intel_panel_compute_brightness(), it should only
> be done in the interface between hardware registers and
> panel->backlight.level.
>
> The CPU mode takeover code added in commit 5b1ec9ac7ab5
> ("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the
> hardware register and converts to panel->backlight.level correctly,
> however the value written back should remain in the hardware register
> "domain".
>
> This hasn't been an issue, because GM45 machines are the only known
> users of i915.invert_brightness and the brightness invert quirk, and
> without one of them no conversion is made. It's likely nobody's ever hit
> the problem.
>
> Fixes: 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: <stable@vger.kernel.org> # v5.1+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
> b/drivers/gpu/drm/i915/display/intel_panel.c
> index 67f81ae995c4..7a4239d1c241 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1649,16 +1649,13 @@ static int lpt_setup_backlight(struct intel_connector
> *connector, enum pipe unus
> val = pch_get_backlight(connector);
> else
> val = lpt_get_backlight(connector);
> - val = intel_panel_compute_brightness(connector, val);
> - panel->backlight.level = clamp(val, panel->backlight.min,
> - panel->backlight.max);
>
> if (cpu_mode) {
> drm_dbg_kms(&dev_priv->drm,
> "CPU backlight register was enabled, switching to
> PCH override\n");
>
> /* Write converted CPU PWM value to PCH override register */
> - lpt_set_backlight(connector->base.state, panel-
> >backlight.level);
> + lpt_set_backlight(connector->base.state, val);
> intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
> pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
>
> @@ -1666,6 +1663,10 @@ static int lpt_setup_backlight(struct intel_connector
> *connector, enum pipe unus
> cpu_ctl2 & ~BLM_PWM_ENABLE);
> }
>
> + val = intel_panel_compute_brightness(connector, val);
> + panel->backlight.level = clamp(val, panel->backlight.min,
> + panel->backlight.max);
> +
> return 0;
> }
>
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/backlight: fix CPU mode backlight takeover on LPT
2021-01-08 15:28 ` [Intel-gfx] " Jani Nikula
(?)
(?)
@ 2021-01-08 19:18 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-01-08 19:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3014 bytes --]
== Series Details ==
Series: drm/i915/backlight: fix CPU mode backlight takeover on LPT
URL : https://patchwork.freedesktop.org/series/85619/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9567 -> Patchwork_19295
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/index.html
Known issues
------------
Here are the changes found in Patchwork_19295 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/fi-kbl-soraka/igt@amdgpu/amd_basic@cs-gfx.html
* igt@fbdev@read:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#402]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/fi-tgl-y/igt@fbdev@read.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/fi-tgl-y/igt@fbdev@read.html
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [DMESG-WARN][4] ([i915#402]) -> [PASS][5] +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_selftest@live@gem:
- fi-kbl-soraka: [DMESG-FAIL][6] -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/fi-kbl-soraka/igt@i915_selftest@live@gem.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/fi-kbl-soraka/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@reset:
- fi-kbl-soraka: [SKIP][8] ([fdo#109271]) -> [PASS][9] +12 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/fi-kbl-soraka/igt@i915_selftest@live@reset.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/fi-kbl-soraka/igt@i915_selftest@live@reset.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (43 -> 38)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9567 -> Patchwork_19295
CI-20190529: 20190529
CI_DRM_9567: 9fc1f6dac2ec9339e390931322768a0286f01f71 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5951: fec3b9c7d88357144f0d7a1447b9316a1c81da1a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19295: 26bee7ddae51ded6388b8cb1d913596eb52bf795 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
26bee7ddae51 drm/i915/backlight: fix CPU mode backlight takeover on LPT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/index.html
[-- Attachment #1.2: Type: text/html, Size: 3873 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/backlight: fix CPU mode backlight takeover on LPT
2021-01-08 15:28 ` [Intel-gfx] " Jani Nikula
` (2 preceding siblings ...)
(?)
@ 2021-01-09 0:08 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-01-09 0:08 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 20974 bytes --]
== Series Details ==
Series: drm/i915/backlight: fix CPU mode backlight takeover on LPT
URL : https://patchwork.freedesktop.org/series/85619/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9567_full -> Patchwork_19295_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19295_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed:
- shard-hsw: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-hsw4/igt@gem_ctx_persistence@engines-mixed.html
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-snb6/igt@gem_ctx_persistence@engines-mixed.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-skl: NOTRUN -> [FAIL][3] ([i915#2389]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@gem_exec_reloc@basic-wide-active@bcs0.html
- shard-hsw: NOTRUN -> [FAIL][4] ([i915#2389]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-hsw7/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][5] ([i915#2389])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@vcs1.html
* igt@gem_exec_whisper@basic-normal-all:
- shard-skl: NOTRUN -> [DMESG-WARN][6] ([i915#1982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl5/igt@gem_exec_whisper@basic-normal-all.html
* igt@gem_media_vme:
- shard-skl: NOTRUN -> [SKIP][7] ([fdo#109271]) +152 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@gem_media_vme.html
* igt@gem_pread@exhaustion:
- shard-hsw: NOTRUN -> [WARN][8] ([i915#2658])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-hsw7/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@process-exit-mmap-busy@uc:
- shard-skl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1699]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@gem_userptr_blits@process-exit-mmap-busy@uc.html
* igt@gem_userptr_blits@process-exit-mmap@wc:
- shard-hsw: NOTRUN -> [SKIP][10] ([fdo#109271]) +259 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-hsw7/igt@gem_userptr_blits@process-exit-mmap@wc.html
* igt@gen7_exec_parse@basic-allocation:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-glk7/igt@gen7_exec_parse@basic-allocation.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-kbl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#658])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl4/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-dpms:
- shard-skl: NOTRUN -> [FAIL][13] ([i915#454])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-hsw: [PASS][14] -> [WARN][15] ([i915#1519])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-hsw7/igt@i915_pm_rc6_residency@rc6-fence.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [PASS][16] -> [FAIL][17] ([i915#2597])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-tglb3/igt@kms_async_flips@test-time-stamp.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +15 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl9/igt@kms_color@pipe-b-ctm-0-25.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl9/igt@kms_color@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-gamma:
- shard-hsw: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +19 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-hsw7/igt@kms_color_chamelium@pipe-d-gamma.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#54]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-128x42-random.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#54]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-random.html
* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-snb: NOTRUN -> [SKIP][25] ([fdo#109271]) +41 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-snb6/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][26] -> [FAIL][27] ([i915#79])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: NOTRUN -> [FAIL][28] ([i915#79]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#2122])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl5/igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#2672])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#2642])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271]) +12 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- shard-skl: NOTRUN -> [FAIL][34] ([i915#49])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#1188])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#533])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [PASS][38] -> [INCOMPLETE][39] ([i915#198])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][40] ([fdo#108145] / [i915#265]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][41] ([fdo#108145] / [i915#265])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][42] ([i915#265])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-iclb2/igt@kms_psr@psr2_suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb7/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-b-query-forked-hang:
- shard-kbl: [PASS][45] -> [DMESG-WARN][46] ([i915#180])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-kbl1/igt@kms_vblank@pipe-b-query-forked-hang.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl2/igt@kms_vblank@pipe-b-query-forked-hang.html
#### Possible fixes ####
* {igt@gem_exec_fair@basic-none@vcs0}:
- shard-kbl: [FAIL][47] ([i915#2842]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
- shard-apl: [FAIL][49] ([i915#2842]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-apl3/igt@gem_exec_fair@basic-none@vcs0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-apl7/igt@gem_exec_fair@basic-none@vcs0.html
* {igt@gem_exec_fair@basic-pace-solo@rcs0}:
- shard-iclb: [FAIL][51] ([i915#2842]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-iclb3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_whisper@basic-contexts-priority:
- shard-glk: [DMESG-WARN][53] ([i915#118] / [i915#95]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-glk4/igt@gem_exec_whisper@basic-contexts-priority.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-glk5/igt@gem_exec_whisper@basic-contexts-priority.html
* igt@gem_linear_blits@interruptible:
- shard-glk: [INCOMPLETE][55] -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-glk5/igt@gem_linear_blits@interruptible.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-glk7/igt@gem_linear_blits@interruptible.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [INCOMPLETE][57] ([i915#2880]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][59] ([i915#454]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][61] ([i915#151]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl5/igt@i915_pm_rpm@system-suspend-execbuf.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl7/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-kbl7/igt@i915_suspend@sysfs-reader.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl4/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-skl: [FAIL][65] ([i915#54]) -> [PASS][66] +4 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [INCOMPLETE][69] ([i915#198]) -> [FAIL][70] ([i915#454])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-skl10/igt@i915_pm_dc@dc6-psr.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-skl2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][71] ([i915#1804] / [i915#2684]) -> [WARN][72] ([i915#2681] / [i915#2684])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][73] ([i915#1804] / [i915#2684]) -> [WARN][74] ([i915#2684])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][75], [FAIL][76]) ([i915#2295]) -> ([FAIL][77], [FAIL][78]) ([i915#2295] / [i915#2426] / [i915#2505])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-kbl7/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-kbl4/igt@runner@aborted.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl6/igt@runner@aborted.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-kbl3/igt@runner@aborted.html
- shard-glk: [FAIL][79] ([i915#2295] / [k.org#202321]) -> ([FAIL][80], [FAIL][81]) ([i915#2295] / [i915#2426] / [k.org#202321])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-glk3/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-glk2/igt@runner@aborted.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-glk8/igt@runner@aborted.html
- shard-tglb: ([FAIL][82], [FAIL][83]) ([i915#1814] / [i915#2295] / [i915#2667] / [i915#456]) -> ([FAIL][84], [FAIL][85], [FAIL][86]) ([i915#1814] / [i915#2295] / [i915#2426] / [i915#2667] / [i915#2803] / [i915#456])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-tglb2/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9567/shard-tglb7/igt@runner@aborted.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-tglb2/igt@runner@aborted.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-tglb8/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/shard-tglb6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1699]: https://gitlab.freedesktop.org/drm/intel/issues/1699
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2880]: https://gitlab.freedesktop.org/drm/intel/issues/2880
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9567 -> Patchwork_19295
CI-20190529: 20190529
CI_DRM_9567: 9fc1f6dac2ec9339e390931322768a0286f01f71 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5951: fec3b9c7d88357144f0d7a1447b9316a1c81da1a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19295: 26bee7ddae51ded6388b8cb1d913596eb52bf795 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19295/index.html
[-- Attachment #1.2: Type: text/html, Size: 26118 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
2021-01-08 19:01 ` [Intel-gfx] " Lyude Paul
@ 2021-01-11 10:03 ` Jani Nikula
-1 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-01-11 10:03 UTC (permalink / raw)
To: lyude, intel-gfx; +Cc: Maarten Lankhorst, Ville Syrjälä, stable
On Fri, 08 Jan 2021, Lyude Paul <lyude@redhat.com> wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> Let me know when you've pushed this upstream and I'll go ahead and send out a
> rebased version of my backlight series.
Pushed, thanks for the review.
I'm hoping to do more review of the series today, so please hold off on
actually sending the rebased version for a bit longer.
BR,
Jani.
>
> On Fri, 2021-01-08 at 17:28 +0200, Jani Nikula wrote:
>> The pch_get_backlight(), lpt_get_backlight(), and lpt_set_backlight()
>> functions operate directly on the hardware registers. If inverting the
>> value is needed, using intel_panel_compute_brightness(), it should only
>> be done in the interface between hardware registers and
>> panel->backlight.level.
>>
>> The CPU mode takeover code added in commit 5b1ec9ac7ab5
>> ("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the
>> hardware register and converts to panel->backlight.level correctly,
>> however the value written back should remain in the hardware register
>> "domain".
>>
>> This hasn't been an issue, because GM45 machines are the only known
>> users of i915.invert_brightness and the brightness invert quirk, and
>> without one of them no conversion is made. It's likely nobody's ever hit
>> the problem.
>>
>> Fixes: 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.")
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Lyude Paul <lyude@redhat.com>
>> Cc: <stable@vger.kernel.org> # v5.1+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_panel.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
>> b/drivers/gpu/drm/i915/display/intel_panel.c
>> index 67f81ae995c4..7a4239d1c241 100644
>> --- a/drivers/gpu/drm/i915/display/intel_panel.c
>> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
>> @@ -1649,16 +1649,13 @@ static int lpt_setup_backlight(struct intel_connector
>> *connector, enum pipe unus
>> val = pch_get_backlight(connector);
>> else
>> val = lpt_get_backlight(connector);
>> - val = intel_panel_compute_brightness(connector, val);
>> - panel->backlight.level = clamp(val, panel->backlight.min,
>> - panel->backlight.max);
>>
>> if (cpu_mode) {
>> drm_dbg_kms(&dev_priv->drm,
>> "CPU backlight register was enabled, switching to
>> PCH override\n");
>>
>> /* Write converted CPU PWM value to PCH override register */
>> - lpt_set_backlight(connector->base.state, panel-
>> >backlight.level);
>> + lpt_set_backlight(connector->base.state, val);
>> intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
>> pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
>>
>> @@ -1666,6 +1663,10 @@ static int lpt_setup_backlight(struct intel_connector
>> *connector, enum pipe unus
>> cpu_ctl2 & ~BLM_PWM_ENABLE);
>> }
>>
>> + val = intel_panel_compute_brightness(connector, val);
>> + panel->backlight.level = clamp(val, panel->backlight.min,
>> + panel->backlight.max);
>> +
>> return 0;
>> }
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
@ 2021-01-11 10:03 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-01-11 10:03 UTC (permalink / raw)
To: lyude, intel-gfx; +Cc: stable
On Fri, 08 Jan 2021, Lyude Paul <lyude@redhat.com> wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> Let me know when you've pushed this upstream and I'll go ahead and send out a
> rebased version of my backlight series.
Pushed, thanks for the review.
I'm hoping to do more review of the series today, so please hold off on
actually sending the rebased version for a bit longer.
BR,
Jani.
>
> On Fri, 2021-01-08 at 17:28 +0200, Jani Nikula wrote:
>> The pch_get_backlight(), lpt_get_backlight(), and lpt_set_backlight()
>> functions operate directly on the hardware registers. If inverting the
>> value is needed, using intel_panel_compute_brightness(), it should only
>> be done in the interface between hardware registers and
>> panel->backlight.level.
>>
>> The CPU mode takeover code added in commit 5b1ec9ac7ab5
>> ("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the
>> hardware register and converts to panel->backlight.level correctly,
>> however the value written back should remain in the hardware register
>> "domain".
>>
>> This hasn't been an issue, because GM45 machines are the only known
>> users of i915.invert_brightness and the brightness invert quirk, and
>> without one of them no conversion is made. It's likely nobody's ever hit
>> the problem.
>>
>> Fixes: 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.")
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Lyude Paul <lyude@redhat.com>
>> Cc: <stable@vger.kernel.org> # v5.1+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_panel.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
>> b/drivers/gpu/drm/i915/display/intel_panel.c
>> index 67f81ae995c4..7a4239d1c241 100644
>> --- a/drivers/gpu/drm/i915/display/intel_panel.c
>> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
>> @@ -1649,16 +1649,13 @@ static int lpt_setup_backlight(struct intel_connector
>> *connector, enum pipe unus
>> val = pch_get_backlight(connector);
>> else
>> val = lpt_get_backlight(connector);
>> - val = intel_panel_compute_brightness(connector, val);
>> - panel->backlight.level = clamp(val, panel->backlight.min,
>> - panel->backlight.max);
>>
>> if (cpu_mode) {
>> drm_dbg_kms(&dev_priv->drm,
>> "CPU backlight register was enabled, switching to
>> PCH override\n");
>>
>> /* Write converted CPU PWM value to PCH override register */
>> - lpt_set_backlight(connector->base.state, panel-
>> >backlight.level);
>> + lpt_set_backlight(connector->base.state, val);
>> intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
>> pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
>>
>> @@ -1666,6 +1663,10 @@ static int lpt_setup_backlight(struct intel_connector
>> *connector, enum pipe unus
>> cpu_ctl2 & ~BLM_PWM_ENABLE);
>> }
>>
>> + val = intel_panel_compute_brightness(connector, val);
>> + panel->backlight.level = clamp(val, panel->backlight.min,
>> + panel->backlight.max);
>> +
>> return 0;
>> }
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
2021-01-11 10:03 ` [Intel-gfx] " Jani Nikula
@ 2021-01-11 19:10 ` Jani Nikula
-1 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-01-11 19:10 UTC (permalink / raw)
To: lyude, intel-gfx; +Cc: Maarten Lankhorst, Ville Syrjälä, stable
On Mon, 11 Jan 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> On Fri, 08 Jan 2021, Lyude Paul <lyude@redhat.com> wrote:
>> Reviewed-by: Lyude Paul <lyude@redhat.com>
>>
>> Let me know when you've pushed this upstream and I'll go ahead and send out a
>> rebased version of my backlight series.
>
> Pushed, thanks for the review.
>
> I'm hoping to do more review of the series today, so please hold off on
> actually sending the rebased version for a bit longer.
Done, go ahead!
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT
@ 2021-01-11 19:10 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-01-11 19:10 UTC (permalink / raw)
To: lyude, intel-gfx; +Cc: stable
On Mon, 11 Jan 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> On Fri, 08 Jan 2021, Lyude Paul <lyude@redhat.com> wrote:
>> Reviewed-by: Lyude Paul <lyude@redhat.com>
>>
>> Let me know when you've pushed this upstream and I'll go ahead and send out a
>> rebased version of my backlight series.
>
> Pushed, thanks for the review.
>
> I'm hoping to do more review of the series today, so please hold off on
> actually sending the rebased version for a bit longer.
Done, go ahead!
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-01-11 19:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 15:28 [PATCH] drm/i915/backlight: fix CPU mode backlight takeover on LPT Jani Nikula
2021-01-08 15:28 ` [Intel-gfx] " Jani Nikula
2021-01-08 19:01 ` Lyude Paul
2021-01-08 19:01 ` [Intel-gfx] " Lyude Paul
2021-01-11 10:03 ` Jani Nikula
2021-01-11 10:03 ` [Intel-gfx] " Jani Nikula
2021-01-11 19:10 ` Jani Nikula
2021-01-11 19:10 ` [Intel-gfx] " Jani Nikula
2021-01-08 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-09 0:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.