All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH master] package/linux-headers: the latest headers are 5.8
@ 2020-09-09 10:25 Thomas Petazzoni
  2020-09-09 10:49 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2020-09-09 10:25 UTC (permalink / raw)
  To: buildroot

In commit c2009e9f757fe759c74406f1025967b7b8e77f0a
("package/linux-headers: license files hashes only valid for latest
version"), we introduced BR2_KERNEL_HEADERS_LATEST, which should only
be set for the most recent kernel headers versions.

Indeed, the COPYING file of Linux has changed before/after Linux 5.6,
causing its hash file to be different. Since linux-headers uses
linux/linux.hash as the hash file, and this hash file contains the
COPYING hash of Linux >= 5.6, we cannot use that hash for Linux
versions older than 5.6.

When newer versions of the headers than 5.4 were added, this
BR2_KERNEL_HEADERS_LATEST was not moved as it should have been. We fix
this, which fixes a legal-info failure happening when Linux kernel
headers 5.4 are used:

>>> linux-headers 5.4.63 Patching
>>> linux-headers 5.4.63 Collecting legal info
ERROR: COPYING has wrong sha256 hash:
ERROR: expected: fb5a425bd3b3cd6071a3a9aff9909a859e7c1158d54d32e07658398cd67eb6a0
ERROR: got     : ee5808b032a67f587d3541099d46de34f5bec8cd5976114ba07f1299ee6001ff
ERROR: Incomplete download, or man-in-the-middle (MITM) attack

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/linux-headers/Config.in.host | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/linux-headers/Config.in.host b/package/linux-headers/Config.in.host
index c1e169988b..0d92dfada7 100644
--- a/package/linux-headers/Config.in.host
+++ b/package/linux-headers/Config.in.host
@@ -53,11 +53,11 @@ config BR2_KERNEL_HEADERS_4_19
 config BR2_KERNEL_HEADERS_5_4
 	bool "Linux 5.4.x kernel headers"
 	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_4
-	select BR2_KERNEL_HEADERS_LATEST
 
 config BR2_KERNEL_HEADERS_5_8
 	bool "Linux 5.8.x kernel headers"
 	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8
+	select BR2_KERNEL_HEADERS_LATEST
 
 config BR2_KERNEL_HEADERS_VERSION
 	bool "Manually specified Linux version"
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH master] package/linux-headers: the latest headers are 5.8
  2020-09-09 10:25 [Buildroot] [PATCH master] package/linux-headers: the latest headers are 5.8 Thomas Petazzoni
@ 2020-09-09 10:49 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2020-09-09 10:49 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > In commit c2009e9f757fe759c74406f1025967b7b8e77f0a
 > ("package/linux-headers: license files hashes only valid for latest
 > version"), we introduced BR2_KERNEL_HEADERS_LATEST, which should only
 > be set for the most recent kernel headers versions.

 > Indeed, the COPYING file of Linux has changed before/after Linux 5.6,
 > causing its hash file to be different. Since linux-headers uses
 > linux/linux.hash as the hash file, and this hash file contains the
 > COPYING hash of Linux >= 5.6, we cannot use that hash for Linux
 > versions older than 5.6.

 > When newer versions of the headers than 5.4 were added, this
 > BR2_KERNEL_HEADERS_LATEST was not moved as it should have been. We fix
 > this, which fixes a legal-info failure happening when Linux kernel
 > headers 5.4 are used:

 >>>> linux-headers 5.4.63 Patching
 >>>> linux-headers 5.4.63 Collecting legal info
 > ERROR: COPYING has wrong sha256 hash:
 > ERROR: expected: fb5a425bd3b3cd6071a3a9aff9909a859e7c1158d54d32e07658398cd67eb6a0
 > ERROR: got     : ee5808b032a67f587d3541099d46de34f5bec8cd5976114ba07f1299ee6001ff
 > ERROR: Incomplete download, or man-in-the-middle (MITM) attack

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-09 10:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 10:25 [Buildroot] [PATCH master] package/linux-headers: the latest headers are 5.8 Thomas Petazzoni
2020-09-09 10:49 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.