From: Michael Ellerman <mpe@ellerman.id.au> To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton <akpm@linux-foundation.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Thiago Jung Bauermann <bauerman@linux.ibm.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Anshuman Khandual <khandual@linux.vnet.ibm.com>, Oliver O'Halloran <oohall@gmail.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, "Enrico Weigelt\, metux IT consult" <info@metux.net>, Thomas Gleixner <tglx@linutronix.de>, Allison Randal <allison@lohutok.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Pavel Tatashin <pasha.tatashin@soleen.com>, Arun KS <arunks@codeaurora.org>, Todd Kjos <tkjos@google.com>, Christian Brauner <christian@brauner.io>, Gao Xiang <xiang@kernel.org>, Greg Hackmann <ghackmann@google.com>, David Howells <dhowells@redhat.com> Subject: Re: [PATCH v1 08/12] powerpc/pseries: CMM: Implement balloon compaction Date: Tue, 12 Nov 2019 21:46:59 +1100 [thread overview] Message-ID: <87blth2wyk.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <be7c1424-f240-b72c-8d6d-310ebbd816e1@redhat.com> David Hildenbrand <david@redhat.com> writes: > On 31.10.19 15:29, David Hildenbrand wrote: >> We can now get rid of the cmm_lock and completely rely on the balloon >> compaction internals, which now also manage the page list and the lock. ... >> + >> +static int cmm_migratepage(struct balloon_dev_info *b_dev_info, >> + struct page *newpage, struct page *page, >> + enum migrate_mode mode) >> +{ >> + unsigned long flags; >> + >> + /* >> + * loan/"inflate" the newpage first. >> + * >> + * We might race against the cmm_thread who might discover after our >> + * loan request that another page is to be unloaned. However, once >> + * the cmm_thread runs again later, this error will automatically >> + * be corrected. >> + */ >> + if (plpar_page_set_loaned(newpage)) { >> + /* Unlikely, but possible. Tell the caller not to retry now. */ >> + pr_err_ratelimited("%s: Cannot set page to loaned.", __func__); >> + return -EBUSY; >> + } >> + >> + /* balloon page list reference */ >> + get_page(newpage); >> + >> + spin_lock_irqsave(&b_dev_info->pages_lock, flags); >> + balloon_page_insert(b_dev_info, newpage); >> + balloon_page_delete(page); > > I think I am missing a b_dev_info->isolated_pages-- here. I don't know this code at all, but looking at other balloon drivers they do seem to do that in roughly the same spot. I'll add it, how can we test that it's correct? cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au> To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>, Oliver O'Halloran <oohall@gmail.com>, Pavel Tatashin <pasha.tatashin@soleen.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, Gao Xiang <xiang@kernel.org>, Greg Hackmann <ghackmann@google.com>, David Howells <dhowells@redhat.com>, linux-mm@kvack.org, Arun KS <arunks@codeaurora.org>, Paul Mackerras <paulus@samba.org>, Allison Randal <allison@lohutok.net>, Christian Brauner <christian@brauner.io>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Morton <akpm@linux-foundation.org>, Todd Kjos <tkjos@google.com>, linuxppc-dev@lists.ozlabs.org, Thomas Gleixner <tglx@linutronix.de>, Thiago Jung Bauermann <bauerman@linux.ibm.com>, Anshuman Khandual <khandual@linux.vnet.ibm.com> Subject: Re: [PATCH v1 08/12] powerpc/pseries: CMM: Implement balloon compaction Date: Tue, 12 Nov 2019 21:46:59 +1100 [thread overview] Message-ID: <87blth2wyk.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <be7c1424-f240-b72c-8d6d-310ebbd816e1@redhat.com> David Hildenbrand <david@redhat.com> writes: > On 31.10.19 15:29, David Hildenbrand wrote: >> We can now get rid of the cmm_lock and completely rely on the balloon >> compaction internals, which now also manage the page list and the lock. ... >> + >> +static int cmm_migratepage(struct balloon_dev_info *b_dev_info, >> + struct page *newpage, struct page *page, >> + enum migrate_mode mode) >> +{ >> + unsigned long flags; >> + >> + /* >> + * loan/"inflate" the newpage first. >> + * >> + * We might race against the cmm_thread who might discover after our >> + * loan request that another page is to be unloaned. However, once >> + * the cmm_thread runs again later, this error will automatically >> + * be corrected. >> + */ >> + if (plpar_page_set_loaned(newpage)) { >> + /* Unlikely, but possible. Tell the caller not to retry now. */ >> + pr_err_ratelimited("%s: Cannot set page to loaned.", __func__); >> + return -EBUSY; >> + } >> + >> + /* balloon page list reference */ >> + get_page(newpage); >> + >> + spin_lock_irqsave(&b_dev_info->pages_lock, flags); >> + balloon_page_insert(b_dev_info, newpage); >> + balloon_page_delete(page); > > I think I am missing a b_dev_info->isolated_pages-- here. I don't know this code at all, but looking at other balloon drivers they do seem to do that in roughly the same spot. I'll add it, how can we test that it's correct? cheers
next prev parent reply other threads:[~2019-11-12 10:47 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-31 14:29 [PATCH v1 00/12] powerpc/pseries: CMM: Implement balloon compaction and remove isolate notifier David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-11-14 9:08 ` Michael Ellerman 2019-11-14 9:08 ` Michael Ellerman 2019-11-14 12:21 ` David Hildenbrand 2019-11-14 12:21 ` David Hildenbrand 2019-11-20 10:35 ` David Hildenbrand 2019-11-20 10:35 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 02/12] powerpc/pseries: CMM: Report errors when registering notifiers fails David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 03/12] powerpc/pseries: CMM: Cleanup rc handling in cmm_init() David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 04/12] powerpc/pseries: CMM: Drop page array David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 05/12] powerpc/pseries: CMM: Use adjust_managed_page_count() insted of totalram_pages_* David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 06/12] powerpc/pseries: CMM: Rip out memory isolate notifier David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 07/12] powerpc/pseries: CMM: Convert loaned_pages to an atomic_long_t David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 08/12] powerpc/pseries: CMM: Implement balloon compaction David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:35 ` David Hildenbrand 2019-10-31 14:35 ` David Hildenbrand 2019-11-12 10:46 ` Michael Ellerman [this message] 2019-11-12 10:46 ` Michael Ellerman 2019-11-12 11:12 ` David Hildenbrand 2019-11-12 11:12 ` David Hildenbrand 2019-11-13 11:08 ` Michael Ellerman 2019-11-13 11:08 ` Michael Ellerman 2019-10-31 14:29 ` [PATCH v1 09/12] powerpc/pseries: CMM: Switch to balloon_page_alloc() David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 10/12] powerpc/pseries: CMM: Simulation mode David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 11/12] mm: remove the memory isolate notifier David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand 2019-10-31 14:29 ` [PATCH v1 12/12] mm: remove "count" parameter from has_unmovable_pages() David Hildenbrand 2019-10-31 14:29 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87blth2wyk.fsf@mpe.ellerman.id.au \ --to=mpe@ellerman.id.au \ --cc=aik@ozlabs.ru \ --cc=akpm@linux-foundation.org \ --cc=allison@lohutok.net \ --cc=arunks@codeaurora.org \ --cc=bauerman@linux.ibm.com \ --cc=benh@kernel.crashing.org \ --cc=christian@brauner.io \ --cc=david@redhat.com \ --cc=dhowells@redhat.com \ --cc=geert@linux-m68k.org \ --cc=ghackmann@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=info@metux.net \ --cc=khandual@linux.vnet.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=oohall@gmail.com \ --cc=pasha.tatashin@soleen.com \ --cc=paulus@samba.org \ --cc=tglx@linutronix.de \ --cc=tkjos@google.com \ --cc=xiang@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.