All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW
@ 2018-10-18 19:31 Gabriel Krisman Bertazi
  2018-10-19  7:28 ` Hans de Goede
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Krisman Bertazi @ 2018-10-18 19:31 UTC (permalink / raw)
  To: gustavo, maarten.lankhorst, sean, j.w.r.degoede
  Cc: kernel, Gabriel Krisman Bertazi, dri-devel

I just got a new GDP Win2 device with an updated firmware, which still
requires this quirk to get the rotation right, so add the new firmware
date to the quirk matching table.

This should go to drm-misc-next.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 280a41d33081..b0bf5a55ae9a 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -57,7 +57,7 @@ static const struct drm_dmi_panel_orientation_data gpd_win2 = {
 	.width = 720,
 	.height = 1280,
 	.bios_dates = (const char * const []){
-		"12/07/2017", "05/24/2018", NULL },
+		"12/07/2017", "05/24/2018", "06/29/2018", NULL },
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW
  2018-10-18 19:31 [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW Gabriel Krisman Bertazi
@ 2018-10-19  7:28 ` Hans de Goede
  2018-11-09 15:36   ` Gabriel Krisman Bertazi
  0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2018-10-19  7:28 UTC (permalink / raw)
  To: Gabriel Krisman Bertazi, gustavo, maarten.lankhorst, sean
  Cc: kernel, dri-devel

Hi,

On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
> I just got a new GDP Win2 device with an updated firmware, which still
> requires this quirk to get the rotation right, so add the new firmware
> date to the quirk matching table.
> 
> This should go to drm-misc-next.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

Thanks for the patch and this looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 280a41d33081..b0bf5a55ae9a 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -57,7 +57,7 @@ static const struct drm_dmi_panel_orientation_data gpd_win2 = {
>   	.width = 720,
>   	.height = 1280,
>   	.bios_dates = (const char * const []){
> -		"12/07/2017", "05/24/2018", NULL },
> +		"12/07/2017", "05/24/2018", "06/29/2018", NULL },
>   	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>   };
>   
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW
  2018-10-19  7:28 ` Hans de Goede
@ 2018-11-09 15:36   ` Gabriel Krisman Bertazi
  2018-11-15 10:05     ` Maarten Lankhorst
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Krisman Bertazi @ 2018-11-09 15:36 UTC (permalink / raw)
  To: Hans de Goede; +Cc: sean, kernel, dri-devel

Hans de Goede <hdegoede@redhat.com> writes:

> Hi,
>
> On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
>> I just got a new GDP Win2 device with an updated firmware, which still
>> requires this quirk to get the rotation right, so add the new firmware
>> date to the quirk matching table.
>>
>> This should go to drm-misc-next.
>>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>
> Thanks for the patch and this looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Hello,

I suspect this might have drown into the void and never got
applied. can someone merge this?

Sorry if it was applied already.  Couldn't find in any of
the -next or -fixes branches.

Thanks,

-- 
Gabriel Krisman Bertazi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW
  2018-11-09 15:36   ` Gabriel Krisman Bertazi
@ 2018-11-15 10:05     ` Maarten Lankhorst
  0 siblings, 0 replies; 4+ messages in thread
From: Maarten Lankhorst @ 2018-11-15 10:05 UTC (permalink / raw)
  To: Gabriel Krisman Bertazi, Hans de Goede; +Cc: kernel, sean, dri-devel

Op 09-11-18 om 16:36 schreef Gabriel Krisman Bertazi:
> Hans de Goede <hdegoede@redhat.com> writes:
>
>> Hi,
>>
>> On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
>>> I just got a new GDP Win2 device with an updated firmware, which still
>>> requires this quirk to get the rotation right, so add the new firmware
>>> date to the quirk matching table.
>>>
>>> This should go to drm-misc-next.
>>>
>>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>> Thanks for the patch and this looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Hello,
>
> I suspect this might have drown into the void and never got
> applied. can someone merge this?
>
> Sorry if it was applied already.  Couldn't find in any of
> the -next or -fixes branches.
>
> Thanks,
>
Looks like this fell through. I pushed it to drm-misc-next.

Thanks for the patch,

~Maarten

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-15 10:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 19:31 [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW Gabriel Krisman Bertazi
2018-10-19  7:28 ` Hans de Goede
2018-11-09 15:36   ` Gabriel Krisman Bertazi
2018-11-15 10:05     ` Maarten Lankhorst

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.