From: Punit Agrawal <punit.agrawal@arm.com> To: kvmarm@lists.cs.columbia.edu Cc: marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>, will.deacon@arm.com, linux-kernel@vger.kernel.org, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7.1 9/9] KVM: arm64: Add support for creating PUD hugepages at stage 2 Date: Mon, 01 Oct 2018 15:00:38 +0100 [thread overview] Message-ID: <87bm8dn4vt.fsf@e105922-lin.cambridge.arm.com> (raw) In-Reply-To: <20180925143731.27475-1-punit.agrawal@arm.com> (Punit Agrawal's message of "Tue, 25 Sep 2018 15:37:31 +0100") Punit Agrawal <punit.agrawal@arm.com> writes: > KVM only supports PMD hugepages at stage 2. Now that the various page > handling routines are updated, extend the stage 2 fault handling to > map in PUD hugepages. > > Addition of PUD hugepage support enables additional page sizes (e.g., > 1G with 4K granule) which can be useful on cores that support mapping > larger block sizes in the TLB entries. > > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com> > Cc: Christoffer Dall <christoffer.dall@arm.com> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > --- > > v7 -> v7.1 > > * Added arm helper kvm_stage2_has_pud() > * Added check for PUD level present at stage 2 > * Dropped redundant comment > * Fixed up kvm_pud_mkhuge() to complain on arm > > arch/arm/include/asm/kvm_mmu.h | 20 +++++ > arch/arm/include/asm/stage2_pgtable.h | 5 ++ > arch/arm64/include/asm/kvm_mmu.h | 16 ++++ > arch/arm64/include/asm/pgtable-hwdef.h | 2 + > arch/arm64/include/asm/pgtable.h | 2 + > virt/kvm/arm/mmu.c | 106 +++++++++++++++++++++++-- > 6 files changed, 145 insertions(+), 6 deletions(-) > [...] > diff --git a/arch/arm/include/asm/stage2_pgtable.h b/arch/arm/include/asm/stage2_pgtable.h > index f6a7ea805232..ec1567d9eb4b 100644 > --- a/arch/arm/include/asm/stage2_pgtable.h > +++ b/arch/arm/include/asm/stage2_pgtable.h > @@ -68,4 +68,9 @@ stage2_pmd_addr_end(struct kvm *kvm, phys_addr_t addr, phys_addr_t end) > #define stage2_pmd_table_empty(kvm, pmdp) kvm_page_empty(pmdp) > #define stage2_pud_table_empty(kvm, pudp) false > > +static inline bool kvm_stage2_has_pud(struct kvm *kvm) > +{ > + return KVM_VTCR_SL0 == VTCR_SL_L1; > +} > + Turns out this isn't quite the right check. On arm32, the maximum number of supported levels is 3 with LPAE - effectively the helper should always return false. I've updated the check locally to key off of CONFIG_PGTABLE_LEVELS. I'll post these patches later today. Thanks, Punit
WARNING: multiple messages have this Message-ID (diff)
From: punit.agrawal@arm.com (Punit Agrawal) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7.1 9/9] KVM: arm64: Add support for creating PUD hugepages at stage 2 Date: Mon, 01 Oct 2018 15:00:38 +0100 [thread overview] Message-ID: <87bm8dn4vt.fsf@e105922-lin.cambridge.arm.com> (raw) In-Reply-To: <20180925143731.27475-1-punit.agrawal@arm.com> (Punit Agrawal's message of "Tue, 25 Sep 2018 15:37:31 +0100") Punit Agrawal <punit.agrawal@arm.com> writes: > KVM only supports PMD hugepages at stage 2. Now that the various page > handling routines are updated, extend the stage 2 fault handling to > map in PUD hugepages. > > Addition of PUD hugepage support enables additional page sizes (e.g., > 1G with 4K granule) which can be useful on cores that support mapping > larger block sizes in the TLB entries. > > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com> > Cc: Christoffer Dall <christoffer.dall@arm.com> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > --- > > v7 -> v7.1 > > * Added arm helper kvm_stage2_has_pud() > * Added check for PUD level present at stage 2 > * Dropped redundant comment > * Fixed up kvm_pud_mkhuge() to complain on arm > > arch/arm/include/asm/kvm_mmu.h | 20 +++++ > arch/arm/include/asm/stage2_pgtable.h | 5 ++ > arch/arm64/include/asm/kvm_mmu.h | 16 ++++ > arch/arm64/include/asm/pgtable-hwdef.h | 2 + > arch/arm64/include/asm/pgtable.h | 2 + > virt/kvm/arm/mmu.c | 106 +++++++++++++++++++++++-- > 6 files changed, 145 insertions(+), 6 deletions(-) > [...] > diff --git a/arch/arm/include/asm/stage2_pgtable.h b/arch/arm/include/asm/stage2_pgtable.h > index f6a7ea805232..ec1567d9eb4b 100644 > --- a/arch/arm/include/asm/stage2_pgtable.h > +++ b/arch/arm/include/asm/stage2_pgtable.h > @@ -68,4 +68,9 @@ stage2_pmd_addr_end(struct kvm *kvm, phys_addr_t addr, phys_addr_t end) > #define stage2_pmd_table_empty(kvm, pmdp) kvm_page_empty(pmdp) > #define stage2_pud_table_empty(kvm, pudp) false > > +static inline bool kvm_stage2_has_pud(struct kvm *kvm) > +{ > + return KVM_VTCR_SL0 == VTCR_SL_L1; > +} > + Turns out this isn't quite the right check. On arm32, the maximum number of supported levels is 3 with LPAE - effectively the helper should always return false. I've updated the check locally to key off of CONFIG_PGTABLE_LEVELS. I'll post these patches later today. Thanks, Punit
next prev parent reply other threads:[~2018-10-01 14:00 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-24 17:45 [PATCH v7 0/9] KVM: Support PUD hugepages at stage 2 Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 1/9] KVM: arm/arm64: Ensure only THP is candidate for adjustment Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 20:54 ` Suzuki K Poulose 2018-09-24 20:54 ` Suzuki K Poulose 2018-09-24 17:45 ` [PATCH v7 2/9] KVM: arm/arm64: Share common code in user_mem_abort() Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 3/9] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 4/9] KVM: arm/arm64: Introduce helpers to manipulate page table entries Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 5/9] KVM: arm64: Support dirty page tracking for PUD hugepages Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 6/9] KVM: arm64: Support PUD hugepage in stage2_is_exec() Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 7/9] KVM: arm64: Support handling access faults for PUD hugepages Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 8/9] KVM: arm64: Update age handlers to support " Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 17:45 ` [PATCH v7 9/9] KVM: arm64: Add support for creating PUD hugepages at stage 2 Punit Agrawal 2018-09-24 17:45 ` Punit Agrawal 2018-09-24 21:21 ` Suzuki K Poulose 2018-09-24 21:21 ` Suzuki K Poulose 2018-09-25 9:21 ` Punit Agrawal 2018-09-25 9:21 ` Punit Agrawal 2018-09-25 9:21 ` Punit Agrawal 2018-09-25 14:37 ` [PATCH v7.1 " Punit Agrawal 2018-09-25 14:37 ` Punit Agrawal 2018-10-01 14:00 ` Punit Agrawal [this message] 2018-10-01 14:00 ` Punit Agrawal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87bm8dn4vt.fsf@e105922-lin.cambridge.arm.com \ --to=punit.agrawal@arm.com \ --cc=catalin.marinas@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=marc.zyngier@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.