* [PATCH] posix-timers: Prevent broadcast signals
@ 2018-04-27 9:34 Sebastian Andrzej Siewior
2018-04-27 16:16 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-04-27 9:34 UTC (permalink / raw)
To: linux-kernel
Cc: Eric W . Biederman , Thomas Gleixner, Sebastian Andrzej Siewior
From: Thomas Gleixner <tglx@linutronix.de>
Posix timers should not send broadcast signals and kernel only
signals. Prevent it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
kernel/time/posix-timers.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index b6899b5060bd..4c4cbebb0d71 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -435,6 +435,7 @@ static enum hrtimer_restart posix_timer_fn(struct hrtimer *timer)
static struct pid *good_sigevent(sigevent_t * event)
{
struct task_struct *rtn = current->group_leader;
+ int sig = event->sigev_signo;
switch (event->sigev_notify) {
case SIGEV_SIGNAL | SIGEV_THREAD_ID:
@@ -444,7 +445,8 @@ static struct pid *good_sigevent(sigevent_t * event)
/* FALLTHRU */
case SIGEV_SIGNAL:
case SIGEV_THREAD:
- if (event->sigev_signo <= 0 || event->sigev_signo > SIGRTMAX)
+ if (sig <= 0 || sig > SIGRTMAX ||
+ sig_kernel_only(sig) || sig_kernel_coredump(sig))
return NULL;
/* FALLTHRU */
case SIGEV_NONE:
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] posix-timers: Prevent broadcast signals
2018-04-27 9:34 [PATCH] posix-timers: Prevent broadcast signals Sebastian Andrzej Siewior
@ 2018-04-27 16:16 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2018-04-27 16:16 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-kernel, Thomas Gleixner
Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Posix timers should not send broadcast signals and kernel only
> signals. Prevent it.
You are not adding prevention of ``broadcast'' signals by preventing
sig_kernel_only and sig_kernel_coredump so your change description does
not make sense.
Second we are sending the signal to ourselves. It may be silly to use
a timer to send SIGKILL or SIGSTOP but I can imagine some reasons.
For signals that might coredump if you setup a handler they won't
coredump so preventing those seems even sillier.
So what is the reason for changing which signals posix timers send?
If SIGEV_THREAD_ID is specificied I can understand not wanting
to send signals that could affect more than just a thread.
if SIGEV_THREAD is specified I can understand not wanting signals
that will do more than wake up the thread. I presume glibc precreates
the thread.
Neither of those cases should apply to everything passing through
good_sigevent. So your code is wrong if those are your justification.
Further the kernel is perfectly capable of delivering all types of
signal through send_sigqueue so there is no techincal reason for
preventing these signals.
Eric
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> kernel/time/posix-timers.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
> index b6899b5060bd..4c4cbebb0d71 100644
> --- a/kernel/time/posix-timers.c
> +++ b/kernel/time/posix-timers.c
> @@ -435,6 +435,7 @@ static enum hrtimer_restart posix_timer_fn(struct hrtimer *timer)
> static struct pid *good_sigevent(sigevent_t * event)
> {
> struct task_struct *rtn = current->group_leader;
> + int sig = event->sigev_signo;
>
> switch (event->sigev_notify) {
> case SIGEV_SIGNAL | SIGEV_THREAD_ID:
> @@ -444,7 +445,8 @@ static struct pid *good_sigevent(sigevent_t * event)
> /* FALLTHRU */
> case SIGEV_SIGNAL:
> case SIGEV_THREAD:
> - if (event->sigev_signo <= 0 || event->sigev_signo > SIGRTMAX)
> + if (sig <= 0 || sig > SIGRTMAX ||
> + sig_kernel_only(sig) || sig_kernel_coredump(sig))
> return NULL;
> /* FALLTHRU */
> case SIGEV_NONE:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-27 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 9:34 [PATCH] posix-timers: Prevent broadcast signals Sebastian Andrzej Siewior
2018-04-27 16:16 ` Eric W. Biederman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.