[Buildroot] [PATCH] fs/tar: make --no-recursion effective

[Buildroot] [PATCH] fs/tar: make --no-recursion effective

[Baruch Siach]

The tar --no-recursion option is position sensitive. It only affects following
file listing options. Move --no-recursion before the -T option to make it
effective. This fixes duplication of entries in the generated rootfs.tar
archive.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 fs/tar/tar.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/tar/tar.mk b/fs/tar/tar.mk
index b14c977d761c..0e3eacbedf05 100644
--- a/fs/tar/tar.mk
+++ b/fs/tar/tar.mk
@@ -8,7 +8,7 @@ TAR_OPTS := $(call qstrip,$(BR2_TARGET_ROOTFS_TAR_OPTIONS))
 
 define ROOTFS_TAR_CMD
 	(cd $(TARGET_DIR); find -print0 | LC_ALL=C sort -z | \
-		tar $(TAR_OPTS) -cf $@ --null -T - --no-recursion --numeric-owner)
+		tar $(TAR_OPTS) -cf $@ --null --no-recursion -T - --numeric-owner)
 endef
 
 $(eval $(call ROOTFS_TARGET,tar))
-- 
2.11.0

[Buildroot] [PATCH] fs/tar: make --no-recursion effective

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > The tar --no-recursion option is position sensitive. It only affects following
 > file listing options. Move --no-recursion before the -T option to make it
 > effective. This fixes duplication of entries in the generated rootfs.tar
 > archive.

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

I got a bit confused by this, as the manual explicitly shows the -T -
--no-recursion sequence:

https://www.gnu.org/software/tar/manual/html_section/tar_54.html

But indeed, tar -tvf output/images/rootfs.tar | grep '/usr/$' had 2 hits
before, and not after applying this patch - So committed, thanks!

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] fs/tar: make --no-recursion effective

[Baruch Siach]

Hi Peter,

On Wed, Dec 28, 2016 at 10:21:26AM +0100, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> 
>  > The tar --no-recursion option is position sensitive. It only affects following
>  > file listing options. Move --no-recursion before the -T option to make it
>  > effective. This fixes duplication of entries in the generated rootfs.tar
>  > archive.
> 
>  > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> I got a bit confused by this, as the manual explicitly shows the -T -
> --no-recursion sequence:
> 
> https://www.gnu.org/software/tar/manual/html_section/tar_54.html

That part of the tar manual looks wrong. The "Position-Sensitive Options"[1] 
section shows this example to illustrate the position sensitivity concept:

  tar -cf a.tar --recursion /usr --no-recursion /var/*

[1] https://www.gnu.org/software/tar/manual/html_section/tar_22.html#SEC44

> But indeed, tar -tvf output/images/rootfs.tar | grep '/usr/$' had 2 hits
> before, and not after applying this patch - So committed, thanks!

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH] fs/tar: make --no-recursion effective

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

Hi,

 >> I got a bit confused by this, as the manual explicitly shows the -T -
 >> --no-recursion sequence:
 >> 
 >> https://www.gnu.org/software/tar/manual/html_section/tar_54.html

 > That part of the tar manual looks wrong. The "Position-Sensitive Options"[1] 
 > section shows this example to illustrate the position sensitivity concept:

 >   tar -cf a.tar --recursion /usr --no-recursion /var/*

 > [1] https://www.gnu.org/software/tar/manual/html_section/tar_22.html#SEC44

Ahh, ok - Thanks.

-- 
Bye, Peter Korsgaard