All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: ak4642: Replace mdelay function to msleep
       [not found]                             ` <HK2PR06MB1235B7DA8F97119F90296F4ABE930@HK2PR06MB1235.apcprd06.prod.outlook.com>
@ 2016-12-21  3:55                               ` Kuninori Morimoto
  2016-12-31 18:52                                 ` Mark Brown
  2017-01-10  2:13                               ` Kuninori Morimoto
  1 sibling, 1 reply; 5+ messages in thread
From: Kuninori Morimoto @ 2016-12-21  3:55 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux-ALSA, NAOYA SHIIBA, Hisao Munakata, TOSHIAKI KOMATSU,
	Yusuke Goda, Simon, YOSHIYUKI ITO, Tsuyoshi Tsumuraya,
	HARUNOBU KUROKAWA, RYO KODAMA

From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>

Replace mdelay to msleep to avoid busy loop on ak4642_lout_event().
Otherwise, sometimes playback doesn't work correctly when pulseaudio
was used.

Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
---
 sound/soc/codecs/ak4642.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 40500cd..0205ae1 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -186,7 +186,7 @@ static int ak4642_lout_event(struct snd_soc_dapm_widget *w,
 		break;
 	case SND_SOC_DAPM_POST_PMU:	/* after widget power up */
 		/* Power save mode OFF */
-		mdelay(popup_wait);
+		msleep(popup_wait);
 		snd_soc_update_bits(codec, SG_SL2, LOPS, 0);
 		break;
 	case SND_SOC_DAPM_PRE_PMD:	/* before widget power down */
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ak4642: Replace mdelay function to msleep
  2016-12-21  3:55                               ` [PATCH] ASoC: ak4642: Replace mdelay function to msleep Kuninori Morimoto
@ 2016-12-31 18:52                                 ` Mark Brown
  2017-01-10  2:12                                   ` Kuninori Morimoto
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2016-12-31 18:52 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Linux-ALSA, NAOYA SHIIBA, Hisao Munakata, TOSHIAKI KOMATSU,
	Yusuke Goda, Simon, YOSHIYUKI ITO, Tsuyoshi Tsumuraya,
	HARUNOBU KUROKAWA, RYO KODAMA


[-- Attachment #1.1: Type: text/plain, Size: 535 bytes --]

On Wed, Dec 21, 2016 at 03:55:11AM +0000, Kuninori Morimoto wrote:
> From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
> 
> Replace mdelay to msleep to avoid busy loop on ak4642_lout_event().
> Otherwise, sometimes playback doesn't work correctly when pulseaudio
> was used.
> 
> Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
> ---

I can't do anything with this without a signoff from you Morimoto-san as
it is required for licensing reasons, please see SubmittingPatches for
full details.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ak4642: Replace mdelay function to msleep
  2016-12-31 18:52                                 ` Mark Brown
@ 2017-01-10  2:12                                   ` Kuninori Morimoto
  0 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2017-01-10  2:12 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux-ALSA, NAOYA SHIIBA, Hisao Munakata, TOSHIAKI KOMATSU,
	Yusuke Goda, Simon, YOSHIYUKI ITO, Tsuyoshi Tsumuraya,
	HARUNOBU KUROKAWA, RYO KODAMA


Hi Mark

> > From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
> > 
> > Replace mdelay to msleep to avoid busy loop on ak4642_lout_event().
> > Otherwise, sometimes playback doesn't work correctly when pulseaudio
> > was used.
> > 
> > Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
> > ---
> 
> I can't do anything with this without a signoff from you Morimoto-san as
> it is required for licensing reasons, please see SubmittingPatches for
> full details.

Oops, thank you for pointing it.
I will re-post it soon

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] ASoC: ak4642: Replace mdelay function to msleep
       [not found]                             ` <HK2PR06MB1235B7DA8F97119F90296F4ABE930@HK2PR06MB1235.apcprd06.prod.outlook.com>
  2016-12-21  3:55                               ` [PATCH] ASoC: ak4642: Replace mdelay function to msleep Kuninori Morimoto
@ 2017-01-10  2:13                               ` Kuninori Morimoto
  2017-01-10 12:24                                 ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Kuninori Morimoto @ 2017-01-10  2:13 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux-ALSA, NAOYA SHIIBA, Hisao Munakata, TOSHIAKI KOMATSU,
	Yusuke Goda, Simon, YOSHIYUKI ITO, Tsuyoshi Tsumuraya,
	HARUNOBU KUROKAWA, RYO KODAMA

From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>

Replace mdelay to msleep to avoid busy loop on ak4642_lout_event().
Otherwise, sometimes playback doesn't work correctly when pulseaudio
was used.

Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/codecs/ak4642.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 40500cd..0205ae1 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -186,7 +186,7 @@ static int ak4642_lout_event(struct snd_soc_dapm_widget *w,
 		break;
 	case SND_SOC_DAPM_POST_PMU:	/* after widget power up */
 		/* Power save mode OFF */
-		mdelay(popup_wait);
+		msleep(popup_wait);
 		snd_soc_update_bits(codec, SG_SL2, LOPS, 0);
 		break;
 	case SND_SOC_DAPM_PRE_PMD:	/* before widget power down */
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ak4642: Replace mdelay function to msleep
  2017-01-10  2:13                               ` Kuninori Morimoto
@ 2017-01-10 12:24                                 ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-01-10 12:24 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Linux-ALSA, NAOYA SHIIBA, Hisao Munakata, TOSHIAKI KOMATSU,
	Yusuke Goda, Simon, YOSHIYUKI ITO, Tsuyoshi Tsumuraya,
	HARUNOBU KUROKAWA, RYO KODAMA


[-- Attachment #1.1: Type: text/plain, Size: 379 bytes --]

On Tue, Jan 10, 2017 at 02:13:04AM +0000, Kuninori Morimoto wrote:

>  	case SND_SOC_DAPM_POST_PMU:	/* after widget power up */
>  		/* Power save mode OFF */
> -		mdelay(popup_wait);
> +		msleep(popup_wait);
>  		snd_soc_update_bits(codec, SG_SL2, LOPS, 0);
>  		break;

This doesn't apply against current code, the driver appears to have a
fixed delay here not a variable one?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-10 12:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <KL1PR06MB1558D289757F434A9C6618C7BE900@KL1PR06MB1558.apcprd06.prod.outlook.com>
     [not found] ` <HK2PR06MB1092794596913BC4287D1BB4C5900@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]   ` <KL1PR06MB15580C36E2CCEE0609270003BE900@KL1PR06MB1558.apcprd06.prod.outlook.com>
     [not found]     ` <HK2PR06MB1235F138E73E5BE0A1BB9EA1BE900@HK2PR06MB1235.apcprd06.prod.outlook.com>
     [not found]       ` <HK2PR06MB1092041371630C232825868AC5900@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]         ` <HK2PR06MB10929196AD848D2221AA65D3C5900@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]           ` <878trbb3gx.wl%kuninori.morimoto.gx@renesas.com>
     [not found]             ` <HK2PR06MB123504946F7D9CBFA0445A74BE900@HK2PR06MB1235.apcprd06.prod.outlook.com>
     [not found]               ` <HK2PR06MB1092F11AFF71BCF6CFE41CE6C5900@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]                 ` <HK2PR06MB1235B6435DA88D1DEEFF37FBBE900@HK2PR06MB1235.apcprd06.prod.outlook.com>
     [not found]                   ` <874m1zay9v.wl%kuninori.morimoto.gx@renesas.com>
     [not found]                     ` <HK2PR06MB1092376B43150072E37148DBC5900@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]                       ` <HK2PR06MB10928AA734902EC15D19EE50C5900@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]                         ` <87k2auxk40.wl%kuninori.morimoto.gx@renesas.com>
     [not found]                           ` <HK2PR06MB109231252C5BD2F3CD6A7E93C5930@HK2PR06MB1092.apcprd06.prod.outlook.com>
     [not found]                             ` <HK2PR06MB1235B7DA8F97119F90296F4ABE930@HK2PR06MB1235.apcprd06.prod.outlook.com>
2016-12-21  3:55                               ` [PATCH] ASoC: ak4642: Replace mdelay function to msleep Kuninori Morimoto
2016-12-31 18:52                                 ` Mark Brown
2017-01-10  2:12                                   ` Kuninori Morimoto
2017-01-10  2:13                               ` Kuninori Morimoto
2017-01-10 12:24                                 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.