All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Dave Stevenson <linux-rpi-kernel@destevenson.freeserve.co.uk>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Wahren <stefan.wahren@i2se.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Russell King <linux@armlinux.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.
Date: Mon, 12 Sep 2016 23:09:30 -0700	[thread overview]
Message-ID: <87bmzse3fp.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <7f432ebf-78d9-9089-f79d-d0584de89887@destevenson.freeserve.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

Dave Stevenson <linux-rpi-kernel@destevenson.freeserve.co.uk> writes:

> On 09/09/16 22:20, Eric Anholt wrote:
>> e<#secure method=pgpmime mode=sign>
>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>
>>>    Hi,
>>>
>>>> According to this page [1] the pinctrl group for parallel display interface is
>>>> missing. Is it intended?
>>>>
>>>> [1] - http://elinux.org/RPi_BCM2835_GPIOs
>>> Just an oversight I guess.  Eric?
>>>
>>> Does this look correct?
>>>
>>> +                       dpi_gpio4: dpi_gpio4 {
>>> +                               brcm,pins = <4 5 6 7 8 9 10 11 12 13
>>> +                                            14 15 16 17 18 19 20 21
>>> +                                            22 23 24 25 26 27>;
>>> +                               brcm,function = <BCM2835_FSEL_ALT2>;
>>> +                       };
>> For DPI, you also need pins 0-3 in there for clock and syncs.
>>
>> That set of data pins would be for a 24-bit mode, which is what we
>> should be using for the Adafruit kippah + 7" panel combo.
> The Kippah is only 18bit, RGB666.
> https://www.adafruit.com/products/2454
> "The pins used are GPIO 2 through 21 inclusive. That means you don't get 
> the UART RX/TX pins (no console cable) and you don't get the standard 
> user I2C pins, the EEPROM I2C pins, or hardware SPI pins. You do get to 
> use pins #22, #23, #24, #25, #26 and #27, and the USB ports are fine to 
> use too."

I was confused because my pinctrl was set up for 18, but the panel
driver for it is set up for 24.  It looks like 18 is right, so I should
probably correct the panel driver.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.
Date: Mon, 12 Sep 2016 23:09:30 -0700	[thread overview]
Message-ID: <87bmzse3fp.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <7f432ebf-78d9-9089-f79d-d0584de89887@destevenson.freeserve.co.uk>

Dave Stevenson <linux-rpi-kernel@destevenson.freeserve.co.uk> writes:

> On 09/09/16 22:20, Eric Anholt wrote:
>> e<#secure method=pgpmime mode=sign>
>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>
>>>    Hi,
>>>
>>>> According to this page [1] the pinctrl group for parallel display interface is
>>>> missing. Is it intended?
>>>>
>>>> [1] - http://elinux.org/RPi_BCM2835_GPIOs
>>> Just an oversight I guess.  Eric?
>>>
>>> Does this look correct?
>>>
>>> +                       dpi_gpio4: dpi_gpio4 {
>>> +                               brcm,pins = <4 5 6 7 8 9 10 11 12 13
>>> +                                            14 15 16 17 18 19 20 21
>>> +                                            22 23 24 25 26 27>;
>>> +                               brcm,function = <BCM2835_FSEL_ALT2>;
>>> +                       };
>> For DPI, you also need pins 0-3 in there for clock and syncs.
>>
>> That set of data pins would be for a 24-bit mode, which is what we
>> should be using for the Adafruit kippah + 7" panel combo.
> The Kippah is only 18bit, RGB666.
> https://www.adafruit.com/products/2454
> "The pins used are GPIO 2 through 21 inclusive. That means you don't get 
> the UART RX/TX pins (no console cable) and you don't get the standard 
> user I2C pins, the EEPROM I2C pins, or hardware SPI pins. You do get to 
> use pins #22, #23, #24, #25, #26 and #27, and the USB ports are fine to 
> use too."

I was confused because my pinctrl was set up for 18, but the panel
driver for it is set up for 24.  It looks like 18 is right, so I should
probably correct the panel driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160912/a143f3d2/attachment.sig>

  reply	other threads:[~2016-09-13 15:32 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 10:31 [PATCH 0/8] ARM: dts: bcm283x: add and use pinctrl groups Gerd Hoffmann
2016-09-07 10:31 ` Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 1/8] ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 18:09   ` Stefan Wahren
2016-09-07 18:09     ` Stefan Wahren
2016-09-07 18:09     ` Stefan Wahren
2016-09-07 18:50     ` Eric Anholt
2016-09-07 18:50       ` Eric Anholt
2016-09-08  7:48       ` Gerd Hoffmann
2016-09-08  7:48         ` Gerd Hoffmann
2016-09-08  7:48         ` Gerd Hoffmann
2016-09-08 17:55   ` Stefan Wahren
2016-09-08 17:55     ` Stefan Wahren
2016-09-08 17:55     ` Stefan Wahren
2016-09-09  9:05     ` Gerd Hoffmann
2016-09-09  9:05       ` Gerd Hoffmann
2016-09-09  9:05       ` Gerd Hoffmann
2016-09-09 14:12       ` Stefan Wahren
2016-09-09 14:12         ` Stefan Wahren
2016-09-09 14:12         ` Stefan Wahren
2016-09-09 21:20       ` Eric Anholt
2016-09-09 21:20         ` Eric Anholt
2016-09-09 21:20         ` Eric Anholt
2016-09-11 21:22         ` Dave Stevenson
2016-09-11 21:22           ` Dave Stevenson
2016-09-13  6:09           ` Eric Anholt [this message]
2016-09-13  6:09             ` Eric Anholt
2016-09-07 10:31 ` [PATCH 2/8] ARM: dts: bcm283x: Add the emmc pin group to bcm283x.dtsi Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 3/8] ARM: dts: bcm283x: Add a group for mapping pins 48-53 to sdhost Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 18:13   ` Stefan Wahren
2016-09-07 18:13     ` Stefan Wahren
2016-09-08  7:44     ` Gerd Hoffmann
2016-09-08  7:44       ` Gerd Hoffmann
2016-09-08 12:06       ` Stefan Wahren
2016-09-08 12:06         ` Stefan Wahren
2016-09-09  8:26         ` Gerd Hoffmann
2016-09-09  8:26           ` Gerd Hoffmann
2016-09-09  8:47           ` Gerd Hoffmann
2016-09-09  8:47             ` Gerd Hoffmann
2016-09-09  8:47             ` Gerd Hoffmann
2016-09-08 19:50       ` Scott Branden
2016-09-08 19:50         ` Scott Branden
2016-09-08 19:50         ` Scott Branden
2016-09-09  6:58         ` Stefan Wahren
2016-09-09  6:58           ` Stefan Wahren
2016-09-09  6:58           ` Stefan Wahren
2016-09-09 16:37           ` Scott Branden
2016-09-09 16:37             ` Scott Branden
2016-09-09 16:37             ` Scott Branden
2016-09-09 21:22     ` Eric Anholt
2016-09-09 21:22       ` Eric Anholt
2016-09-07 10:31 ` [PATCH 5/8] ARM: dts: bcm283x: add pinctrl group to &pwm, drop pins from &gpio Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 6/8] ARM: dts: bcm283x: add pinctrl group to &i2c0, " Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 7/8] ARM: dts: bcm283x: add pinctrl group to &i2c1, " Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 8/8] ARM: dts: bcm283x: add pinctrl group to &sdhci, " Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann
2016-09-07 10:31   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmzse3fp.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@destevenson.freeserve.co.uk \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.