From: ebiederm@xmission.com (Eric W. Biederman)
To: Kees Cook <keescook@chromium.org>
Cc: "Andy Lutomirski" <luto@amacapital.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Richard Weinberger" <richard@nod.at>,
"Robert Święcki" <robert@swiecki.net>,
"Dmitry Vyukov" <dvyukov@google.com>,
"David Howells" <dhowells@redhat.com>,
"Miklos Szeredi" <mszeredi@suse.cz>,
"Kostya Serebryany" <kcc@google.com>,
"Alexander Potapenko" <glider@google.com>,
"Eric Dumazet" <edumazet@google.com>,
"Sasha Levin" <sasha.levin@oracle.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled
Date: Mon, 25 Jan 2016 13:33:49 -0600 [thread overview]
Message-ID: <87bn89sbc2.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <CAGXu5jJ6fQ5E17jKoC3kFZ0RgbcNLuzW6zdunaXV+jiQPSo+Lg@mail.gmail.com> (Kees Cook's message of "Mon, 25 Jan 2016 10:56:41 -0800")
Kees Cook <keescook@chromium.org> writes:
>
> Well, I don't know about less weird, but it would leave a unneeded
> hole in the permission checks.
To be clear the current patch has my:
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
The code is buggy, and poorly thought through. Your lack of interest in
fixing the bugs in your patch is distressing.
So broken code, not willing to fix. No. We are not merging this sysctl.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Kees Cook <keescook@chromium.org>
Cc: "Andy Lutomirski" <luto@amacapital.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Richard Weinberger" <richard@nod.at>,
"Robert Święcki" <robert@swiecki.net>,
"Dmitry Vyukov" <dvyukov@google.com>,
"David Howells" <dhowells@redhat.com>,
"Miklos Szeredi" <mszeredi@suse.cz>,
"Kostya Serebryany" <kcc@google.com>,
"Alexander Potapenko" <glider@google.com>,
"Eric Dumazet" <edumazet@google.com>,
"Sasha Levin" <sasha.levin@oracle.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: [kernel-hardening] Re: [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled
Date: Mon, 25 Jan 2016 13:33:49 -0600 [thread overview]
Message-ID: <87bn89sbc2.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <CAGXu5jJ6fQ5E17jKoC3kFZ0RgbcNLuzW6zdunaXV+jiQPSo+Lg@mail.gmail.com> (Kees Cook's message of "Mon, 25 Jan 2016 10:56:41 -0800")
Kees Cook <keescook@chromium.org> writes:
>
> Well, I don't know about less weird, but it would leave a unneeded
> hole in the permission checks.
To be clear the current patch has my:
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
The code is buggy, and poorly thought through. Your lack of interest in
fixing the bugs in your patch is distressing.
So broken code, not willing to fix. No. We are not merging this sysctl.
Eric
next prev parent reply other threads:[~2016-01-25 19:51 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 22:39 [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled Kees Cook
2016-01-22 22:39 ` [kernel-hardening] " Kees Cook
2016-01-22 22:39 ` [PATCH 1/2] sysctl: expand use of proc_dointvec_minmax_sysadmin Kees Cook
2016-01-22 22:39 ` [kernel-hardening] " Kees Cook
2016-01-23 3:10 ` Eric W. Biederman
2016-01-23 3:10 ` [kernel-hardening] " Eric W. Biederman
2016-01-23 22:25 ` Jann Horn
2016-01-24 1:20 ` Eric W. Biederman
2016-01-24 1:43 ` Al Viro
2016-01-24 1:56 ` Jann Horn
2016-01-24 6:02 ` Eric W. Biederman
2016-01-24 6:32 ` Jann Horn
2016-01-24 6:44 ` Eric W. Biederman
2016-01-22 22:39 ` [PATCH 2/2] sysctl: allow CLONE_NEWUSER to be disabled Kees Cook
2016-01-22 22:39 ` [kernel-hardening] " Kees Cook
2016-01-22 22:47 ` Robert Święcki
2016-01-22 22:47 ` [kernel-hardening] " Robert Święcki
2016-01-22 22:50 ` Kees Cook
2016-01-22 22:50 ` [kernel-hardening] " Kees Cook
2016-01-22 22:55 ` Robert Święcki
2016-01-22 22:55 ` [kernel-hardening] " Robert Święcki
2016-01-22 23:00 ` Kees Cook
2016-01-22 23:00 ` [kernel-hardening] " Kees Cook
2016-01-23 0:44 ` Serge Hallyn
2016-01-23 0:44 ` [kernel-hardening] " Serge Hallyn
2016-01-23 0:44 ` Serge Hallyn
2016-01-23 0:44 ` [kernel-hardening] " Serge Hallyn
2016-01-23 0:59 ` Ben Hutchings
2016-01-24 20:59 ` Kees Cook
2016-01-24 20:59 ` Kees Cook
2016-01-24 22:20 ` Andy Lutomirski
2016-01-25 18:51 ` Kees Cook
2016-01-22 22:49 ` [PATCH 0/2] " Richard Weinberger
2016-01-22 22:49 ` [kernel-hardening] " Richard Weinberger
2016-01-23 3:02 ` Eric W. Biederman
2016-01-23 3:02 ` [kernel-hardening] " Eric W. Biederman
2016-01-24 20:57 ` Kees Cook
2016-01-24 20:57 ` [kernel-hardening] " Kees Cook
2016-01-26 7:38 ` Serge Hallyn
2016-01-24 22:22 ` Andy Lutomirski
2016-01-24 22:22 ` [kernel-hardening] " Andy Lutomirski
2016-01-25 18:51 ` Kees Cook
2016-01-25 18:51 ` [kernel-hardening] " Kees Cook
2016-01-25 18:53 ` Andy Lutomirski
2016-01-25 18:53 ` [kernel-hardening] " Andy Lutomirski
2016-01-25 18:56 ` Kees Cook
2016-01-25 18:56 ` [kernel-hardening] " Kees Cook
2016-01-25 19:33 ` Eric W. Biederman [this message]
2016-01-25 19:33 ` Eric W. Biederman
2016-01-25 22:34 ` Kees Cook
2016-01-25 22:34 ` [kernel-hardening] " Kees Cook
2016-01-25 23:33 ` Andy Lutomirski
2016-01-25 23:33 ` [kernel-hardening] " Andy Lutomirski
2016-01-26 2:27 ` Daniel Micay
2016-01-26 4:57 ` Eric W. Biederman
2016-01-26 4:57 ` [kernel-hardening] " Eric W. Biederman
2016-01-26 14:38 ` Josh Boyer
2016-01-26 14:38 ` [kernel-hardening] " Josh Boyer
2016-01-26 14:46 ` Austin S. Hemmelgarn
2016-01-26 14:46 ` [kernel-hardening] " Austin S. Hemmelgarn
2016-01-26 14:56 ` Josh Boyer
2016-01-26 14:56 ` [kernel-hardening] " Josh Boyer
2016-01-26 17:20 ` Serge Hallyn
2016-01-26 19:56 ` Josh Boyer
2016-01-26 20:11 ` Austin S. Hemmelgarn
2016-01-26 17:15 ` Serge Hallyn
2016-01-26 18:09 ` Austin S. Hemmelgarn
2016-01-26 18:27 ` Andy Lutomirski
2016-01-26 18:45 ` Austin S. Hemmelgarn
2016-01-26 23:15 ` Kees Cook
2016-01-26 23:13 ` Kees Cook
2016-01-27 10:27 ` Eric W. Biederman
2016-01-27 12:32 ` Austin S. Hemmelgarn
2016-01-28 14:41 ` Robert Święcki
2016-01-28 14:41 ` Robert Święcki
2016-01-26 23:47 ` Josh Boyer
2016-01-26 16:37 ` Kees Cook
2016-01-26 16:37 ` [kernel-hardening] " Kees Cook
2016-01-28 8:56 ` Serge E. Hallyn
2016-01-28 12:53 ` Austin S. Hemmelgarn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn89sbc2.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mszeredi@suse.cz \
--cc=richard@nod.at \
--cc=robert@swiecki.net \
--cc=sasha.levin@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.