* [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors
@ 2013-01-18 17:45 Jeff Cody
2013-01-18 18:08 ` Markus Armbruster
2013-01-18 19:37 ` Luiz Capitulino
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Cody @ 2013-01-18 17:45 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, armbru, stefanha, lcapitulino
The non-live bdrv_commit() function may return one of the following
errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is
checked in the HMP handler is -EBUSY, so the monitor command 'commit'
silently fails for all error cases other than 'Device is in use'.
Report error using monitor_printf() and strerror(), and convert existing
qerror_report() calls in do_commit() to monitor_printf().
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
blockdev.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index d724e2d..cb3b426 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -642,21 +642,17 @@ void do_commit(Monitor *mon, const QDict *qdict)
if (!strcmp(device, "all")) {
ret = bdrv_commit_all();
- if (ret == -EBUSY) {
- qerror_report(QERR_DEVICE_IN_USE, device);
- return;
- }
} else {
bs = bdrv_find(device);
if (!bs) {
- qerror_report(QERR_DEVICE_NOT_FOUND, device);
+ monitor_printf(mon, "Device '%s' not found\n", device);
return;
}
ret = bdrv_commit(bs);
- if (ret == -EBUSY) {
- qerror_report(QERR_DEVICE_IN_USE, device);
- return;
- }
+ }
+ if (ret < 0) {
+ monitor_printf(mon, "'commit' error for '%s': %s\n", device,
+ strerror(-ret));
}
}
--
1.8.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors
2013-01-18 17:45 [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors Jeff Cody
@ 2013-01-18 18:08 ` Markus Armbruster
2013-01-18 19:37 ` Luiz Capitulino
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2013-01-18 18:08 UTC (permalink / raw)
To: Jeff Cody; +Cc: kwolf, qemu-devel, stefanha, lcapitulino
Jeff Cody <jcody@redhat.com> writes:
> The non-live bdrv_commit() function may return one of the following
> errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is
> checked in the HMP handler is -EBUSY, so the monitor command 'commit'
> silently fails for all error cases other than 'Device is in use'.
>
> Report error using monitor_printf() and strerror(), and convert existing
> qerror_report() calls in do_commit() to monitor_printf().
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors
2013-01-18 17:45 [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors Jeff Cody
2013-01-18 18:08 ` Markus Armbruster
@ 2013-01-18 19:37 ` Luiz Capitulino
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Capitulino @ 2013-01-18 19:37 UTC (permalink / raw)
To: Jeff Cody; +Cc: kwolf, qemu-devel, stefanha, armbru
On Fri, 18 Jan 2013 12:45:35 -0500
Jeff Cody <jcody@redhat.com> wrote:
> The non-live bdrv_commit() function may return one of the following
> errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is
> checked in the HMP handler is -EBUSY, so the monitor command 'commit'
> silently fails for all error cases other than 'Device is in use'.
>
> Report error using monitor_printf() and strerror(), and convert existing
> qerror_report() calls in do_commit() to monitor_printf().
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Applied to the qmp branch, thanks.
> ---
> blockdev.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index d724e2d..cb3b426 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -642,21 +642,17 @@ void do_commit(Monitor *mon, const QDict *qdict)
>
> if (!strcmp(device, "all")) {
> ret = bdrv_commit_all();
> - if (ret == -EBUSY) {
> - qerror_report(QERR_DEVICE_IN_USE, device);
> - return;
> - }
> } else {
> bs = bdrv_find(device);
> if (!bs) {
> - qerror_report(QERR_DEVICE_NOT_FOUND, device);
> + monitor_printf(mon, "Device '%s' not found\n", device);
> return;
> }
> ret = bdrv_commit(bs);
> - if (ret == -EBUSY) {
> - qerror_report(QERR_DEVICE_IN_USE, device);
> - return;
> - }
> + }
> + if (ret < 0) {
> + monitor_printf(mon, "'commit' error for '%s': %s\n", device,
> + strerror(-ret));
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-18 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-18 17:45 [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors Jeff Cody
2013-01-18 18:08 ` Markus Armbruster
2013-01-18 19:37 ` Luiz Capitulino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.