All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] linux: add a comment about CONFIG_EXTRA_FIRMWARE requirement
@ 2022-05-05  3:20 Baruch Siach via buildroot
  2022-05-05 21:00 ` Arnout Vandecappelle
  2022-05-28  9:03 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach via buildroot @ 2022-05-05  3:20 UTC (permalink / raw)
  To: buildroot; +Cc: Charlie Leger

Explain why the kernel needs firmware packages as build time
dependencies.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 linux/linux.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/linux/linux.mk b/linux/linux.mk
index 7ff7b05042e4..e0a1ff74f998 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -70,7 +70,11 @@ LINUX_MAKE_ENV = \
 	BR_BINARIES_DIR=$(BINARIES_DIR)
 
 LINUX_INSTALL_IMAGES = YES
-LINUX_DEPENDENCIES = host-kmod \
+LINUX_DEPENDENCIES = host-kmod
+
+# The kernel CONFIG_EXTRA_FIRMWARE feature requires firmware files at build
+# time. Make sure they are available before the kernel builds.
+LINUX_DEPENDENCIES += \
 	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
 	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
 	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] linux: add a comment about CONFIG_EXTRA_FIRMWARE requirement
  2022-05-05  3:20 [Buildroot] [PATCH] linux: add a comment about CONFIG_EXTRA_FIRMWARE requirement Baruch Siach via buildroot
@ 2022-05-05 21:00 ` Arnout Vandecappelle
  2022-05-28  9:03 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-05-05 21:00 UTC (permalink / raw)
  To: Baruch Siach, buildroot; +Cc: Charlie Leger



On 05/05/2022 05:20, Baruch Siach via buildroot wrote:
> Explain why the kernel needs firmware packages as build time
> dependencies.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   linux/linux.mk | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 7ff7b05042e4..e0a1ff74f998 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -70,7 +70,11 @@ LINUX_MAKE_ENV = \
>   	BR_BINARIES_DIR=$(BINARIES_DIR)
>   
>   LINUX_INSTALL_IMAGES = YES
> -LINUX_DEPENDENCIES = host-kmod \
> +LINUX_DEPENDENCIES = host-kmod
> +
> +# The kernel CONFIG_EXTRA_FIRMWARE feature requires firmware files at build
> +# time. Make sure they are available before the kernel builds.
> +LINUX_DEPENDENCIES += \
>   	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>   	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
>   	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] linux: add a comment about CONFIG_EXTRA_FIRMWARE requirement
  2022-05-05  3:20 [Buildroot] [PATCH] linux: add a comment about CONFIG_EXTRA_FIRMWARE requirement Baruch Siach via buildroot
  2022-05-05 21:00 ` Arnout Vandecappelle
@ 2022-05-28  9:03 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-05-28  9:03 UTC (permalink / raw)
  To: Baruch Siach via buildroot; +Cc: buildroot, Charlie Leger

>>>>> "Baruch" == Baruch Siach via buildroot <buildroot@buildroot.org> writes:

 > Explain why the kernel needs firmware packages as build time
 > dependencies.

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-28  9:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05  3:20 [Buildroot] [PATCH] linux: add a comment about CONFIG_EXTRA_FIRMWARE requirement Baruch Siach via buildroot
2022-05-05 21:00 ` Arnout Vandecappelle
2022-05-28  9:03 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.