* [Buildroot] [PATCH 1/1] package/python-pyudev: fix build with python 2
@ 2021-09-03 21:45 Fabrice Fontaine
2021-09-04 9:24 ` Peter Korsgaard
2021-09-10 11:12 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-09-03 21:45 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Thomas Petazzoni, Asaf Kahlon
Build with python 2 is broken since bump to version 0.22.0 in commit
0adb141d342707ca9a478f57f187e38d5bb716f2:
error: File "/usr/lib/python2.7/site-packages/pyudev/_ctypeslib/utils.py", line 54
lib = cdll.LoadLibrary(f'lib{name}.so')
^
SyntaxError: invalid syntax
Fixes:
- http://autobuild.buildroot.org/results/8b35ca6910dfd881953968f8d88ac842d57c9262
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...Workaround-finding-libudev-on-systems-without-ldconf.patch | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/python-pyudev/0001-Workaround-finding-libudev-on-systems-without-ldconf.patch b/package/python-pyudev/0001-Workaround-finding-libudev-on-systems-without-ldconf.patch
index 67c2766496..d798f836a5 100644
--- a/package/python-pyudev/0001-Workaround-finding-libudev-on-systems-without-ldconf.patch
+++ b/package/python-pyudev/0001-Workaround-finding-libudev-on-systems-without-ldconf.patch
@@ -13,6 +13,8 @@ https://github.com/pyudev/pyudev/pull/117
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
[Marcin: adjust to 0.22.0]
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
+[Fabrice: Use %-formatting instead of f-string for python 2]
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
src/pyudev/_ctypeslib/utils.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
@@ -37,7 +39,7 @@ index 9dffb3c..aa9942f 100644
- library_name = find_library(name)
- if not library_name:
+ try:
-+ lib = cdll.LoadLibrary(f'lib{name}.so')
++ lib = cdll.LoadLibrary('lib%s.so' % name)
+ except OSError:
raise ImportError('No library named %s' % name)
- lib = CDLL(library_name, use_errno=True)
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-pyudev: fix build with python 2
2021-09-03 21:45 [Buildroot] [PATCH 1/1] package/python-pyudev: fix build with python 2 Fabrice Fontaine
@ 2021-09-04 9:24 ` Peter Korsgaard
2021-09-10 11:12 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-09-04 9:24 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Asaf Kahlon, Thomas Petazzoni, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Build with python 2 is broken since bump to version 0.22.0 in commit
> 0adb141d342707ca9a478f57f187e38d5bb716f2:
> error: File "/usr/lib/python2.7/site-packages/pyudev/_ctypeslib/utils.py", line 54
> lib = cdll.LoadLibrary(f'lib{name}.so')
> ^
> SyntaxError: invalid syntax
> Fixes:
> - http://autobuild.buildroot.org/results/8b35ca6910dfd881953968f8d88ac842d57c9262
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-pyudev: fix build with python 2
2021-09-03 21:45 [Buildroot] [PATCH 1/1] package/python-pyudev: fix build with python 2 Fabrice Fontaine
2021-09-04 9:24 ` Peter Korsgaard
@ 2021-09-10 11:12 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-09-10 11:12 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Asaf Kahlon, Thomas Petazzoni, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Build with python 2 is broken since bump to version 0.22.0 in commit
> 0adb141d342707ca9a478f57f187e38d5bb716f2:
> error: File "/usr/lib/python2.7/site-packages/pyudev/_ctypeslib/utils.py", line 54
> lib = cdll.LoadLibrary(f'lib{name}.so')
> ^
> SyntaxError: invalid syntax
> Fixes:
> - http://autobuild.buildroot.org/results/8b35ca6910dfd881953968f8d88ac842d57c9262
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-10 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 21:45 [Buildroot] [PATCH 1/1] package/python-pyudev: fix build with python 2 Fabrice Fontaine
2021-09-04 9:24 ` Peter Korsgaard
2021-09-10 11:12 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.