[Buildroot] [PATCH 1/1] package/jq: needs threads

[Buildroot] [PATCH 1/1] package/jq: needs threads

[Fabrice Fontaine]

threads is a strong requirement since
https://github.com/stedolan/jq/commit/cf4b48c7ba30cb30e116b523cff036ea481459f6

Fixes:
 - http://autobuild.buildroot.org/results/b871cc175655c2d6aa5f184d891b994a0ebd9902

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/jq/Config.in     | 4 ++++
 package/sysdig/Config.in | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/jq/Config.in b/package/jq/Config.in
index 321cbe8b51..5edb5d0989 100644
--- a/package/jq/Config.in
+++ b/package/jq/Config.in
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_JQ
 	bool "jq"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  jq is like sed for JSON data - you can use it to slice and
 	  filter and map and transform structured data with the same
 	  ease that sed, awk, grep and friends let you play with text.
 
 	  http://stedolan.github.io/jq/
+
+comment "jq needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
index 0a1b3f8935..ee53b4fa20 100644
--- a/package/sysdig/Config.in
+++ b/package/sysdig/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_SYSDIG
 	depends on BR2_INSTALL_LIBSTDCPP # libjson
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_TOOLCHAIN_HAS_THREADS # jq
 	depends on !BR2_STATIC_LIBS # luajit, elfutils
 	depends on BR2_USE_WCHAR # elfutils
 	depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils
@@ -25,8 +26,9 @@ config BR2_PACKAGE_SYSDIG
 
 	  https://github.com/draios/sysdig/wiki
 
-comment "sysdig needs a glibc or uclibc toolchain w/ C++, gcc >= 4.8, dynamic library and a Linux kernel to be built"
+comment "sysdig needs a glibc or uclibc toolchain w/ C++, threads, gcc >= 4.8, dynamic library and a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP \
+		|| !BR2_TOOLCHAIN_HAS_THREADS \
 		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS \
 		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
-- 
2.27.0

[Buildroot] [PATCH 1/1] package/jq: needs threads

[Yann E. MORIN]

Fabrice, All,

On 2020-07-18 23:11 +0200, Fabrice Fontaine spake thusly:
> threads is a strong requirement since
> https://github.com/stedolan/jq/commit/cf4b48c7ba30cb30e116b523cff036ea481459f6
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b871cc175655c2d6aa5f184d891b994a0ebd9902
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/jq/Config.in     | 4 ++++
>  package/sysdig/Config.in | 4 +++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/package/jq/Config.in b/package/jq/Config.in
> index 321cbe8b51..5edb5d0989 100644
> --- a/package/jq/Config.in
> +++ b/package/jq/Config.in
> @@ -1,8 +1,12 @@
>  config BR2_PACKAGE_JQ
>  	bool "jq"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	help
>  	  jq is like sed for JSON data - you can use it to slice and
>  	  filter and map and transform structured data with the same
>  	  ease that sed, awk, grep and friends let you play with text.
>  
>  	  http://stedolan.github.io/jq/
> +
> +comment "jq needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
> index 0a1b3f8935..ee53b4fa20 100644
> --- a/package/sysdig/Config.in
> +++ b/package/sysdig/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_SYSDIG
>  	depends on BR2_INSTALL_LIBSTDCPP # libjson
>  	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # jq
>  	depends on !BR2_STATIC_LIBS # luajit, elfutils
>  	depends on BR2_USE_WCHAR # elfutils
>  	depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils
> @@ -25,8 +26,9 @@ config BR2_PACKAGE_SYSDIG
>  
>  	  https://github.com/draios/sysdig/wiki
>  
> -comment "sysdig needs a glibc or uclibc toolchain w/ C++, gcc >= 4.8, dynamic library and a Linux kernel to be built"
> +comment "sysdig needs a glibc or uclibc toolchain w/ C++, threads, gcc >= 4.8, dynamic library and a Linux kernel to be built"
>  	depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP \
> +		|| !BR2_TOOLCHAIN_HAS_THREADS \
>  		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS \
>  		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
>  	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> -- 
> 2.27.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/jq: needs threads

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > threads is a strong requirement since
 > https://github.com/stedolan/jq/commit/cf4b48c7ba30cb30e116b523cff036ea481459f6

 > Fixes:
 >  - http://autobuild.buildroot.org/results/b871cc175655c2d6aa5f184d891b994a0ebd9902

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2020.02.x and 2020.05.x, thanks.

-- 
Bye, Peter Korsgaard