* [PATCH] travis.yml: Improve the --disable-tcg test on s390x
@ 2020-05-12 13:38 Thomas Huth
2020-05-12 13:50 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2020-05-12 13:38 UTC (permalink / raw)
To: qemu-devel, Alex Bennée
Cc: qemu-s390x, Cornelia Huck, Philippe Mathieu-Daudé
Since the s390x containers do not allow KVM, we only compile-test
the --disable-tcg build on s390x and do not run the qtests. Thus,
it does not make sense to install genisoimage here, and it also does
not make sense to build the s390-ccw.img here again - it is simply
not used without the qtests.
On the other hand, if we do not build the s390-ccw.img anymore, we
can also compile with Clang - so let's use that compiler here to
get some additional test coverage.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.travis.yml | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index fe708792ca..1ec8a7b465 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -502,9 +502,10 @@ jobs:
$(exit $BUILD_RC);
fi
- - name: "[s390x] GCC check (KVM)"
+ - name: "[s390x] Clang (disable-tcg)"
arch: s390x
dist: bionic
+ compiler: clang
addons:
apt_packages:
- libaio-dev
@@ -528,21 +529,10 @@ jobs:
- libusb-1.0-0-dev
- libvdeplug-dev
- libvte-2.91-dev
- # Tests dependencies
- - genisoimage
env:
- TEST_CMD="make check-unit"
- - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools"
- script:
- - ( cd ${SRC_DIR} ; git submodule update --init roms/SLOF )
- - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
- - |
- if [ "$BUILD_RC" -eq 0 ] ; then
- mv pc-bios/s390-ccw/*.img pc-bios/ ;
- ${TEST_CMD} ;
- else
- $(exit $BUILD_RC);
- fi
+ - CONFIG="--disable-containers --disable-tcg --enable-kvm
+ --disable-tools --host-cc=clang --cxx=clang++"
# Release builds
# The make-release script expect a QEMU version, so our tag must start with a 'v'.
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] travis.yml: Improve the --disable-tcg test on s390x
2020-05-12 13:38 [PATCH] travis.yml: Improve the --disable-tcg test on s390x Thomas Huth
@ 2020-05-12 13:50 ` Philippe Mathieu-Daudé
2020-05-12 15:08 ` Cornelia Huck
2020-05-12 16:55 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-12 13:50 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Alex Bennée; +Cc: qemu-s390x, Cornelia Huck
On 5/12/20 3:38 PM, Thomas Huth wrote:
> Since the s390x containers do not allow KVM, we only compile-test
> the --disable-tcg build on s390x and do not run the qtests. Thus,
> it does not make sense to install genisoimage here, and it also does
> not make sense to build the s390-ccw.img here again - it is simply
> not used without the qtests.
> On the other hand, if we do not build the s390-ccw.img anymore, we
> can also compile with Clang - so let's use that compiler here to
> get some additional test coverage.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .travis.yml | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index fe708792ca..1ec8a7b465 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -502,9 +502,10 @@ jobs:
> $(exit $BUILD_RC);
> fi
>
> - - name: "[s390x] GCC check (KVM)"
> + - name: "[s390x] Clang (disable-tcg)"
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> arch: s390x
> dist: bionic
> + compiler: clang
> addons:
> apt_packages:
> - libaio-dev
> @@ -528,21 +529,10 @@ jobs:
> - libusb-1.0-0-dev
> - libvdeplug-dev
> - libvte-2.91-dev
> - # Tests dependencies
> - - genisoimage
> env:
> - TEST_CMD="make check-unit"
> - - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools"
> - script:
> - - ( cd ${SRC_DIR} ; git submodule update --init roms/SLOF )
> - - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
> - - |
> - if [ "$BUILD_RC" -eq 0 ] ; then
> - mv pc-bios/s390-ccw/*.img pc-bios/ ;
> - ${TEST_CMD} ;
> - else
> - $(exit $BUILD_RC);
> - fi
> + - CONFIG="--disable-containers --disable-tcg --enable-kvm
> + --disable-tools --host-cc=clang --cxx=clang++"
>
> # Release builds
> # The make-release script expect a QEMU version, so our tag must start with a 'v'.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] travis.yml: Improve the --disable-tcg test on s390x
2020-05-12 13:38 [PATCH] travis.yml: Improve the --disable-tcg test on s390x Thomas Huth
2020-05-12 13:50 ` Philippe Mathieu-Daudé
@ 2020-05-12 15:08 ` Cornelia Huck
2020-05-12 16:55 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2020-05-12 15:08 UTC (permalink / raw)
To: Thomas Huth
Cc: Philippe Mathieu-Daudé, qemu-s390x, Alex Bennée, qemu-devel
On Tue, 12 May 2020 15:38:49 +0200
Thomas Huth <thuth@redhat.com> wrote:
> Since the s390x containers do not allow KVM, we only compile-test
> the --disable-tcg build on s390x and do not run the qtests. Thus,
> it does not make sense to install genisoimage here, and it also does
> not make sense to build the s390-ccw.img here again - it is simply
> not used without the qtests.
> On the other hand, if we do not build the s390-ccw.img anymore, we
> can also compile with Clang - so let's use that compiler here to
> get some additional test coverage.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .travis.yml | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] travis.yml: Improve the --disable-tcg test on s390x
2020-05-12 13:38 [PATCH] travis.yml: Improve the --disable-tcg test on s390x Thomas Huth
2020-05-12 13:50 ` Philippe Mathieu-Daudé
2020-05-12 15:08 ` Cornelia Huck
@ 2020-05-12 16:55 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-05-12 16:55 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-s390x, Cornelia Huck, Philippe Mathieu-Daudé, qemu-devel
Thomas Huth <thuth@redhat.com> writes:
> Since the s390x containers do not allow KVM, we only compile-test
> the --disable-tcg build on s390x and do not run the qtests. Thus,
> it does not make sense to install genisoimage here, and it also does
> not make sense to build the s390-ccw.img here again - it is simply
> not used without the qtests.
> On the other hand, if we do not build the s390-ccw.img anymore, we
> can also compile with Clang - so let's use that compiler here to
> get some additional test coverage.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Queued to testing/next, thanks.
> ---
> .travis.yml | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index fe708792ca..1ec8a7b465 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -502,9 +502,10 @@ jobs:
> $(exit $BUILD_RC);
> fi
>
> - - name: "[s390x] GCC check (KVM)"
> + - name: "[s390x] Clang (disable-tcg)"
> arch: s390x
> dist: bionic
> + compiler: clang
> addons:
> apt_packages:
> - libaio-dev
> @@ -528,21 +529,10 @@ jobs:
> - libusb-1.0-0-dev
> - libvdeplug-dev
> - libvte-2.91-dev
> - # Tests dependencies
> - - genisoimage
> env:
> - TEST_CMD="make check-unit"
> - - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools"
> - script:
> - - ( cd ${SRC_DIR} ; git submodule update --init roms/SLOF )
> - - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
> - - |
> - if [ "$BUILD_RC" -eq 0 ] ; then
> - mv pc-bios/s390-ccw/*.img pc-bios/ ;
> - ${TEST_CMD} ;
> - else
> - $(exit $BUILD_RC);
> - fi
> + - CONFIG="--disable-containers --disable-tcg --enable-kvm
> + --disable-tools --host-cc=clang --cxx=clang++"
>
> # Release builds
> # The make-release script expect a QEMU version, so our tag must start with a 'v'.
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-12 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 13:38 [PATCH] travis.yml: Improve the --disable-tcg test on s390x Thomas Huth
2020-05-12 13:50 ` Philippe Mathieu-Daudé
2020-05-12 15:08 ` Cornelia Huck
2020-05-12 16:55 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.